From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tvrtko Ursulin Subject: Re: [PATCH v5 4/4] drm/i915: Delay disabling the user interrupt for breadcrumbs Date: Mon, 27 Feb 2017 19:05:59 +0000 Message-ID: References: <20170227132427.25224-1-chris@chris-wilson.co.uk> <20170227132427.25224-4-chris@chris-wilson.co.uk> <437a85df-5441-202e-0970-0af2e5e531d2@linux.intel.com> <20170227140658.GL13095@nuc-i3427.alporthouse.com> <20170227141337.GM13095@nuc-i3427.alporthouse.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by gabe.freedesktop.org (Postfix) with ESMTPS id 58A226E332 for ; Mon, 27 Feb 2017 19:06:20 +0000 (UTC) In-Reply-To: <20170227141337.GM13095@nuc-i3427.alporthouse.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org Ck9uIDI3LzAyLzIwMTcgMTQ6MTMsIENocmlzIFdpbHNvbiB3cm90ZToKPiBPbiBNb24sIEZlYiAy NywgMjAxNyBhdCAwMjowNjo1OFBNICswMDAwLCBDaHJpcyBXaWxzb24gd3JvdGU6Cj4+IE9uIE1v biwgRmViIDI3LCAyMDE3IGF0IDAxOjU3OjM1UE0gKzAwMDAsIFR2cnRrbyBVcnN1bGluIHdyb3Rl Ogo+Pj4KPj4+IE9uIDI3LzAyLzIwMTcgMTM6MjQsIENocmlzIFdpbHNvbiB3cm90ZToKPj4+PiAJ aWYgKGItPmhhbmdjaGVja19pbnRlcnJ1cHRzICE9IGF0b21pY19yZWFkKCZlbmdpbmUtPmlycV9j b3VudCkpIHsKPj4+PiBAQCAtNjcsNyArNzYsNyBAQCBzdGF0aWMgdm9pZCBpbnRlbF9icmVhZGNy dW1ic19oYW5nY2hlY2sodW5zaWduZWQgbG9uZyBkYXRhKQo+Pj4+IAkgKiB0byBwcm9jZXNzIHRo ZSBwZW5kaW5nIGludGVycnVwdCAoZS5nLCBsb3cgcHJpb3JpdHkgdGFzayBvbiBhIGxvYWRlZAo+ Pj4+IAkgKiBzeXN0ZW0pIGFuZCB3YWl0IHVudGlsIGl0IHNsZWVwcyBiZWZvcmUgZGVjbGFyaW5n IGEgbWlzc2VkIGludGVycnVwdC4KPj4+PiAJICovCj4+Pj4gLQlpZiAoaW50ZWxfZW5naW5lX3dh a2V1cChlbmdpbmUpICYgRU5HSU5FX1dBS0VVUF9BQ1RJVkUpIHsKPj4+PiArCWlmICghKGludGVs X2VuZ2luZV93YWtldXAoZW5naW5lKSAmIEVOR0lORV9XQUtFVVBfQVNMRUVQKSkgewo+Pj4KPj4+ IEkgZGlkIG5vdCBnZXQgdGhlIGV4cGxhbmF0aW9uIGZyb20gdGhlIHByZXZpb3VzIHJvdW5kIG9u IHdoeSB5b3UgaGFkCj4+PiB0byByZXZlcnNlIHRoZSBhY3RpdmUgdG8gYXNsZWVwLiBIZXJlIGl0 IGV2ZW4gbG9va3Mgd3Jvbmcgbm93LAo+Pj4gYmVjYXVzZSBJIHRob3VnaHQgeW91IGRvbid0IHdh bnQgdG8gcmUtcXVldWUgdGhlIGhhbmdjaGVjayB3aGVuCj4+PiB0aGVyZSBhcmUgbm8gd2FpdGVy cz8KPj4KPj4gTm8gd2FpdGVyczogcmVzdWx0ID0gMAo+PiBSdW5uaW5nIHdhaXRlcjogcmVzdWx0 ID0gV0FLRVVQX1dBSVRFUgo+PiBTbGVlcGluZyB3YWl0ZXI6IHJlc3VsdCA9IFdBS0VVUF9XQUlU RVIgfCBXQUtFVVBfQVNMRUVQCj4+Cj4+IFdlIG9ubHkgd2FudCB0byBkZWNsYXJlIGEgbWlzZWQg aXJxIGlmIHdlIHdha2UgdXAgYSBzbGVlcGluZyB3YWl0ZXIsIGFuZAo+PiBrZWVwIHRoZSBoYW5n Y2hlY2sgdGltZXIgcnVubmluZyB1bnRpbCB0aGUgZGV2aWNlIGlzIGlkbGUgKHdoZW4gdGhlIGly cQo+PiBpcyBkaXNhcm1lZCkuCj4+Cj4+IEhvdyBhYm91dDoKPj4KPj4gaWYgKGludGVsX2VuZ2lu ZV93YWtldXAoZW5naW5lKSAmIEVOR0lORV9XQUtFVVBfQVNMRUVQKSB7Cj4+IAlzZXRfYml0KG1p c3NlZF9pcnEpOwo+PiAJbW9kX3RpbWVyKCZiLT5mYWtlX2lycSwgamlmZmllcyArIDEpOwo+PiB9 IGVsc2Ugewo+PiAJbW9kX3RpbWVyKGItPmhhbmdjaGVjaywgd2FpdF90aW1lb3V0KTsKPj4gfQo+ Cj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2JyZWFkY3J1bWJzLmMg Yi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9icmVhZGNydW1icy5jCj4gaW5kZXggZWJiN2Jj MGJlOWZiLi4wMDRlYjRjMGM1MzEgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUv aW50ZWxfYnJlYWRjcnVtYnMuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Jy ZWFkY3J1bWJzLmMKPiBAQCAtNzIsMTggKzcyLDI1IEBAIHN0YXRpYyB2b2lkIGludGVsX2JyZWFk Y3J1bWJzX2hhbmdjaGVjayh1bnNpZ25lZCBsb25nIGRhdGEpCj4gICAgICAgICAgICAgICAgIHJl dHVybjsKPiAgICAgICAgIH0KPgo+IC0gICAgICAgLyogSWYgdGhlIHdhaXRlciB3YXMgY3VycmVu dGx5IHJ1bm5pbmcsIGFzc3VtZSBpdCBoYXNuJ3QgaGFkIGEgY2hhbmNlCj4gKyAgICAgICAvKiBX ZSBrZWVwIHRoZSBoYW5nY2hlY2sgdGltZSBhbGl2ZSB1bnRpbCB3ZSBkaXNhcm0gdGhlIGlycSwg ZXZlbgo+ICsgICAgICAgICogaWYgdGhlcmUgYXJlIG5vIHdhaXRlcnMgYXQgcHJlc2VudC4KPiAr ICAgICAgICAqCj4gKyAgICAgICAgKiBJZiB0aGUgd2FpdGVyIHdhcyBjdXJyZW50bHkgcnVubmlu ZywgYXNzdW1lIGl0IGhhc24ndCBoYWQgYSBjaGFuY2UKPiAgICAgICAgICAqIHRvIHByb2Nlc3Mg dGhlIHBlbmRpbmcgaW50ZXJydXB0IChlLmcsIGxvdyBwcmlvcml0eSB0YXNrIG9uIGEgbG9hZGVk Cj4gICAgICAgICAgKiBzeXN0ZW0pIGFuZCB3YWl0IHVudGlsIGl0IHNsZWVwcyBiZWZvcmUgZGVj bGFyaW5nIGEgbWlzc2VkIGludGVycnVwdC4KPiArICAgICAgICAqCj4gKyAgICAgICAgKiBJZiB0 aGUgd2FpdGVyIHdhcyBhc2xlZXAgKGFuZCBub3QgZXZlbiBwZW5kaW5nIGEgd2FrZXVwKSwgdGhl biB3ZQo+ICsgICAgICAgICogbXVzdCBoYXZlIG1pc3NlZCBhbiBpbnRlcnJ1cHQgYXMgdGhlIEdQ VSBoYXMgc3RvcHBlZCBhZHZhbmNpbmcKPiArICAgICAgICAqIGJ1dCB3ZSBzdGlsbCBoYXZlIGEg d2FpdGVyLiBBc3N1bWluZyBhbGwgYmF0Y2hlcyBjb21wbGV0ZSB3aXRoaW4KPiArICAgICAgICAq IERSTV9JOTE1X0hBTkdDSEVDS19KSUZGSUVTIFsxLjVzXSEKPiAgICAgICAgICAqLwo+IC0gICAg ICAgaWYgKCEoaW50ZWxfZW5naW5lX3dha2V1cChlbmdpbmUpICYgRU5HSU5FX1dBS0VVUF9BU0xF RVApKSB7Cj4gKyAgICAgICBpZiAoaW50ZWxfZW5naW5lX3dha2V1cChlbmdpbmUpICYgRU5HSU5F X1dBS0VVUF9BU0xFRVApIHsKPiArICAgICAgICAgICAgICAgRFJNX0RFQlVHKCJIYW5nY2hlY2sg dGltZXIgZWxhcHNlZC4uLiAlcyBpZGxlXG4iLCBlbmdpbmUtPm5hbWUpOwo+ICsgICAgICAgICAg ICAgICBzZXRfYml0KGVuZ2luZS0+aWQsICZlbmdpbmUtPmk5MTUtPmdwdV9lcnJvci5taXNzZWRf aXJxX3JpbmdzKTsKPiArICAgICAgICAgICAgICAgbW9kX3RpbWVyKCZlbmdpbmUtPmJyZWFkY3J1 bWJzLmZha2VfaXJxLCBqaWZmaWVzICsgMSk7Cj4gKyAgICAgICB9IGVsc2Ugewo+ICAgICAgICAg ICAgICAgICBtb2RfdGltZXIoJmItPmhhbmdjaGVjaywgd2FpdF90aW1lb3V0KCkpOwo+IC0gICAg ICAgICAgICAgICByZXR1cm47Cj4gICAgICAgICB9Cj4gLQo+IC0gICAgICAgRFJNX0RFQlVHKCJI YW5nY2hlY2sgdGltZXIgZWxhcHNlZC4uLiAlcyBpZGxlXG4iLCBlbmdpbmUtPm5hbWUpOwo+IC0g ICAgICAgc2V0X2JpdChlbmdpbmUtPmlkLCAmZW5naW5lLT5pOTE1LT5ncHVfZXJyb3IubWlzc2Vk X2lycV9yaW5ncyk7Cj4gLSAgICAgICBtb2RfdGltZXIoJmVuZ2luZS0+YnJlYWRjcnVtYnMuZmFr ZV9pcnEsIGppZmZpZXMgKyAxKTsKPiAgfQo+Cj4gIHN0YXRpYyB2b2lkIGludGVsX2JyZWFkY3J1 bWJzX2Zha2VfaXJxKHVuc2lnbmVkIGxvbmcgZGF0YSkKPiBAQCAtMTY3LDYgKzE3NCwxMCBAQCB2 b2lkIGludGVsX2VuZ2luZV9kaXNhcm1fYnJlYWRjcnVtYnMoc3RydWN0IGludGVsX2VuZ2luZV9j cyAqZW5naW5lKQo+Cj4gICAgICAgICBzcGluX2xvY2tfaXJxc2F2ZSgmYi0+bG9jaywgZmxhZ3Mp Owo+Cj4gKyAgICAgICAvKiBXZSBvbmx5IGRpc2FybSB0aGUgaXJxIHdoZW4gd2UgYXJlIGlkbGUg KGFsbCByZXF1ZXN0cyBjb21wbGV0ZWQpLAo+ICsgICAgICAgICogc28gaWYgdGhlcmUgcmVtYWlu cyBhIHNsZWVwaW5nIHdhaXRlciwgaXQgbWlzc2VkIHRoZSByZXF1ZXN0Cj4gKyAgICAgICAgKiBj b21wbGV0aW9uLgo+ICsgICAgICAgICovCj4gICAgICAgICBpZiAoX19pbnRlbF9lbmdpbmVfd2Fr ZXVwKGVuZ2luZSkgJiBFTkdJTkVfV0FLRVVQX0FTTEVFUCkKPiAgICAgICAgICAgICAgICAgc2V0 X2JpdChlbmdpbmUtPmlkLCAmZW5naW5lLT5pOTE1LT5ncHVfZXJyb3IubWlzc2VkX2lycV9yaW5n cyk7Cj4KPgo+CgpMb29rcyBva2F5IGFmdGVyIHNvbWUgcmUtcmUtcmUtcmVhZGluZy4gSSBndWVz cyBzaHVmZmxpbmcgdGhpbmdzIGJhY2sgCmFuZCBmb3J0aCBpbiB0aGlzIHNlcmllcywgbm90IGxv bmcgYWZ0ZXIgdGhlIGFyZWEgd2FzIHJlY2VudGx5IGNoYW5nZWQgCmFzIHdlbGwsIHdhcyBhIGJp dCBjaGFsbGVuZ2luZy4KClJldmlld2VkLWJ5OiBUdnJ0a28gVXJzdWxpbiA8dHZydGtvLnVyc3Vs aW5AaW50ZWwuY29tPgoKUmVnYXJkcywKClR2cnRrbwpfX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBs aXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1h bi9saXN0aW5mby9pbnRlbC1nZngK