From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A0DA3C433EF for ; Tue, 19 Oct 2021 11:44:27 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 65FCE60FC1 for ; Tue, 19 Oct 2021 11:44:27 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 65FCE60FC1 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id C824F6EB88; Tue, 19 Oct 2021 11:44:26 +0000 (UTC) Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by gabe.freedesktop.org (Postfix) with ESMTPS id 76D1D6EB88 for ; Tue, 19 Oct 2021 11:44:25 +0000 (UTC) X-IronPort-AV: E=McAfee;i="6200,9189,10141"; a="227254996" X-IronPort-AV: E=Sophos;i="5.85,384,1624345200"; d="scan'208";a="227254996" Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Oct 2021 04:44:03 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.85,384,1624345200"; d="scan'208";a="594205638" Received: from fmsmsx606.amr.corp.intel.com ([10.18.126.86]) by orsmga004.jf.intel.com with ESMTP; 19 Oct 2021 04:44:03 -0700 Received: from bgsmsx606.gar.corp.intel.com (10.67.234.8) by fmsmsx606.amr.corp.intel.com (10.18.126.86) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Tue, 19 Oct 2021 04:44:02 -0700 Received: from bgsmsx602.gar.corp.intel.com (10.109.78.81) by BGSMSX606.gar.corp.intel.com (10.67.234.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Tue, 19 Oct 2021 17:13:59 +0530 Received: from bgsmsx602.gar.corp.intel.com ([10.109.78.81]) by BGSMSX602.gar.corp.intel.com ([10.109.78.81]) with mapi id 15.01.2242.012; Tue, 19 Oct 2021 17:13:59 +0530 From: "Kulkarni, Vandita" To: "Kulkarni, Vandita" , "Nikula, Jani" , "intel-gfx@lists.freedesktop.org" CC: "Deak, Imre" , "Roper, Matthew D" Thread-Topic: [PATCH 4/4] drm/i915/dsi: Ungate clock before enabling the phy Thread-Index: AQHXw+yfy9Z1c2yNRkSqQfk1IFFtcKvZwTMAgABvplCAAAPLgA== Date: Tue, 19 Oct 2021 11:43:59 +0000 Message-ID: References: <20211018065207.30587-1-vandita.kulkarni@intel.com> <20211018065207.30587-5-vandita.kulkarni@intel.com> <87y26pqpw9.fsf@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.6.200.16 x-originating-ip: [10.223.10.1] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [Intel-gfx] [PATCH 4/4] drm/i915/dsi: Ungate clock before enabling the phy X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" > -----Original Message----- > From: Intel-gfx On Behalf Of > Kulkarni, Vandita > Sent: Tuesday, October 19, 2021 5:03 PM > To: Nikula, Jani ; intel-gfx@lists.freedesktop.org > Cc: Deak, Imre ; Roper, Matthew D > > Subject: Re: [Intel-gfx] [PATCH 4/4] drm/i915/dsi: Ungate clock before > enabling the phy >=20 > > -----Original Message----- > > From: Nikula, Jani > > Sent: Tuesday, October 19, 2021 3:48 PM > > To: Kulkarni, Vandita ; intel- > > gfx@lists.freedesktop.org > > Cc: Deak, Imre ; Roper, Matthew D > > ; Kulkarni, Vandita > > > > Subject: Re: [PATCH 4/4] drm/i915/dsi: Ungate clock before enabling > > the phy > > > > On Mon, 18 Oct 2021, Vandita Kulkarni > wrote: > > > For the PHY enable/disable signalling to propagate between Dispaly > > > and PHY, DDI clocks need to be running when enabling the PHY. > > > > > > > A bspec reference would be useful: > > > > Bspec: NNN Bspec: 49187 > > > > > Signed-off-by: Vandita Kulkarni > > > --- > > > drivers/gpu/drm/i915/display/icl_dsi.c | 8 +++----- > > > 1 file changed, 3 insertions(+), 5 deletions(-) > > > > > > diff --git a/drivers/gpu/drm/i915/display/icl_dsi.c > > b/drivers/gpu/drm/i915/display/icl_dsi.c > > > index 8c166f92f8bd..77cd01ecfa80 100644 > > > --- a/drivers/gpu/drm/i915/display/icl_dsi.c > > > +++ b/drivers/gpu/drm/i915/display/icl_dsi.c > > > @@ -1135,8 +1135,6 @@ static void > > > gen11_dsi_enable_port_and_phy(struct intel_encoder *encoder, > > > const struct intel_crtc_state *crtc_state) { > > > - struct drm_i915_private *dev_priv =3D to_i915(encoder->base.dev); > > > - > > > /* step 4a: power up all lanes of the DDI used by DSI */ > > > gen11_dsi_power_up_lanes(encoder); > > > > > > @@ -1146,6 +1144,8 @@ gen11_dsi_enable_port_and_phy(struct > > intel_encoder *encoder, > > > /* step 4c: configure voltage swing and skew */ > > > gen11_dsi_voltage_swing_program_seq(encoder); > > > > > > + gen11_dsi_ungate_clocks(encoder); > > > + > > > /* enable DDI buffer */ > > > gen11_dsi_enable_ddi_buffer(encoder); > > > > > > @@ -1161,9 +1161,7 @@ gen11_dsi_enable_port_and_phy(struct > > intel_encoder *encoder, > > > /* Step (4h, 4i, 4j, 4k): Configure transcoder */ > > > gen11_dsi_configure_transcoder(encoder, crtc_state); > > > > > > - /* Step 4l: Gate DDI clocks */ > > > - if (DISPLAY_VER(dev_priv) =3D=3D 11) > > > - gen11_dsi_gate_clocks(encoder); > > > + gen11_dsi_gate_clocks(encoder); > > > > So how does this relate to > > 991d9557b0c4 ("drm/i915/tgl/dsi: Gate the ddi clocks after pll > > mapping") >=20 > As per the latest bspec, this change doesn't seem to be valid anymore. > It is marked with removed tag. > When TGL got added this change came in. >=20 > But now with ADL the whole thing is marked as removed. And the gating is now added after enabling DDI Buffer=20 > So, Do you suggest that I submit a revert for this change ? >=20 > Thanks, > Vandita > > > > > } > > > > > > static void gen11_dsi_powerup_panel(struct intel_encoder *encoder) > > > > -- > > Jani Nikula, Intel Open Source Graphics Center