From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D5228C4332F for ; Wed, 23 Mar 2022 15:40:56 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 47CE110E712; Wed, 23 Mar 2022 15:40:55 +0000 (UTC) Received: from mail-lf1-x12f.google.com (mail-lf1-x12f.google.com [IPv6:2a00:1450:4864:20::12f]) by gabe.freedesktop.org (Postfix) with ESMTPS id 46F5C10E66B for ; Wed, 23 Mar 2022 10:39:48 +0000 (UTC) Received: by mail-lf1-x12f.google.com with SMTP id t25so1959083lfg.7 for ; Wed, 23 Mar 2022 03:39:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=LJG6LchEWg7eLND4+i+6tV16qS1u0tcHKvRxEtTuG+w=; b=yAkPXvHZVB3DXiA6lnV3OJs4l7boHKACGrx2zNN0q0WdW4bDDBFu/J4udxtyTi4LnD EW5GVcRjYXzEeDLkpqeGo1qdR36WyqvDgbQswBau6NJctIIV72R0Wo2Kj1TEosLVpGaq UvO0sdl+erB80ekBTDMX7IEdiKF3ft8qxVaWiecxxSgBJsWhhrQHl5YOnjDD05TZdcGP GDOInQ2USvHXmJkV5XU+7gTi59xIrI9Dv6xe++mHYqDqDI5n+u4nmlN8qRthsqM0DM33 fzmhSc0ONmXxs82ScbBBb79fjsbtQFhKXPJYW/HWmd9J56xvz4lQapq28hyricqZ/Ueu gp4A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=LJG6LchEWg7eLND4+i+6tV16qS1u0tcHKvRxEtTuG+w=; b=P6IIaSuFTS6oMdEuOHbQXA7Hi0FpW7sJscpbNy1aZbC4hPX+Psh8bM7NHX3OBJVTKs B9HDwVKQrlOL7bnUEAf6vW1PWaSiAaurtJxf2+YWwD/w+Yr0Q5tMZjF91Z7F6dzCO2c1 UobPW8PjACd/MvWdaYN41Q706mo2iXYVGbnFi2tvaUY1kRSGZG/sdh8IColL28FDM9Vy BbBW6rSSQIBT0EKLuVzubW2i6jOh03vMncQImk/wdrEgCxLK4gci2oAVERAUKhQxi+EA rGCBBqW+o9n+sDZzsVk21HZxV4O3ZqmszuMUWYqQin87P42Bo76sVhNfqjK5GuAf37mD zRCw== X-Gm-Message-State: AOAM532mjEYP6AdF/M4XfKDCz1ngi3qMzN+YPF2mrR9tQd7F/jaT0QwA 8Ur3nCRddn4V/JjHmfzmPicVOw== X-Google-Smtp-Source: ABdhPJxdoE2MJzCwqFEPkOY+WggWU0jxIXl/lqXQbtd4rieBWf/meitV/U1e3m4J8NKMlt9q9m+iIA== X-Received: by 2002:a05:6512:34c7:b0:44a:37de:9d74 with SMTP id w7-20020a05651234c700b0044a37de9d74mr6436931lfr.314.1648031986613; Wed, 23 Mar 2022 03:39:46 -0700 (PDT) Received: from [192.168.1.211] ([37.153.55.125]) by smtp.gmail.com with ESMTPSA id x33-20020a0565123fa100b00443d3cffd89sm2479850lfa.210.2022.03.23.03.39.45 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 23 Mar 2022 03:39:46 -0700 (PDT) Message-ID: Date: Wed, 23 Mar 2022 13:39:44 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.6.2 Content-Language: en-GB To: =?UTF-8?B?VmlsbGUgU3lyasOkbMOk?= , Alex Deucher References: <20220218100403.7028-1-ville.syrjala@linux.intel.com> From: Dmitry Baryshkov In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Mailman-Approved-At: Wed, 23 Mar 2022 15:40:20 +0000 Subject: Re: [Intel-gfx] [PATCH 00/22] drm: Review of mode copies X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: =?UTF-8?Q?Heiko_St=c3=bcbner?= , Emma Anholt , Neil Armstrong , Xinliang Liu , Maling list - DRI developers , Jernej Skrabec , Andrzej Hajda , Sam Ravnborg , Rodrigo Siqueira , amd-gfx list , linux-rockchip@lists.infradead.org, Xinwei Kong , Aurabindo Pillai , linux-arm-msm , Alain Volmat , Harry Wentland , Chun-Kuang Hu , Jonas Karlman , Leo Li , Chen Feng , Intel Graphics Development , Abhinav Kumar , Maxime Ripard , Nikola Cornij , John Stultz , linux-arm-kernel , Tomi Valkeinen , freedreno , Sandy Huang , Robert Foss , Philipp Zabel , Alex Deucher , Tian Tao , Jyri Sarha , Laurent Pinchart Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On 22/03/2022 01:37, Ville Syrjälä wrote: > On Tue, Mar 15, 2022 at 02:52:38PM -0400, Alex Deucher wrote: >> On Mon, Mar 14, 2022 at 6:12 PM Ville Syrjälä >> wrote: >>> >>> On Fri, Feb 18, 2022 at 12:03:41PM +0200, Ville Syrjala wrote: >>>> drm: Add drm_mode_init() >>>> drm/bridge: Use drm_mode_copy() >>>> drm/imx: Use drm_mode_duplicate() >>>> drm/panel: Use drm_mode_duplicate() >>>> drm/vc4: Use drm_mode_copy() >>> These have been pushed to drm-misc-next. >>> >>>> drm/amdgpu: Remove pointless on stack mode copies >>>> drm/amdgpu: Use drm_mode_init() for on-stack modes >>>> drm/amdgpu: Use drm_mode_copy() >>> amdgpu ones are reviewed, but I'll leave them for the >>> AMD folks to push to whichever tree they prefer. >> >> I pulled patches 2, 4, 5 into my tree. > > Thanks. > >> For 3, I'm happy to have it >> land via drm-misc with the rest of the mode_init changes if you'd >> prefer. > > Either way works for me. I don't yet have reviews yet for > the other drivers, so I'll proably hold off for a bit more > at least. And the i915 patch I'll be merging via drm-intel. > >>>> drm/radeon: Use drm_mode_copy() >>>> drm/gma500: Use drm_mode_copy() >>>> drm/tilcdc: Use drm_mode_copy() >>>> drm/i915: Use drm_mode_copy() > > Those are now all in. > > Which leaves us with these stragglers: >>>> drm/hisilicon: Use drm_mode_init() for on-stack modes >>>> drm/msm: Nuke weird on stack mode copy >>>> drm/msm: Use drm_mode_init() for on-stack modes >>>> drm/msm: Use drm_mode_copy() These three patches went beneath my radar for some reason. I have just sent a replacement for the first patch ([1]). Other two patches can be pulled in msm/msm-next (or msm/msm-fixes) during the next development cycle if that works for you. [1] https://patchwork.freedesktop.org/series/101682/ >>>> drm/mtk: Use drm_mode_init() for on-stack modes >>>> drm/rockchip: Use drm_mode_copy() >>>> drm/sti: Use drm_mode_copy() >>>> drm: Use drm_mode_init() for on-stack modes >>>> drm: Use drm_mode_copy() > -- With best wishes Dmitry