Re: [Intel-gfx] [v7 1/3] drm/i915/display: Add write permissions for fec support

Jani Nikula
2021-07-08T13:06:01Z

On Thu, 08 Jul 2021, Vandita Kulkarni <vandita.kulkarni@intel.com> wrote:
> Though there is a write option available on fec_suport
> debugfs file, so far it has been registering with read
> permissions only.
>
> Suggested-by: Jani Nikula <jani.nikula@intel.com>
> Signed-off-by: Vandita Kulkarni <vandita.kulkarni@intel.com>

Reviewed-by: Jani Nikula <jani.nikula@intel.com>

> ---
> drivers/gpu/drm/i915/display/intel_display_debugfs.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_display_debugfs.c b/drivers/gpu/drm/i915/display/intel_display_debugfs.c
> index af9e58619667..942c4419e0cb 100644
> --- a/drivers/gpu/drm/i915/display/intel_display_debugfs.c
> +++ b/drivers/gpu/drm/i915/display/intel_display_debugfs.c
> @@ -2428,7 +2428,7 @@ int intel_connector_debugfs_add(struct drm_connector *connector)
> }
>
> if ((DISPLAY_VER(dev_priv) >= 11 || IS_CANNONLAKE(dev_priv)) && ((connector->connector_type == DRM_MODE_CONNECTOR_DisplayPort && !to_intel_connector(connector)->mst_port) || connector->connector_type == DRM_MODE_CONNECTOR_eDP))
> - debugfs_create_file("i915_dsc_fec_support", S_IRUGO, root,
> + debugfs_create_file("i915_dsc_fec_support", 0644, root,
> connector, &i915_dsc_fec_support_fops);
>
> /* Legacy panels doesn't lpsp on any platform */

--
Jani Nikula, Intel Open Source Graphics Center