From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tvrtko Ursulin Subject: Re: [PATCH 5/7] drm/i915: Return immediately if trylock fails for direct-reclaim Date: Thu, 6 Dec 2018 15:18:13 +0000 Message-ID: References: <20181204141522.13640-1-chris@chris-wilson.co.uk> <20181204141522.13640-5-chris@chris-wilson.co.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by gabe.freedesktop.org (Postfix) with ESMTPS id 985496E5E9 for ; Thu, 6 Dec 2018 15:18:16 +0000 (UTC) In-Reply-To: <20181204141522.13640-5-chris@chris-wilson.co.uk> Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org Ck9uIDA0LzEyLzIwMTggMTQ6MTUsIENocmlzIFdpbHNvbiB3cm90ZToKPiBJZ25vcmUgdHJ5aW5n IHRvIHNocmluayBmcm9tIGk5MTUgaWYgd2UgZmFpbCB0byBhY3F1aXJlIHRoZSBzdHJ1Y3RfbXV0 ZXgKPiBpbiB0aGUgc2hyaW5rZXIgd2hpbGUgcGVyZm9ybWluZyBkaXJlY3QtcmVjbGFpbS4gVGhl IHRyYWRlLW9mZiBiZWluZwo+IChtdWNoKSBsb3dlciBsYXRlbmN5IGZvciBub24taTkxNSBjbGll bnRzIGF0IGFuIGluY3JlYXNlZCByaXNrIG9mIGJlaW5nCj4gdW5hYmxlIHRvIG9idGFpbiBhIHBh Z2UgZnJvbSBkaXJlY3QtcmVjbGFpbSB3aXRob3V0IGhpdHRpbmcgdGhlCj4gb29tLW5vdGlmaWVy LiBUaGUgcHJvdmlzbyBiZWluZyB0aGF0IHdlIHN0aWxsIGtlZXAgdHJ5aW5nIHRvIGhhcmQKPiBv YnRhaW4gdGhlIGxvY2sgZm9yIG9vbSBzbyB0aGF0IHdlIGNhbiByZWFwIHVuZGVyIGhlYXZ5IG1l bW9yeSBwcmVzc3VyZS4KPiAKPiBTaWduZWQtb2ZmLWJ5OiBDaHJpcyBXaWxzb24gPGNocmlzQGNo cmlzLXdpbHNvbi5jby51az4KPiBDYzogVHZydGtvIFVyc3VsaW4gPHR2cnRrby51cnN1bGluQGlu dGVsLmNvbT4KPiAtLS0KPiAgIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZHJ2LmggICAgICAg ICAgfCAgNCArKy0tCj4gICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2dlbV9zaHJpbmtlci5j IHwgMjQgKysrKysrKysrKystLS0tLS0tLS0tLS0tCj4gICAyIGZpbGVzIGNoYW5nZWQsIDEzIGlu c2VydGlvbnMoKyksIDE1IGRlbGV0aW9ucygtKQo+IAo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dw dS9kcm0vaTkxNS9pOTE1X2Rydi5oIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9kcnYuaAo+ IGluZGV4IGM1ZjAxOTY0ZjBmYi4uMWNhZDIxOGI3MWQzIDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMv Z3B1L2RybS9pOTE1L2k5MTVfZHJ2LmgKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1 X2Rydi5oCj4gQEAgLTI5MTYsOSArMjkxNiw5IEBAIGk5MTVfZ2VtX29iamVjdF91bnBpbl9wYWdl cyhzdHJ1Y3QgZHJtX2k5MTVfZ2VtX29iamVjdCAqb2JqKQo+ICAgCV9faTkxNV9nZW1fb2JqZWN0 X3VucGluX3BhZ2VzKG9iaik7Cj4gICB9Cj4gICAKPiAtZW51bSBpOTE1X21tX3N1YmNsYXNzIHsg LyogbG9ja2RlcCBzdWJjbGFzcyBmb3Igb2JqLT5tbS5sb2NrICovCj4gK2VudW0gaTkxNV9tbV9z dWJjbGFzcyB7IC8qIGxvY2tkZXAgc3ViY2xhc3MgZm9yIG9iai0+bW0ubG9jay9zdHJ1Y3RfbXV0 ZXggKi8KPiAgIAlJOTE1X01NX05PUk1BTCA9IDAsCj4gLQlJOTE1X01NX1NIUklOS0VSCj4gKwlJ OTE1X01NX1NIUklOS0VSIC8qIGNhbGxlZCAicmVjdXJzaXZlbHkiIGZyb20gZGlyZWN0LXJlY2xh aW0tZXNxdWUgKi8KPiAgIH07Cj4gICAKPiAgIHZvaWQgX19pOTE1X2dlbV9vYmplY3RfcHV0X3Bh Z2VzKHN0cnVjdCBkcm1faTkxNV9nZW1fb2JqZWN0ICpvYmosCj4gZGlmZiAtLWdpdCBhL2RyaXZl cnMvZ3B1L2RybS9pOTE1L2k5MTVfZ2VtX3Nocmlua2VyLmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkx NS9pOTE1X2dlbV9zaHJpbmtlci5jCj4gaW5kZXggZWE5MGQzYTBkNTExLi5kNDYxZjQ1OGY0YWYg MTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9nZW1fc2hyaW5rZXIuYwo+ ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZ2VtX3Nocmlua2VyLmMKPiBAQCAtMzYs NyArMzYsOSBAQAo+ICAgI2luY2x1ZGUgImk5MTVfZHJ2LmgiCj4gICAjaW5jbHVkZSAiaTkxNV90 cmFjZS5oIgo+ICAgCj4gLXN0YXRpYyBib29sIHNocmlua2VyX2xvY2soc3RydWN0IGRybV9pOTE1 X3ByaXZhdGUgKmk5MTUsIGJvb2wgKnVubG9jaykKPiArc3RhdGljIGJvb2wgc2hyaW5rZXJfbG9j ayhzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqaTkxNSwKPiArCQkJICB1bnNpZ25lZCBpbnQgZmxh Z3MsCj4gKwkJCSAgYm9vbCAqdW5sb2NrKQo+ICAgewo+ICAgCXN3aXRjaCAobXV0ZXhfdHJ5bG9j a19yZWN1cnNpdmUoJmk5MTUtPmRybS5zdHJ1Y3RfbXV0ZXgpKSB7Cj4gICAJY2FzZSBNVVRFWF9U UllMT0NLX1JFQ1VSU0lWRToKPiBAQCAtNDUsMTUgKzQ3LDExIEBAIHN0YXRpYyBib29sIHNocmlu a2VyX2xvY2soc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmk5MTUsIGJvb2wgKnVubG9jaykKPiAg IAo+ICAgCWNhc2UgTVVURVhfVFJZTE9DS19GQUlMRUQ6Cj4gICAJCSp1bmxvY2sgPSBmYWxzZTsK PiAtCQlwcmVlbXB0X2Rpc2FibGUoKTsKPiAtCQlkbyB7Cj4gLQkJCWNwdV9yZWxheCgpOwo+IC0J CQlpZiAobXV0ZXhfdHJ5bG9jaygmaTkxNS0+ZHJtLnN0cnVjdF9tdXRleCkpIHsKPiAtCQkJCSp1 bmxvY2sgPSB0cnVlOwo+IC0JCQkJYnJlYWs7Cj4gLQkJCX0KPiAtCQl9IHdoaWxlICghbmVlZF9y ZXNjaGVkKCkpOwo+IC0JCXByZWVtcHRfZW5hYmxlKCk7Cj4gKwkJaWYgKGZsYWdzICYgSTkxNV9T SFJJTktfQUNUSVZFKSB7Cj4gKwkJCW11dGV4X2xvY2tfbmVzdGVkKCZpOTE1LT5kcm0uc3RydWN0 X211dGV4LAo+ICsJCQkJCSAgSTkxNV9NTV9TSFJJTktFUik7Cj4gKwkJCSp1bmxvY2sgPSB0cnVl Owo+ICsJCX0KCkkganVzdCByZWFsaXplZCBvbmNlIG9kZGl0eSBpbiB0aGUgc2hyaW5rZXIgY29k ZSB3aGljaCBlc2NhcGVkIG1lIApiZWZvcmUuIEl0IGlzIHRoZSBmYWN0IHRoZSBjYWxsIHBhdGhz IHdpbGwgY2FsbCB0aGUgc2hyaW5rZXJfbG9jayB0d2ljZS4gCkZvciBpbnN0YW5jZSBpOTE1X2dl bV9zaHJpbmtlcl92bWFwIGFuZCBpOTE1X2dlbV9zaHJpbmtlcl9zY2FuLiBUaGV5IApib3RoIGZp cnN0IHRha2UgbG9jayB3aXRoIGZsYWdzIG9mIHplcm8sIGFuZCB0aGVuIHRoZXkgY2FsbCAKaTkx NV9nZW1fc2hyaW5rIHdoaWNoIHRha2VzIHRoZSBsb2NrIGFnYWluLCB3aGljaCBvYnZpb3VzbHkg YWx3YXlzIApyZXN1bHRzIGluIHRoZSByZWN1cnNpdmUgcGF0aCB0byBiZSB0YWtlbi4KCkkgdGhp bmsgd2UgbmVlZCB0byBjbGVhbiB0aGlzIHVwIHNvIGl0IGlzIGVhc2llciB0byB1bmRlcnN0YW5k IHRoZSBjb2RlIApiZWZvcmUgZnVydGhlciB0d2Vha2luZywgZXZlbiBpZiBpbiB0aGlzIHBhdGNo LiBGb3IgaW5zdGFuY2UgYWRkaW5nIApJOTE1X1NIUklOS19MT0NLRUQgd291bGQgc29sdmUgaXQu CgpzaHJpbmtlcl9sb2NrX3VuaW50ZXJydXB0aWJsZSBpcyBhbHNvIGZ1bmt5IGluIHRoYXQgaXQg ZG9lc24ndCByZXNwZWN0IAp0aGUgdGltZW91dCBpbiB0aGUgd2FpdGluZyBmb3IgaWRsZSBwaGFz ZS4KClNvdW5kcyByZWFzb25hYmxlPwoKUmVnYXJkcywKClR2cnRrbwoKPiAgIAkJcmV0dXJuICp1 bmxvY2s7Cj4gICAKPiAgIAljYXNlIE1VVEVYX1RSWUxPQ0tfU1VDQ0VTUzoKPiBAQCAtMTYwLDcg KzE1OCw3IEBAIGk5MTVfZ2VtX3NocmluayhzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqaTkxNSwK PiAgIAl1bnNpZ25lZCBsb25nIHNjYW5uZWQgPSAwOwo+ICAgCWJvb2wgdW5sb2NrOwo+ICAgCj4g LQlpZiAoIXNocmlua2VyX2xvY2soaTkxNSwgJnVubG9jaykpCj4gKwlpZiAoIXNocmlua2VyX2xv Y2soaTkxNSwgZmxhZ3MsICZ1bmxvY2spKQo+ICAgCQlyZXR1cm4gMDsKPiAgIAo+ICAgCS8qCj4g QEAgLTM1Nyw3ICszNTUsNyBAQCBpOTE1X2dlbV9zaHJpbmtlcl9zY2FuKHN0cnVjdCBzaHJpbmtl ciAqc2hyaW5rZXIsIHN0cnVjdCBzaHJpbmtfY29udHJvbCAqc2MpCj4gICAKPiAgIAlzYy0+bnJf c2Nhbm5lZCA9IDA7Cj4gICAKPiAtCWlmICghc2hyaW5rZXJfbG9jayhpOTE1LCAmdW5sb2NrKSkK PiArCWlmICghc2hyaW5rZXJfbG9jayhpOTE1LCAwLCAmdW5sb2NrKSkKPiAgIAkJcmV0dXJuIFNI UklOS19TVE9QOwo+ICAgCj4gICAJZnJlZWQgPSBpOTE1X2dlbV9zaHJpbmsoaTkxNSwKPiBAQCAt Mzk3LDcgKzM5NSw3IEBAIHNocmlua2VyX2xvY2tfdW5pbnRlcnJ1cHRpYmxlKHN0cnVjdCBkcm1f aTkxNV9wcml2YXRlICppOTE1LCBib29sICp1bmxvY2ssCj4gICAJZG8gewo+ICAgCQlpZiAoaTkx NV9nZW1fd2FpdF9mb3JfaWRsZShpOTE1LAo+ICAgCQkJCQkgICAwLCBNQVhfU0NIRURVTEVfVElN RU9VVCkgPT0gMCAmJgo+IC0JCSAgICBzaHJpbmtlcl9sb2NrKGk5MTUsIHVubG9jaykpCj4gKwkJ ICAgIHNocmlua2VyX2xvY2soaTkxNSwgMCwgdW5sb2NrKSkKPiAgIAkJCWJyZWFrOwo+ICAgCj4g ICAJCXNjaGVkdWxlX3RpbWVvdXRfa2lsbGFibGUoMSk7Cj4gCl9fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fCkludGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwt Z2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9t YWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeAo=