Re: [PATCH 7/8] drm/i915/pmu: Wire up engine busy stats to PMU

Tvrtko Ursulin
2017-09-19T08:46:35Z

On 18/09/2017 15:58, Chris Wilson wrote:
> Quoting Tvrtko Ursulin (2017-09-18 12:38:13)
>> diff --git a/drivers/gpu/drm/i915/i915_pmu.c b/drivers/gpu/drm/i915/i915_pmu.c
>> index b7de6fe3cac7..ffba21eeb5d0 100644
>> --- a/drivers/gpu/drm/i915/i915_pmu.c
>> +++ b/drivers/gpu/drm/i915/i915_pmu.c
>> @@ -90,6 +90,11 @@ static unsigned int event_enabled_bit(struct perf_event *event)
>> return config_enabled_bit(event->attr.config);
>> }
>>
>> +static bool supports_busy_stats(void)
>> +{
>> + return i915.enable_execlists;
>> +}
>> +
>> static bool pmu_needs_timer(struct drm_i915_private *i915, bool gpu_active)
>> {
>> u64 enable;
>> @@ -115,6 +120,12 @@ static bool pmu_needs_timer(struct drm_i915_private *i915, bool gpu_active)
>> */
>> if (!gpu_active)
>> enable &= ~ENGINE_SAMPLE_MASK;
>> + /**
>
> /** kerneldoc?

I've managed to sprinkle quite a few of those around while added
comments. Finger memory, what can I say.. Another thing on the todo list.

Regards,

Tvrtko