From mboxrd@z Thu Jan 1 00:00:00 1970 From: Maarten Lankhorst Subject: Re: [PATCH i-g-t v2 09/15] igt_kms: Clear all _changed members centrally Date: Thu, 21 Jul 2016 14:43:09 +0200 Message-ID: References: <1467798955-7324-1-git-send-email-maarten.lankhorst@linux.intel.com> <1467798955-7324-10-git-send-email-maarten.lankhorst@linux.intel.com> <1469103220.2625.16.camel@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by gabe.freedesktop.org (Postfix) with ESMTP id 26CB86E171 for ; Thu, 21 Jul 2016 12:43:24 +0000 (UTC) In-Reply-To: <1469103220.2625.16.camel@gmail.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Ander Conselvan De Oliveira , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T3AgMjEtMDctMTYgb20gMTQ6MTMgc2NocmVlZiBBbmRlciBDb25zZWx2YW4gRGUgT2xpdmVpcmE6 Cj4gT24gV2VkLCAyMDE2LTA3LTA2IGF0IDExOjU1ICswMjAwLCBNYWFydGVuIExhbmtob3JzdCB3 cm90ZToKPj4gVGhpcyB3aWxsIG1ha2UgaXQgZWFzaWVyIHRvIHN1cHBvcnQgVEVTVF9PTkxZIGNv bW1pdHMuCj4+Cj4+IFNpZ25lZC1vZmYtYnk6IE1hYXJ0ZW4gTGFua2hvcnN0IDxtYWFydGVuLmxh bmtob3JzdEBsaW51eC5pbnRlbC5jb20+Cj4+IC0tLQo+PiAgbGliL2lndF9rbXMuYyB8IDg0ICsr KysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKystLS0tLS0tLS0tLS0tLS0tLS0tLS0tCj4+ IC0tLQo+PiAgMSBmaWxlIGNoYW5nZWQsIDQ4IGluc2VydGlvbnMoKyksIDM2IGRlbGV0aW9ucygt KQo+Pgo+PiBkaWZmIC0tZ2l0IGEvbGliL2lndF9rbXMuYyBiL2xpYi9pZ3Rfa21zLmMKPj4gaW5k ZXggOWZjNTU1OWE1ZGY0Li5kMGQwZGNmZjgxOTMgMTAwNjQ0Cj4+IC0tLSBhL2xpYi9pZ3Rfa21z LmMKPj4gKysrIGIvbGliL2lndF9rbXMuYwo+PiBAQCAtMTcyNywxMSArMTcyNyw2IEBAIGlndF9h dG9taWNfcHJlcGFyZV9wbGFuZV9jb21taXQoaWd0X3BsYW5lX3QgKnBsYW5lLAo+PiBpZ3RfcGlw ZV90ICpwaXBlLAo+PiAgCWlmIChwbGFuZS0+cm90YXRpb25fY2hhbmdlZCkKPj4gIAkJaWd0X2F0 b21pY19wb3B1bGF0ZV9wbGFuZV9yZXEocmVxLCBwbGFuZSwKPj4gIAkJCUlHVF9QTEFORV9ST1RB VElPTiwgcGxhbmUtPnJvdGF0aW9uKTsKPj4gLQo+PiAtCXBsYW5lLT5mYl9jaGFuZ2VkID0gZmFs c2U7Cj4+IC0JcGxhbmUtPnBvc2l0aW9uX2NoYW5nZWQgPSBmYWxzZTsKPj4gLQlwbGFuZS0+c2l6 ZV9jaGFuZ2VkID0gZmFsc2U7Cj4+IC0JcGxhbmUtPnJvdGF0aW9uX2NoYW5nZWQgPSBmYWxzZTsK Pj4gIH0KPj4gIAo+PiAgCj4+IEBAIC0xODE5LDE1ICsxODE0LDEwIEBAIHN0YXRpYyBpbnQgaWd0 X2RybV9wbGFuZV9jb21taXQoaWd0X3BsYW5lX3QgKnBsYW5lLAo+PiAgCQlDSEVDS19SRVRVUk4o cmV0LCBmYWlsX29uX2Vycm9yKTsKPj4gIAl9Cj4+ICAKPj4gLQlwbGFuZS0+ZmJfY2hhbmdlZCA9 IGZhbHNlOwo+PiAtCXBsYW5lLT5wb3NpdGlvbl9jaGFuZ2VkID0gZmFsc2U7Cj4+IC0JcGxhbmUt PnNpemVfY2hhbmdlZCA9IGZhbHNlOwo+PiAtCj4+ICAJaWYgKHBsYW5lLT5yb3RhdGlvbl9jaGFu Z2VkKSB7Cj4+ICAJCXJldCA9IGlndF9wbGFuZV9zZXRfcHJvcGVydHkocGxhbmUsIHBsYW5lLT5y b3RhdGlvbl9wcm9wZXJ0eSwKPj4gIAkJCQkgICAgICAgcGxhbmUtPnJvdGF0aW9uKTsKPj4gIAo+ PiAtCQlwbGFuZS0+cm90YXRpb25fY2hhbmdlZCA9IGZhbHNlOwo+PiAgCQlDSEVDS19SRVRVUk4o cmV0LCBmYWlsX29uX2Vycm9yKTsKPj4gIAl9Cj4+ICAKPj4gQEAgLTE4NzIsOCArMTg2Miw2IEBA IHN0YXRpYyBpbnQgaWd0X2N1cnNvcl9jb21taXRfbGVnYWN5KGlndF9wbGFuZV90ICpjdXJzb3Is Cj4+ICAJCX0KPj4gIAo+PiAgCQlDSEVDS19SRVRVUk4ocmV0LCBmYWlsX29uX2Vycm9yKTsKPj4g LQo+PiAtCQljdXJzb3ItPmZiX2NoYW5nZWQgPSBmYWxzZTsKPj4gIAl9Cj4+ICAKPj4gIAlpZiAo Y3Vyc29yLT5wb3NpdGlvbl9jaGFuZ2VkKSB7Cj4+IEBAIC0xODg3LDggKzE4NzUsNiBAQCBzdGF0 aWMgaW50IGlndF9jdXJzb3JfY29tbWl0X2xlZ2FjeShpZ3RfcGxhbmVfdCAqY3Vyc29yLAo+PiAg Cj4+ICAJCXJldCA9IGRybU1vZGVNb3ZlQ3Vyc29yKGRpc3BsYXktPmRybV9mZCwgY3J0Y19pZCwg eCwgeSk7Cj4+ICAJCUNIRUNLX1JFVFVSTihyZXQsIGZhaWxfb25fZXJyb3IpOwo+PiAtCj4+IC0J CWN1cnNvci0+cG9zaXRpb25fY2hhbmdlZCA9IGZhbHNlOwo+PiAgCX0KPj4gIAo+PiAgCXJldHVy biAwOwo+PiBAQCAtMTkxNSw3ICsxOTAxLDcgQEAgc3RhdGljIGludCBpZ3RfcHJpbWFyeV9wbGFu ZV9jb21taXRfbGVnYWN5KGlndF9wbGFuZV90Cj4+ICpwcmltYXJ5LAo+PiAgCWlndF9hc3NlcnQo IXByaW1hcnktPnJvdGF0aW9uX2NoYW5nZWQpOwo+PiAgCj4+ICAJaWYgKCFwcmltYXJ5LT5mYl9j aGFuZ2VkICYmICFwcmltYXJ5LT5wb3NpdGlvbl9jaGFuZ2VkICYmCj4+IC0JCSFwcmltYXJ5LT5z aXplX2NoYW5nZWQpCj4+ICsJICAgICFwcmltYXJ5LT5zaXplX2NoYW5nZWQpCj4+ICAJCXJldHVy biAwOwo+PiAgCj4+ICAJY3J0Y19pZCA9IHBpcGUtPmNydGNfaWQ7Cj4+IEBAIC0xOTU5LDkgKzE5 NDUsNiBAQCBzdGF0aWMgaW50IGlndF9wcmltYXJ5X3BsYW5lX2NvbW1pdF9sZWdhY3koaWd0X3Bs YW5lX3QKPj4gKnByaW1hcnksCj4+ICAJQ0hFQ0tfUkVUVVJOKHJldCwgZmFpbF9vbl9lcnJvcik7 Cj4+ICAKPj4gIAlwcmltYXJ5LT5waXBlLT5lbmFibGVkID0gKGZiX2lkICE9IDApOwo+PiAtCXBy aW1hcnktPmZiX2NoYW5nZWQgPSBmYWxzZTsKPj4gLQlwcmltYXJ5LT5wb3NpdGlvbl9jaGFuZ2Vk ID0gZmFsc2U7Cj4+IC0JcHJpbWFyeS0+c2l6ZV9jaGFuZ2VkID0gZmFsc2U7Cj4+ICAKPj4gIAly ZXR1cm4gMDsKPj4gIH0KPj4gQEAgLTE5ODIsNyArMTk2NSw3IEBAIHN0YXRpYyBpbnQgaWd0X3Bs YW5lX2NvbW1pdChpZ3RfcGxhbmVfdCAqcGxhbmUsCj4+ICAJCXJldHVybiBpZ3RfcHJpbWFyeV9w bGFuZV9jb21taXRfbGVnYWN5KHBsYW5lLCBwaXBlLAo+PiAgCQkJCQkJICAgICAgIGZhaWxfb25f ZXJyb3IpOwo+PiAgCX0gZWxzZSB7Cj4+IC0JCQlyZXR1cm4gaWd0X2RybV9wbGFuZV9jb21taXQo cGxhbmUsIHBpcGUsCj4+IGZhaWxfb25fZXJyb3IpOwo+PiArCQlyZXR1cm4gaWd0X2RybV9wbGFu ZV9jb21taXQocGxhbmUsIHBpcGUsIGZhaWxfb25fZXJyb3IpOwo+PiAgCX0KPj4gIH0KPj4gIAo+ PiBAQCAtMjAwOCw4ICsxOTkxLDYgQEAgc3RhdGljIGludCBpZ3RfcGlwZV9jb21taXQoaWd0X3Bp cGVfdCAqcGlwZSwKPj4gIAlpZiAocGlwZS0+YmFja2dyb3VuZF9jaGFuZ2VkKSB7Cj4+ICAJCWln dF9jcnRjX3NldF9wcm9wZXJ0eShwaXBlLCBwaXBlLT5iYWNrZ3JvdW5kX3Byb3BlcnR5LAo+PiAg CQkJcGlwZS0+YmFja2dyb3VuZCk7Cj4+IC0KPj4gLQkJcGlwZS0+YmFja2dyb3VuZF9jaGFuZ2Vk ID0gZmFsc2U7Cj4+ICAJfQo+PiAgCj4+ICAJaWYgKHBpcGUtPmNvbG9yX21nbXRfY2hhbmdlZCkg ewo+PiBAQCAtMjAxOSw4ICsyMDAwLDYgQEAgc3RhdGljIGludCBpZ3RfcGlwZV9jb21taXQoaWd0 X3BpcGVfdCAqcGlwZSwKPj4gIAkJCQkgICAgICBwaXBlLT5jdG1fYmxvYik7Cj4+ICAJCWlndF9j cnRjX3NldF9wcm9wZXJ0eShwaXBlLCBwaXBlLT5nYW1tYV9wcm9wZXJ0eSwKPj4gIAkJCQkgICAg ICBwaXBlLT5nYW1tYV9ibG9iKTsKPj4gLQo+PiAtCQlwaXBlLT5jb2xvcl9tZ210X2NoYW5nZWQg PSBmYWxzZTsKPj4gIAl9Cj4+ICAKPj4gIAlmb3IgKGkgPSAwOyBpIDwgcGlwZS0+bl9wbGFuZXM7 IGkrKykgewo+PiBAQCAtMjE0MCwzNSArMjExOSw2OCBAQCBzdGF0aWMgaW50IGRvX2Rpc3BsYXlf Y29tbWl0KGlndF9kaXNwbGF5X3QgKmRpc3BsYXksCj4+ICAJCQkgICAgIGJvb2wgZmFpbF9vbl9l cnJvcikKPj4gIHsKPj4gIAlpbnQgaSwgcmV0Owo+PiAtCWludCB2YWxpZF9vdXRzID0gMDsKPj4g LQo+PiArCWVudW0gcGlwZSBwaXBlOwo+PiAgCUxPR19JTkRFTlQoZGlzcGxheSwgImNvbW1pdCIp Owo+PiAgCj4+ICAJaWd0X2Rpc3BsYXlfcmVmcmVzaChkaXNwbGF5KTsKPj4gIAo+PiAgCWlmIChz ID09IENPTU1JVF9BVE9NSUMpIHsKPj4gLQo+PiAgCQlyZXQgPSBpZ3RfYXRvbWljX2NvbW1pdChk aXNwbGF5KTsKPj4gKwo+PiAgCQlDSEVDS19SRVRVUk4ocmV0LCBmYWlsX29uX2Vycm9yKTsKPj4g LQkJcmV0dXJuIDA7Cj4+ICsJfSBlbHNlIHsKPj4gKwkJaW50IHZhbGlkX291dHMgPSAwOwo+PiAg Cj4+IC0JfQo+PiArCQlmb3JfZWFjaF9waXBlKGRpc3BsYXksIHBpcGUpIHsKPj4gKwkJCWlndF9w aXBlX3QgKnBpcGVfb2JqID0gJmRpc3BsYXktPnBpcGVzW3BpcGVdOwo+PiArCQkJaWd0X291dHB1 dF90ICpvdXRwdXQgPSBpZ3RfcGlwZV9nZXRfb3V0cHV0KHBpcGVfb2JqKTsKPj4gIAo+PiAtCWZv cl9lYWNoX3BpcGUoZGlzcGxheSwgaSkgewo+PiAtCQlpZ3RfcGlwZV90ICpwaXBlX29iaiA9ICZk aXNwbGF5LT5waXBlc1tpXTsKPj4gLQkJaWd0X291dHB1dF90ICpvdXRwdXQgPSBpZ3RfcGlwZV9n ZXRfb3V0cHV0KHBpcGVfb2JqKTsKPj4gKwkJCWlmIChvdXRwdXQgJiYgb3V0cHV0LT52YWxpZCkK Pj4gKwkJCQl2YWxpZF9vdXRzKys7Cj4+ICAKPj4gLQkJaWYgKG91dHB1dCAmJiBvdXRwdXQtPnZh bGlkKQo+PiAtCQkJdmFsaWRfb3V0cysrOwo+PiArCQkJcmV0ID0gaWd0X3BpcGVfY29tbWl0KHBp cGVfb2JqLCBzLCBmYWlsX29uX2Vycm9yKTsKPj4gKwkJCUNIRUNLX1JFVFVSTihyZXQsIGZhaWxf b25fZXJyb3IpOwo+PiArCQl9Cj4+ICAKPj4gLQkJcmV0ID0gaWd0X3BpcGVfY29tbWl0KHBpcGVf b2JqLCBzLCBmYWlsX29uX2Vycm9yKTsKPj4gIAkJQ0hFQ0tfUkVUVVJOKHJldCwgZmFpbF9vbl9l cnJvcik7Cj4+ICsKPj4gKwkJaWYgKHZhbGlkX291dHMgPT0gMCkgewo+PiArCQkJTE9HX1VOSU5E RU5UKGRpc3BsYXkpOwo+PiArCj4+ICsJCQlyZXR1cm4gLTE7Cj4+ICsJCX0KPj4gIAl9Cj4+ICAK Pj4gIAlMT0dfVU5JTkRFTlQoZGlzcGxheSk7Cj4+ICAKPj4gLQlpZiAodmFsaWRfb3V0cyA9PSAw KQo+PiAtCQlyZXR1cm4gLTE7Cj4+ICsJaWYgKHJldCkKPj4gKwkJcmV0dXJuIHJldDsKPj4gKwo+ PiArCWZvcl9lYWNoX3BpcGUoZGlzcGxheSwgcGlwZSkgewo+PiArCQlpZ3RfcGlwZV90ICpwaXBl X29iaiA9ICZkaXNwbGF5LT5waXBlc1twaXBlXTsKPj4gKwkJaWd0X3BsYW5lX3QgKnBsYW5lOwo+ PiArCj4+ICsJCWlmIChzID09IENPTU1JVF9BVE9NSUMpIHsKPj4gKwkJCXBpcGVfb2JqLT5jb2xv cl9tZ210X2NoYW5nZWQgPSBmYWxzZTsKPj4gKwkJCXBpcGVfb2JqLT5iYWNrZ3JvdW5kX2NoYW5n ZWQgPSBmYWxzZTsKPj4gKwkJfQo+IElmIHRoaXMgaXMgc3VwcG9zZWQgdG8gbWF0Y2ggdGhlIHBy ZXZpb3VzIGJlaGF2aW9yLCBzaG91bGRuJ3QgdGhlIGNvbmRpdGlvbiBiZQo+ICIhPSBDT01NSVRf QVRPTUlDIi4gQm90aCBmbGFncyBhcmUgc2V0IGZyb20gaWd0X3BpcGVfY29tbWl0KCkgd2hpY2gg aXMgbm90Cj4gY2FsbGVkIGluIHRoZSBhdG9taWMgY2FzZS4gSG93ZXZlciwgdGhlIGZsYWdzIGFy ZW4ndCBzZXQgdG8gZmFsc2UgaW4KPiBpZ3RfYXRvbWljX3ByZXBhcmVfY3J0Y19jb21taXQoKS4g VGhhdCBhY3R1YWxseSBzb3VuZHMgbGlrZSBhIGJ1Zz8KSSB0aGluayB5b3UncmUgcmlnaHQsIHJl YWwgZml4IGlzIHRvIGp1c3QgdXBkYXRlIHRob3NlIGF0b21pY2FsbHkgdG9vLiA6KQo+PiArCj4+ ICsJCWZvcl9lYWNoX3BsYW5lX29uX3BpcGUoZGlzcGxheSwgcGlwZSwgcGxhbmUpIHsKPj4gKwkJ CXBsYW5lLT5mYl9jaGFuZ2VkID0gZmFsc2U7Cj4+ICsJCQlwbGFuZS0+cG9zaXRpb25fY2hhbmdl ZCA9IGZhbHNlOwo+PiArCQkJcGxhbmUtPnNpemVfY2hhbmdlZCA9IGZhbHNlOwo+PiArCj4+ICsJ CQlpZiAocyAhPSBDT01NSVRfTEVHQUNZIHx8ICEocGxhbmUtPmlzX3ByaW1hcnkgfHwgCj4+IHBs YW5lLT5pc19jdXJzb3IpKQo+PiArCQkJCXBsYW5lLT5yb3RhdGlvbl9jaGFuZ2VkID0gZmFsc2U7 Cj4gQ2FuJ3QgcGxhbmUtPnJvdGF0aW9uX2NoYW5nZWQgYmUgc2V0IHVuY29uZGl0aW9uYWxseSBo ZXJlPyBUaGUgbGVnYWN5IHByaW1hcnkKPiBwbGFuZSBjb21taXQgaGFzIGFuIGFzc2VydCBmb3Ig cm90YXRpb25fY2hhbmdlZCA9PSBmYWxzZSBhbmQgcGVyaGFwcyB0aGUgY3Vyc29yCj4gdmVyc2lv biBzaG91bGQgaGF2ZSB0aGUgc2FtZS4KVGhpcyBpcyBzcGVjaWZpY2FsbHkgdG8gZXhjbHVkZSBz ID09IENPTU1JVF9MRUdBQ1kgJiYgKHBsYW5lLT5pc19wcmltYXJ5IHx8IHBsYW5lLT5pc19jdXJz b3IpLAp3ZSBkb24ndCB1cGRhdGUgcm90YXRpb25fY2hhbmdlZCBpbiB0aGlzIGNhc2UuCgpNYXli ZSBJIHNob3VsZCBqdXN0IGFkZCBhbiBhc3NlcnQgdG8gdGhlIGxlZ2FjeSB1cGRhdGUgZnVuY3Rp b25zIGluc3RlYWQuCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fCkludGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9y ZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdm eAo=