From: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
To: Jani Nikula <jani.nikula@intel.com>,
intel-gfx@lists.freedesktop.org, Peter Wu <peter@lekensteyn.nl>
Subject: Re: [PATCH v3] drm/i915/opregion: update cadl based on actually active outputs
Date: Mon, 13 Jun 2016 12:21:53 +0200 [thread overview]
Message-ID: <ecf5f5dc-7b29-7d16-2696-efad0fe8a873@linux.intel.com> (raw)
In-Reply-To: <1465812007-2353-1-git-send-email-jani.nikula@intel.com>
Op 13-06-16 om 12:00 schreef Jani Nikula:
> Previously we've just shoved the first eight devices in DIDL to CADL
> (list of active outputs). Some of the active outputs may have been left
> outside of CADL. The problem is, some BIOS implementations prevent
> laptop brightness hotkey propagation if the flat panel is not active.
>
> Now that we have connector to acpi device id mapping covered, we can
> update CADL based on which outputs are actually active.
>
> v3: actually git add the dev->dev_priv change.
>
Can CADL be set before the crtc's are updated?
It seems to me it should be set after intel_shared_dpll_commit,
since that's when we update all sw state. And put behind a if (intel_state->modeset),
it's not allowed to walk the connector list otherwise. We get away with it now
because we always take mode_config.mutex.
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2016-06-13 10:21 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-13 9:30 [PATCH v2 0/5] drm/i915/opregion: proper handling of DIDL and CADL Jani Nikula
2016-06-13 9:30 ` [PATCH v2 1/5] drm/i915/opregion: add acpi defines from the spec Jani Nikula
2016-06-13 9:30 ` [PATCH v2 2/5] drm/i915/opregion: abstract acpi display type getter for a connector Jani Nikula
2016-06-13 9:30 ` [PATCH v2 3/5] drm/i915/opregion: handle missing connector types for acpi display types Jani Nikula
2016-06-29 14:53 ` Jani Nikula
2016-06-13 9:30 ` [PATCH v2 4/5] drm/i915: make i915 the source of acpi device ids for _DOD Jani Nikula
2016-06-13 9:30 ` [PATCH v2 5/5] drm/i915/opregion: update cadl based on actually active outputs Jani Nikula
2016-06-13 9:57 ` kbuild test robot
2016-06-13 10:00 ` [PATCH v3] " Jani Nikula
2016-06-13 10:21 ` Maarten Lankhorst [this message]
2016-06-13 10:25 ` [PATCH v2 5/5] " kbuild test robot
2016-06-13 9:43 ` ✗ Ro.CI.BAT: failure for drm/i915/opregion: proper handling of DIDL and CADL (rev2) Patchwork
2016-06-13 10:29 ` ✗ Ro.CI.BAT: failure for drm/i915/opregion: proper handling of DIDL and CADL (rev3) Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ecf5f5dc-7b29-7d16-2696-efad0fe8a873@linux.intel.com \
--to=maarten.lankhorst@linux.intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jani.nikula@intel.com \
--cc=peter@lekensteyn.nl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox