Re: [PATCH 2/5] drm/i915: Convert BUGs to WARNs in the video overlay code

Ville Syrjälä
2015-03-31T14:59:23Z

On Tue, Mar 31, 2015 at 01:27:04PM +0100, Chris Wilson wrote:
> On Tue, Mar 31, 2015 at 10:37:22AM +0300, ville.syrjala@linux.intel.com wrote:
> > From: Ville Syrjälä <ville.syrjala@linux.intel.com>
> >
> > BUG is bad, just use WARN.
> >
> > Also drop one BUG(!overlay) since we'd oops anyway when dereferencing
> > it.
>
> Bonus points for erroring out rather than continuing to nose dive into a
> crash. At least that way userspace should stop trying as well.

I have the feeling it shouldn't really blow up if we keep going in these
cases. I didn't do a very thorough analysis though.

I didn't want to start coding too defensively as there's practically no
limit on how far down that path we could go. So a line has to be drawn
somewhere.

--
Ville Syrjälä
Intel OTC