From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Souza, Jose" Subject: Re: [PATCH v2 07/11] drm/i915/psr: Check if resolution is supported by default SU granularity Date: Mon, 3 Dec 2018 20:40:48 +0000 Message-ID: References: <20181130022525.25676-1-jose.souza@intel.com> <20181130022525.25676-7-jose.souza@intel.com> <49f3e74eab793822bb628d55f0ada752a3a33af1.camel@intel.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1377466739==" Return-path: In-Reply-To: <49f3e74eab793822bb628d55f0ada752a3a33af1.camel@intel.com> Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: "intel-gfx@lists.freedesktop.org" , "Pandiyan, Dhinakaran" Cc: "dri-devel@lists.freedesktop.org" , "Vivi, Rodrigo" List-Id: intel-gfx@lists.freedesktop.org --===============1377466739== Content-Language: en-US Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="=-nMiA/zXwbTeJCCAGIA+M" --=-nMiA/zXwbTeJCCAGIA+M Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Fri, 2018-11-30 at 16:37 -0800, Dhinakaran Pandiyan wrote: > On Thu, 2018-11-29 at 18:25 -0800, Jos=C3=A9 Roberto de Souza wrote: > > Selective updates have a default granularity requirements as stated > > by eDP spec > Needs reference to the location in the spec. Done >=20 > > , so check if HW can match those requirements before > > enable PSR2. > typo: enabling* Done >=20 > > Cc: Dhinakaran Pandiyan > > Cc: Rodrigo Vivi > > Signed-off-by: Jos=C3=A9 Roberto de Souza > > --- > > drivers/gpu/drm/i915/intel_psr.c | 12 ++++++++++++ > > 1 file changed, 12 insertions(+) > >=20 > > diff --git a/drivers/gpu/drm/i915/intel_psr.c > > b/drivers/gpu/drm/i915/intel_psr.c > > index c4a8f476eea9..282ff1bc68a7 100644 > > --- a/drivers/gpu/drm/i915/intel_psr.c > > +++ b/drivers/gpu/drm/i915/intel_psr.c > > @@ -539,6 +539,18 @@ static bool intel_psr2_config_valid(struct > > intel_dp *intel_dp, > > return false; > > } > > =20 > > + /* HW will always send full lines in SU blocks, so X will > s/X/starting X coordinate >=20 > > + * always be 0 and we only need to check the width to validate > > + * horizontal granularity. > > + * About vertical granularity HW works by SU blocks starting > > + * at each 4 lines with height of 4 lines, what eDP states > > + * that sink should support. > How about rewriting this as - =20 > "HW sends SU blocks of size four scan lines, which means the starting > X > coordinate and Y granularity requirements will always be met. We only > need to validate the SU block width is a multiple of 4."? >=20 >=20 Sounds better, thanks >=20 >=20 > > + */ > > + if (crtc_hdisplay % 4) { > > + DRM_DEBUG_KMS("PSR2 not enabled, default SU granularity > > not match\n"); > "PSR2 not enabled, hdisplay(%d) not multiple of 4\n" Done. >=20 > With nits addressed, >=20 > Reviewed-by: Dhinakaran Pandiyan >=20 Thanks > > + return false; > > + } > > + > > return true; > > } > > =20 --=-nMiA/zXwbTeJCCAGIA+M Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- iQEzBAABCAAdFiEEVNG051EijGa0MiaQVenbO/mOWkkFAlwFlM8ACgkQVenbO/mO WklRywf9Ha4cnRMKODGQ1epXVUBIPuIMHncYgp6E6yW4HYBRIO/4QDIC1RIYtTib xm8JhxJviZpSXdYApx31zNshBrPWn/o4lnmqiPgAVZeE7bNbTJJMfh6CN0nAxH0/ vbpr+wxJvljsqOSTxYjDkDo3cfEYgkxrijqXoC1QtxVmG17IBVCkG93GtpLLsH50 QP8FQrXietqzjeMiU2LTKiPUX0xCqZwDLr4whAWJRkxAXfHgv2kZtZ+RlB9JyhaY bpMQVM831UraJ0uQnERStvWKrbTk1VcO3sEKOlXcp85bQnwLm9EiSvmx9BfBxohl 5U4KY5fK4IIGzhPEx+BiICUS7uF62A== =fgv3 -----END PGP SIGNATURE----- --=-nMiA/zXwbTeJCCAGIA+M-- --===============1377466739== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg== --===============1377466739==--