From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tvrtko Ursulin Subject: Re: [PATCH] drm/i915/query: Split out query item checks Date: Wed, 9 Jan 2019 09:25:49 +0000 Message-ID: References: <20190109075108.16779-1-abdiel.janulgue@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by gabe.freedesktop.org (Postfix) with ESMTPS id 239EC6EBF1 for ; Wed, 9 Jan 2019 09:25:52 +0000 (UTC) In-Reply-To: <20190109075108.16779-1-abdiel.janulgue@linux.intel.com> Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Abdiel Janulgue , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org Ck9uIDA5LzAxLzIwMTkgMDc6NTEsIEFiZGllbCBKYW51bGd1ZSB3cm90ZToKPiBUaGlzIHNpbXBs aWZpZXMgYWRkaW5nIG5ldyBxdWVyeSBpdGVtIG9iamVjdHMuCj4gCj4gU2lnbmVkLW9mZi1ieTog QWJkaWVsIEphbnVsZ3VlIDxhYmRpZWwuamFudWxndWVAbGludXguaW50ZWwuY29tPgo+IENjOiBK b29uYXMgTGFodGluZW4gPGpvb25hcy5sYWh0aW5lbkBsaW51eC5pbnRlbC5jb20+Cj4gLS0tCj4g ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X3F1ZXJ5LmMgfCA0MCArKysrKysrKysrKysrKysr KysrKy0tLS0tLS0tLS0tCj4gICAxIGZpbGUgY2hhbmdlZCwgMjYgaW5zZXJ0aW9ucygrKSwgMTQg ZGVsZXRpb25zKC0pCj4gCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVf cXVlcnkuYyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfcXVlcnkuYwo+IGluZGV4IGNiY2I5 NTdiNzE0MS4uYjRmMjY2MDVmNjE3IDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1 L2k5MTVfcXVlcnkuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfcXVlcnkuYwo+ IEBAIC0xMCwxMiArMTAsMzMgQEAKPiAgICNpbmNsdWRlICJpOTE1X3F1ZXJ5LmgiCj4gICAjaW5j bHVkZSA8dWFwaS9kcm0vaTkxNV9kcm0uaD4KPiAgIAo+ICtzdGF0aWMgaW50IGluaXRfcXVlcnlf aXRlbV9jaGVjayh2b2lkKiBkYXRhX3B0ciwgc2l6ZV90IGRhdGFfc3osCgp2b2lkICpwdHIKCmRh dGFfIHByZWZpeCBpcyBub3QgaWRlYWwgc2luY2UgdGhpcyBpcyBub3QgdGhlIHRyYWlsaW5nIGRh dGEgYnV0IHRoZSAKcXVlcnkgaGVhZGVyLiBNYXliZSBxdWVyeV8gPwoKPiArCQkJCSB1MzIgdG90 YWxfbGVuZ3RoLAo+ICsJCQkJIHN0cnVjdCBkcm1faTkxNV9xdWVyeV9pdGVtICpxdWVyeV9pdGVt KQo+ICt7Cj4gKwlpZiAocXVlcnlfaXRlbS0+bGVuZ3RoID09IDApCj4gKwkJcmV0dXJuIHRvdGFs X2xlbmd0aDsKPiArCj4gKwlpZiAocXVlcnlfaXRlbS0+bGVuZ3RoIDwgdG90YWxfbGVuZ3RoKQo+ ICsJCXJldHVybiAtRUlOVkFMOwo+ICsKPiArCWlmIChjb3B5X2Zyb21fdXNlcihkYXRhX3B0ciwg dTY0X3RvX3VzZXJfcHRyKHF1ZXJ5X2l0ZW0tPmRhdGFfcHRyKSwKPiArCQkJICAgZGF0YV9zeikp Cj4gKwkJcmV0dXJuIC1FRkFVTFQ7CgpJcyBsb3N0IHR5cGUgaW5mb3JtYXRpb24gYSBjb25jZXJu IHdpdGggY29weV9mcm9tX3VzZXIuLiBsZXQgbWUgY2hlY2suLiAKSSBhbSBub3Qgc3VyZSBUQkgu LiB0aGVyZSBzZWVtcyB0byBiZSB0eXBlIGJhc2VkIG9iamVjdCBzaXplIGNoZWNrIGluIAp0aGVy ZSBidXQgZG9lcyBpdCB3b3JrIHdoZW4gaW5kaXJlY3RlZCB2aWEgdm9pZCo/Cgo+ICsKPiArCWlm ICghYWNjZXNzX29rKHU2NF90b191c2VyX3B0cihxdWVyeV9pdGVtLT5kYXRhX3B0ciksCj4gKwkJ ICAgICAgIHRvdGFsX2xlbmd0aCkpCj4gKwkJcmV0dXJuIC1FRkFVTFQ7CgpLaW5kIG9mIE9LLCBi dXQgcHJldmVudHMgdGhlIGNvZGUgZm9yIGNoZWNraW5nIHRoZSB3aG9sZSB1c2VyIHN1cHBsaWVk IApidWZmZXIgaW4gcXVlcmllcyB3aGljaCBjYXJyeSB0aGUgbGVuZ3RoIGZpZWxkLiAoRW5naW5l IGRpc2NvdmVyeSBpcyBvbmUgCm9mIHRoZW0uKSBBcmd1bWVudCB0aGVyZSB3YXMgd2h5IGNoZWNr IG1vcmUgdGhhbiB3ZSB3aWxsIHdyaXRlIC0gdG8gCmNhdGNoIHVzZXJzcGFjZSBhY2NpZGVudGFs bHkgcGFzc2luZyBpbiBhIHNtYWxsZXIgYnVmZmVyIHRoYW4gaXQgdGhpbmtzIAppdCBpcyBwYXNz aW5nIGluLiBCdXQgaXQgaXMgcHJvYmFibHkgbm90IGFuIGltcG9ydGFudCBlbm91Z2ggY29uY2Vy biB0byAKcHJldmVudCBjb2RlIGNvbnNvbGlkYXRpb24uCgpTbyBJIHRoaW5rIGZvciBtZSB0aGF0 IGxlYXZlcyB0aGUgcXVlc3Rpb24gb2YgdHlwZSBzYWZldHkgb24gdGhlIGZpcnN0IApjaGVjay4K Cj4gKwo+ICsJcmV0dXJuIDA7Cj4gK30KPiArCj4gICBzdGF0aWMgaW50IHF1ZXJ5X3RvcG9sb2d5 X2luZm8oc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2LAo+ICAgCQkJICAgICAgIHN0 cnVjdCBkcm1faTkxNV9xdWVyeV9pdGVtICpxdWVyeV9pdGVtKQo+ICAgewo+ICAgCWNvbnN0IHN0 cnVjdCBzc2V1X2Rldl9pbmZvICpzc2V1ID0gJlJVTlRJTUVfSU5GTyhkZXZfcHJpdiktPnNzZXU7 Cj4gICAJc3RydWN0IGRybV9pOTE1X3F1ZXJ5X3RvcG9sb2d5X2luZm8gdG9wbzsKPiAtCXUzMiBz bGljZV9sZW5ndGgsIHN1YnNsaWNlX2xlbmd0aCwgZXVfbGVuZ3RoLCB0b3RhbF9sZW5ndGg7Cj4g Kwl1MzIgcmV0LCBzbGljZV9sZW5ndGgsIHN1YnNsaWNlX2xlbmd0aCwgZXVfbGVuZ3RoLCB0b3Rh bF9sZW5ndGg7CgppbnQgcmV0OwoKPiAgIAo+ICAgCWlmIChxdWVyeV9pdGVtLT5mbGFncyAhPSAw KQo+ICAgCQlyZXR1cm4gLUVJTlZBTDsKPiBAQCAtMzMsMjMgKzU0LDE0IEBAIHN0YXRpYyBpbnQg cXVlcnlfdG9wb2xvZ3lfaW5mbyhzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYsCj4g ICAKPiAgIAl0b3RhbF9sZW5ndGggPSBzaXplb2YodG9wbykgKyBzbGljZV9sZW5ndGggKyBzdWJz bGljZV9sZW5ndGggKyBldV9sZW5ndGg7Cj4gICAKPiAtCWlmIChxdWVyeV9pdGVtLT5sZW5ndGgg PT0gMCkKPiAtCQlyZXR1cm4gdG90YWxfbGVuZ3RoOwo+IC0KPiAtCWlmIChxdWVyeV9pdGVtLT5s ZW5ndGggPCB0b3RhbF9sZW5ndGgpCj4gLQkJcmV0dXJuIC1FSU5WQUw7Cj4gLQo+IC0JaWYgKGNv cHlfZnJvbV91c2VyKCZ0b3BvLCB1NjRfdG9fdXNlcl9wdHIocXVlcnlfaXRlbS0+ZGF0YV9wdHIp LAo+IC0JCQkgICBzaXplb2YodG9wbykpKQo+IC0JCXJldHVybiAtRUZBVUxUOwo+ICsJcmV0ID0g aW5pdF9xdWVyeV9pdGVtX2NoZWNrKCZ0b3BvLCBzaXplb2YodG9wbyksIHRvdGFsX2xlbmd0aCwK PiArCQkJCSAgICBxdWVyeV9pdGVtKTsKPiArCWlmIChyZXQgIT0gMCkKPiArCQlyZXR1cm4gcmV0 Owo+ICAgCj4gICAJaWYgKHRvcG8uZmxhZ3MgIT0gMCkKPiAgIAkJcmV0dXJuIC1FSU5WQUw7Cj4g ICAKPiAtCWlmICghYWNjZXNzX29rKHU2NF90b191c2VyX3B0cihxdWVyeV9pdGVtLT5kYXRhX3B0 ciksCj4gLQkJICAgICAgIHRvdGFsX2xlbmd0aCkpCj4gLQkJcmV0dXJuIC1FRkFVTFQ7Cj4gLQo+ ICAgCW1lbXNldCgmdG9wbywgMCwgc2l6ZW9mKHRvcG8pKTsKPiAgIAl0b3BvLm1heF9zbGljZXMg PSBzc2V1LT5tYXhfc2xpY2VzOwo+ICAgCXRvcG8ubWF4X3N1YnNsaWNlcyA9IHNzZXUtPm1heF9z dWJzbGljZXM7Cj4gCgpSZWdhcmRzLAoKVHZydGtvCl9fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fCkludGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxp c3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFu L2xpc3RpbmZvL2ludGVsLWdmeAo=