From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chris Wilson Subject: Re: [PATCH 4/4] drm/i915: don't rewrite the GTT on resume v3 Date: Fri, 02 Nov 2012 15:16:36 +0000 Message-ID: References: <1351723265-4086-1-git-send-email-jbarnes@virtuousgeek.org> <1351723265-4086-4-git-send-email-jbarnes@virtuousgeek.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mga14.intel.com (mga14.intel.com [143.182.124.37]) by gabe.freedesktop.org (Postfix) with ESMTP id 4D5EC9E860 for ; Fri, 2 Nov 2012 08:17:23 -0700 (PDT) In-Reply-To: <1351723265-4086-4-git-send-email-jbarnes@virtuousgeek.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Jesse Barnes , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Wed, 31 Oct 2012 15:41:05 -0700, Jesse Barnes wrote: > The BIOS shouldn't be touching this memory across suspend/resume, so > just leave it alone. This saves us ~6ms on resume on my T420 (retested > with write combined PTEs). > > v2: change gtt restore default on pre-gen4 (Chris) > move needs_gtt_restore flag into dev_priv > v3: make sure we restore GTT on resume from hibernate (Daniel) > use opregion support as the cutoff for restore from resume (Chris) > > Signed-off-by: Jesse Barnes My troublesome PNV of yore remains happy with this patch, so Reviewed-by: Chris Wilson Bikeshed: intel_bios_has_opregion(), as we test for this in different locations in different ways. -Chris -- Chris Wilson, Intel Open Source Technology Centre