From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,PDS_BAD_THREAD_QP_64,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EC60DC47082 for ; Thu, 3 Jun 2021 07:37:35 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id AB5E3613D6 for ; Thu, 3 Jun 2021 07:37:35 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org AB5E3613D6 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=intel-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 4B9F36F413; Thu, 3 Jun 2021 07:37:35 +0000 (UTC) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by gabe.freedesktop.org (Postfix) with ESMTPS id BBCBF6F414 for ; Thu, 3 Jun 2021 07:37:33 +0000 (UTC) IronPort-SDR: /RfZDN89EGCdkc8ILm4yK7SWUZVngFbGrCZqaM6eMhR5EPgA/Hh9y/w0tbffO0CsTyElS1MWzo GfGgZQPox4OA== X-IronPort-AV: E=McAfee;i="6200,9189,10003"; a="203977707" X-IronPort-AV: E=Sophos;i="5.83,244,1616482800"; d="scan'208";a="203977707" Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Jun 2021 00:37:31 -0700 IronPort-SDR: tlJ8kA1ULd9qNfeu2iVer8HfPGpIkWXSTG4+1Cmdc/5DxIqva0yt8C6J2dHWDo48H7eNh+UMYj PyUHj+pPRu5A== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.83,244,1616482800"; d="scan'208";a="549835241" Received: from irsmsx606.ger.corp.intel.com ([163.33.146.139]) by orsmga004.jf.intel.com with ESMTP; 03 Jun 2021 00:37:30 -0700 Received: from irsmsx603.ger.corp.intel.com (163.33.146.9) by IRSMSX606.ger.corp.intel.com (163.33.146.139) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.4; Thu, 3 Jun 2021 08:37:29 +0100 Received: from irsmsx603.ger.corp.intel.com ([163.33.146.9]) by irsmsx603.ger.corp.intel.com ([163.33.146.9]) with mapi id 15.01.2242.008; Thu, 3 Jun 2021 08:37:29 +0100 From: "Saarinen, Jani" To: "Kulkarni, Vandita" , "intel-gfx@lists.freedesktop.org" Thread-Topic: [Intel-gfx] [PATCH] drm/i915/dsc: Remove redundant checks in DSC disable Thread-Index: AQHXWEe27rwtQ1K7Ckir2cBzMejrGqsB5fOA Date: Thu, 3 Jun 2021 07:37:29 +0000 Message-ID: References: <20210603065356.15435-1-vandita.kulkarni@intel.com> In-Reply-To: <20210603065356.15435-1-vandita.kulkarni@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.5.1.3 dlp-reaction: no-action dlp-product: dlpe-windows x-originating-ip: [10.184.70.1] MIME-Version: 1.0 Subject: Re: [Intel-gfx] [PATCH] drm/i915/dsc: Remove redundant checks in DSC disable X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "Nikula, Jani" Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" Hi, = > -----Original Message----- > From: Intel-gfx On Behalf Of Va= ndita > Kulkarni > Sent: torstai 3. kes=E4kuuta 2021 9.54 > To: intel-gfx@lists.freedesktop.org > Cc: Nikula, Jani > Subject: [Intel-gfx] [PATCH] drm/i915/dsc: Remove redundant checks in DSC= disable > = > There can be a chance that pre os has enabled DSC and driver's compute co= nfig > would not need dsc to be enabled, in such case if we check on compute con= fig's > compression state to disable, we might end up in state mismatch. I assume this fixes real gitlab issue too? = > = > Signed-off-by: Vandita Kulkarni > --- > drivers/gpu/drm/i915/display/intel_vdsc.c | 4 ---- > 1 file changed, 4 deletions(-) > = > diff --git a/drivers/gpu/drm/i915/display/intel_vdsc.c > b/drivers/gpu/drm/i915/display/intel_vdsc.c > index 19cd9531c115..b05a96011d93 100644 > --- a/drivers/gpu/drm/i915/display/intel_vdsc.c > +++ b/drivers/gpu/drm/i915/display/intel_vdsc.c > @@ -1161,10 +1161,6 @@ void intel_dsc_disable(const struct intel_crtc_sta= te > *old_crtc_state) > struct intel_crtc *crtc =3D to_intel_crtc(old_crtc_state->uapi.crtc); > struct drm_i915_private *dev_priv =3D to_i915(crtc->base.dev); > = > - if (!(old_crtc_state->dsc.compression_enable && > - old_crtc_state->bigjoiner)) > - return; > - > intel_de_write(dev_priv, dss_ctl1_reg(old_crtc_state), 0); > intel_de_write(dev_priv, dss_ctl2_reg(old_crtc_state), 0); } > -- > 2.21.0.5.gaeb582a > = > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/intel-gfx _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx