From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tvrtko Ursulin Subject: Re: [PATCH 04/16] drm/i915: Add unit tests for the breadcrumb rbtree, completion Date: Thu, 8 Dec 2016 11:47:45 +0000 Message-ID: References: <20161207135833.32740-1-chris@chris-wilson.co.uk> <20161207135833.32740-5-chris@chris-wilson.co.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by gabe.freedesktop.org (Postfix) with ESMTPS id 8AE4C6E071 for ; Thu, 8 Dec 2016 11:47:48 +0000 (UTC) In-Reply-To: <20161207135833.32740-5-chris@chris-wilson.co.uk> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org Ck9uIDA3LzEyLzIwMTYgMTM6NTgsIENocmlzIFdpbHNvbiB3cm90ZToKPiBTZWNvbmQgcmV0cm9h Y3RpdmUgdGVzdCwgbWFrZSBzdXJlIHRoYXQgdGhlIHdhaXRlcnMgYXJlIHJlbW92ZWQgZnJvbSB0 aGUKPiBnbG9iYWwgd2FpdC10cmVlIHdoZW4gdGhlaXIgc2Vxbm8gY29tcGxldGVzLgo+Cj4gU2ln bmVkLW9mZi1ieTogQ2hyaXMgV2lsc29uIDxjaHJpc0BjaHJpcy13aWxzb24uY28udWs+Cj4gLS0t Cj4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2JyZWFkY3J1bWJzLmMgfCAxMTAgKysrKysr KysrKysrKysrKysrKysrKysrKysrKysrKwo+ICAxIGZpbGUgY2hhbmdlZCwgMTEwIGluc2VydGlv bnMoKykKPgo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9icmVhZGNy dW1icy5jIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfYnJlYWRjcnVtYnMuYwo+IGluZGV4 IGM3Njg2MDg5NzRlMS4uZmM5NTBmN2ZmMzIyIDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2Ry bS9pOTE1L2ludGVsX2JyZWFkY3J1bWJzLmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9p bnRlbF9icmVhZGNydW1icy5jCj4gQEAgLTcwNSw2ICs3MDUsMTIgQEAgc3RhdGljIHN0cnVjdCBp bnRlbF9lbmdpbmVfY3MgKm1vY2tfZW5naW5lKGNvbnN0IGNoYXIgKm5hbWUpCj4gIAlyZXR1cm4g ZW5naW5lOwo+ICB9Cj4KPiArc3RhdGljIHZvaWQgbW9ja19zZXFub19hZHZhbmNlKHN0cnVjdCBp bnRlbF9lbmdpbmVfY3MgKmVuZ2luZSwgdTMyIHNlcW5vKQo+ICt7Cj4gKwlpbnRlbF93cml0ZV9z dGF0dXNfcGFnZShlbmdpbmUsIEk5MTVfR0VNX0hXU19JTkRFWCwgc2Vxbm8pOwo+ICsJaW50ZWxf ZW5naW5lX3dha2V1cChlbmdpbmUpOwo+ICt9Cj4gKwo+ICBzdGF0aWMgaW50ICpnZXRfcmFuZG9t X29yZGVyKGludCBjb3VudCkKPiAgewo+ICAJaW50ICpvcmRlcjsKPiBAQCAtNzY2LDYgKzc3Miwy NyBAQCBzdGF0aWMgaW50IGNoZWNrX3JidHJlZShzdHJ1Y3QgaW50ZWxfZW5naW5lX2NzICplbmdp bmUsCj4gIAlyZXR1cm4gMDsKPiAgfQo+Cj4gK3N0YXRpYyBpbnQgY2hlY2tfY29tcGxldGlvbihz dHJ1Y3QgaW50ZWxfZW5naW5lX2NzICplbmdpbmUsCj4gKwkJCSAgICBjb25zdCB1bnNpZ25lZCBs b25nICpiaXRtYXAsCj4gKwkJCSAgICBjb25zdCBzdHJ1Y3QgaW50ZWxfd2FpdCAqd2FpdGVycywK PiArCQkJICAgIGNvbnN0IGludCBjb3VudCkKPiArewo+ICsJaW50IG47Cj4gKwo+ICsJZm9yIChu ID0gMDsgbiA8IGNvdW50OyBuKyspIHsKPiArCQlpZiAoaW50ZWxfd2FpdF9jb21wbGV0ZSgmd2Fp dGVyc1tuXSkgIT0gISF0ZXN0X2JpdChuLCBiaXRtYXApKQo+ICsJCQljb250aW51ZTsKPiArCj4g KwkJcHJfZXJyKCJ3YWl0ZXJbJWQsIHNlcW5vPSVkXSBpcyAlcywgYnV0IGV4cGVjdGVkICVzXG4i LAo+ICsJCSAgICAgICBuLCB3YWl0ZXJzW25dLnNlcW5vLAo+ICsJCSAgICAgICBpbnRlbF93YWl0 X2NvbXBsZXRlKCZ3YWl0ZXJzW25dKSA/ICJjb21wbGV0ZSIgOiAiYWN0aXZlIiwKPiArCQkgICAg ICAgdGVzdF9iaXQobiwgYml0bWFwKSA/ICJhY3RpdmUiIDogImNvbXBsZXRlIik7Cj4gKwkJcmV0 dXJuIC1FSU5WQUw7Cj4gKwl9Cj4gKwo+ICsJcmV0dXJuIDA7Cj4gK30KPiArCj4gIHN0YXRpYyBp bnQgY2hlY2tfcmJ0cmVlX2VtcHR5KHN0cnVjdCBpbnRlbF9lbmdpbmVfY3MgKmVuZ2luZSkKPiAg ewo+ICAJc3RydWN0IGludGVsX2JyZWFkY3J1bWJzICpiID0gJmVuZ2luZS0+YnJlYWRjcnVtYnM7 Cj4gQEAgLTg1NywxMCArODg0LDkzIEBAIHN0YXRpYyBpbnQgaWd0X3JhbmRvbV9pbnNlcnRfcmVt b3ZlKHZvaWQgKmlnbm9yZSkKPiAgCXJldHVybiBlcnI7Cj4gIH0KPgo+ICtzdGF0aWMgaW50IGln dF9pbnNlcnRfY29tcGxldGUodm9pZCAqaWdub3JlKQo+ICt7Cj4gKwlzdHJ1Y3QgaW50ZWxfZW5n aW5lX2NzICplbmdpbmU7Cj4gKwlzdHJ1Y3QgaW50ZWxfd2FpdCAqd2FpdGVyczsKPiArCWNvbnN0 IGludCBjb3VudCA9IDQwOTY7Cj4gKwl1bnNpZ25lZCBsb25nICpiaXRtYXA7Cj4gKwlpbnQgZXJy ID0gLUVOT01FTTsKPiArCWludCBuLCBtOwo+ICsKPiArCWVuZ2luZSA9IG1vY2tfZW5naW5lKCJt b2NrIik7Cj4gKwlpZiAoIWVuZ2luZSkKPiArCQlnb3RvIG91dDsKPiArCj4gKwl3YWl0ZXJzID0g ZHJtX21hbGxvY19nZnAoY291bnQsIHNpemVvZigqd2FpdGVycyksIEdGUF9URU1QT1JBUlkpOwo+ ICsJaWYgKCF3YWl0ZXJzKQo+ICsJCWdvdG8gb3V0X2VuZ2luZXM7Cj4gKwo+ICsJYml0bWFwID0g a2NhbGxvYyhESVZfUk9VTkRfVVAoY291bnQsIEJJVFNfUEVSX0xPTkcpLCBzaXplb2YoKmJpdG1h cCksCj4gKwkJCSBHRlBfVEVNUE9SQVJZKTsKPiArCWlmICghYml0bWFwKQo+ICsJCWdvdG8gb3V0 X3dhaXRlcnM7Cj4gKwo+ICsJZm9yIChuID0gMDsgbiA8IGNvdW50OyBuKyspIHsKPiArCQlpbnRl bF93YWl0X2luaXQoJndhaXRlcnNbbl0sIG4gKyAweDEwMDApOwoKTWF5YmUgY29uc3QgaW50IHNl cW5vX3N0YXJ0ID0gMHgxMDAwIHNpbmNlIHRoZXJlIGFyZSBtdWx0aXBsZSB1c2Vycy4KCj4gKwkJ aW50ZWxfZW5naW5lX2FkZF93YWl0KGVuZ2luZSwgJndhaXRlcnNbbl0pOwo+ICsJCV9fc2V0X2Jp dChuLCBiaXRtYXApOwo+ICsJfQo+ICsJZXJyID0gY2hlY2tfcmJ0cmVlKGVuZ2luZSwgYml0bWFw LCB3YWl0ZXJzLCBjb3VudCk7Cj4gKwlpZiAoZXJyKQo+ICsJCWdvdG8gZXJyOwo+ICsKPiArCWZv ciAobiA9IDA7IG4gPCBjb3VudDsgbiA9IG0pIHsKPiArCQlpbnQgc2Vxbm8gPSAyICogbjsKPiAr Cj4gKwkJR0VNX0JVR19PTihmaW5kX2ZpcnN0X2JpdChiaXRtYXAsIGNvdW50KSAhPSBuKTsKPiAr Cj4gKwkJaWYgKGludGVsX3dhaXRfY29tcGxldGUoJndhaXRlcnNbbl0pKSB7Cj4gKwkJCXByX2Vy cigid2FpdGVyWyVkLCBzZXFubz0lZF0gY29tcGxldGVkIHRvbyBlYXJseVxuIiwKPiArCQkJICAg ICAgIG4sIHdhaXRlcnNbbl0uc2Vxbm8pOwo+ICsJCQllcnIgPSAtRUlOVkFMOwo+ICsJCQlnb3Rv IGVycjsKPiArCQl9Cj4gKwo+ICsJCS8qIGNvbXBsZXRlIHRoZSBmb2xsb3dpbmcgd2FpdGVycyAq Lwo+ICsJCW1vY2tfc2Vxbm9fYWR2YW5jZShlbmdpbmUsIHNlcW5vICsgMHgxMDAwKTsKPiArCQlm b3IgKG0gPSBuOyBtIDw9IHNlcW5vOyBtKyspIHsKPiArCQkJaWYgKG0gPT0gY291bnQpCj4gKwkJ CQlicmVhazsKPiArCj4gKwkJCUdFTV9CVUdfT04oIXRlc3RfYml0KG0sIGJpdG1hcCkpOwo+ICsJ CQlfX2NsZWFyX2JpdChtLCBiaXRtYXApOwo+ICsJCX0KPiArCj4gKwkJaW50ZWxfZW5naW5lX3Jl bW92ZV93YWl0KGVuZ2luZSwgJndhaXRlcnNbbl0pOwo+ICsJCVJCX0NMRUFSX05PREUoJndhaXRl cnNbbl0ubm9kZSk7Cj4gKwo+ICsJCWVyciA9IGNoZWNrX3JidHJlZShlbmdpbmUsIGJpdG1hcCwg d2FpdGVycywgY291bnQpOwo+ICsJCWlmIChlcnIpIHsKPiArCQkJcHJfZXJyKCJyYnRyZWUgY29y cnVwdCBhZnRlciBzZXFubyBhZHZhbmNlIHRvICVkXG4iLAo+ICsJCQkgICAgICAgc2Vxbm8gKyAw eDEwMDApOwo+ICsJCQlnb3RvIGVycjsKPiArCQl9Cj4gKwo+ICsJCWVyciA9IGNoZWNrX2NvbXBs ZXRpb24oZW5naW5lLCBiaXRtYXAsIHdhaXRlcnMsIGNvdW50KTsKPiArCQlpZiAoZXJyKSB7Cj4g KwkJCXByX2VycigiY29tcGxldGlvbnMgYWZ0ZXIgc2Vxbm8gYWR2YW5jZSB0byAlZCBmYWlsZWRc biIsCj4gKwkJCSAgICAgICBzZXFubyArIDB4MTAwMCk7Cj4gKwkJCWdvdG8gZXJyOwo+ICsJCX0K PiArCX0KPiArCj4gKwllcnIgPSBjaGVja19yYnRyZWVfZW1wdHkoZW5naW5lKTsKPiArZXJyOgo+ ICsJa2ZyZWUoYml0bWFwKTsKPiArb3V0X3dhaXRlcnM6Cj4gKwlkcm1fZnJlZV9sYXJnZSh3YWl0 ZXJzKTsKPiArb3V0X2VuZ2luZXM6Cj4gKwlrZnJlZShlbmdpbmUpOwo+ICtvdXQ6Cj4gKwlyZXR1 cm4gZXJyOwo+ICt9Cj4gKwo+ICBpbnQgaW50ZWxfYnJlYWRjcnVtYnNfc2VsZnRlc3Qodm9pZCkK PiAgewo+ICAJc3RhdGljIGNvbnN0IHN0cnVjdCBpOTE1X3N1YnRlc3QgdGVzdHNbXSA9IHsKPiAg CQlTVUJURVNUKGlndF9yYW5kb21faW5zZXJ0X3JlbW92ZSksCj4gKwkJU1VCVEVTVChpZ3RfaW5z ZXJ0X2NvbXBsZXRlKSwKPiAgCX07Cj4KPiAgCXJldHVybiBpOTE1X3N1YnRlc3RzKHRlc3RzLCBO VUxMKTsKPgoKTG9va3MgT0suCgpSZXZpZXdlZC1ieTogVHZydGtvIFVyc3VsaW4gPHR2cnRrby51 cnN1bGluQGludGVsLmNvbT4KClJlZ2FyZHMsCgpUdnJ0a28KX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1n ZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21h aWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cg==