From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tvrtko Ursulin Subject: Re: [PATCH 3/6] drm/i915: Compact memcmp in i915_vma_compare() Date: Thu, 12 Jan 2017 07:08:53 +0000 Message-ID: References: <20170111215106.13482-1-chris@chris-wilson.co.uk> <20170111215106.13482-4-chris@chris-wilson.co.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by gabe.freedesktop.org (Postfix) with ESMTPS id 44CAE6EAB7 for ; Thu, 12 Jan 2017 07:08:55 +0000 (UTC) In-Reply-To: <20170111215106.13482-4-chris@chris-wilson.co.uk> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org Ck9uIDExLzAxLzIwMTcgMjE6NTEsIENocmlzIFdpbHNvbiB3cm90ZToKPiBJbiBwcmVwYXJhdGlv biBmb3IgdGhlIG5leHQgcGF0Y2ggdG8gY29udmVydCB0byB1c2luZyBhbiBhbm9ueW1vdXMgdW5p b24KPiBhbmQgbGVhdmluZyB0aGUgZXhjZXNzIGJ5dGVzIGluIHRoZSB1bmlvbiB1bmluaXRpYWxp c2VkLCB3ZSBmaXJzdCBuZWVkCj4gdG8gbWFrZSBzdXJlIHdlIGRvIG5vdCBjb21wYXJlIHVzaW5n IHRob3NlIHVuaW5pdGlhbGlzZWQgYnl0ZXMuIFdlIGFsc28KPiB3YW50IHRvIHByZXNlcnZlIHRo ZSBjb21wYWN0bmVzcyBvZiB0aGUgY29kZSwgYXZvaWRpbmcgYSBzZWNvbmQgY2FsbCB0bwo+IG1l bWNtcCBvciBpbnRyb2R1Y2luZyBhIHN3aXRjaCwgc28gd2UgdGFrZSBhZHZhbnRhZ2Ugb2YgdXNp bmcgdGhlIHR5cGUKPiBhcyBhbiBlbmNvZGVkIHNpemUgKGFzIHdlbGwgYXMgYSB1bmlxdWUgaWRl bnRpZmllciBmb3IgZWFjaCB0eXBlIG9mIHZpZXcpLgo+Cj4gU2lnbmVkLW9mZi1ieTogQ2hyaXMg V2lsc29uIDxjaHJpc0BjaHJpcy13aWxzb24uY28udWs+Cj4gLS0tCj4gIGRyaXZlcnMvZ3B1L2Ry bS9pOTE1L2k5MTVfZ2VtX2d0dC5oIHwgMTQgKysrKysrKy0tLS0tLS0KPiAgZHJpdmVycy9ncHUv ZHJtL2k5MTUvaTkxNV92bWEuaCAgICAgfCAxNSArKysrKysrKystLS0tLS0KPiAgMiBmaWxlcyBj aGFuZ2VkLCAxNiBpbnNlcnRpb25zKCspLCAxMyBkZWxldGlvbnMoLSkKPgo+IGRpZmYgLS1naXQg YS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2dlbV9ndHQuaCBiL2RyaXZlcnMvZ3B1L2RybS9p OTE1L2k5MTVfZ2VtX2d0dC5oCj4gaW5kZXggMzE4N2EyNjBlNmUxLi4zNmQ4NTU5OWZmYzkgMTAw NjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9nZW1fZ3R0LmgKPiArKysgYi9k cml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2dlbV9ndHQuaAo+IEBAIC0xNDUsMTIgKzE0NSw2IEBA IHR5cGVkZWYgdWludDY0X3QgZ2VuOF9wcGd0dF9wbWw0ZV90Owo+Cj4gIHN0cnVjdCBzZ190YWJs ZTsKPgo+IC1lbnVtIGk5MTVfZ2d0dF92aWV3X3R5cGUgewo+IC0JSTkxNV9HR1RUX1ZJRVdfTk9S TUFMID0gMCwKPiAtCUk5MTVfR0dUVF9WSUVXX1JPVEFURUQsCj4gLQlJOTE1X0dHVFRfVklFV19Q QVJUSUFMLAo+IC19Owo+IC0KPiAgc3RydWN0IGludGVsX3JvdGF0aW9uX2luZm8gewo+ICAJc3Ry dWN0IGludGVsX3JvdGF0aW9uX3BsYW5lX2luZm8gewo+ICAJCS8qIHRpbGVzICovCj4gQEAgLTE4 NCwxMCArMTc4LDE2IEBAIHN0YXRpYyBpbmxpbmUgdTY0IGludGVsX3BhcnRpYWxfZ2V0X3BhZ2Vf b2Zmc2V0KGNvbnN0IHN0cnVjdCBpbnRlbF9wYXJ0aWFsX2luZm8KPiAgCXJldHVybiBwaS0+b2Zm c2V0X3NpemUgPj4gSU5URUxfUEFSVElBTF9TSVpFX0JJVFM7Cj4gIH0KPgo+ICtlbnVtIGk5MTVf Z2d0dF92aWV3X3R5cGUgewo+ICsJSTkxNV9HR1RUX1ZJRVdfTk9STUFMID0gMCwKPiArCUk5MTVf R0dUVF9WSUVXX1JPVEFURUQgPSBzaXplb2Yoc3RydWN0IGludGVsX3JvdGF0aW9uX2luZm8pLAo+ ICsJSTkxNV9HR1RUX1ZJRVdfUEFSVElBTCA9IHNpemVvZihzdHJ1Y3QgaW50ZWxfcGFydGlhbF9p bmZvKSwKPiArfTsKCkkganVzdCByZWFsaXplZCB0aGlzIHdpbGwgdWdsaWZ5IHRoZSBkZWJ1Z2Zz IG91dHB1dC4gSW4gdGhlIGxpZ2h0IG9mIAp0aGF0IEkgdGhpbmsgd2Ugc2hvdWxkIGxlYXZlIHRo ZSBlbnVtIGh1bWFuIHJlYWRhYmxlIGFuZCBpbnN0ZWFkIHlvdSAKY291bGQgaGF2ZSBhIHN0YXRp YyBtYXAgaW4gaTkxNV92bWFfY29tcGFyZS4gSG9wZWZ1bGx5IGNvZGUgZ2VuZXJhdGlvbiAKd291 bGRuJ3QgYmUgYWZmZWN0ZWQgYnkgaXQuCgpSZWdhcmRzLAoKVHZydGtvCgo+ICsKPiAgc3RydWN0 IGk5MTVfZ2d0dF92aWV3IHsKPiAgCWVudW0gaTkxNV9nZ3R0X3ZpZXdfdHlwZSB0eXBlOwo+IC0K PiAgCXVuaW9uIHsKPiArCQkvKiBNZW1iZXJzIG5lZWQgdG8gY29udGFpbiBubyBob2xlcy9wYWRk aW5nICovCj4gIAkJc3RydWN0IGludGVsX3BhcnRpYWxfaW5mbyBwYXJ0aWFsOwo+ICAJCXN0cnVj dCBpbnRlbF9yb3RhdGlvbl9pbmZvIHJvdGF0ZWQ7Cj4gIAl9IHBhcmFtczsKPiBkaWZmIC0tZ2l0 IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV92bWEuaCBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1 L2k5MTVfdm1hLmgKPiBpbmRleCBhOTY5YmJiNjU4NzEuLjE5ZjA0OWNlZjllMyAxMDA2NDQKPiAt LS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X3ZtYS5oCj4gKysrIGIvZHJpdmVycy9ncHUv ZHJtL2k5MTUvaTkxNV92bWEuaAo+IEBAIC0xOTksMTUgKzE5OSwxOCBAQCBpOTE1X3ZtYV9jb21w YXJlKHN0cnVjdCBpOTE1X3ZtYSAqdm1hLAo+ICAJaWYgKGNtcCkKPiAgCQlyZXR1cm4gY21wOwo+ Cj4gKwlCVUlMRF9CVUdfT04oSTkxNV9HR1RUX1ZJRVdfTk9STUFMICE9IDApOwo+ICsJY21wID0g dm1hLT5nZ3R0X3ZpZXcudHlwZTsKPiAgCWlmICghdmlldykKPiAtCQlyZXR1cm4gdm1hLT5nZ3R0 X3ZpZXcudHlwZTsKPiArCQlyZXR1cm4gY21wOwo+ICsKPiArCWNtcCAtPSB2aWV3LT50eXBlOwo+ ICsJaWYgKGNtcCkKPiArCQlyZXR1cm4gY21wOwo+Cj4gLQlpZiAodm1hLT5nZ3R0X3ZpZXcudHlw ZSAhPSB2aWV3LT50eXBlKQo+IC0JCXJldHVybiB2bWEtPmdndHRfdmlldy50eXBlIC0gdmlldy0+ dHlwZTsKPiArCUJVSUxEX0JVR19PTihJOTE1X0dHVFRfVklFV19QQVJUSUFMID09IEk5MTVfR0dU VF9WSUVXX1JPVEFURUQpOwo+Cj4gLQlyZXR1cm4gbWVtY21wKCZ2bWEtPmdndHRfdmlldy5wYXJh bXMsCj4gLQkJICAgICAgJnZpZXctPnBhcmFtcywKPiAtCQkgICAgICBzaXplb2Yodmlldy0+cGFy YW1zKSk7Cj4gKwlyZXR1cm4gbWVtY21wKCZ2bWEtPmdndHRfdmlldy5wYXJhbXMsICZ2aWV3LT5w YXJhbXMsIHZpZXctPnR5cGUpOwo+ICB9Cj4KPiAgaW50IGk5MTVfdm1hX2JpbmQoc3RydWN0IGk5 MTVfdm1hICp2bWEsIGVudW0gaTkxNV9jYWNoZV9sZXZlbCBjYWNoZV9sZXZlbCwKPgpfX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJbnRlbC1nZnggbWFpbGlu ZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVl ZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK