From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 17F81C6FD1D for ; Tue, 4 Apr 2023 15:57:30 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id CEE0110E6E6; Tue, 4 Apr 2023 15:57:28 +0000 (UTC) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by gabe.freedesktop.org (Postfix) with ESMTPS id CE93010E531; Tue, 4 Apr 2023 15:57:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1680623845; x=1712159845; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=IGSS2ncpRPEUGuI2WAgN5IGlyOhaZKVf36+5Z8vngv0=; b=ZPOCQBhwEACtIJBQ2RWhplzar3udMxe0XIq5bhgeGKL9Gh0lq1Qny3H3 ljSQNhIby99mCoLizF2UJagxZVvSXs0LZ+XbyaodLbTpmU5Vvx2np4TJm Drovo7Mrh3r3V3yFCkNXmK2E8TkEBKYaYM4L/Zb+aLjDFTwJcKv54DSwQ 7hfqkDiEFcLYlz1JMd3hnmBYY8Cz/SNY3BrXZSwmkv6pfS+igjED4SAjl xn6zxW7ehSIHlvNQAfmp8hvBnajQ/E3j13lrmnoT4K9G9loNecINLfthe 5IVx22S6KQSA7uvV5+3GM2ZWz+bgPiJicQ9UjqhIjGl7z+helQ1qySA0W g==; X-IronPort-AV: E=McAfee;i="6600,9927,10670"; a="370044535" X-IronPort-AV: E=Sophos;i="5.98,318,1673942400"; d="scan'208";a="370044535" Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Apr 2023 08:57:25 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10670"; a="932503603" X-IronPort-AV: E=Sophos;i="5.98,318,1673942400"; d="scan'208";a="932503603" Received: from pcanders-mobl1.ger.corp.intel.com (HELO [10.213.217.134]) ([10.213.217.134]) by fmsmga006-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Apr 2023 08:57:22 -0700 Message-ID: Date: Tue, 4 Apr 2023 16:57:20 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Content-Language: en-US To: Andi Shyti , Andrzej Hajda References: <20230330-hold_wakeref_for_active_vm-v2-1-724d201499c2@intel.com> From: Tvrtko Ursulin Organization: Intel Corporation UK Plc In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Intel-gfx] [PATCH v2] drm/i915/gt: Hold a wakeref for the active VM X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Chris Wilson , intel-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org, Chris Wilson , dri-devel@lists.freedesktop.org, Daniel Vetter , Rodrigo Vivi , David Airlie Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On 04/04/2023 16:39, Andi Shyti wrote: > Hi Andrzej, > >> diff --git a/drivers/gpu/drm/i915/gt/intel_context.h b/drivers/gpu/drm/i915/gt/intel_context.h >> index 0a8d553da3f439..48f888c3da083b 100644 >> --- a/drivers/gpu/drm/i915/gt/intel_context.h >> +++ b/drivers/gpu/drm/i915/gt/intel_context.h >> @@ -14,6 +14,7 @@ >> #include "i915_drv.h" >> #include "intel_context_types.h" >> #include "intel_engine_types.h" >> +#include "intel_gt_pm.h" >> #include "intel_ring_types.h" >> #include "intel_timeline_types.h" >> #include "i915_trace.h" >> @@ -207,8 +208,11 @@ void intel_context_exit_engine(struct intel_context *ce); >> static inline void intel_context_enter(struct intel_context *ce) >> { >> lockdep_assert_held(&ce->timeline->mutex); >> - if (!ce->active_count++) >> - ce->ops->enter(ce); >> + if (ce->active_count++) >> + return; >> + >> + ce->ops->enter(ce); >> + intel_gt_pm_get(ce->vm->gt); >> } >> >> static inline void intel_context_mark_active(struct intel_context *ce) >> @@ -222,8 +226,11 @@ static inline void intel_context_exit(struct intel_context *ce) >> { >> lockdep_assert_held(&ce->timeline->mutex); >> GEM_BUG_ON(!ce->active_count); >> - if (!--ce->active_count) >> - ce->ops->exit(ce); >> + if (--ce->active_count) >> + return; >> + >> + intel_gt_pm_put_async(ce->vm->gt); >> + ce->ops->exit(ce); > > shouldn't these two be swapped? > >> } >> >> static inline struct intel_context *intel_context_get(struct intel_context *ce) >> diff --git a/drivers/gpu/drm/i915/gt/intel_engine_pm.c b/drivers/gpu/drm/i915/gt/intel_engine_pm.c >> index e971b153fda976..ee531a5c142c77 100644 >> --- a/drivers/gpu/drm/i915/gt/intel_engine_pm.c >> +++ b/drivers/gpu/drm/i915/gt/intel_engine_pm.c >> @@ -114,6 +114,15 @@ __queue_and_release_pm(struct i915_request *rq, >> >> ENGINE_TRACE(engine, "parking\n"); >> >> + /* >> + * Open coded one half of intel_context_enter, which we have to omit >> + * here (see the large comment below) and because the other part must >> + * not be called due constructing directly with __i915_request_create >> + * which increments active count via intel_context_mark_active. >> + */ >> + GEM_BUG_ON(rq->context->active_count != 1); >> + __intel_gt_pm_get(engine->gt); > > where is it's brother "put"? It's in request retire via intel_context_exit. Ie. request construction is special here, while retirement is standard. Regards, Tvrtko > > Thanks, > Andi > >> + >> /* >> * We have to serialise all potential retirement paths with our >> * submission, as we don't want to underflow either the >> >> --- >> base-commit: 3385d6482cd60f2a0bbb0fa97b70ae7dbba4f95c >> change-id: 20230330-hold_wakeref_for_active_vm-7f013a449ef3 >> >> Best regards, >> -- >> Andrzej Hajda