From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniele Ceraolo Spurio Subject: Re: [PATCH 1/3] drm/i915/uc: Extract common code from GuC stop/disable comm Date: Wed, 28 Aug 2019 13:47:24 -0700 Message-ID: References: <20190828004558.11903-1-fernando.pacheco@intel.com> <20190828004558.11903-2-fernando.pacheco@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by gabe.freedesktop.org (Postfix) with ESMTPS id 1DE7189E11 for ; Wed, 28 Aug 2019 20:47:46 +0000 (UTC) In-Reply-To: <20190828004558.11903-2-fernando.pacheco@intel.com> Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Fernando Pacheco , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org CgpPbiA4LzI3LzE5IDU6NDUgUE0sIEZlcm5hbmRvIFBhY2hlY28gd3JvdGU6Cj4gRHVyaW5nIG5v cm1hbCBkcml2ZXIgdW5sb2FkIHdlIGF0dGVtcHQgdG8gZGlzYWJsZSBHdUMgY29tbXVuaWNhdGlv bgo+IHdoaWxlIGl0IGlzIGN1cnJlbnRseSBzdG9wcGVkLiBUaGlzIHJlc3VsdHMgaW4gYSBub3An ZCBjYWxsIHRvCj4gaW50ZWxfZ3VjX2N0X2Rpc2FibGUgd2l0aGluIGd1Y19kaXNhYmxlX2NvbW11 bmljYXRpb24gYmVjYXVzZQo+IHN0b3AvZGlzYWJsZSByZWx5IG9uIHRoZSBzYW1lIGZsYWcgdG8g cHJldmVudCBmdXJ0aGVyIGNvbW1zIHdpdGggQ1QuCj4gCj4gV2UgY2FuIGF2b2lkIHRoZSBjYWxs IHRvIGRpc2FibGUgYW5kIHN0aWxsIGxlYXZlIGNvbW11bmljYXRpb24gaW4gYQo+IHNhdGlzZmFj dG9yeSBzdGF0ZSBieSBleHRyYWN0aW5nIGEgc2V0IG9mIHNoYXJlZCBzdGVwcyBmcm9tIHN0b3Av ZGlzYWJsZS4KPiBUaGlzIHNldCBjYW4gaW5jbHVkZSBndWNfZGlzYWJsZV9pbnRlcnJ1cHRzIGFz IHdlIGRvIG5vdCByZXF1aXJlIHRoZQo+IHNpbmdsZSBjYWxsZXIgb2YgZ3VjX3N0b3BfY29tbXVu aWNhdGlvbiB0byBiZSBhdG9taWM6Cj4gImRybS9pOTE1L3NlbGZ0ZXN0czogRml4dXAgYXRvbWlj IHJlc2V0IGNoZWNraW5nIi4KPiAKPiBUaGlzIHNpdHVhdGlvbiAoc3RvcCAtPiBkaXNhYmxlKSBv bmx5IG9jY3VycyBkdXJpbmcgaW50ZWxfdWNfZmluaV9odywKPiBzbyBkdXJpbmcgZmluaSwgY2Fs bCBndWNfZGlzYWJsZV9jb21tdW5pY2F0aW9uIG9ubHkgaWYgY3VycmVudGx5IGVuYWJsZWQuCj4g VGhlIHN5bW1ldHJpYyBjYWxscyB0byBlbmFibGUvZGlzYWJsZSByZW1haW4gdW5tb2RpZmllZCBm b3IgYWxsIG90aGVyCj4gc2NlbmFyaW9zLgo+IAo+IFNpZ25lZC1vZmYtYnk6IEZlcm5hbmRvIFBh Y2hlY28gPGZlcm5hbmRvLnBhY2hlY29AaW50ZWwuY29tPgo+IENjOiBDaHJpcyBXaWxzb24gPGNo cmlzQGNocmlzLXdpbHNvbi5jby51az4KPiBDYzogTWljaGFsIFdhamRlY3prbyA8bWljaGFsLndh amRlY3prb0BpbnRlbC5jb20+Cj4gQ2M6IERhbmllbGUgQ2VyYW9sbyBTcHVyaW8gPGRhbmllbGUu Y2VyYW9sb3NwdXJpb0BpbnRlbC5jb20+Cj4gLS0tCj4gICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9n dC91Yy9pbnRlbF91Yy5jIHwgMzAgKysrKysrKysrKysrKysrKy0tLS0tLS0tLS0tCj4gICAxIGZp bGUgY2hhbmdlZCwgMTggaW5zZXJ0aW9ucygrKSwgMTIgZGVsZXRpb25zKC0pCj4gCj4gZGlmZiAt LWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2d0L3VjL2ludGVsX3VjLmMgYi9kcml2ZXJzL2dw dS9kcm0vaTkxNS9ndC91Yy9pbnRlbF91Yy5jCj4gaW5kZXggNzFlZTdhYjAzNWNjLi4yOWE5ZWVj NjBkMmUgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvZ3QvdWMvaW50ZWxfdWMu Ywo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2d0L3VjL2ludGVsX3VjLmMKPiBAQCAtMjI0 LDE3ICsyMjQsNyBAQCBzdGF0aWMgaW50IGd1Y19lbmFibGVfY29tbXVuaWNhdGlvbihzdHJ1Y3Qg aW50ZWxfZ3VjICpndWMpCj4gICAJcmV0dXJuIDA7Cj4gICB9Cj4gICAKPiAtc3RhdGljIHZvaWQg Z3VjX3N0b3BfY29tbXVuaWNhdGlvbihzdHJ1Y3QgaW50ZWxfZ3VjICpndWMpCj4gLXsKPiAtCWlu dGVsX2d1Y19jdF9zdG9wKCZndWMtPmN0KTsKPiAtCj4gLQlndWMtPnNlbmQgPSBpbnRlbF9ndWNf c2VuZF9ub3A7Cj4gLQlndWMtPmhhbmRsZXIgPSBpbnRlbF9ndWNfdG9faG9zdF9ldmVudF9oYW5k bGVyX25vcDsKPiAtCj4gLQlndWNfY2xlYXJfbW1pb19tc2coZ3VjKTsKPiAtfQo+IC0KPiAtc3Rh dGljIHZvaWQgZ3VjX2Rpc2FibGVfY29tbXVuaWNhdGlvbihzdHJ1Y3QgaW50ZWxfZ3VjICpndWMp Cj4gK3N0YXRpYyB2b2lkIF9fZ3VjX3N0b3BfY29tbXVuaWNhdGlvbihzdHJ1Y3QgaW50ZWxfZ3Vj ICpndWMpCj4gICB7Cj4gICAJLyoKPiAgIAkgKiBFdmVudHMgZ2VuZXJhdGVkIGR1cmluZyBvciBh ZnRlciBDVCBkaXNhYmxlIGFyZSBsb2dnZWQgYnkgZ3VjIGluCj4gQEAgLTI0Nyw2ICsyMzcsMjAg QEAgc3RhdGljIHZvaWQgZ3VjX2Rpc2FibGVfY29tbXVuaWNhdGlvbihzdHJ1Y3QgaW50ZWxfZ3Vj ICpndWMpCj4gICAKPiAgIAlndWMtPnNlbmQgPSBpbnRlbF9ndWNfc2VuZF9ub3A7Cj4gICAJZ3Vj LT5oYW5kbGVyID0gaW50ZWxfZ3VjX3RvX2hvc3RfZXZlbnRfaGFuZGxlcl9ub3A7Cj4gK30KPiAr Cj4gK3N0YXRpYyB2b2lkIGd1Y19zdG9wX2NvbW11bmljYXRpb24oc3RydWN0IGludGVsX2d1YyAq Z3VjKQo+ICt7Cj4gKwlpbnRlbF9ndWNfY3Rfc3RvcCgmZ3VjLT5jdCk7Cj4gKwoKVGhlIG9ubHkg ZGlmZmVyZW5jZSBiZXR3ZWVuIGludGVsX2d1Y19jdF9zdG9wKCkgYW5kIAppbnRlbF9ndWNfY3Rf ZGlzYWJsZSgpIGlzIHRoYXQgaW4gdGhlIGxhdHRlciB3ZSBhbHNvIHRlbGwgZ3VjIHRoYXQgd2Un dmUgCmRpc2FibGVkIHRoZSBidWZmZXJzLiBXZSBjb3VsZCBwcm9iYWJseSBqdXN0IGFkZCBhIGNo ZWNrIHRvIHJldHVybiBlYXJseSAKaWYgIWludGVsX2d1Y19pc19ydW5uaW5nKCkgaW4gaW50ZWxf Z3VjX2N0X2Rpc2FibGUoKSBhbmQgZHJvcCB0aGUgCnN0b3AvZGlzYWJsZSBkaWZmZXJlbnRpYXRp b24gZW50aXJlbHksIGJ1dCB0aGF0IGRvZXNuJ3QgbmVlZCB0byBoYXBwZW4gCmluIHRoaXMgcGF0 Y2guCgoKPiArCV9fZ3VjX3N0b3BfY29tbXVuaWNhdGlvbihndWMpOwo+ICsKPiArCURSTV9JTkZP KCJHdUMgY29tbXVuaWNhdGlvbiBzdG9wcGVkXG4iKTsKPiArfQo+ICsKPiArc3RhdGljIHZvaWQg Z3VjX2Rpc2FibGVfY29tbXVuaWNhdGlvbihzdHJ1Y3QgaW50ZWxfZ3VjICpndWMpCj4gK3sKCkFy ZSB3ZSBub3cgZ3VhcmFudGVlZCB0aGF0IGd1Y19kaXNhYmxlX2NvbW11bmljYXRpb24oKSBpcyBj YWxsZWQgb25seSBvZiAKY29tbXVuaWNhdGlvbiBpcyBhY3R1YWxseSBlbmFibGVkPyBpZiBzbywg d2UgY291bGQgYWRkIGhlcmUgYToKCglHRU1fQlVHX09OKCFndWNfY29tbXVuaWNhdGlvbl9lbmFi bGVkKGd1YykpOwoKd2l0aCBvciB3aXRob3V0IHRoYXQ6CgpSZXZpZXdlZC1ieTogRGFuaWVsZSBD ZXJhb2xvIFNwdXJpbyA8ZGFuaWVsZS5jZXJhb2xvc3B1cmlvQGludGVsLmNvbT4KCkRhbmllbGUK Cj4gKwlfX2d1Y19zdG9wX2NvbW11bmljYXRpb24oZ3VjKTsKPiAgIAo+ICAgCWludGVsX2d1Y19j dF9kaXNhYmxlKCZndWMtPmN0KTsKPiAgIAo+IEBAIC01MzcsNyArNTQxLDkgQEAgdm9pZCBpbnRl bF91Y19maW5pX2h3KHN0cnVjdCBpbnRlbF91YyAqdWMpCj4gICAJaWYgKGludGVsX3VjX3N1cHBv cnRzX2d1Y19zdWJtaXNzaW9uKHVjKSkKPiAgIAkJaW50ZWxfZ3VjX3N1Ym1pc3Npb25fZGlzYWJs ZShndWMpOwo+ICAgCj4gLQlndWNfZGlzYWJsZV9jb21tdW5pY2F0aW9uKGd1Yyk7Cj4gKwlpZiAo Z3VjX2NvbW11bmljYXRpb25fZW5hYmxlZChndWMpKQo+ICsJCWd1Y19kaXNhYmxlX2NvbW11bmlj YXRpb24oZ3VjKTsKPiArCj4gICAJX191Y19zYW5pdGl6ZSh1Yyk7Cj4gICB9Cj4gICAKPiAKX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4IG1h aWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMu ZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4