From: "Kamble, Sagar A" <sagar.a.kamble@intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>, intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH v4 23/26] drm/i915/slpc: Keep RP SW Mode enabled while disabling rps
Date: Thu, 15 Sep 2016 16:14:11 +0530 [thread overview]
Message-ID: <f1fabced-08db-e171-019e-a77480721159@intel.com> (raw)
In-Reply-To: <20160909165842.GJ20027@nuc-i3427.alporthouse.com>
On 9/9/2016 10:28 PM, Chris Wilson wrote:
> On Fri, Sep 09, 2016 at 06:21:42PM +0530, Sagar Arun Kamble wrote:
>> With SLPC, only RP SW Mode control should be left enabled by i915.
>> Else, SLPC requests through through RPNSWREQ will not be granted.
>>
>> Signed-off-by: Sagar Arun Kamble <sagar.a.kamble@intel.com>
>> ---
>> drivers/gpu/drm/i915/intel_pm.c | 8 +++++++-
>> 1 file changed, 7 insertions(+), 1 deletion(-)
>>
>> diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/intel_pm.c
>> index 70e08d9..d06c9bb 100644
>> --- a/drivers/gpu/drm/i915/intel_pm.c
>> +++ b/drivers/gpu/drm/i915/intel_pm.c
>> @@ -5064,7 +5064,13 @@ static void gen9_disable_rc6(struct drm_i915_private *dev_priv)
>>
>> static void gen9_disable_rps(struct drm_i915_private *dev_priv)
>> {
>> - I915_WRITE(GEN6_RP_CONTROL, 0);
>> + uint32_t rp_ctl = 0;
> u32 rp_ctl = 0;
>
>> +
>> + /* RP SW Mode Control will be needed for SLPC, Hence not clearing.*/
> /* RP SW Mode Control will be needed for SLPC, so keep it enabled. */
>
>> + if (i915.enable_slpc)
> intel_slpc_enabled() ? (consistency!)
Will update this.
>
>> + rp_ctl = I915_READ(GEN6_RP_CONTROL) & GEN6_RP_MEDIA_MODE_MASK;
> Ok, so this is not doing what you describe. This is preserving state,
> yes. But if we know that state is meant to be enabled for SLPC why are
> we reading it back.
>
> I am left with questions about what is happening behind our backs, and
> what the code is trying to hide.
Will fix this. SLPC is going to request frequency hence we need to make
sure host
does not tamper RP_CONTROL settings.
> -Chris
>
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2016-09-15 10:44 UTC|newest]
Thread overview: 51+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-09 12:51 [PATCH v4 00/26] Add support for GuC-based SLPC Sagar Arun Kamble
2016-09-09 12:51 ` [PATCH v4 01/26] drm/i915: Remove RPM suspend dependency on rps.enabled and related changes Sagar Arun Kamble
2016-09-09 12:51 ` [PATCH v4 02/26] drm/i915/slpc: Expose guc functions for use with SLPC Sagar Arun Kamble
2016-09-09 12:51 ` [PATCH v4 03/26] drm/i915/slpc: Add has_slpc capability flag Sagar Arun Kamble
2016-09-09 12:51 ` [PATCH v4 04/26] drm/i915/slpc: Add SKL SLPC Support Sagar Arun Kamble
2016-09-09 12:51 ` [PATCH v4 05/26] drm/i915/slpc: Add enable_slpc module parameter Sagar Arun Kamble
2016-09-09 12:51 ` [PATCH v4 06/26] drm/i915/slpc: Sanitize SLPC version Sagar Arun Kamble
2016-09-09 12:51 ` [PATCH v4 07/26] drm/i915/slpc: Use intel_slpc_* functions if supported Sagar Arun Kamble
2016-09-09 17:20 ` Chris Wilson
2016-09-15 10:40 ` Kamble, Sagar A
2016-09-09 12:51 ` [PATCH v4 08/26] drm/i915/slpc: Enable SLPC in guc " Sagar Arun Kamble
2016-09-09 12:51 ` [PATCH v4 09/26] drm/i915/slpc: If using SLPC, do not set frequency Sagar Arun Kamble
2016-09-09 17:21 ` Chris Wilson
2016-09-15 10:41 ` Kamble, Sagar A
2016-09-09 12:51 ` [PATCH v4 10/26] drm/i915/slpc: Allocate/Release/Initialize SLPC shared data Sagar Arun Kamble
2016-09-09 17:08 ` Chris Wilson
2016-09-15 10:41 ` Kamble, Sagar A
2016-09-09 12:51 ` [PATCH v4 11/26] drm/i915/slpc: Update sysfs/debugfs interfaces for frequency parameters Sagar Arun Kamble
2016-09-09 17:13 ` Chris Wilson
2016-09-15 10:41 ` Kamble, Sagar A
2016-09-15 12:00 ` Chris Wilson
2016-09-09 12:51 ` [PATCH v4 12/26] drm/i915/slpc: Send reset event Sagar Arun Kamble
2016-09-09 12:51 ` [PATCH v4 13/26] drm/i915/slpc: Send shutdown event Sagar Arun Kamble
2016-09-09 12:51 ` [PATCH v4 14/26] drm/i915/slpc: Add slpc_status enum values Sagar Arun Kamble
2016-09-09 12:51 ` [PATCH v4 15/26] drm/i915/slpc: Add parameter unset/set/get functions Sagar Arun Kamble
2016-09-09 12:51 ` [PATCH v4 16/26] drm/i915/slpc: Add slpc support for max/min freq Sagar Arun Kamble
2016-09-09 16:49 ` Chris Wilson
2016-09-15 10:42 ` Kamble, Sagar A
2016-09-09 12:51 ` [PATCH v4 17/26] drm/i915/slpc: Add enable/disable debugfs for slpc Sagar Arun Kamble
2016-09-09 16:54 ` Chris Wilson
2016-09-15 10:42 ` Kamble, Sagar A
2016-09-09 12:51 ` [PATCH v4 18/26] drm/i915/slpc: Add i915_slpc_info to debugfs Sagar Arun Kamble
2016-09-09 17:14 ` Chris Wilson
2016-09-15 10:43 ` Kamble, Sagar A
2016-09-09 12:51 ` [PATCH v4 19/26] drm/i915/slpc: Add Broxton SLPC support Sagar Arun Kamble
2016-09-09 12:51 ` [PATCH v4 20/26] drm/i915/slpc: Only Enable GTPERF, Disable DCC, Balancer, IBC, FPS Stall Sagar Arun Kamble
2016-09-09 12:51 ` [PATCH v4 21/26] drm/i915/slpc: Update freq min/max softlimits Sagar Arun Kamble
2016-09-09 12:51 ` [PATCH v4 22/26] drm/i915/slpc: Check GuC load status in SLPC active check Sagar Arun Kamble
2016-09-09 12:51 ` [PATCH v4 23/26] drm/i915/slpc: Keep RP SW Mode enabled while disabling rps Sagar Arun Kamble
2016-09-09 16:58 ` Chris Wilson
2016-09-15 10:44 ` Kamble, Sagar A [this message]
2016-09-09 12:51 ` [PATCH v4 24/26] drm/i915/slpc: Enable SLPC, where supported Sagar Arun Kamble
2016-09-09 16:45 ` Chris Wilson
2016-09-15 10:43 ` Kamble, Sagar A
2016-09-09 12:51 ` [PATCH v4 25/26] drm/i915: Add sysfs interface to know the HW requested frequency Sagar Arun Kamble
2016-09-09 16:43 ` Chris Wilson
2016-09-15 10:44 ` Kamble, Sagar A
2016-09-15 12:01 ` Chris Wilson
2016-09-09 12:51 ` [PATCH v4 26/26] drm/i915: Mark GuC load status as PENDING in i915_drm_resume_early Sagar Arun Kamble
2016-09-09 16:59 ` Chris Wilson
2016-09-09 13:24 ` ✓ Fi.CI.BAT: success for Add support for GuC-based SLPC (rev5) Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f1fabced-08db-e171-019e-a77480721159@intel.com \
--to=sagar.a.kamble@intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).