From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3DEE2E6E80E for ; Tue, 3 Feb 2026 11:09:57 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 8D7B710E610; Tue, 3 Feb 2026 11:09:56 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="CNrsjF8B"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.18]) by gabe.freedesktop.org (Postfix) with ESMTPS id 8C80B10E31F; Tue, 3 Feb 2026 11:09:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1770116996; x=1801652996; h=from:to:cc:subject:in-reply-to:references:date: message-id:mime-version:content-transfer-encoding; bh=56R1y2uK0WuvOdgZJclIVIEh40jpSjHWy/rEnFSTa0o=; b=CNrsjF8B4UfOpmrDYEi83CKK/BpgB5QpKYGUu+brhTQEk0lST82KA5T7 fKPbBqRTWKfkTuzq6wiyHH240+MhTspUXVptlENmKx0KpjPZE2YvHzJT5 HL++qgDigcIiRtroDzVpaH09x3xdiBFpgY/x/iNeXXUeDvaOh6f64YgPT 2MjqrylH7QS1UuQmcAeyln4lO+BzYUGGFQvHEZROD+omwlueM9NhZrAh7 2gEtR8+z+XP9PucybTTlKTFEGVEC8J+kPN5v8U4GMgBG4qq/f6SvBa/uk X88XhzzaX4eq68SGPgUBXXPDrLo0d6hQu0OTO+o5ShONMdh1lk/aFGBX1 g==; X-CSE-ConnectionGUID: wCLVyc5JSNyVOoY47SghUg== X-CSE-MsgGUID: tZr8KUfvT2ilZ/Qdx+aqpg== X-IronPort-AV: E=McAfee;i="6800,10657,11690"; a="71324878" X-IronPort-AV: E=Sophos;i="6.21,270,1763452800"; d="scan'208";a="71324878" Received: from orviesa001.jf.intel.com ([10.64.159.141]) by orvoesa110.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Feb 2026 03:09:55 -0800 X-CSE-ConnectionGUID: OxGEck8HTBaQAzssDpnRaQ== X-CSE-MsgGUID: tc1n5BauSTyToFVHotTZ+g== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.21,270,1763452800"; d="scan'208";a="247426838" Received: from klitkey1-mobl1.ger.corp.intel.com (HELO localhost) ([10.245.246.205]) by smtpauth.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Feb 2026 03:09:49 -0800 From: Jani Nikula To: Atharva Tiwari Cc: Atharva Tiwari , Ard Biesheuvel , Rodrigo Vivi , Joonas Lahtinen , Tvrtko Ursulin , David Airlie , Simona Vetter , Thomas Zimmermann , Javier Martinez Canillas , "Borislav Petkov (AMD)" , Ingo Molnar , Francesco Pompo , Lenny Szubowicz , linux-efi@vger.kernel.org, linux-kernel@vger.kernel.org, intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org, dri-devel@lists.freedesktop.org Subject: Re: [PATCH v3 2/2] drm/i915/display: Disable display for iMac's In-Reply-To: <20260203073130.1111-3-atharvatiwarilinuxdev@gmail.com> Organization: Intel Finland Oy - BIC 0357606-4 - c/o Alberga Business Park, 6 krs Bertel Jungin Aukio 5, 02600 Espoo, Finland References: <20260203073130.1111-1-atharvatiwarilinuxdev@gmail.com> <20260203073130.1111-3-atharvatiwarilinuxdev@gmail.com> Date: Tue, 03 Feb 2026 13:09:46 +0200 Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Tue, 03 Feb 2026, Atharva Tiwari wrote: > Disable display on iMacs, as they can't do link training > on the internal display. > > (tested on iMac20,1) I thought there were open review comments about this. Why are you resending the same thing? BR, Jani. > > Reviewed-by: Jani Nikula > Signed-off-by: Atharva Tiwari > --- > .../gpu/drm/i915/display/intel_display_device.c | 14 +++++++++++++- > 1 file changed, 13 insertions(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/i915/display/intel_display_device.c b/driver= s/gpu/drm/i915/display/intel_display_device.c > index 1170afaa8680..b1fec1018d7e 100644 > --- a/drivers/gpu/drm/i915/display/intel_display_device.c > +++ b/drivers/gpu/drm/i915/display/intel_display_device.c > @@ -3,6 +3,7 @@ > * Copyright =C2=A9 2023 Intel Corporation > */ >=20=20 > +#include > #include >=20=20 > #include > @@ -1435,7 +1436,18 @@ static bool has_no_display(struct pci_dev *pdev) > {} > }; >=20=20 > - return pci_match_id(ids, pdev); > + static const struct dmi_system_id dmi_ids[] =3D { > + { > + .ident =3D "Apple Inc. iMac", > + .matches =3D { > + DMI_EXACT_MATCH(DMI_BOARD_VENDOR, "Apple Inc."), > + DMI_MATCH(DMI_PRODUCT_NAME, "iMac"), > + } > + }, > + {} > + }; > + > + return pci_match_id(ids, pdev) || dmi_check_system(dmi_ids); > } >=20=20 > #define INTEL_DISPLAY_DEVICE(_id, _desc) { .devid =3D (_id), .desc =3D (= _desc) } --=20 Jani Nikula, Intel