From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tvrtko Ursulin Subject: Re: [PATCH v2] drm/i915: Reorder context-close to avoid calling i915_vma_close() under RCU Date: Thu, 9 Nov 2017 09:32:35 +0000 Message-ID: References: <20171109082048.29408-1-chris@chris-wilson.co.uk> <20171109085540.32264-1-chris@chris-wilson.co.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by gabe.freedesktop.org (Postfix) with ESMTPS id 092FE6E886 for ; Thu, 9 Nov 2017 09:32:37 +0000 (UTC) In-Reply-To: <20171109085540.32264-1-chris@chris-wilson.co.uk> Content-Language: en-GB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org Ck9uIDA5LzExLzIwMTcgMDg6NTUsIENocmlzIFdpbHNvbiB3cm90ZToKPiBXaGVuIHdlIGNsb3Nl IHRoZSBWTUEsIHdlIHVuYmluZCBpdCBmcm9tIHRoZSBwcGd0dCBhbmQgdGVhciBkb3duIHRoZQo+ IHBhZ2UgZGlyZWN0b3J5IHBvaW50aW5nIGF0IGl0LiBUaGF0IG1heSB0cmlnZ2VyIHVzIHRvIHJl dHVybiBXQyBwYWdlcwo+IGJhY2sgdG8gdGhlIHN5c3RlbSwgcmVxdWlyaW5nIGNvbnZlcnNpb24g YmFjayB0byBXQiB3aGljaCBpdHNlbGYgbWF5Cj4gc2xlZXAuIFRoYXQgbWFrZXMgaTkxNV92bWFf Y2xvc2UoKSB1bnN1aXRhYmxlIGZvciB1c2UgaW5zaWRlIHRoZSBSQ1UKPiByZWFkIGxvY2ssIHdo aWNoIHdlIG5lZWQgdG8gaG9sZCB0byBpdGVyYXRlIHRoZSByYWRpeHRyZWUuCj4gCj4gVGhlIGZp eCBpcyBxdWl0ZSBzaW1wbGUsIHdlIGNhbiBjbG9zZSBhbGwgdGhlIFZNQSBhcyB3ZSBjbG9zZSB0 aGUgcHBndHQsCj4gd2Ugb25seSBuZWVkIHRvIGRvIHRoYXQgaW5zdGVhZCBvZiBjbG9zaW5nIHRo ZW0gZHVyaW5nIGRlc3RydWN0aW9uIG9mCj4gdGhlIExVVC4KPiAKPiB2MjogT3JkZXIgYmV0d2Vl biBjbG9zaW5nIHRoZSBMVVQgYW5kIHRoZSBwcGd0dCBpcyBpbXBvcnRhbnQ7IHdlIHVzZSB0aGUK PiB2bWEgaW5zaWRlIHRoZSBMVVQgYXMgYSBtZWFucyBvZiByZXRyaWV2aW5nIHRoZSBvYmplY3Qs IGFuZCBzbyB3ZSBtdXN0Cj4gY2xlYXIgdGhlIExVVCBiZWZvcmUgZnJlZWluZyB0aGUgVk1BIHdo ZW4gY2xvc2luZyB0aGUgcHBndHQuCj4gCj4gQnVnemlsbGE6IGh0dHBzOi8vYnVncy5mcmVlZGVz a3RvcC5vcmcvc2hvd19idWcuY2dpP2lkPTEwMzYzOAo+IEZpeGVzOiA1NDdkYTc2YjU3NzcgKCJk cm0vaTkxNTogSG9sZCByY3VfcmVhZF9sb2NrIHdoZW4gaXRlcmF0aW5nIG92ZXIgdGhlIHJhZGl4 dHJlZSAodm1hIGlkcikiKQo+IEZpeGVzOiBkMWI0OGMxZTcxODQgKCJkcm0vaTkxNTogUmVwbGFj ZSBleGVjYnVmIHZtYSBodCB3aXRoIGFuIGlkciIpCj4gQ2M6IFR2cnRrbyBVcnN1bGluIDx0dnJ0 a28udXJzdWxpbkBpbnRlbC5jb20+Cj4gQ2M6IEpvb25hcyBMYWh0aW5lbiA8am9vbmFzLmxhaHRp bmVuQGxpbnV4LmludGVsLmNvbT4KPiBDYzogTWF0dGhldyBBdWxkIDxtYXR0aGV3LndpbGxpYW0u YXVsZEBnbWFpbC5jb20+Cj4gLS0tCj4gICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2dlbV9j b250ZXh0LmMgfCAxMiArKysrKystLS0tLS0KPiAgIDEgZmlsZSBjaGFuZ2VkLCA2IGluc2VydGlv bnMoKyksIDYgZGVsZXRpb25zKC0pCj4gCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9p OTE1L2k5MTVfZ2VtX2NvbnRleHQuYyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZ2VtX2Nv bnRleHQuYwo+IGluZGV4IDEwYWZmYjM1YWM1Ni4uYzA1YzNkN2QyMWE1IDEwMDY0NAo+IC0tLSBh L2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZ2VtX2NvbnRleHQuYwo+ICsrKyBiL2RyaXZlcnMv Z3B1L2RybS9pOTE1L2k5MTVfZ2VtX2NvbnRleHQuYwo+IEBAIC0xMDcsMTQgKzEwNyw5IEBAIHN0 YXRpYyB2b2lkIGx1dF9jbG9zZShzdHJ1Y3QgaTkxNV9nZW1fY29udGV4dCAqY3R4KQo+ICAgCXJj dV9yZWFkX2xvY2soKTsKPiAgIAlyYWRpeF90cmVlX2Zvcl9lYWNoX3Nsb3Qoc2xvdCwgJmN0eC0+ aGFuZGxlc192bWEsICZpdGVyLCAwKSB7Cj4gICAJCXN0cnVjdCBpOTE1X3ZtYSAqdm1hID0gcmN1 X2RlcmVmZXJlbmNlX3Jhdygqc2xvdCk7Cj4gLQkJc3RydWN0IGRybV9pOTE1X2dlbV9vYmplY3Qg Km9iaiA9IHZtYS0+b2JqOwo+ICAgCj4gICAJCXJhZGl4X3RyZWVfaXRlcl9kZWxldGUoJmN0eC0+ aGFuZGxlc192bWEsICZpdGVyLCBzbG90KTsKPiAtCj4gLQkJaWYgKCFpOTE1X3ZtYV9pc19nZ3R0 KHZtYSkpCj4gLQkJCWk5MTVfdm1hX2Nsb3NlKHZtYSk7Cj4gLQo+IC0JCV9faTkxNV9nZW1fb2Jq ZWN0X3JlbGVhc2VfdW5sZXNzX2FjdGl2ZShvYmopOwo+ICsJCV9faTkxNV9nZW1fb2JqZWN0X3Jl bGVhc2VfdW5sZXNzX2FjdGl2ZSh2bWEtPm9iaik7Cj4gICAJfQo+ICAgCXJjdV9yZWFkX3VubG9j aygpOwo+ICAgfQo+IEBAIC0yMDAsNiArMTk1LDExIEBAIHN0YXRpYyB2b2lkIGNvbnRleHRfY2xv c2Uoc3RydWN0IGk5MTVfZ2VtX2NvbnRleHQgKmN0eCkKPiAgIHsKPiAgIAlpOTE1X2dlbV9jb250 ZXh0X3NldF9jbG9zZWQoY3R4KTsKPiAgIAo+ICsJLyoKPiArCSAqIFRoZSBMVVQgdXNlcyB0aGUg Vk1BIGFzIGEgYmFja3BvaW50ZXIgdG8gdW5yZWYgdGhlIG9iamVjdCwKPiArCSAqIHNvIHdlIG5l ZWQgdG8gY2xlYXIgdGhlIExVVCBiZWZvcmUgd2UgY2xvc2UgYWxsIHRoZSBWTUEgKGluc2lkZQo+ ICsJICogdGhlIHBwZ3R0KS4KPiArCSAqLwo+ICAgCWx1dF9jbG9zZShjdHgpOwo+ICAgCWlmIChj dHgtPnBwZ3R0KQo+ICAgCQlpOTE1X3BwZ3R0X2Nsb3NlKCZjdHgtPnBwZ3R0LT5iYXNlKTsKPiAK ClJldmlld2VkLWJ5OiBUdnJ0a28gVXJzdWxpbiA8dHZydGtvLnVyc3VsaW5AaW50ZWwuY29tPgoK UmVnYXJkcywKClR2cnRrbwpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3Rv cC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRl bC1nZngK