From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.1 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 038B4C2D0C2 for ; Fri, 3 Jan 2020 11:05:22 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CE4C4227BF for ; Fri, 3 Jan 2020 11:05:21 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="H6psqo3X" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CE4C4227BF Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=intel-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 56B6A8991E; Fri, 3 Jan 2020 11:05:21 +0000 (UTC) Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [205.139.110.120]) by gabe.freedesktop.org (Postfix) with ESMTPS id 49ECD8991E for ; Fri, 3 Jan 2020 11:05:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1578049519; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=9XmOaPsSShmldOxrVwacPyclsM2BoBNToZ/DRswhF70=; b=H6psqo3XKuxeOm7xj9ZWddcxQzeBX5ohaQv8iGsQFtvejR/TnFLli8KHMl56khgv++Btg3 Hfzk0nGk3cDrnrYiSR0TeOL9UkBx3iyR9zxdTDkfv0mM1TbM0j+dZ8GX6rRgT91p2MHg7y pw56eqOWslZVRJaUvbPIvWbcaePgZi8= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-18-lwv0TapTMsGR_-WigiZoOA-1; Fri, 03 Jan 2020 06:05:14 -0500 Received: by mail-wr1-f71.google.com with SMTP id u18so22876927wrn.11 for ; Fri, 03 Jan 2020 03:05:14 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=9XmOaPsSShmldOxrVwacPyclsM2BoBNToZ/DRswhF70=; b=qrfEM2EAV1q1mqJW6JpEvORmbryXl9oY7W+FFqYAoi73A/WVp2rSaWB/kMN8qMdAu1 nYVTTKVU/yoIeHB7YSxEDj2Zf2vRIA5ul3crGhtSqJBukg9ZX4AIjMDYSjCE/HdVXJTR mkQJR85xbfq16SUcxgrF5RpatCbzOB4ivU1WNxMMFXRQCfyaqWGXfnU4Q6HTsI0qYtFR BayCFXZ9gwU+vUV27O9wzjTSjedy0x8q48eaHK4WX6gAIOQilvd0KPSLvoQkQ0lEKcjL 6YqJbZIwy7/8nUc7jR6A+qYlGJ4v+0moTPJ13DP0kpOrEQLEAATNNCDSIQ5KB8xeUAdR WwsQ== X-Gm-Message-State: APjAAAWMT2nURBa17qFdoQIdasezsxrOApz8j/VQeE1FF5bNWE+rBUh1 rOwWgN4ZyhQjsHgjpLTZ+PFQMO6p1FVqPzBbSIIOoMoe/JLVPPxECjKSsoLPfmXj3etO5VinWRI i4Ba5XBlWrLZFyOeibOuNrbsDRcsG X-Received: by 2002:adf:ed83:: with SMTP id c3mr84991931wro.51.1578049513566; Fri, 03 Jan 2020 03:05:13 -0800 (PST) X-Google-Smtp-Source: APXvYqzH+13boLCLBlH1JGgWGkjgluCu1ZfyETghu3yV/8nIiokg2z/Fe75Ksx9wDvoKumOS6QrMZg== X-Received: by 2002:adf:ed83:: with SMTP id c3mr84991912wro.51.1578049513306; Fri, 03 Jan 2020 03:05:13 -0800 (PST) Received: from shalem.localdomain (2001-1c00-0c0c-fe00-7e79-4dac-39d0-9c14.cable.dynamic.v6.ziggo.nl. [2001:1c00:c0c:fe00:7e79:4dac:39d0:9c14]) by smtp.gmail.com with ESMTPSA id r15sm11550537wmh.21.2020.01.03.03.05.12 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 03 Jan 2020 03:05:12 -0800 (PST) To: Vivek Kasireddy , intel-gfx@lists.freedesktop.org References: <20200103000050.8223-1-vivek.kasireddy@intel.com> From: Hans de Goede Message-ID: Date: Fri, 3 Jan 2020 12:05:11 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.3.1 MIME-Version: 1.0 In-Reply-To: <20200103000050.8223-1-vivek.kasireddy@intel.com> Content-Language: en-US X-MC-Unique: lwv0TapTMsGR_-WigiZoOA-1 X-Mimecast-Spam-Score: 0 Subject: Re: [Intel-gfx] [PATCH] drm/i915/dsi: Parse the I2C element from the VBT MIPI sequence block X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Deepak M Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" Hi Vivek, On 03-01-2020 01:00, Vivek Kasireddy wrote: > Parsing the i2c element is mainly done to transfer the payload from the > MIPI sequence block to the relevant slave device. In some cases, the > commands that are part of the payload can be used to turn on the backlight. > > This patch is actually a refactored version of this old patch: > https://lists.freedesktop.org/archives/intel-gfx/2014-December/056897.html > > In addition to the refactoring, the old patch is augmented by looking up > the i2c bus from ACPI NS instead of relying on the bus number provided > in the VBT. > > Cc: Deepak M > Cc: Nabendu Maiti > Cc: Matt Roper > Cc: Bob Paauwe > Signed-off-by: Vivek Kasireddy Thank you for this patch, I have been doing a lot of work to make DSI panels on Bay Trail and Cherry Trail devices work better, as such I've done a lot of testing of DSI panels. But I have never seen any MIPI sequences actually use the i2c commands. May I ask how you have tested this? Do you have a device which actually uses the i2c commands? I also have some small review comments inline: > --- > drivers/gpu/drm/i915/display/intel_dsi.h | 3 + > drivers/gpu/drm/i915/display/intel_dsi_vbt.c | 93 ++++++++++++++++++++ > 2 files changed, 96 insertions(+) > > diff --git a/drivers/gpu/drm/i915/display/intel_dsi.h b/drivers/gpu/drm/i915/display/intel_dsi.h > index b15be5814599..5651bc8aa5c2 100644 > --- a/drivers/gpu/drm/i915/display/intel_dsi.h > +++ b/drivers/gpu/drm/i915/display/intel_dsi.h > @@ -68,6 +68,9 @@ struct intel_dsi { > /* number of DSI lanes */ > unsigned int lane_count; > > + /* i2c bus associated with the slave device */ > + int i2c_bus_num; > + > /* > * video mode pixel format > * > diff --git a/drivers/gpu/drm/i915/display/intel_dsi_vbt.c b/drivers/gpu/drm/i915/display/intel_dsi_vbt.c > index f90946c912ee..60441a5a3dba 100644 > --- a/drivers/gpu/drm/i915/display/intel_dsi_vbt.c > +++ b/drivers/gpu/drm/i915/display/intel_dsi_vbt.c > @@ -83,6 +83,12 @@ static struct gpio_map vlv_gpio_table[] = { > { VLV_GPIO_NC_11_PANEL1_BKLTCTL }, > }; > > +struct i2c_adapter_lookup { > + u16 slave_addr; > + struct intel_dsi *intel_dsi; > + acpi_handle dev_handle; > +}; > + > #define CHV_GPIO_IDX_START_N 0 > #define CHV_GPIO_IDX_START_E 73 > #define CHV_GPIO_IDX_START_SW 100 > @@ -375,8 +381,93 @@ static const u8 *mipi_exec_gpio(struct intel_dsi *intel_dsi, const u8 *data) > return data; > } > > +static int i2c_adapter_lookup(struct acpi_resource *ares, void *data) > +{ > + struct i2c_adapter_lookup *lookup = data; > + struct intel_dsi *intel_dsi = lookup->intel_dsi; > + struct acpi_resource_i2c_serialbus *sb; > + struct i2c_adapter *adapter; > + acpi_handle adapter_handle; > + acpi_status status; > + > + if (intel_dsi->i2c_bus_num >= 0 || > + !i2c_acpi_get_i2c_resource(ares, &sb)) > + return 1; > + > + if (lookup->slave_addr != sb->slave_address) > + return 1; > + > + status = acpi_get_handle(lookup->dev_handle, > + sb->resource_source.string_ptr, > + &adapter_handle); > + if (ACPI_FAILURE(status)) > + return 1; > + > + adapter = i2c_acpi_find_adapter_by_handle(adapter_handle); > + if (adapter) > + intel_dsi->i2c_bus_num = adapter->nr; > + > + return 1; > +} > + > static const u8 *mipi_exec_i2c(struct intel_dsi *intel_dsi, const u8 *data) > { > + struct drm_device *dev = intel_dsi->base.base.dev; > + struct i2c_adapter *adapter; > + struct acpi_device *acpi_dev; > + struct list_head resource_list; > + struct i2c_adapter_lookup lookup; > + struct i2c_msg msg; > + int ret; > + u8 vbt_i2c_bus_num = *(data + 2); > + u16 slave_addr = *(u16 *)(data + 3); > + u8 reg_offset = *(data + 5); > + u8 payload_size = *(data + 6); > + u8 *payload_data; > + > + if (intel_dsi->i2c_bus_num < 0) { > + intel_dsi->i2c_bus_num = vbt_i2c_bus_num; > + > + acpi_dev = ACPI_COMPANION(&dev->pdev->dev); > + if (acpi_dev) { > + memset(&lookup, 0, sizeof(lookup)); > + lookup.slave_addr = slave_addr; > + lookup.intel_dsi = intel_dsi; > + lookup.dev_handle = acpi_device_handle(acpi_dev); > + > + INIT_LIST_HEAD(&resource_list); > + acpi_dev_get_resources(acpi_dev, &resource_list, > + i2c_adapter_lookup, > + &lookup); > + acpi_dev_free_resource_list(&resource_list); > + } > + } > + > + adapter = i2c_get_adapter(intel_dsi->i2c_bus_num); > + if (!adapter) > + goto out; This should never happen, so you should put a DRM_DEV_WARN here. > + > + payload_data = kzalloc(payload_size + 1, GFP_KERNEL); > + if (!payload_data) > + goto out; > + > + payload_data[0] = reg_offset; > + memcpy(&payload_data[1], (data + 7), payload_size); > + > + msg.addr = slave_addr; > + msg.flags = 0; > + msg.len = payload_size + 1; > + msg.buf = payload_data; > + > + ret = i2c_transfer(adapter, &msg, 1); > + if (ret < 0) > + DRM_ERROR("i2c transfer failed"); DRM_DEV_ERROR? And maybe some more info, like the register which the transfer is going to + payload size? > + > + kfree(payload_data); > + i2c_put_adapter(adapter); > + Just put out here, no need for the DRM_DEBUG (which should no longer be a debug now that we implement this) below, since we WARN or ERROR on all goto out; statements above. out: > + return data + payload_size + 7; And drop these 3 lines: > +out: > DRM_DEBUG_KMS("Skipping I2C element execution\n"); > > return data + *(data + 6) + 7; > @@ -664,6 +755,8 @@ bool intel_dsi_vbt_init(struct intel_dsi *intel_dsi, u16 panel_id) > intel_dsi->panel_off_delay = pps->panel_off_delay / 10; > intel_dsi->panel_pwr_cycle_delay = pps->panel_power_cycle_delay / 10; > > + intel_dsi->i2c_bus_num = -1; > + > /* a regular driver would get the device in probe */ > for_each_dsi_port(port, intel_dsi->ports) { > mipi_dsi_attach(intel_dsi->dsi_hosts[port]->device); > Regards, Hans _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx