From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tvrtko Ursulin Subject: Re: [PATCH] drm/i915: Increase the busyspin durations for i915_wait_request Date: Fri, 15 Sep 2017 11:01:02 +0100 Message-ID: References: <20170914095807.16359-1-chris@chris-wilson.co.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by gabe.freedesktop.org (Postfix) with ESMTPS id 79EE06EB93 for ; Fri, 15 Sep 2017 10:01:05 +0000 (UTC) In-Reply-To: <20170914095807.16359-1-chris@chris-wilson.co.uk> Content-Language: en-GB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson , intel-gfx@lists.freedesktop.org Cc: Ben Widawsky , Eero Tamminen List-Id: intel-gfx@lists.freedesktop.org Ck9uIDE0LzA5LzIwMTcgMTA6NTgsIENocmlzIFdpbHNvbiB3cm90ZToKPiBBbiBpbnRlcmVzdGlu ZyBkaXNjdXNzaW9uIHJlZ2FyZGluZyAiaHlicmlkIGludGVycnVwdCBwb2xsaW5nIiBmb3IgTlZN ZQo+IGNhbWUgdG8gdGhlIGNvbmNsdXNpb24gdGhhdCB0aGUgaWRlYWwgYnVzeXNwaW4gYmVmb3Jl IHNsZWVwaW5nIHdhcyBoYWxmCj4gb2YgdGhlIGV4cGVjdGVkIHJlcXVlc3QgbGF0ZW5jeSAoYW5k IGJldHRlciBpZiBpdCB3YXMgYWxyZWFkeSBoYWxmd2F5Cj4gdGhyb3VnaCB0aGF0IHJlcXVlc3Qp LiBUaGlzIHN1Z2dlc3RlZCB0aGF0IHdlIHRvbyBzaG91bGQgbG9vayBhZ2FpbiBhdAo+IG91ciB0 cmFkZW9mZiBiZXR3ZWVuIHNwaW5uaW5nIGFuZCB3YWl0aW5nLiBDdXJyZW50bHksIG91ciBzcGlu IHNpbXBseQo+IHRyaWVzIHRvIGhpZGUgdGhlIGNvc3Qgb2YgZW5hYmxpbmcgdGhlIGludGVycnVw dCwgd2hpY2ggaXMgZ29vZCB0byBhdm9pZAo+IHBlbmFsaXNpbmcgbm9wIHJlcXVlc3RzIChpLmUu IHRlc3QgdGhyb3VnaHB1dCkgYW5kIG5vdCBtdWNoIGVsc2UuCj4gU3R1ZHlpbmcgcmVhbCB3b3Js ZCB3b3JrbG9hZHMgc3VnZ2VzdHMgdGhhdCBhIHNwaW4gb2YgdXB0byA1MDB1cyBjYW4KCldoYXQg d29ya2xvYWRzIGFuZCBhbmQgcG93ZXIvcGVyZiB0ZXN0aW5nPwoKPiBkcmFtYXRpY2FsbHkgYm9v c3QgcGVyZm9ybWFuY2UsIGJ1dCB0aGUgc3VnZ2VzdGlvbiBpcyB0aGF0IHRoaXMgaXMgbm90Cj4g ZnJvbSBhdm9pZGluZyBpbnRlcnJ1cHQgbGF0ZW5jeSBwZXItc2UsIGJ1dCBmcm9tIHNlY29uZGFy eSBlZmZlY3RzIG9mCj4gc2xlZXBpbmcgc3VjaCBhcyBhbGxvd2luZyB0aGUgQ1BVIHJlZHVjZSBj c3RhdGUgYW5kIGNvbnRleHQgc3dpdGNoIGF3YXkuCgpNYXliZSB0aGUgc2Vjb25kIHBhcnQgb2Yg dGhlIHNlbnRlbmNlIHdvdWxkIGJlIGNsZWFyZXIgaWYgbm90IGluIGEgd2F5IAppbiBpbnZlcnRl ZCBmb3JtLiBMaWtlIGxvbmdlciBzcGluID0gbW9yZSBwZXJmb3JtYW5jZSA9IGxlc3Mgc2xlZXBp bmcgPSAKbGVzcyBjc3RhdGUgc3dpdGNoaW5nPyBPciBqdXN0IGFkZCAiYnV0IGZyb20gX2F2b2lk aW5nXyBzZWNvbmRhcnkgCmVmZmVjdHMgb2Ygc2xlZXBpbmciPwoKPiBUbyBvZmZzZXQgdGhvc2Ug Y29zdHMgZnJvbSBwZW5hbGlzaW5nIHRoZSBhY3RpdmUgY2xpZW50LCBidW1wIHRoZSBpbml0aWFs Cj4gc3BpbiBzb21ld2hhdCB0byAyNTB1cyBhbmQgdGhlIHNlY29uZGFyeSBzcGluIHRvIDIwdXMg dG8gYmFsYW5jZSB0aGUgY29zdAo+IG9mIGFub3RoZXIgY29udGV4dCBzd2l0Y2ggZm9sbG93aW5n IHRoZSBpbnRlcnJ1cHQuCj4gCj4gU3VnZ2VzdGVkLWJ5OiBTYWdhciBLYW1ibGUgPHNhZ2FyLmEu a2FtYmxlQGludGVsLmNvbT4KPiBTaWduZWQtb2ZmLWJ5OiBDaHJpcyBXaWxzb24gPGNocmlzQGNo cmlzLXdpbHNvbi5jby51az4KPiBDYzogU2FnYXIgS2FtYmxlIDxzYWdhci5hLmthbWJsZUBpbnRl bC5jb20+Cj4gQ2M6IEVlcm8gVGFtbWluZW4gPGVlcm8udC50YW1taW5lbkBpbnRlbC5jb20+Cj4g Q2M6IFR2cnRrbyBVcnN1bGluIDx0dnJ0a28udXJzdWxpbkBpbnRlbC5jb20+Cj4gQ2M6IEJlbiBX aWRhd3NreSA8YmVuQGJ3aWRhd3NrLm5ldD4KPiBDYzogSm9vbmFzIExhaHRpbmVuIDxqb29uYXMu bGFodGluZW5AbGludXguaW50ZWwuY29tPgo+IC0tLQo+ICAgZHJpdmVycy9ncHUvZHJtL2k5MTUv aTkxNV9nZW1fcmVxdWVzdC5jIHwgMjUgKysrKysrKysrKysrKysrKysrKysrLS0tLQo+ICAgMSBm aWxlIGNoYW5nZWQsIDIxIGluc2VydGlvbnMoKyksIDQgZGVsZXRpb25zKC0pCj4gCj4gZGlmZiAt LWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZ2VtX3JlcXVlc3QuYyBiL2RyaXZlcnMv Z3B1L2RybS9pOTE1L2k5MTVfZ2VtX3JlcXVlc3QuYwo+IGluZGV4IDgxM2EzYjU0NmQ2ZS4uY2Ni ZGFmNmEwZTRkIDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZ2VtX3Jl cXVlc3QuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZ2VtX3JlcXVlc3QuYwo+ IEBAIC0xMTU1LDggKzExNTUsMjAgQEAgbG9uZyBpOTE1X3dhaXRfcmVxdWVzdChzdHJ1Y3QgZHJt X2k5MTVfZ2VtX3JlcXVlc3QgKnJlcSwKPiAgIAlHRU1fQlVHX09OKCFpbnRlbF93YWl0X2hhc19z ZXFubygmd2FpdCkpOwo+ICAgCUdFTV9CVUdfT04oIWk5MTVfc3dfZmVuY2Vfc2lnbmFsZWQoJnJl cS0+c3VibWl0KSk7Cj4gICAKPiAtCS8qIE9wdGltaXN0aWMgc2hvcnQgc3BpbiBiZWZvcmUgdG91 Y2hpbmcgSVJRcyAqLwo+IC0JaWYgKGk5MTVfc3Bpbl9yZXF1ZXN0KHJlcSwgc3RhdGUsIDUpKQo+ ICsJLyogT3B0aW1pc3RpYyBzaG9ydCBzcGluIGJlZm9yZSB0b3VjaGluZyBJUlFzLgoKU28gaXQn cyBub3Qgc2hvcnQgYW55IG1vcmUuICJPcHRpbWlzdGljIGJ1c3kgc3BpbiIgPwoKPiArCSAqCj4g KwkgKiBXZSB1c2UgYSByYXRoZXIgbGFyZ2UgdmFsdWUgaGVyZSB0byBvZmZzZXQgdGhlIHBlbmFs dHkgb2Ygc3dpdGNoaW5nCj4gKwkgKiBhd2F5IGZyb20gdGhlIGFjdGl2ZSB0YXNrLiBGcmVxdWVu dGx5LCB0aGUgY2xpZW50IHdpbGwgd2FpdCB1cG9uCj4gKwkgKiBhbiBvbGQgc3dhcGJ1ZmZlciB0 byB0aHJvdHRsZSBpdHNlbGYgdG8gcmVtYWluIHdpdGhpbiBhIGZyYW1lIG9mCj4gKwkgKiB0aGUg Z3B1LiBJZiB0aGUgY2xpZW50IGlzIHJ1bm5pbmcgaW4gbG9ja3N0ZXAgd2l0aCB0aGUgZ3B1LCB0 aGVuCj4gKwkgKiBpdCBzaG91bGQgbm90IGJlIHdhaXRpbmcgbG9uZyBhdCBhbGwsIGFuZCBhIHNs ZWVwIG5vdyB3aWxsIGluY3VyCj4gKwkgKiBleHRyYSBzY2hlZHVsZXIgbGF0ZW5jeSBpbiBwcm9k dWNpbmcgdGhlIG5leHQgZnJhbWUuIFNvIHdlIHNsZWVwCj4gKwkgKiBmb3IgbG9uZ2VyIHRvIHRy eSBhbmQga2VlcCB0aGUgY2xpZW50IHJ1bm5pbmcuCj4gKwkgKgoKMjUwdXMgc291bmRzIHF1aXRl IGxvbmcgYW5kIHdvcnJ5aW5nIHRvIG1lLgoKSW4gdGhlIHdhaXRpbmcgb24gc3dhcGJ1ZmZlciBj YXNlLCB3aGF0IGFyZSB0aGUgY2xpZW50cyB3YWl0aW5nIGZvcj8gR1BVIApyZW5kZXJpbmcgdG8g ZmluaXNoIG9yIHByZXZpb3VzIHZibGFuayBvciBzb21ldGhpbmc/CgpJIGFtIHRoaW5raW5nIGlm IGl0IHdvdWxkIGJlIHBvc3NpYmxlIHRvIGFkZCBhIHNwZWNpYWwgQVBJIGp1c3QgZm9yIHRoaXMg CnNvcnQgb2Ygd2FpdHMgYW5kIGludGVybmFsbHkga25vdyBob3cgbG9uZyBpdCBpcyBsaWtlbHkg dG8gdGFrZS4gU28gdGhlbiAKZGVjaWRlIGJhc2VkIG9uIHRoYXQgd2hldGhlciB0byBzcGluIG9y IHNsZWVwLiBMaWtlIG5leHQgdmJsYW5rIGlzIApjb21pbmcgaW4gNW1zLCBubyBwb2ludCBpbiBi dXN5IHNwaW5uaW5nIG9yIHNvbWV0aGluZyBsaWtlIHRoYXQuCgpSZWdhcmRzLAoKVHZydGtvCgo+ ICsJICogV2UgbmVlZCB+NXVzIHRvIGVuYWJsZSB0aGUgaXJxLCB+MjB1cyB0byBoaWRlIGEgY29u dGV4dCBzd2l0Y2gsCj4gKwkgKiB3ZSB1c2UgMjUwdXMgdG8ga2VlcCB0aGUgY2FjaGUgaG90Lgo+ ICsJICovCj4gKwlpZiAoaTkxNV9zcGluX3JlcXVlc3QocmVxLCBzdGF0ZSwgMjUwKSkKPiAgIAkJ Z290byBjb21wbGV0ZTsKPiAgIAo+ICAgCXNldF9jdXJyZW50X3N0YXRlKHN0YXRlKTsKPiBAQCAt MTIxMiw4ICsxMjI0LDEzIEBAIGxvbmcgaTkxNV93YWl0X3JlcXVlc3Qoc3RydWN0IGRybV9pOTE1 X2dlbV9yZXF1ZXN0ICpyZXEsCj4gICAJCSAgICBfX2k5MTVfd2FpdF9yZXF1ZXN0X2NoZWNrX2Fu ZF9yZXNldChyZXEpKQo+ICAgCQkJY29udGludWU7Cj4gICAKPiAtCQkvKiBPbmx5IHNwaW4gaWYg d2Uga25vdyB0aGUgR1BVIGlzIHByb2Nlc3NpbmcgdGhpcyByZXF1ZXN0ICovCj4gLQkJaWYgKGk5 MTVfc3Bpbl9yZXF1ZXN0KHJlcSwgc3RhdGUsIDIpKQo+ICsJCS8qCj4gKwkJICogQSBxdWljayBz cGluIG5vdyB3ZSBhcmUgb24gdGhlIENQVSB0byBvZmZzZXQgdGhlIGNvc3Qgb2YKPiArCQkgKiBj b250ZXh0IHN3aXRjaGluZyBhd2F5IChhbmQgc28gc3BpbiBmb3Igcm91Z2hseSB0aGUgc2FtZSBh cwo+ICsJCSAqIHRoZSBzY2hlZHVsZXIgbGF0ZW5jeSkuIFdlIG9ubHkgc3BpbiBpZiB3ZSBrbm93 IHRoZSBHUFUgaXMKPiArCQkgKiBwcm9jZXNzaW5nIHRoaXMgcmVxdWVzdCwgYW5kIHNvIGxpa2Vs eSB0byBmaW5pc2ggc2hvcnRseS4KPiArCQkgKi8KPiArCQlpZiAoaTkxNV9zcGluX3JlcXVlc3Qo cmVxLCBzdGF0ZSwgMjApKQo+ICAgCQkJYnJlYWs7Cj4gICAKPiAgIAkJaWYgKCFpbnRlbF93YWl0 X2NoZWNrX3JlcXVlc3QoJndhaXQsIHJlcSkpIHsKPiAKX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhA bGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxt YW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cg==