From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tvrtko Ursulin Subject: Re: [PATCH v2 08/15] drm/i915: Take a reference whilst processing the signaler request Date: Wed, 22 Feb 2017 12:35:09 +0000 Message-ID: References: <20170222114610.5819-1-chris@chris-wilson.co.uk> <20170222114610.5819-9-chris@chris-wilson.co.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by gabe.freedesktop.org (Postfix) with ESMTPS id A3F356E7E3 for ; Wed, 22 Feb 2017 12:35:12 +0000 (UTC) In-Reply-To: <20170222114610.5819-9-chris@chris-wilson.co.uk> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org Ck9uIDIyLzAyLzIwMTcgMTE6NDYsIENocmlzIFdpbHNvbiB3cm90ZToKPiBUaGUgcGxhbiBpbiB0 aGUgbmVhci1mdXR1cmUgaXMgdG8gYWxsb3cgcmVxdWVzdHMgdG8gYmUgcmVtb3ZlZCBmcm9tIHRo ZQo+IHNpZ25hbGVyLiBXZSBjYW4gbm8gbG9uZ2VyIHRoZW4gcmVseSBvbiBob2xkaW5nIGEgcmVm ZXJlbmNlIHRvIHRoZQo+IHJlcXVlc3QgZm9yIHRoZSBkdXJhdGlvbiBpdCBpcyBpbiB0aGUgc2ln bmFsaW5nIHRyZWUsIGFuZCBpbnN0ZWFkIG11c3QKPiBvYnRhaW4gYSByZWZlcmVuY2UgdG8gdGhl IHJlcXVlc3QgZm9yIHRoZSBjdXJyZW50IG9wZXJhdGlvbiB1c2luZyBSQ1UuCj4KPiBTaWduZWQt b2ZmLWJ5OiBDaHJpcyBXaWxzb24gPGNocmlzQGNocmlzLXdpbHNvbi5jby51az4KPiAtLS0KPiAg ZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfYnJlYWRjcnVtYnMuYyB8IDI0ICsrKysrKysrKysr KysrKystLS0tLS0tLQo+ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9yaW5nYnVmZmVyLmgg IHwgIDIgKy0KPiAgMiBmaWxlcyBjaGFuZ2VkLCAxNyBpbnNlcnRpb25zKCspLCA5IGRlbGV0aW9u cygtKQo+Cj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2JyZWFkY3J1 bWJzLmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9icmVhZGNydW1icy5jCj4gaW5kZXgg ZDViZjRjMGIyZGViLi42MmU2YjgxODEyMDAgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJt L2k5MTUvaW50ZWxfYnJlYWRjcnVtYnMuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2lu dGVsX2JyZWFkY3J1bWJzLmMKPiBAQCAtNDk2LDcgKzQ5NiwxMSBAQCBzdGF0aWMgaW50IGludGVs X2JyZWFkY3J1bWJzX3NpZ25hbGVyKHZvaWQgKmFyZykKPiAgCQkgKiBuZWVkIHRvIHdhaXQgZm9y IGEgbmV3IGludGVycnVwdCBmcm9tIHRoZSBHUFUgb3IgZm9yCj4gIAkJICogYSBuZXcgY2xpZW50 Lgo+ICAJCSAqLwo+IC0JCXJlcXVlc3QgPSBSRUFEX09OQ0UoYi0+Zmlyc3Rfc2lnbmFsKTsKPiAr CQlyY3VfcmVhZF9sb2NrKCk7Cj4gKwkJcmVxdWVzdCA9IHJjdV9kZXJlZmVyZW5jZShiLT5maXJz dF9zaWduYWwpOwo+ICsJCWlmIChyZXF1ZXN0KQo+ICsJCQlyZXF1ZXN0ID0gaTkxNV9nZW1fcmVx dWVzdF9nZXRfcmN1KHJlcXVlc3QpOwo+ICsJCXJjdV9yZWFkX3VubG9jaygpOwo+ICAJCWlmIChz aWduYWxfY29tcGxldGUocmVxdWVzdCkpIHsKPiAgCQkJbG9jYWxfYmhfZGlzYWJsZSgpOwo+ICAJ CQlkbWFfZmVuY2Vfc2lnbmFsKCZyZXF1ZXN0LT5mZW5jZSk7Cj4gQEAgLTUxNSwyNCArNTE5LDI4 IEBAIHN0YXRpYyBpbnQgaW50ZWxfYnJlYWRjcnVtYnNfc2lnbmFsZXIodm9pZCAqYXJnKQo+ICAJ CQkgKiB0aGUgb2xkZXN0IGJlZm9yZSBwaWNraW5nIHRoZSBuZXh0IG9uZS4KPiAgCQkJICovCj4g IAkJCXNwaW5fbG9ja19pcnEoJmItPmxvY2spOwo+IC0JCQlpZiAocmVxdWVzdCA9PSBiLT5maXJz dF9zaWduYWwpIHsKPiArCQkJaWYgKHJlcXVlc3QgPT0gcmN1X2FjY2Vzc19wb2ludGVyKGItPmZp cnN0X3NpZ25hbCkpIHsKPiAgCQkJCXN0cnVjdCByYl9ub2RlICpyYiA9Cj4gIAkJCQkJcmJfbmV4 dCgmcmVxdWVzdC0+c2lnbmFsaW5nLm5vZGUpOwo+IC0JCQkJYi0+Zmlyc3Rfc2lnbmFsID0gcmIg PyB0b19zaWduYWxlcihyYikgOiBOVUxMOwo+ICsJCQkJcmN1X2Fzc2lnbl9wb2ludGVyKGItPmZp cnN0X3NpZ25hbCwKPiArCQkJCQkJICAgcmIgPyB0b19zaWduYWxlcihyYikgOiBOVUxMKTsKPiAg CQkJfQo+ICAJCQlyYl9lcmFzZSgmcmVxdWVzdC0+c2lnbmFsaW5nLm5vZGUsICZiLT5zaWduYWxz KTsKPiAgCQkJc3Bpbl91bmxvY2tfaXJxKCZiLT5sb2NrKTsKPgo+ICAJCQlpOTE1X2dlbV9yZXF1 ZXN0X3B1dChyZXF1ZXN0KTsKPiAgCQl9IGVsc2Ugewo+IC0JCQlpZiAoa3RocmVhZF9zaG91bGRf c3RvcCgpKQo+ICsJCQlpZiAoa3RocmVhZF9zaG91bGRfc3RvcCgpKSB7Cj4gKwkJCQlHRU1fQlVH X09OKHJlcXVlc3QpOwo+ICAJCQkJYnJlYWs7Cj4gKwkJCX0KPgo+ICAJCQlzY2hlZHVsZSgpOwo+ Cj4gIAkJCWlmIChrdGhyZWFkX3Nob3VsZF9wYXJrKCkpCj4gIAkJCQlrdGhyZWFkX3BhcmttZSgp Owo+ICAJCX0KPiArCQlpOTE1X2dlbV9yZXF1ZXN0X3B1dChyZXF1ZXN0KTsKPiAgCX0gd2hpbGUg KDEpOwo+ICAJX19zZXRfY3VycmVudF9zdGF0ZShUQVNLX1JVTk5JTkcpOwo+Cj4gQEAgLTU5Nyw3 ICs2MDUsNyBAQCB2b2lkIGludGVsX2VuZ2luZV9lbmFibGVfc2lnbmFsaW5nKHN0cnVjdCBkcm1f aTkxNV9nZW1fcmVxdWVzdCAqcmVxdWVzdCkKPiAgCXJiX2xpbmtfbm9kZSgmcmVxdWVzdC0+c2ln bmFsaW5nLm5vZGUsIHBhcmVudCwgcCk7Cj4gIAlyYl9pbnNlcnRfY29sb3IoJnJlcXVlc3QtPnNp Z25hbGluZy5ub2RlLCAmYi0+c2lnbmFscyk7Cj4gIAlpZiAoZmlyc3QpCj4gLQkJc21wX3N0b3Jl X21iKGItPmZpcnN0X3NpZ25hbCwgcmVxdWVzdCk7Cj4gKwkJcmN1X2Fzc2lnbl9wb2ludGVyKGIt PmZpcnN0X3NpZ25hbCwgcmVxdWVzdCk7Cj4KPiAgCXNwaW5fdW5sb2NrKCZiLT5sb2NrKTsKPgo+ IEBAIC02NzAsNyArNjc4LDcgQEAgdm9pZCBpbnRlbF9lbmdpbmVfZmluaV9icmVhZGNydW1icyhz dHJ1Y3QgaW50ZWxfZW5naW5lX2NzICplbmdpbmUpCj4gIAkvKiBUaGUgZW5naW5lcyBzaG91bGQg YmUgaWRsZSBhbmQgYWxsIHJlcXVlc3RzIGFjY291bnRlZCBmb3IhICovCj4gIAlXQVJOX09OKFJF QURfT05DRShiLT5maXJzdF93YWl0KSk7Cj4gIAlXQVJOX09OKCFSQl9FTVBUWV9ST09UKCZiLT53 YWl0ZXJzKSk7Cj4gLQlXQVJOX09OKFJFQURfT05DRShiLT5maXJzdF9zaWduYWwpKTsKPiArCVdB Uk5fT04ocmN1X2FjY2Vzc19wb2ludGVyKGItPmZpcnN0X3NpZ25hbCkpOwo+ICAJV0FSTl9PTigh UkJfRU1QVFlfUk9PVCgmYi0+c2lnbmFscykpOwo+Cj4gIAlpZiAoIUlTX0VSUl9PUl9OVUxMKGIt PnNpZ25hbGVyKSkKPiBAQCAtNjg2LDggKzY5NCw4IEBAIGJvb2wgaW50ZWxfYnJlYWRjcnVtYnNf YnVzeShzdHJ1Y3QgaW50ZWxfZW5naW5lX2NzICplbmdpbmUpCj4KPiAgCXNwaW5fbG9ja19pcnEo JmItPmxvY2spOwo+Cj4gLQlpZiAoYi0+Zmlyc3Rfd2FpdCkgewo+IC0JCXdha2VfdXBfcHJvY2Vz cyhiLT5maXJzdF93YWl0LT50c2spOwo+ICsJaWYgKHJjdV9hY2Nlc3NfcG9pbnRlcihiLT5maXJz dF9zaWduYWwpKSB7Cj4gKwkJd2FrZV91cF9wcm9jZXNzKGItPnNpZ25hbGVyKTsKPiAgCQlidXN5 IHw9IGludGVsX2VuZ2luZV9mbGFnKGVuZ2luZSk7Cj4gIAl9Cj4KPiBkaWZmIC0tZ2l0IGEvZHJp dmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfcmluZ2J1ZmZlci5oIGIvZHJpdmVycy9ncHUvZHJtL2k5 MTUvaW50ZWxfcmluZ2J1ZmZlci5oCj4gaW5kZXggYjkxYzJjN2VmNWE2Li4zZmNiOWRkMTliMDcg MTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfcmluZ2J1ZmZlci5oCj4g KysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfcmluZ2J1ZmZlci5oCj4gQEAgLTI0Miw3 ICsyNDIsNyBAQCBzdHJ1Y3QgaW50ZWxfZW5naW5lX2NzIHsKPiAgCQlzdHJ1Y3QgcmJfcm9vdCBz aWduYWxzOyAvKiBzb3J0ZWQgYnkgcmV0aXJlbWVudCAqLwo+ICAJCXN0cnVjdCBpbnRlbF93YWl0 ICpmaXJzdF93YWl0OyAvKiBvbGRlc3Qgd2FpdGVyIGJ5IHJldGlyZW1lbnQgKi8KPiAgCQlzdHJ1 Y3QgdGFza19zdHJ1Y3QgKnNpZ25hbGVyOyAvKiB1c2VkIGZvciBmZW5jZSBzaWduYWxsaW5nICov Cj4gLQkJc3RydWN0IGRybV9pOTE1X2dlbV9yZXF1ZXN0ICpmaXJzdF9zaWduYWw7Cj4gKwkJc3Ry dWN0IGRybV9pOTE1X2dlbV9yZXF1ZXN0IF9fcmN1ICpmaXJzdF9zaWduYWw7Cj4gIAkJc3RydWN0 IHRpbWVyX2xpc3QgZmFrZV9pcnE7IC8qIHVzZWQgYWZ0ZXIgYSBtaXNzZWQgaW50ZXJydXB0ICov Cj4gIAkJc3RydWN0IHRpbWVyX2xpc3QgaGFuZ2NoZWNrOyAvKiBkZXRlY3QgbWlzc2VkIGludGVy cnVwdHMgKi8KPgo+CgpMb29rcyBPSy4KClJldmlld2VkLWJ5OiBUdnJ0a28gVXJzdWxpbiA8dHZy dGtvLnVyc3VsaW5AaW50ZWwuY29tPgoKUmVnYXJkcywKClR2cnRrbwpfX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0Cklu dGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5v cmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK