From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tvrtko Ursulin Subject: Re: [PATCH 2/6] drm/i915: Pack the partial view size and offset into a single u64 Date: Thu, 12 Jan 2017 07:24:02 +0000 Message-ID: References: <20170111215106.13482-1-chris@chris-wilson.co.uk> <20170111215106.13482-3-chris@chris-wilson.co.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by gabe.freedesktop.org (Postfix) with ESMTPS id 2C2BC6EBB3 for ; Thu, 12 Jan 2017 07:24:05 +0000 (UTC) In-Reply-To: <20170111215106.13482-3-chris@chris-wilson.co.uk> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org Ck9uIDExLzAxLzIwMTcgMjE6NTEsIENocmlzIFdpbHNvbiB3cm90ZToKPiBTaW5jZSB0aGUgcGFy dGlhbCBvZmZzZXQgbXVzdCBiZSBwYWdlIGFsaWduZWQsIHdlIGNhbiB1c2UgdGhvc2UgbG93IDEy Cj4gYml0cyB0byBlbmNvZGUgdGhlIHNpemUgb2YgdGhlIHBhcnRpYWwgdmlldyAod2hpY2ggdGhl biBjYW5ub3QgYmUgbGFyZ2VyCj4gdGhhbiA4TWlCIGluIHBhZ2VzKS4gQSByZXF1aXJlbWVudCBm b3IgYXZvaWRpbmcgdW51c2VkIGJpdHMgaW5zaWRlIHRoZQo+IHN0cnVjdCBpcyBpbXBvc2VkIGxh dGVyIGJ5IGF2b2lkaW5nIHRoZSBjbGVhciBvZiB0aGUgc3RydWN0IChvciBvZgo+IGNvcHlpbmcg YXJvdW5kIHN0YXRpYyBpbml0aWFsaXNlcnMpLiBUaGlzIGlzIGVhc2llciB0byBndWFyYW50ZWUg YnkKPiBtYW51YWwgcGFja2luZyBpbnRvIGEgc2luZ2xlIHU2NCAtIHRoZSBwcmVzZW5jZSBvZiB0 aGUgdTY0IGluc2lkZSBhCj4gc3RydWN0IGNhdXNlcyBnY2MgdG8gcGFkIHRoZSBzdHJ1Y3Qgb3V0 IHRvIGEgdTY0IGJvdW5kYXJ5LCBldmVuIGlmIHdlCj4gdXNlIHRoZSBfX3BhY2tlZCBhdHRyaWJ1 dGUuCgpIYXZlIHlvdSBtYXliZSB0cmllZCBiaXRmaWVsZHM/IEl0IHdvdWxkIGJlIG11Y2ggbW9y ZSByZWFkYWJsZSBpZiB0aGUgCmdlbmVyYXRlZCBjb2RlIGlzIHJvdWdobHkgdGhlIHNhbWUuLgoK UmVnYXJkcywKClR2cnRrbwoKPiBTaWduZWQtb2ZmLWJ5OiBDaHJpcyBXaWxzb24gPGNocmlzQGNo cmlzLXdpbHNvbi5jby51az4KPiAtLS0KPiAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9nZW0u YyAgICAgfCAxNCArKysrKysrKystLS0tLQo+ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2dl bV9ndHQuYyB8ICA2ICsrKy0tLQo+ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2dlbV9ndHQu aCB8IDI1ICsrKysrKysrKysrKysrKysrKysrKysrLS0KPiAgZHJpdmVycy9ncHUvZHJtL2k5MTUv aTkxNV92bWEuYyAgICAgfCAgOSArKysrLS0tLS0KPiAgNCBmaWxlcyBjaGFuZ2VkLCAzOSBpbnNl cnRpb25zKCspLCAxNSBkZWxldGlvbnMoLSkKPgo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9k cm0vaTkxNS9pOTE1X2dlbS5jIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9nZW0uYwo+IGlu ZGV4IDNiZjUxN2UyNDMwYS4uMzEwN2ZmZjk3MGZkIDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1 L2RybS9pOTE1L2k5MTVfZ2VtLmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2dl bS5jCj4gQEAgLTE2OTYsNiArMTY5Niw5IEBAIGk5MTVfZ2VtX21tYXBfaW9jdGwoc3RydWN0IGRy bV9kZXZpY2UgKmRldiwgdm9pZCAqZGF0YSwKPgo+ICBzdGF0aWMgdW5zaWduZWQgaW50IHRpbGVf cm93X3BhZ2VzKHN0cnVjdCBkcm1faTkxNV9nZW1fb2JqZWN0ICpvYmopCj4gIHsKPiArCUJVSUxE X0JVR19PTihpbG9nMihHRU43X0ZFTkNFX01BWF9QSVRDSF9WQUwqMTI4KjMyID4+IFBBR0VfU0hJ RlQpID4KPiArCQkgICAgIElOVEVMX1BBUlRJQUxfU0laRV9CSVRTKTsKPiArCj4gIAlyZXR1cm4g aTkxNV9nZW1fb2JqZWN0X2dldF90aWxlX3Jvd19zaXplKG9iaikgPj4gUEFHRV9TSElGVDsKPiAg fQo+Cj4gQEAgLTE3NjEsMTAgKzE3NjQsMTEgQEAgY29tcHV0ZV9wYXJ0aWFsX3ZpZXcoc3RydWN0 IGRybV9pOTE1X2dlbV9vYmplY3QgKm9iaiwKPgo+ICAJbWVtc2V0KCZ2aWV3LCAwLCBzaXplb2Yo dmlldykpOwo+ICAJdmlldy50eXBlID0gSTkxNV9HR1RUX1ZJRVdfUEFSVElBTDsKPiAtCXZpZXcu cGFyYW1zLnBhcnRpYWwub2Zmc2V0ID0gcm91bmRkb3duKHBhZ2Vfb2Zmc2V0LCBjaHVuayk7Cj4g LQl2aWV3LnBhcmFtcy5wYXJ0aWFsLnNpemUgPQo+IC0JCW1pbl90KHVuc2lnbmVkIGludCwgY2h1 bmssCj4gLQkJICAgICAgKG9iai0+YmFzZS5zaXplID4+IFBBR0VfU0hJRlQpIC0gdmlldy5wYXJh bXMucGFydGlhbC5vZmZzZXQpOwo+ICsJdmlldy5wYXJhbXMucGFydGlhbC5vZmZzZXRfc2l6ZSA9 IHJvdW5kZG93bihwYWdlX29mZnNldCwgY2h1bmspOwo+ICsJdmlldy5wYXJhbXMucGFydGlhbC5v ZmZzZXRfc2l6ZSA9Cj4gKwkJKHZpZXcucGFyYW1zLnBhcnRpYWwub2Zmc2V0X3NpemUgPDwgSU5U RUxfUEFSVElBTF9TSVpFX0JJVFMpIHwKPiArCQkobWluX3QodW5zaWduZWQgaW50LCBjaHVuaywK PiArCQkgICAgICAgKG9iai0+YmFzZS5zaXplID4+IFBBR0VfU0hJRlQpIC0gdmlldy5wYXJhbXMu cGFydGlhbC5vZmZzZXRfc2l6ZSkgLSAxKTsKPgo+ICAJLyogSWYgdGhlIHBhcnRpYWwgY292ZXJz IHRoZSBlbnRpcmUgb2JqZWN0LCBqdXN0IGNyZWF0ZSBhIG5vcm1hbCBWTUEuICovCj4gIAlpZiAo Y2h1bmsgPj0gb2JqLT5iYXNlLnNpemUgPj4gUEFHRV9TSElGVCkKPiBAQCAtMTg4MCw3ICsxODg0 LDcgQEAgaW50IGk5MTVfZ2VtX2ZhdWx0KHN0cnVjdCB2bV9hcmVhX3N0cnVjdCAqYXJlYSwgc3Ry dWN0IHZtX2ZhdWx0ICp2bWYpCj4KPiAgCS8qIEZpbmFsbHksIHJlbWFwIGl0IHVzaW5nIHRoZSBu ZXcgR1RUIG9mZnNldCAqLwo+ICAJcmV0ID0gcmVtYXBfaW9fbWFwcGluZyhhcmVhLAo+IC0JCQkg ICAgICAgYXJlYS0+dm1fc3RhcnQgKyAodm1hLT5nZ3R0X3ZpZXcucGFyYW1zLnBhcnRpYWwub2Zm c2V0IDw8IFBBR0VfU0hJRlQpLAo+ICsJCQkgICAgICAgYXJlYS0+dm1fc3RhcnQgKyBpbnRlbF9w YXJ0aWFsX2dldF9vZmZzZXQoJnZtYS0+Z2d0dF92aWV3LnBhcmFtcy5wYXJ0aWFsKSwKPiAgCQkJ ICAgICAgIChnZ3R0LT5tYXBwYWJsZV9iYXNlICsgdm1hLT5ub2RlLnN0YXJ0KSA+PiBQQUdFX1NI SUZULAo+ICAJCQkgICAgICAgbWluX3QodTY0LCB2bWEtPnNpemUsIGFyZWEtPnZtX2VuZCAtIGFy ZWEtPnZtX3N0YXJ0KSwKPiAgCQkJICAgICAgICZnZ3R0LT5tYXBwYWJsZSk7Cj4gZGlmZiAtLWdp dCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZ2VtX2d0dC5jIGIvZHJpdmVycy9ncHUvZHJt L2k5MTUvaTkxNV9nZW1fZ3R0LmMKPiBpbmRleCBlZDEyMGExZTdmOTMuLmMzNmMxOTY1NDZmOCAx MDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2dlbV9ndHQuYwo+ICsrKyBi L2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZ2VtX2d0dC5jCj4gQEAgLTM0OTAsMjAgKzM0OTAs MjAgQEAgaW50ZWxfcGFydGlhbF9wYWdlcyhjb25zdCBzdHJ1Y3QgaTkxNV9nZ3R0X3ZpZXcgKnZp ZXcsCj4gIHsKPiAgCXN0cnVjdCBzZ190YWJsZSAqc3Q7Cj4gIAlzdHJ1Y3Qgc2NhdHRlcmxpc3Qg KnNnLCAqaXRlcjsKPiAtCXVuc2lnbmVkIGludCBjb3VudCA9IHZpZXctPnBhcmFtcy5wYXJ0aWFs LnNpemU7Cj4gLQl1bnNpZ25lZCBpbnQgb2Zmc2V0Owo+ICsJdW5zaWduZWQgaW50IGNvdW50LCBv ZmZzZXQ7Cj4gIAlpbnQgcmV0ID0gLUVOT01FTTsKPgo+ICAJc3QgPSBrbWFsbG9jKHNpemVvZigq c3QpLCBHRlBfS0VSTkVMKTsKPiAgCWlmICghc3QpCj4gIAkJZ290byBlcnJfc3RfYWxsb2M7Cj4K PiArCWNvdW50ID0gaW50ZWxfcGFydGlhbF9nZXRfcGFnZV9jb3VudCgmdmlldy0+cGFyYW1zLnBh cnRpYWwpOwo+ICAJcmV0ID0gc2dfYWxsb2NfdGFibGUoc3QsIGNvdW50LCBHRlBfS0VSTkVMKTsK PiAgCWlmIChyZXQpCj4gIAkJZ290byBlcnJfc2dfYWxsb2M7Cj4KPiAgCWl0ZXIgPSBpOTE1X2dl bV9vYmplY3RfZ2V0X3NnKG9iaiwKPiAtCQkJCSAgICAgIHZpZXctPnBhcmFtcy5wYXJ0aWFsLm9m ZnNldCwKPiArCQkJCSAgICAgIGludGVsX3BhcnRpYWxfZ2V0X3BhZ2Vfb2Zmc2V0KCZ2aWV3LT5w YXJhbXMucGFydGlhbCksCj4gIAkJCQkgICAgICAmb2Zmc2V0KTsKPiAgCUdFTV9CVUdfT04oIWl0 ZXIpOwo+Cj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZ2VtX2d0dC5o IGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9nZW1fZ3R0LmgKPiBpbmRleCA1ZGQzNzU1YTVh NDUuLjMxODdhMjYwZTZlMSAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1 X2dlbV9ndHQuaAo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZ2VtX2d0dC5oCj4g QEAgLTE1OSwxMCArMTU5LDMxIEBAIHN0cnVjdCBpbnRlbF9yb3RhdGlvbl9pbmZvIHsKPiAgfTsK Pgo+ICBzdHJ1Y3QgaW50ZWxfcGFydGlhbF9pbmZvIHsKPiAtCXU2NCBvZmZzZXQ7Cj4gLQl1bnNp Z25lZCBpbnQgc2l6ZTsKPiArCS8qIG9mZnNldCBpcyBwYWdlLWFsaWduZWQsIGxlYXZpbmcganVz dCBlbm91Z2ggYml0cyBmb3IgdGhlIHNpemUgKi8KPiArI2RlZmluZSBJTlRFTF9QQVJUSUFMX1NJ WkVfQklUUyBQQUdFX1NISUZUCj4gKwl1NjQgb2Zmc2V0X3NpemU7Cj4gIH07Cj4KPiArc3RhdGlj IGlubGluZSB1MzIgaW50ZWxfcGFydGlhbF9nZXRfcGFnZV9jb3VudChjb25zdCBzdHJ1Y3QgaW50 ZWxfcGFydGlhbF9pbmZvICpwaSkKPiArewo+ICsJcmV0dXJuIDEgKyAocGktPm9mZnNldF9zaXpl ICYgR0VOTUFTSyhJTlRFTF9QQVJUSUFMX1NJWkVfQklUUy0xLCAwKSk7Cj4gK30KPiArCj4gK3N0 YXRpYyBpbmxpbmUgdTMyIGludGVsX3BhcnRpYWxfZ2V0X3NpemUoY29uc3Qgc3RydWN0IGludGVs X3BhcnRpYWxfaW5mbyAqcGkpCj4gK3sKPiArCXJldHVybiBpbnRlbF9wYXJ0aWFsX2dldF9wYWdl X2NvdW50KHBpKSA8PCBQQUdFX1NISUZUOwo+ICt9Cj4gKwo+ICtzdGF0aWMgaW5saW5lIHU2NCBp bnRlbF9wYXJ0aWFsX2dldF9vZmZzZXQoY29uc3Qgc3RydWN0IGludGVsX3BhcnRpYWxfaW5mbyAq cGkpCj4gK3sKPiArCXJldHVybiBwaS0+b2Zmc2V0X3NpemUgJiBHRU5NQVNLKDYzLCBJTlRFTF9Q QVJUSUFMX1NJWkVfQklUUyk7Cj4gK30KPiArCj4gK3N0YXRpYyBpbmxpbmUgdTY0IGludGVsX3Bh cnRpYWxfZ2V0X3BhZ2Vfb2Zmc2V0KGNvbnN0IHN0cnVjdCBpbnRlbF9wYXJ0aWFsX2luZm8gKnBp KQo+ICt7Cj4gKwlyZXR1cm4gcGktPm9mZnNldF9zaXplID4+IElOVEVMX1BBUlRJQUxfU0laRV9C SVRTOwo+ICt9Cj4gKwo+ICBzdHJ1Y3QgaTkxNV9nZ3R0X3ZpZXcgewo+ICAJZW51bSBpOTE1X2dn dHRfdmlld190eXBlIHR5cGU7Cj4KPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUv aTkxNV92bWEuYyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfdm1hLmMKPiBpbmRleCBiNzRl ZWI3M2FlNDEuLjcyMjZjNWVmNTQxMCAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkx NS9pOTE1X3ZtYS5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV92bWEuYwo+IEBA IC05NywxMSArOTcsMTAgQEAgX19pOTE1X3ZtYV9jcmVhdGUoc3RydWN0IGRybV9pOTE1X2dlbV9v YmplY3QgKm9iaiwKPiAgCQl2bWEtPmdndHRfdmlldyA9ICp2aWV3Owo+ICAJCWlmICh2aWV3LT50 eXBlID09IEk5MTVfR0dUVF9WSUVXX1BBUlRJQUwpIHsKPiAgCQkJR0VNX0JVR19PTihyYW5nZV9v dmVyZmxvd3NfdCh1NjQsCj4gLQkJCQkJCSAgICAgdmlldy0+cGFyYW1zLnBhcnRpYWwub2Zmc2V0 LAo+IC0JCQkJCQkgICAgIHZpZXctPnBhcmFtcy5wYXJ0aWFsLnNpemUsCj4gLQkJCQkJCSAgICAg b2JqLT5iYXNlLnNpemUgPj4gUEFHRV9TSElGVCkpOwo+IC0JCQl2bWEtPnNpemUgPSB2aWV3LT5w YXJhbXMucGFydGlhbC5zaXplOwo+IC0JCQl2bWEtPnNpemUgPDw9IFBBR0VfU0hJRlQ7Cj4gKwkJ CQkJCSAgICAgaW50ZWxfcGFydGlhbF9nZXRfb2Zmc2V0KCZ2aWV3LT5wYXJhbXMucGFydGlhbCks Cj4gKwkJCQkJCSAgICAgaW50ZWxfcGFydGlhbF9nZXRfc2l6ZSgmdmlldy0+cGFyYW1zLnBhcnRp YWwpLAo+ICsJCQkJCQkgICAgIG9iai0+YmFzZS5zaXplKSk7Cj4gKwkJCXZtYS0+c2l6ZSA9IGlu dGVsX3BhcnRpYWxfZ2V0X3NpemUoJnZpZXctPnBhcmFtcy5wYXJ0aWFsKTsKPiAgCQkJR0VNX0JV R19PTih2bWEtPnNpemUgPj0gb2JqLT5iYXNlLnNpemUpOwo+ICAJCX0gZWxzZSBpZiAodmlldy0+ dHlwZSA9PSBJOTE1X0dHVFRfVklFV19ST1RBVEVEKSB7Cj4gIAkJCXZtYS0+c2l6ZSA9Cj4KX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4IG1h aWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMu ZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cg==