From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tvrtko Ursulin Subject: Re: [PATCH v2] drm/i915: Track the last-active inside the i915_vma Date: Thu, 5 Jul 2018 12:38:46 +0100 Message-ID: References: <20180629225419.5832-6-chris@chris-wilson.co.uk> <20180704083422.25572-1-chris@chris-wilson.co.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by gabe.freedesktop.org (Postfix) with ESMTPS id B66616ED07 for ; Thu, 5 Jul 2018 11:38:49 +0000 (UTC) In-Reply-To: <20180704083422.25572-1-chris@chris-wilson.co.uk> Content-Language: en-GB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org Ck9uIDA0LzA3LzIwMTggMDk6MzQsIENocmlzIFdpbHNvbiB3cm90ZToKPiBVc2luZyBhIFZNQSBv biBtb3JlIHRoYW4gb25lIHRpbWVsaW5lIGNvbmN1cnJlbnRseSBpcyB0aGUgZXhjZXB0aW9uCj4g cmF0aGVyIHRoYW4gdGhlIHJ1bGUgKHVzaW5nIGl0IGNvbmN1cnJlbnRseSBvbiBtdWx0aXBsZSBl bmdpbmVzKS4gQXMgd2UKPiBleHBlY3QgdG8gb25seSB1c2Ugb25lIGFjdGl2ZSB0cmFja2VyLCBz dG9yZSB0aGUgbW9zdCByZWNlbnRseSB1c2VkCj4gdHJhY2tlciBpbnNpZGUgdGhlIGk5MTVfdm1h IGl0c2VsZiBhbmQgb25seSBmYWxsYmFjayB0byB0aGUgcmJ0cmVlIGlmCj4gd2UgbmVlZCBhIHNl Y29uZCBvciBtb3JlIGNvbmN1cnJlbnQgYWN0aXZlIHRyYWNrZXJzLgo+IAo+IHYyOiBDb21tZW50 cyBvbiBob3cgd2Ugb3ZlcndyaXRlIGFueSBleGlzdGluZyBsYXN0X2FjdGl2ZSBjYWNoZS4KPiAK PiBTaWduZWQtb2ZmLWJ5OiBDaHJpcyBXaWxzb24gPGNocmlzQGNocmlzLXdpbHNvbi5jby51az4K PiBDYzogVHZydGtvIFVyc3VsaW4gPHR2cnRrby51cnN1bGluQGludGVsLmNvbT4KPiAtLS0KPiAg IGRyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfdm1hLmMgfCA1MCArKysrKysrKysrKysrKysrKysr KysrKysrKysrKysrLS0KPiAgIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfdm1hLmggfCAgMSAr Cj4gICAyIGZpbGVzIGNoYW5nZWQsIDQ5IGluc2VydGlvbnMoKyksIDIgZGVsZXRpb25zKC0pCj4g Cj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfdm1hLmMgYi9kcml2ZXJz L2dwdS9kcm0vaTkxNS9pOTE1X3ZtYS5jCj4gaW5kZXggY2Q5NGZmYzdmMDc5Li4zMzkyNWUwMGY3 ZTggMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV92bWEuYwo+ICsrKyBi L2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfdm1hLmMKPiBAQCAtMTE5LDYgKzExOSwxMiBAQCBp OTE1X3ZtYV9yZXRpcmUoc3RydWN0IGk5MTVfZ2VtX2FjdGl2ZSAqYmFzZSwgc3RydWN0IGk5MTVf cmVxdWVzdCAqcnEpCj4gICAJX19pOTE1X3ZtYV9yZXRpcmUoYWN0aXZlLT52bWEsIHJxKTsKPiAg IH0KPiAgIAo+ICtzdGF0aWMgdm9pZAo+ICtpOTE1X3ZtYV9sYXN0X3JldGlyZShzdHJ1Y3QgaTkx NV9nZW1fYWN0aXZlICpiYXNlLCBzdHJ1Y3QgaTkxNV9yZXF1ZXN0ICpycSkKPiArewo+ICsJX19p OTE1X3ZtYV9yZXRpcmUoY29udGFpbmVyX29mKGJhc2UsIHN0cnVjdCBpOTE1X3ZtYSwgbGFzdF9h Y3RpdmUpLCBycSk7Cj4gK30KPiArCj4gICBzdGF0aWMgc3RydWN0IGk5MTVfdm1hICoKPiAgIHZt YV9jcmVhdGUoc3RydWN0IGRybV9pOTE1X2dlbV9vYmplY3QgKm9iaiwKPiAgIAkgICBzdHJ1Y3Qg aTkxNV9hZGRyZXNzX3NwYWNlICp2bSwKPiBAQCAtMTM2LDYgKzE0Miw3IEBAIHZtYV9jcmVhdGUo c3RydWN0IGRybV9pOTE1X2dlbV9vYmplY3QgKm9iaiwKPiAgIAo+ICAgCXZtYS0+YWN0aXZlID0g UkJfUk9PVDsKPiAgIAo+ICsJaW5pdF9yZXF1ZXN0X2FjdGl2ZSgmdm1hLT5sYXN0X2FjdGl2ZSwg aTkxNV92bWFfbGFzdF9yZXRpcmUpOwo+ICAgCWluaXRfcmVxdWVzdF9hY3RpdmUoJnZtYS0+bGFz dF9mZW5jZSwgTlVMTCk7Cj4gICAJdm1hLT52bSA9IHZtOwo+ICAgCXZtYS0+b3BzID0gJnZtLT52 bWFfb3BzOwo+IEBAIC04OTUsNiArOTAyLDIyIEBAIHN0YXRpYyBzdHJ1Y3QgaTkxNV9nZW1fYWN0 aXZlICpsb29rdXBfYWN0aXZlKHN0cnVjdCBpOTE1X3ZtYSAqdm1hLCB1NjQgaWR4KQo+ICAgewo+ ICAgCXN0cnVjdCBpOTE1X3ZtYV9hY3RpdmUgKmFjdGl2ZTsKPiAgIAlzdHJ1Y3QgcmJfbm9kZSAq KnAsICpwYXJlbnQ7Cj4gKwlzdHJ1Y3QgaTkxNV9yZXF1ZXN0ICpvbGQ7Cj4gKwo+ICsJLyoKPiAr CSAqIFdlIHRyYWNrIHRoZSBtb3N0IHJlY2VudGx5IHVzZWQgdGltZWxpbmUgdG8gc2tpcCBhIHJi dHJlZSBzZWFyY2gKPiArCSAqIGZvciB0aGUgY29tbW9uIGNhc2UsIHVuZGVyIHR5cGljYWwgbG9h ZHMgd2UgbmV2ZXIgbmVlZCB0aGUgcmJ0cmVlCj4gKwkgKiBhdCBhbGwuIFdlIGNhbiByZXVzZSB0 aGUgbGFzdF9hY3RpdmUgc2xvdCBpZiBpdCBpcyBlbXB0eSwgdGhhdCBpcwo+ICsJICogYWZ0ZXIg dGhlIHByZXZpb3VzIGFjdGl2aXR5IGhhcyBiZWVuIHJldGlyZWQsIG9yIGlmIHRoZSBhY3RpdmUK PiArCSAqIG1hdGNoZXMgdGhlIGN1cnJlbnQgdGltZWxpbmUuCj4gKwkgKi8KPiArCW9sZCA9IGk5 MTVfZ2VtX2FjdGl2ZV9yYXcoJnZtYS0+bGFzdF9hY3RpdmUsCj4gKwkJCQkgICZ2bWEtPnZtLT5p OTE1LT5kcm0uc3RydWN0X211dGV4KTsKPiArCWlmICghb2xkIHx8IG9sZC0+ZmVuY2UuY29udGV4 dCA9PSBpZHgpCj4gKwkJZ290byBvdXQ7CgpJcyB0aGUgc2l0dWF0aW9uIHRoYXQgcmV0aXJlIGNh biBiZSBvdXQgb2Ygb3JkZXIgcmVsYXRpdmUgdG8gCm1vdmVfdG9fYWN0aXZlPyBJbiBvdGhlciB3 b3JkcywgbGFzdF9hY3RpdmUgY2FuIHJldGlyZSBiZWZvcmUgdGhlIHJidHJlZSAKcmVjb3JkLCBh bmQgc28gdGhlIGZvbGxvd2luZyBuZXcgbW92ZV90b19hY3RpdmUgd2lsbCBmaW5kIGxhc3RfYWN0 aXZlIAplbXB0eSBhbmQgc28gY291bGQgY3JlYXRlIGEgZG91YmxlIGVudHJ5IGZvciB0aGUgc2Ft ZSB0aW1lbGluZT8KCkF2b2lkaW5nIHRoYXQgd291bGQgZGVmZWF0IHRoZSBjYWNoaW5nLCB1bmxl c3Mgd2hlbiBsYXN0X2FjdGl2ZSBpcyAKYXZhaWxhYmxlIHdlIGFsc28gY2hlY2sgdGhlIHRyZWUs ICppZiogdGhlIHZtYS0+YWN0aXZlX2NvdW50ID4gMD8KClRoYXQgd2F5IHdlIGF2b2lkIGNyZWF0 aW5nIGR1cGxpY2F0ZSBlbnRyaWVzLgoKQnV0IHdvdWxkIHN0aWxsIG5lZWQgdG8gcHVsbCBvdXQg dGhpcyB0cmVlIGVudHJ5IGludG8gbGFzdF9hY3RpdmUgYWZ0ZXIgCnRoZSBmYWN0LgoKUmVnYXJk cywKClR2cnRrbwoKPiArCj4gKwkvKiBNb3ZlIHRoZSBjdXJyZW50bHkgYWN0aXZlIGZlbmNlIGlu dG8gdGhlIHJidHJlZSAqLwo+ICsJaWR4ID0gb2xkLT5mZW5jZS5jb250ZXh0Owo+ICAgCj4gICAJ cGFyZW50ID0gTlVMTDsKPiAgIAlwID0gJnZtYS0+YWN0aXZlLnJiX25vZGU7Cj4gQEAgLTkwMyw3 ICs5MjYsNyBAQCBzdGF0aWMgc3RydWN0IGk5MTVfZ2VtX2FjdGl2ZSAqbG9va3VwX2FjdGl2ZShz dHJ1Y3QgaTkxNV92bWEgKnZtYSwgdTY0IGlkeCkKPiAgIAo+ICAgCQlhY3RpdmUgPSByYl9lbnRy eShwYXJlbnQsIHN0cnVjdCBpOTE1X3ZtYV9hY3RpdmUsIG5vZGUpOwo+ICAgCQlpZiAoYWN0aXZl LT50aW1lbGluZSA9PSBpZHgpCj4gLQkJCXJldHVybiAmYWN0aXZlLT5iYXNlOwo+ICsJCQlnb3Rv IHJlcGxhY2U7Cj4gICAKPiAgIAkJaWYgKGFjdGl2ZS0+dGltZWxpbmUgPCBpZHgpCj4gICAJCQlw ID0gJnBhcmVudC0+cmJfcmlnaHQ7Cj4gQEAgLTkyMiw3ICs5NDUsMjUgQEAgc3RhdGljIHN0cnVj dCBpOTE1X2dlbV9hY3RpdmUgKmxvb2t1cF9hY3RpdmUoc3RydWN0IGk5MTVfdm1hICp2bWEsIHU2 NCBpZHgpCj4gICAJcmJfbGlua19ub2RlKCZhY3RpdmUtPm5vZGUsIHBhcmVudCwgcCk7Cj4gICAJ cmJfaW5zZXJ0X2NvbG9yKCZhY3RpdmUtPm5vZGUsICZ2bWEtPmFjdGl2ZSk7Cj4gICAKPiAtCXJl dHVybiAmYWN0aXZlLT5iYXNlOwo+ICtyZXBsYWNlOgo+ICsJLyoKPiArCSAqIE92ZXJ3cml0ZSB0 aGUgcHJldmlvdXMgYWN0aXZlIHNsb3QgaW4gdGhlIHJidHJlZSB3aXRoIGxhc3RfYWN0aXZlLAo+ ICsJICogbGVhdmluZyBsYXN0X2FjdGl2ZSB6ZXJvZWQuIElmIHRoZSBwcmV2aW91cyBzbG90IGlz IHN0aWxsIGFjdGl2ZSwKPiArCSAqIHdlIG11c3QgYmUgY2FyZWZ1bCBhcyB3ZSBub3cgb25seSBl eHBlY3QgdG8gcmVjaWV2ZSBvbmUgcmV0aXJlCj4gKwkgKiBjYWxsYmFjayBub3QgdHdvLCBhbmQg c28gbXVjaCB1bmRvIHRoZSBhY3RpdmUgY291bnRpbmcgZm9yIHRoZQo+ICsJICogb3ZlcndyaXR0 ZW4gc2xvdC4KPiArCSAqLwo+ICsJaWYgKGk5MTVfZ2VtX2FjdGl2ZV9pc3NldCgmYWN0aXZlLT5i YXNlKSkgewo+ICsJCV9fbGlzdF9kZWxfZW50cnkoJmFjdGl2ZS0+YmFzZS5saW5rKTsKPiArCQl2 bWEtPmFjdGl2ZV9jb3VudC0tOwo+ICsJCUdFTV9CVUdfT04oIXZtYS0+YWN0aXZlX2NvdW50KTsK PiArCX0KPiArCUdFTV9CVUdfT04obGlzdF9lbXB0eSgmdm1hLT5sYXN0X2FjdGl2ZS5saW5rKSk7 Cj4gKwlsaXN0X3JlcGxhY2VfaW5pdCgmdm1hLT5sYXN0X2FjdGl2ZS5saW5rLCAmYWN0aXZlLT5i YXNlLmxpbmspOwo+ICsJYWN0aXZlLT5iYXNlLnJlcXVlc3QgPSBmZXRjaF9hbmRfemVybygmdm1h LT5sYXN0X2FjdGl2ZS5yZXF1ZXN0KTsKPiArCj4gK291dDoKPiArCXJldHVybiAmdm1hLT5sYXN0 X2FjdGl2ZTsKPiAgIH0KPiAgIAo+ICAgaW50IGk5MTVfdm1hX21vdmVfdG9fYWN0aXZlKHN0cnVj dCBpOTE1X3ZtYSAqdm1hLAo+IEBAIC0xMDAyLDYgKzEwNDMsMTEgQEAgaW50IGk5MTVfdm1hX3Vu YmluZChzdHJ1Y3QgaTkxNV92bWEgKnZtYSkKPiAgIAkJICovCj4gICAJCV9faTkxNV92bWFfcGlu KHZtYSk7Cj4gICAKPiArCQlyZXQgPSBpOTE1X2dlbV9hY3RpdmVfcmV0aXJlKCZ2bWEtPmxhc3Rf YWN0aXZlLAo+ICsJCQkJCSAgICAgJnZtYS0+dm0tPmk5MTUtPmRybS5zdHJ1Y3RfbXV0ZXgpOwo+ ICsJCWlmIChyZXQpCj4gKwkJCWdvdG8gdW5waW47Cj4gKwo+ICAgCQlyYnRyZWVfcG9zdG9yZGVy X2Zvcl9lYWNoX2VudHJ5X3NhZmUoYWN0aXZlLCBuLAo+ICAgCQkJCQkJICAgICAmdm1hLT5hY3Rp dmUsIG5vZGUpIHsKPiAgIAkJCXJldCA9IGk5MTVfZ2VtX2FjdGl2ZV9yZXRpcmUoJmFjdGl2ZS0+ YmFzZSwKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV92bWEuaCBiL2Ry aXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfdm1hLmgKPiBpbmRleCBjMjk3YjBhMGRjNDcuLmYwNmQ2 NjM3NzEwNyAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X3ZtYS5oCj4g KysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV92bWEuaAo+IEBAIC05Nyw2ICs5Nyw3IEBA IHN0cnVjdCBpOTE1X3ZtYSB7Cj4gICAKPiAgIAl1bnNpZ25lZCBpbnQgYWN0aXZlX2NvdW50Owo+ ICAgCXN0cnVjdCByYl9yb290IGFjdGl2ZTsKPiArCXN0cnVjdCBpOTE1X2dlbV9hY3RpdmUgbGFz dF9hY3RpdmU7Cj4gICAJc3RydWN0IGk5MTVfZ2VtX2FjdGl2ZSBsYXN0X2ZlbmNlOwo+ICAgCj4g ICAJLyoqCj4gCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f CkludGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpo dHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeAo=