From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tvrtko Ursulin Subject: Re: [PATCH 2/5] drm/i915: Only enqueue already completed requests Date: Mon, 23 Sep 2019 10:51:48 +0100 Message-ID: References: <20190921095542.23205-1-chris@chris-wilson.co.uk> <20190921095542.23205-2-chris@chris-wilson.co.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by gabe.freedesktop.org (Postfix) with ESMTPS id AABED6E81D for ; Mon, 23 Sep 2019 09:51:51 +0000 (UTC) In-Reply-To: <20190921095542.23205-2-chris@chris-wilson.co.uk> Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org Ck9uIDIxLzA5LzIwMTkgMTA6NTUsIENocmlzIFdpbHNvbiB3cm90ZToKPiBJZiB3ZSBhcmUgYXNr ZWQgdG8gc3VibWl0IGEgY29tcGxldGVkIHJlcXVlc3QsIGp1c3QgbW92ZSBpdCBvbnRvIHRoZQo+ IGFjdGl2ZS1saXN0IHdpdGhvdXQgbW9kaWZ5aW5nIGl0J3MgcGF5bG9hZC4gSWYgd2UgdHJ5IHRv IGVtaXQgdGhlCj4gbW9kaWZpZWQgcGF5bG9hZCBvZiBhIGNvbXBsZXRlZCByZXF1ZXN0LCB3ZSBy aXNrIHJhY2luZyB3aXRoIHRoZQo+IHJpbmctPmhlYWQgdXBkYXRlIGR1cmluZyByZXRpcmVtZW50 IHdoaWNoIG1heSBhZHZhbmNlIHRoZSBoZWFkIHBhc3Qgb3VyCj4gYnJlYWRjcnVtYiBhbmQgc28g d2UgZ2VuZXJhdGUgYSB3YXJuaW5nIGZvciB0aGUgZW1pc3Npb24gYmVpbmcgYmVoaW5kCj4gdGhl IFJJTkdfSEVBRC4KPiAKPiBTaWduZWQtb2ZmLWJ5OiBDaHJpcyBXaWxzb24gPGNocmlzQGNocmlz LXdpbHNvbi5jby51az4KPiAtLS0KPiAgIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2d0L2ludGVsX2xy Yy5jIHwgNDUgKysrKysrKysrKysrKy0tLS0tLS0tLS0tLS0tLS0KPiAgIGRyaXZlcnMvZ3B1L2Ry bS9pOTE1L2k5MTVfcmVxdWVzdC5jIHwgMjggKysrKysrKysrKy0tLS0tLS0tCj4gICBkcml2ZXJz L2dwdS9kcm0vaTkxNS9pOTE1X3JlcXVlc3QuaCB8ICAyICstCj4gICAzIGZpbGVzIGNoYW5nZWQs IDM3IGluc2VydGlvbnMoKyksIDM4IGRlbGV0aW9ucygtKQo+IAo+IGRpZmYgLS1naXQgYS9kcml2 ZXJzL2dwdS9kcm0vaTkxNS9ndC9pbnRlbF9scmMuYyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2d0 L2ludGVsX2xyYy5jCj4gaW5kZXggNTNlODIzZDM2YjI4Li41M2JjNDMwODc5M2MgMTAwNjQ0Cj4g LS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvZ3QvaW50ZWxfbHJjLmMKPiArKysgYi9kcml2ZXJz L2dwdS9kcm0vaTkxNS9ndC9pbnRlbF9scmMuYwo+IEBAIC04MDYsNiArODA2LDkgQEAgc3RhdGlj IGJvb2wgY2FuX21lcmdlX3JxKGNvbnN0IHN0cnVjdCBpOTE1X3JlcXVlc3QgKnByZXYsCj4gICAJ R0VNX0JVR19PTihwcmV2ID09IG5leHQpOwo+ICAgCUdFTV9CVUdfT04oIWFzc2VydF9wcmlvcml0 eV9xdWV1ZShwcmV2LCBuZXh0KSk7Cj4gICAKPiArCWlmIChpOTE1X3JlcXVlc3RfY29tcGxldGVk KG5leHQpKQo+ICsJCXJldHVybiB0cnVlOwo+ICsKClRoaXMgcmVhZHMgdmVyeSB1bi1pbnR1aXRp dmUuIFdoeSB3b3VsZCBpdCBhbHdheXMgYmUgb2theSB0byBtZXJnZSAKcG9zc2libHkgdW5yZWxh dGVkIHJlcXVlc3RzPyBGcm9tIHdoaWNoIGl0IGZvbGxvd3MgaXQgbXVzdCBiZSBhIGhhY2sgb2Yg CnNvbWUga2luZCAtIGZyb20gd2hpY2ggaXQgZm9sbG93cyBpdCBuZWVkcyBhIGNvbW1lbnQgdG8g ZXhwbGFpbiBpdC4KCj4gICAJaWYgKCFjYW5fbWVyZ2VfY3R4KHByZXYtPmh3X2NvbnRleHQsIG5l eHQtPmh3X2NvbnRleHQpKQo+ICAgCQlyZXR1cm4gZmFsc2U7Cj4gICAKPiBAQCAtMTE4OCwyMSAr MTE5MSw2IEBAIHN0YXRpYyB2b2lkIGV4ZWNsaXN0c19kZXF1ZXVlKHN0cnVjdCBpbnRlbF9lbmdp bmVfY3MgKmVuZ2luZSkKPiAgIAkJCQljb250aW51ZTsKPiAgIAkJCX0KPiAgIAo+IC0JCQlpZiAo aTkxNV9yZXF1ZXN0X2NvbXBsZXRlZChycSkpIHsKPiAtCQkJCXZlLT5yZXF1ZXN0ID0gTlVMTDsK PiAtCQkJCXZlLT5iYXNlLmV4ZWNsaXN0cy5xdWV1ZV9wcmlvcml0eV9oaW50ID0gSU5UX01JTjsK PiAtCQkJCXJiX2VyYXNlX2NhY2hlZChyYiwgJmV4ZWNsaXN0cy0+dmlydHVhbCk7Cj4gLQkJCQlS Ql9DTEVBUl9OT0RFKHJiKTsKPiAtCj4gLQkJCQlycS0+ZW5naW5lID0gZW5naW5lOwo+IC0JCQkJ X19pOTE1X3JlcXVlc3Rfc3VibWl0KHJxKTsKPiAtCj4gLQkJCQlzcGluX3VubG9jaygmdmUtPmJh c2UuYWN0aXZlLmxvY2spOwo+IC0KPiAtCQkJCXJiID0gcmJfZmlyc3RfY2FjaGVkKCZleGVjbGlz dHMtPnZpcnR1YWwpOwo+IC0JCQkJY29udGludWU7Cj4gLQkJCX0KPiAtCj4gICAJCQlpZiAobGFz dCAmJiAhY2FuX21lcmdlX3JxKGxhc3QsIHJxKSkgewo+ICAgCQkJCXNwaW5fdW5sb2NrKCZ2ZS0+ YmFzZS5hY3RpdmUubG9jayk7Cj4gICAJCQkJcmV0dXJuOyAvKiBsZWF2ZSB0aGlzIGZvciBhbm90 aGVyICovCj4gQEAgLTEyNTYsMTEgKzEyNDQsMTYgQEAgc3RhdGljIHZvaWQgZXhlY2xpc3RzX2Rl cXVldWUoc3RydWN0IGludGVsX2VuZ2luZV9jcyAqZW5naW5lKQo+ICAgCQkJCUdFTV9CVUdfT04o dmUtPnNpYmxpbmdzWzBdICE9IGVuZ2luZSk7Cj4gICAJCQl9Cj4gICAKPiAtCQkJX19pOTE1X3Jl cXVlc3Rfc3VibWl0KHJxKTsKPiAtCQkJaWYgKCFpOTE1X3JlcXVlc3RfY29tcGxldGVkKHJxKSkg ewo+ICsJCQlpZiAoX19pOTE1X3JlcXVlc3Rfc3VibWl0KHJxKSkgewo+ICAgCQkJCXN1Ym1pdCA9 IHRydWU7Cj4gICAJCQkJbGFzdCA9IHJxOwo+ICAgCQkJfQo+ICsKPiArCQkJaWYgKCFzdWJtaXQp IHsKPiArCQkJCXNwaW5fdW5sb2NrKCZ2ZS0+YmFzZS5hY3RpdmUubG9jayk7Cj4gKwkJCQlyYiA9 IHJiX2ZpcnN0X2NhY2hlZCgmZXhlY2xpc3RzLT52aXJ0dWFsKTsKPiArCQkJCWNvbnRpbnVlOwo+ ICsJCQl9CgpUaGlzIGJsb2NrIGFsc28gbmVlZHMgYSBjb21tZW50IEkgdGhpbmsuIEl0J3MgYWJv dXQgc2tpcHBpbmcgdW50aWwgZmlyc3QgCmluY29tcGxldGUgcmVxdWVzdCBpbiB0aGUgcXVldWU/ Cgo+ICAgCQl9Cj4gICAKPiAgIAkJc3Bpbl91bmxvY2soJnZlLT5iYXNlLmFjdGl2ZS5sb2NrKTsK PiBAQCAtMTI3Myw4ICsxMjY2LDcgQEAgc3RhdGljIHZvaWQgZXhlY2xpc3RzX2RlcXVldWUoc3Ry dWN0IGludGVsX2VuZ2luZV9jcyAqZW5naW5lKQo+ICAgCQlpbnQgaTsKPiAgIAo+ICAgCQlwcmlv bGlzdF9mb3JfZWFjaF9yZXF1ZXN0X2NvbnN1bWUocnEsIHJuLCBwLCBpKSB7Cj4gLQkJCWlmIChp OTE1X3JlcXVlc3RfY29tcGxldGVkKHJxKSkKPiAtCQkJCWdvdG8gc2tpcDsKPiArCQkJYm9vbCBt ZXJnZSA9IHRydWU7Cj4gICAKPiAgIAkJCS8qCj4gICAJCQkgKiBDYW4gd2UgY29tYmluZSB0aGlz IHJlcXVlc3Qgd2l0aCB0aGUgY3VycmVudCBwb3J0Pwo+IEBAIC0xMzE1LDE0ICsxMzA3LDE3IEBA IHN0YXRpYyB2b2lkIGV4ZWNsaXN0c19kZXF1ZXVlKHN0cnVjdCBpbnRlbF9lbmdpbmVfY3MgKmVu Z2luZSkKPiAgIAkJCQkgICAgY3R4X3NpbmdsZV9wb3J0X3N1Ym1pc3Npb24ocnEtPmh3X2NvbnRl eHQpKQo+ICAgCQkJCQlnb3RvIGRvbmU7Cj4gICAKPiAtCQkJCSpwb3J0ID0gZXhlY2xpc3RzX3Nj aGVkdWxlX2luKGxhc3QsIHBvcnQgLSBleGVjbGlzdHMtPnBlbmRpbmcpOwo+IC0JCQkJcG9ydCsr Owo+ICsJCQkJbWVyZ2UgPSBmYWxzZTsKPiAgIAkJCX0KPiAgIAo+IC0JCQlsYXN0ID0gcnE7Cj4g LQkJCXN1Ym1pdCA9IHRydWU7Cj4gLXNraXA6Cj4gLQkJCV9faTkxNV9yZXF1ZXN0X3N1Ym1pdChy cSk7Cj4gKwkJCWlmIChfX2k5MTVfcmVxdWVzdF9zdWJtaXQocnEpKSB7Cj4gKwkJCQlpZiAoIW1l cmdlKSB7Cj4gKwkJCQkJKnBvcnQgPSBleGVjbGlzdHNfc2NoZWR1bGVfaW4obGFzdCwgcG9ydCAt IGV4ZWNsaXN0cy0+cGVuZGluZyk7Cj4gKwkJCQkJcG9ydCsrOwo+ICsJCQkJfQo+ICsJCQkJc3Vi bWl0ID0gdHJ1ZTsKPiArCQkJCWxhc3QgPSBycTsKPiArCQkJfQo+ICAgCQl9Cj4gICAKPiAgIAkJ cmJfZXJhc2VfY2FjaGVkKCZwLT5ub2RlLCAmZXhlY2xpc3RzLT5xdWV1ZSk7Cj4gZGlmZiAtLWdp dCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfcmVxdWVzdC5jIGIvZHJpdmVycy9ncHUvZHJt L2k5MTUvaTkxNV9yZXF1ZXN0LmMKPiBpbmRleCA5YmQ4NTM4YjE5MDcuLmRiMWEwMDQ4YTc1MyAx MDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X3JlcXVlc3QuYwo+ICsrKyBi L2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfcmVxdWVzdC5jCj4gQEAgLTM3Nyw5ICszNzcsMTAg QEAgX19pOTE1X3JlcXVlc3RfYXdhaXRfZXhlY3V0aW9uKHN0cnVjdCBpOTE1X3JlcXVlc3QgKnJx LAo+ICAgCXJldHVybiAwOwo+ICAgfQo+ICAgCj4gLXZvaWQgX19pOTE1X3JlcXVlc3Rfc3VibWl0 KHN0cnVjdCBpOTE1X3JlcXVlc3QgKnJlcXVlc3QpCj4gK2Jvb2wgX19pOTE1X3JlcXVlc3Rfc3Vi bWl0KHN0cnVjdCBpOTE1X3JlcXVlc3QgKnJlcXVlc3QpCj4gICB7Cj4gICAJc3RydWN0IGludGVs X2VuZ2luZV9jcyAqZW5naW5lID0gcmVxdWVzdC0+ZW5naW5lOwo+ICsJYm9vbCByZXN1bHQgPSBm YWxzZTsKPiAgIAo+ICAgCUdFTV9UUkFDRSgiJXMgZmVuY2UgJWxseDolbGxkLCBjdXJyZW50ICVk XG4iLAo+ICAgCQkgIGVuZ2luZS0+bmFtZSwKPiBAQCAtMzg5LDYgKzM5MCw5IEBAIHZvaWQgX19p OTE1X3JlcXVlc3Rfc3VibWl0KHN0cnVjdCBpOTE1X3JlcXVlc3QgKnJlcXVlc3QpCj4gICAJR0VN X0JVR19PTighaXJxc19kaXNhYmxlZCgpKTsKPiAgIAlsb2NrZGVwX2Fzc2VydF9oZWxkKCZlbmdp bmUtPmFjdGl2ZS5sb2NrKTsKPiAgIAo+ICsJaWYgKGk5MTVfcmVxdWVzdF9jb21wbGV0ZWQocmVx dWVzdCkpCj4gKwkJZ290byB4ZmVyOwoKQSBjb21tZW50IGhlcmUgYXMgd2VsbCBJIHRoaW5rIHRv IGV4cGxhaW4gd2hhdCBoYXBwZW5zIG5leHQgd2l0aCAKY29tcGxldGVkIHJlcXVlc3RzIHB1dCBv biB0aGUgYWN0aXZlIGxpc3QuIFRoZXkganVzdCBnZXQgcmVtb3ZlZCBkdXJpbmcgCnJldGlyZT8g RG8gdGhleSBuZWVkIHRvIGV2ZW4gYmUgcHV0IG9uIHRoYXQgbGlzdD8KCj4gKwo+ICAgCWlmIChp OTE1X2dlbV9jb250ZXh0X2lzX2Jhbm5lZChyZXF1ZXN0LT5nZW1fY29udGV4dCkpCj4gICAJCWk5 MTVfcmVxdWVzdF9za2lwKHJlcXVlc3QsIC1FSU8pOwo+ICAgCj4gQEAgLTQxMiwxMyArNDE2LDE4 IEBAIHZvaWQgX19pOTE1X3JlcXVlc3Rfc3VibWl0KHN0cnVjdCBpOTE1X3JlcXVlc3QgKnJlcXVl c3QpCj4gICAJICAgIGk5MTVfc3dfZmVuY2Vfc2lnbmFsZWQoJnJlcXVlc3QtPnNlbWFwaG9yZSkp Cj4gICAJCWVuZ2luZS0+c2F0dXJhdGVkIHw9IHJlcXVlc3QtPnNjaGVkLnNlbWFwaG9yZXM7Cj4g ICAKPiAtCS8qIFdlIG1heSBiZSByZWN1cnNpbmcgZnJvbSB0aGUgc2lnbmFsIGNhbGxiYWNrIG9m IGFub3RoZXIgaTkxNSBmZW5jZSAqLwo+IC0Jc3Bpbl9sb2NrX25lc3RlZCgmcmVxdWVzdC0+bG9j aywgU0lOR0xFX0RFUFRIX05FU1RJTkcpOwo+ICsJZW5naW5lLT5lbWl0X2ZpbmlfYnJlYWRjcnVt YihyZXF1ZXN0LAo+ICsJCQkJICAgICByZXF1ZXN0LT5yaW5nLT52YWRkciArIHJlcXVlc3QtPnBv c3RmaXgpOwo+ICAgCj4gLQlsaXN0X21vdmVfdGFpbCgmcmVxdWVzdC0+c2NoZWQubGluaywgJmVu Z2luZS0+YWN0aXZlLnJlcXVlc3RzKTsKPiArCXRyYWNlX2k5MTVfcmVxdWVzdF9leGVjdXRlKHJl cXVlc3QpOwo+ICsJZW5naW5lLT5zZXJpYWwrKzsKPiArCXJlc3VsdCA9IHRydWU7Cj4gICAKPiAt CUdFTV9CVUdfT04odGVzdF9iaXQoSTkxNV9GRU5DRV9GTEFHX0FDVElWRSwgJnJlcXVlc3QtPmZl bmNlLmZsYWdzKSk7Cj4gLQlzZXRfYml0KEk5MTVfRkVOQ0VfRkxBR19BQ1RJVkUsICZyZXF1ZXN0 LT5mZW5jZS5mbGFncyk7Cj4gK3hmZXI6CS8qIFdlIG1heSBiZSByZWN1cnNpbmcgZnJvbSB0aGUg c2lnbmFsIGNhbGxiYWNrIG9mIGFub3RoZXIgaTkxNSBmZW5jZSAqLwo+ICsJc3Bpbl9sb2NrX25l c3RlZCgmcmVxdWVzdC0+bG9jaywgU0lOR0xFX0RFUFRIX05FU1RJTkcpOwo+ICsKPiArCWlmICgh dGVzdF9hbmRfc2V0X2JpdChJOTE1X0ZFTkNFX0ZMQUdfQUNUSVZFLCAmcmVxdWVzdC0+ZmVuY2Uu ZmxhZ3MpKQo+ICsJCWxpc3RfbW92ZV90YWlsKCZyZXF1ZXN0LT5zY2hlZC5saW5rLCAmZW5naW5l LT5hY3RpdmUucmVxdWVzdHMpOwo+ICAgCj4gICAJaWYgKHRlc3RfYml0KERNQV9GRU5DRV9GTEFH X0VOQUJMRV9TSUdOQUxfQklULCAmcmVxdWVzdC0+ZmVuY2UuZmxhZ3MpICYmCj4gICAJICAgICF0 ZXN0X2JpdChETUFfRkVOQ0VfRkxBR19TSUdOQUxFRF9CSVQsICZyZXF1ZXN0LT5mZW5jZS5mbGFn cykgJiYKPiBAQCAtNDI5LDEyICs0MzgsNyBAQCB2b2lkIF9faTkxNV9yZXF1ZXN0X3N1Ym1pdChz dHJ1Y3QgaTkxNV9yZXF1ZXN0ICpyZXF1ZXN0KQo+ICAgCj4gICAJc3Bpbl91bmxvY2soJnJlcXVl c3QtPmxvY2spOwo+ICAgCj4gLQllbmdpbmUtPmVtaXRfZmluaV9icmVhZGNydW1iKHJlcXVlc3Qs Cj4gLQkJCQkgICAgIHJlcXVlc3QtPnJpbmctPnZhZGRyICsgcmVxdWVzdC0+cG9zdGZpeCk7Cj4g LQo+IC0JZW5naW5lLT5zZXJpYWwrKzsKPiAtCj4gLQl0cmFjZV9pOTE1X3JlcXVlc3RfZXhlY3V0 ZShyZXF1ZXN0KTsKPiArCXJldHVybiByZXN1bHQ7Cj4gICB9Cj4gICAKPiAgIHZvaWQgaTkxNV9y ZXF1ZXN0X3N1Ym1pdChzdHJ1Y3QgaTkxNV9yZXF1ZXN0ICpyZXF1ZXN0KQo+IGRpZmYgLS1naXQg YS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X3JlcXVlc3QuaCBiL2RyaXZlcnMvZ3B1L2RybS9p OTE1L2k5MTVfcmVxdWVzdC5oCj4gaW5kZXggYjE4ZjQ5NTI4ZGVkLi5lYzViYjRjMmU1YWUgMTAw NjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9yZXF1ZXN0LmgKPiArKysgYi9k cml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X3JlcXVlc3QuaAo+IEBAIC0yOTIsNyArMjkyLDcgQEAg aW50IGk5MTVfcmVxdWVzdF9hd2FpdF9leGVjdXRpb24oc3RydWN0IGk5MTVfcmVxdWVzdCAqcnEs Cj4gICAKPiAgIHZvaWQgaTkxNV9yZXF1ZXN0X2FkZChzdHJ1Y3QgaTkxNV9yZXF1ZXN0ICpycSk7 Cj4gICAKPiAtdm9pZCBfX2k5MTVfcmVxdWVzdF9zdWJtaXQoc3RydWN0IGk5MTVfcmVxdWVzdCAq cmVxdWVzdCk7Cj4gK2Jvb2wgX19pOTE1X3JlcXVlc3Rfc3VibWl0KHN0cnVjdCBpOTE1X3JlcXVl c3QgKnJlcXVlc3QpOwo+ICAgdm9pZCBpOTE1X3JlcXVlc3Rfc3VibWl0KHN0cnVjdCBpOTE1X3Jl cXVlc3QgKnJlcXVlc3QpOwo+ICAgCj4gICB2b2lkIGk5MTVfcmVxdWVzdF9za2lwKHN0cnVjdCBp OTE1X3JlcXVlc3QgKnJlcXVlc3QsIGludCBlcnJvcik7Cj4gCgpSZWdhcmRzLAoKVHZydGtvCl9f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCkludGVsLWdmeCBt YWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3Rz LmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeA==