Re: [PATCH 1/7] drm/i915: Modifying structures related to DRRS

Chris Wilson
2014-12-18T16:29:37Z

On Thu, Dec 18, 2014 at 09:02:15PM +0530, Vandana Kannan wrote:
> Earlier, DRRS structures were specific to eDP (used only in intel_dp).
> Since DRRS can be extended to other internal display types
> (if the panel supports multiple RR), modifying structures
> to be part of drm_i915_private and have a provision to add display related
> structs like intel_dp.

What's the justification for drm_i915_private though? Why not extend the
struct intel_panel? I think it is conceptually cleaner if PSR was part
of the common panel logic rather than bolted onto the side of
drm_i915_private - on such systems there is still likely to only be
struct intel_panel attached to the connectors on the system.
-Chris

--
Chris Wilson, Intel Open Source Technology Centre