Re: [PATCH 1/7] drm/i915: Modifying structures related to DRRS

Daniel Vetter
2014-12-18T20:13:22Z

On Thu, Dec 18, 2014 at 04:29:24PM +0000, Chris Wilson wrote:
> On Thu, Dec 18, 2014 at 09:02:15PM +0530, Vandana Kannan wrote:
> > Earlier, DRRS structures were specific to eDP (used only in intel_dp).
> > Since DRRS can be extended to other internal display types
> > (if the panel supports multiple RR), modifying structures
> > to be part of drm_i915_private and have a provision to add display related
> > structs like intel_dp.
>
> What's the justification for drm_i915_private though? Why not extend the
> struct intel_panel? I think it is conceptually cleaner if PSR was part
> of the common panel logic rather than bolted onto the side of
> drm_i915_private - on such systems there is still likely to only be
> struct intel_panel attached to the connectors on the system.

Looking up intel_panel from both gem and modeset contexts is painful, so
imo putting it into i915_private is the right approach. We use the same
design with psr and probably soonish with fbc (when it's using the
frontbuffer tracking code).
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch