From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tvrtko Ursulin Subject: Re: [RFC 24/28] drm/i915: Compartmentalize i915_ggtt_cleanup_hw Date: Fri, 14 Jun 2019 11:28:00 +0100 Message-ID: References: <20190613133539.12620-1-tvrtko.ursulin@linux.intel.com> <20190613151904.16256-1-tvrtko.ursulin@linux.intel.com> <156044020985.17012.4212039280122013336@skylake-alporthouse-com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by gabe.freedesktop.org (Postfix) with ESMTPS id 7D8CB892D4 for ; Fri, 14 Jun 2019 10:28:02 +0000 (UTC) In-Reply-To: <156044020985.17012.4212039280122013336@skylake-alporthouse-com> Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson , Intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org Ck9uIDEzLzA2LzIwMTkgMTY6MzYsIENocmlzIFdpbHNvbiB3cm90ZToKPiBRdW90aW5nIFR2cnRr byBVcnN1bGluICgyMDE5LTA2LTEzIDE2OjE5OjAwKQo+PiBGcm9tOiBUdnJ0a28gVXJzdWxpbiA8 dHZydGtvLnVyc3VsaW5AaW50ZWwuY29tPgo+Pgo+PiBDb250aW51aW5nIG9uIHRoZSB0aGVtZSBv ZiBiZXR0ZXIgbG9naWNhbCBvcmdhbml6YXRpb24gb2Ygb3VyIGNvZGUsIG1ha2UKPj4gdGhlIGZp cnN0IHN0ZXAgdG93YXJkcyBtYWtpbmcgdGhlIGdndHQgY29kZSBiZXR0ZXIgaXNvbGF0ZWQgZnJv bSB3aWRlcgo+PiBzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZS4KPj4KPj4gU2lnbmVkLW9mZi1ieTog VHZydGtvIFVyc3VsaW4gPHR2cnRrby51cnN1bGluQGludGVsLmNvbT4KPj4gLS0tCj4+ICAgZHJp dmVycy9ncHUvZHJtL2k5MTUvaTkxNV9nZW1fZ3R0LmMgfCA1NCArKysrKysrKysrKysrKysrKy0t LS0tLS0tLS0tLQo+PiAgIDEgZmlsZSBjaGFuZ2VkLCAzMSBpbnNlcnRpb25zKCspLCAyMyBkZWxl dGlvbnMoLSkKPj4KPj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZ2Vt X2d0dC5jIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9nZW1fZ3R0LmMKPj4gaW5kZXggZDA5 YTRkOWI3MWRhLi4yODVhN2EwMmMwMTUgMTAwNjQ0Cj4+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9p OTE1L2k5MTVfZ2VtX2d0dC5jCj4+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZ2Vt X2d0dC5jCj4+IEBAIC0yODMyLDYgKzI4MzIsOCBAQCBzdGF0aWMgdm9pZCBmaW5pX2FsaWFzaW5n X3BwZ3R0KHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICppOTE1KQo+PiAgICAgICAgICBzdHJ1Y3Qg aTkxNV9nZ3R0ICpnZ3R0ID0gJmk5MTUtPmdndHQ7Cj4+ICAgICAgICAgIHN0cnVjdCBpOTE1X3Bw Z3R0ICpwcGd0dDsKPj4gICAKPj4gKyAgICAgICBtdXRleF9sb2NrKCZpOTE1LT5kcm0uc3RydWN0 X211dGV4KTsKPiAKPiBEbyB3ZSBzdGlsbCBuZWVkIHRvIGFwcGVhc2UgbG9ja2RlcCBoZXJlPyBI b3BlZnVsbHkgbm90LgoKTWF5YmUgbm90IGluIHlvdXIgdHJlZSA6KSBidXQgaW4gZHJtLXRpcCBB RkFJQ1M6CgogICBmaW5pX2FsaWFzaW5nX3BwZ3R0CiAgICAgLT4gaTkxNV92bV9wdXQKICAgICAg IC0+IGk5MTVfdm1fcmVsZWFzZQogICAgICAgICAtPiBwcGd0dF9kZXN0cm95X3ZtYQogICAgICAg ICAgLT4gaTkxNV92bWFfZGVzdHJveQoKPj4gKwo+PiAgICAgICAgICBwcGd0dCA9IGZldGNoX2Fu ZF96ZXJvKCZpOTE1LT5tbS5hbGlhc2luZ19wcGd0dCk7Cj4+ICAgICAgICAgIGlmICghcHBndHQp Cj4+ICAgICAgICAgICAgICAgICAgcmV0dXJuOwo+PiBAQCAtMjg0MCw2ICsyODQyLDggQEAgc3Rh dGljIHZvaWQgZmluaV9hbGlhc2luZ19wcGd0dChzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqaTkx NSkKPj4gICAKPj4gICAgICAgICAgZ2d0dC0+dm0udm1hX29wcy5iaW5kX3ZtYSAgID0gZ2d0dF9i aW5kX3ZtYTsKPj4gICAgICAgICAgZ2d0dC0+dm0udm1hX29wcy51bmJpbmRfdm1hID0gZ2d0dF91 bmJpbmRfdm1hOwo+PiArCj4+ICsgICAgICAgbXV0ZXhfdW5sb2NrKCZpOTE1LT5kcm0uc3RydWN0 X211dGV4KTsKPj4gICB9Cj4+ICAgCj4+ICAgc3RhdGljIGludCBnZ3R0X3Jlc2VydmVfZ3VjX3Rv cChzdHJ1Y3QgaTkxNV9nZ3R0ICpnZ3R0KQo+PiBAQCAtMjk0MSwyMSArMjk0NSwxNSBAQCBpbnQg aTkxNV9nZW1faW5pdF9nZ3R0KHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdikKPj4g ICAgICAgICAgcmV0dXJuIHJldDsKPj4gICB9Cj4+ICAgCj4+IC0vKioKPj4gLSAqIGk5MTVfZ2d0 dF9jbGVhbnVwX2h3IC0gQ2xlYW4gdXAgR0dUVCBoYXJkd2FyZSBpbml0aWFsaXphdGlvbgo+PiAt ICogQGRldl9wcml2OiBpOTE1IGRldmljZQo+PiAtICovCj4+IC12b2lkIGk5MTVfZ2d0dF9jbGVh bnVwX2h3KHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdikKPj4gK3N0YXRpYyB2b2lk IGdndHRfY2xlYW51cF9odyhzdHJ1Y3QgaTkxNV9nZ3R0ICpnZ3R0KQo+PiAgIHsKPj4gLSAgICAg ICBzdHJ1Y3QgaTkxNV9nZ3R0ICpnZ3R0ID0gJmRldl9wcml2LT5nZ3R0Owo+PiAgICAgICAgICBz dHJ1Y3QgaTkxNV9hZGRyZXNzX3NwYWNlICp2bSA9ICZnZ3R0LT52bTsKPj4gKyAgICAgICBzdHJ1 Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqaTkxNSA9IHZtLT5pOTE1Owo+PiAgICAgICAgICBzdHJ1Y3Qg aTkxNV92bWEgKnZtYSwgKnZuOwo+PiAtICAgICAgIHN0cnVjdCBwYWdldmVjICpwdmVjOwo+PiAg IAo+PiAgICAgICAgICB2bS0+Y2xvc2VkID0gdHJ1ZTsKPj4gICAKPj4gLSAgICAgICBtdXRleF9s b2NrKCZkZXZfcHJpdi0+ZHJtLnN0cnVjdF9tdXRleCk7Cj4+IC0gICAgICAgZmluaV9hbGlhc2lu Z19wcGd0dChkZXZfcHJpdik7Cj4+ICsgICAgICAgbXV0ZXhfbG9jaygmaTkxNS0+ZHJtLnN0cnVj dF9tdXRleCk7Cj4gCj4gQXMgdGhlIGxvY2sgaGVyZSBpcyBqdXN0IGZvciB0aGUgaTkxNV92bWFf dW5iaW5kIGFuZCBub3QKPiBmaW5pX2FsaWFzaW5nX3BwZ3R0Lgo+IAo+PiAgICAgICAgICBsaXN0 X2Zvcl9lYWNoX2VudHJ5X3NhZmUodm1hLCB2biwgJnZtLT5ib3VuZF9saXN0LCB2bV9saW5rKQo+ PiAgICAgICAgICAgICAgICAgIFdBUk5fT04oaTkxNV92bWFfdW5iaW5kKHZtYSkpOwo+PiBAQCAt Mjk3MiwxOCArMjk3MCwzMyBAQCB2b2lkIGk5MTVfZ2d0dF9jbGVhbnVwX2h3KHN0cnVjdCBkcm1f aTkxNV9wcml2YXRlICpkZXZfcHJpdikKPj4gICAKPj4gICAgICAgICAgdm0tPmNsZWFudXAodm0p Owo+PiAgIAo+PiAtICAgICAgIHB2ZWMgPSAmZGV2X3ByaXYtPm1tLndjX3N0YXNoLnB2ZWM7Cj4+ ICsgICAgICAgbXV0ZXhfdW5sb2NrKCZpOTE1LT5kcm0uc3RydWN0X211dGV4KTsKPj4gKwo+PiAr ICAgICAgIGFyY2hfcGh5c193Y19kZWwoZ2d0dC0+bXRycik7Cj4+ICsgICAgICAgaW9fbWFwcGlu Z19maW5pKCZnZ3R0LT5pb21hcCk7Cj4+ICt9Cj4+ICsKPj4gKy8qKgo+PiArICogaTkxNV9nZ3R0 X2NsZWFudXBfaHcgLSBDbGVhbiB1cCBHR1RUIGhhcmR3YXJlIGluaXRpYWxpemF0aW9uCj4+ICsg KiBAZGV2X3ByaXY6IGk5MTUgZGV2aWNlCj4+ICsgKi8KPj4gK3ZvaWQgaTkxNV9nZ3R0X2NsZWFu dXBfaHcoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmk5MTUpCj4+ICt7Cj4+ICsgICAgICAgc3Ry dWN0IHBhZ2V2ZWMgKnB2ZWM7Cj4+ICsKPj4gKyAgICAgICBmaW5pX2FsaWFzaW5nX3BwZ3R0KGk5 MTUpOwo+PiArCj4+ICsgICAgICAgZ2d0dF9jbGVhbnVwX2h3KCZpOTE1LT5nZ3R0KTsKPj4gKwo+ PiArICAgICAgIG11dGV4X2xvY2soJmk5MTUtPmRybS5zdHJ1Y3RfbXV0ZXgpOwo+PiArICAgICAg IHB2ZWMgPSAmaTkxNS0+bW0ud2Nfc3Rhc2gucHZlYzsKPj4gICAgICAgICAgaWYgKHB2ZWMtPm5y KSB7Cj4+ICAgICAgICAgICAgICAgICAgc2V0X3BhZ2VzX2FycmF5X3diKHB2ZWMtPnBhZ2VzLCBw dmVjLT5ucik7Cj4+ICAgICAgICAgICAgICAgICAgX19wYWdldmVjX3JlbGVhc2UocHZlYyk7Cj4+ ICAgICAgICAgIH0KPj4gKyAgICAgICBtdXRleF91bmxvY2soJmk5MTUtPmRybS5zdHJ1Y3RfbXV0 ZXgpOwo+IAo+IFRoZSB3Y19zdGFzaCBkb2Vzbid0IHVzZSBzdHJ1Y3RfbXV0ZXgsIHNvIG5vIGxv Y2tkZXAgYXBwZWFzaW5nIHJlcXVpcmVkCj4gaGVyZS4KClRydWUsIHJlbW92ZWQuCgpSZWdhcmRz LAoKVHZydGtvCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f CkludGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpo dHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeA==