From: Michel Thierry <michel.thierry@intel.com>
To: "Chris Wilson" <chris@chris-wilson.co.uk>,
"Michał Winiarski" <michal.winiarski@intel.com>,
"intel-gfx@lists.freedesktop.org"
<intel-gfx@lists.freedesktop.org>
Subject: Re: [PATCH v6] drm/i915/guc: Add a second client, to be used for preemption
Date: Thu, 26 Oct 2017 13:15:27 -0700 [thread overview]
Message-ID: <f85748b4-36d8-9a1c-e8fe-e76eb68b6a00@intel.com> (raw)
In-Reply-To: <150904817177.2864.14324915995783096823@mail.alporthouse.com>
On 10/26/2017 1:02 PM, Chris Wilson wrote:
> Quoting Michel Thierry (2017-10-26 19:49:06)
>> On 26/10/17 07:17, Michał Winiarski wrote:
>>> @@ -763,14 +770,14 @@ static int guc_init_doorbell_hw(struct intel_guc *guc)
>>>
>>> /* Now for every client (and not only execbuf_client) make sure their
>>> * doorbells are known by the GuC */
>>> - //for (client = client_list; client != NULL; client = client->next)
>>> - {
>>> - ret = __create_doorbell(client);
>>> - if (ret) {
>>> - DRM_ERROR("Couldn't recreate client %u doorbell: %d\n",
>>> - client->stage_id, ret);
>>> - return ret;
>>> - }
>>> + ret = __create_doorbell(guc->execbuf_client);
>>> + if (ret)
>>> + return ret;
>>> +
>>> + ret = __create_doorbell(guc->preempt_client);
>>> + if (ret) {
>>> + __destroy_doorbell(guc->execbuf_client);
>>> + return ret;
>>> }
>>
>> I'm pretty sure there's an old client left behind after this, e.g.:
>>
>> static int guc_init_doorbell_hw(struct intel_guc *guc)
>> {
>> - struct i915_guc_client *client = guc->execbuf_client;
>
> That doesn't look like it's a problem, or that confusing. This client
> local var is just a placeholder used to clear the unwanted doorbells. We
> then walk over the known kernel clients to reset them.
>
> So, I think the suggestion is to split this function again, but I don't
> see a blocker for merging.
Ok, I'll need to split the function (or pass some flags to execute just
parts of it) for the selftest anyway.
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2017-10-26 20:15 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-25 20:00 [PATCH 00/12] Preemption with GuC, fourth try Michał Winiarski
2017-10-25 20:00 ` [PATCH v2 01/12] drm/i915/guc: Do not use 0 for GuC doorbell cookie Michał Winiarski
2017-10-25 20:00 ` [PATCH 02/12] drm/i915/guc: Extract GuC stage desc pool creation into a helper Michał Winiarski
2017-10-25 20:00 ` [PATCH v2 03/12] drm/i915/guc: Allocate separate shared data object for GuC communication Michał Winiarski
2017-10-25 21:04 ` Michel Thierry
2017-10-25 20:00 ` [PATCH v2 04/12] drm/i915/guc: Add preemption action to GuC firmware interface Michał Winiarski
2017-10-25 20:00 ` [PATCH v3 05/12] drm/i915/guc: Add a second client, to be used for preemption Michał Winiarski
2017-10-26 12:50 ` Michal Wajdeczko
2017-10-26 13:20 ` [PATCH v4] " Michał Winiarski
2017-10-26 13:32 ` [PATCH v5] " Michał Winiarski
2017-10-26 13:44 ` Michal Wajdeczko
2017-10-26 14:17 ` [PATCH v6] " Michał Winiarski
2017-10-26 18:49 ` Michel Thierry
2017-10-26 20:02 ` Chris Wilson
2017-10-26 20:15 ` Michel Thierry [this message]
2017-10-25 20:00 ` [PATCH 06/12] drm/i915/guc: Split guc_wq_item_append Michał Winiarski
2017-10-25 20:00 ` [PATCH v2 07/12] drm/i915: Extract "emit write" part of emit breadcrumb functions Michał Winiarski
2017-10-25 20:00 ` [PATCH 08/12] drm/i915: Add information needed to track engine preempt state Michał Winiarski
2017-10-25 20:00 ` [PATCH v2 09/12] drm/i915/guc: Keep request->priority for its lifetime Michał Winiarski
2017-10-25 20:00 ` [PATCH v3 10/12] drm/i915: Rename helpers used for unwinding, use macro for can_preempt Michał Winiarski
2017-10-25 20:15 ` Chris Wilson
2017-10-25 20:00 ` [PATCH v4 11/12] drm/i915/guc: Preemption! With GuC Michał Winiarski
2017-10-25 20:24 ` Chris Wilson
2017-10-25 21:14 ` Chris Wilson
2017-10-26 7:27 ` [PATCH v5] " Michał Winiarski
2017-10-26 13:35 ` [PATCH v6] " Michał Winiarski
2017-10-25 20:00 ` [PATCH 12/12] HAX Enable GuC Submission for CI Michał Winiarski
2017-10-25 21:06 ` ✗ Fi.CI.BAT: failure for Preemption with GuC, fourth try Patchwork
2017-10-26 7:48 ` ✗ Fi.CI.BAT: warning for Preemption with GuC, fourth try (rev2) Patchwork
2017-10-26 13:41 ` ✗ Fi.CI.BAT: warning for Preemption with GuC, fourth try (rev3) Patchwork
2017-10-26 13:59 ` ✓ Fi.CI.BAT: success for Preemption with GuC, fourth try (rev5) Patchwork
2017-10-26 14:43 ` ✗ Fi.CI.BAT: warning for Preemption with GuC, fourth try (rev6) Patchwork
2017-10-26 15:18 ` ✓ Fi.CI.IGT: success for Preemption with GuC, fourth try (rev5) Patchwork
2017-10-26 15:59 ` ✓ Fi.CI.IGT: success for Preemption with GuC, fourth try (rev6) Patchwork
2017-10-26 20:37 ` [PATCH 00/12] Preemption with GuC, fourth try Chris Wilson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f85748b4-36d8-9a1c-e8fe-e76eb68b6a00@intel.com \
--to=michel.thierry@intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
--cc=michal.winiarski@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox