From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 59736C433F5 for ; Tue, 11 Oct 2022 16:50:10 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 3029E10E828; Tue, 11 Oct 2022 16:50:09 +0000 (UTC) Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by gabe.freedesktop.org (Postfix) with ESMTPS id F314210E828 for ; Tue, 11 Oct 2022 16:50:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1665507006; x=1697043006; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=Qb4HAMGz2J5kJjw7zSM4NsWZeJKhD22IAjhbGbzJXFM=; b=fCKfE9KOuNECu7p8jaiD2TL3g2jZHe/STP5veNGRAONo50ysDXoRAB2f Xm+mdGzbq9lH8I6zJfPgtnmbJUGFFY0Dx7pj6p3V5xswm/a3va1sXJl4e m3c2HLxbWvHKsneeowg0Rc8SJi+TembQcYGVo2T56KW/aUWG63851IfVM FFWWP/0hpiXAp9SgW+QYtyvWSfSnKzY6I94QqfOZuMaXF05qKRvQjuAix y6+miO+u3a175wUlwvkIJYJhyXADI4ccdzxuMvNufMFh+UU6YemGtENEC /ALeft/Fa96WrRxTO2cdrA1owGpxhElytbTKKH5h6I7Kc5zEs6y0vk3OW w==; X-IronPort-AV: E=McAfee;i="6500,9779,10497"; a="306185687" X-IronPort-AV: E=Sophos;i="5.95,176,1661842800"; d="scan'208";a="306185687" Received: from orsmga006.jf.intel.com ([10.7.209.51]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Oct 2022 09:35:25 -0700 X-IronPort-AV: E=McAfee;i="6500,9779,10497"; a="604208859" X-IronPort-AV: E=Sophos;i="5.95,176,1661842800"; d="scan'208";a="604208859" Received: from mhartiga-mobl.ger.corp.intel.com (HELO [10.213.228.219]) ([10.213.228.219]) by orsmga006-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Oct 2022 09:35:23 -0700 Message-ID: Date: Tue, 11 Oct 2022 17:35:22 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.3.2 Content-Language: en-US To: Matthew Auld , intel-gfx@lists.freedesktop.org References: <20221004131916.233474-1-matthew.auld@intel.com> <20221004131916.233474-4-matthew.auld@intel.com> <519a0e90-3396-ba3e-5b82-e9d0dc9c452e@intel.com> <6448dbb3-fff4-7045-8f55-fb7a46b9d408@intel.com> From: Tvrtko Ursulin Organization: Intel Corporation UK Plc In-Reply-To: <6448dbb3-fff4-7045-8f55-fb7a46b9d408@intel.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Subject: Re: [Intel-gfx] [PATCH v5 4/5] drm/i915/display: consider DG2_RC_CCS_CC when migrating buffers X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Jianshui Yu , Nirmoy Das Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On 11/10/2022 16:28, Matthew Auld wrote: > On 11/10/2022 16:03, Tvrtko Ursulin wrote: >> >> On 11/10/2022 15:39, Matthew Auld wrote: >>> Hi, >>> >>> On 11/10/2022 14:54, Tvrtko Ursulin wrote: >>>> >>>> Hi Matt, >>>> >>>> On 04/10/2022 14:19, Matthew Auld wrote: >>>>> For these types of display buffers, we need to able to CPU access some >>>>> part of the backing memory in prepare_plane_clear_colors(). As a >>>>> result >>>>> we need to ensure we always place in the mappable part of lmem, which >>>>> becomes necessary on small-bar systems. >>>>> >>>>> v2(Nirmoy & Ville): >>>>>   - Add some commentary for why we need to CPU access the buffer. >>>>>   - Split out the other changes, so we just consider the display >>>>> change >>>>>     here. >>>>> v3: >>>>>   - Handle this in the dpt path. >>>>> v4(Ville): >>>>>   - Drop the intel_fb_rc_ccs_cc_plane() sanity check in >>>>>     pin_and_fence_fb_obj(), since we can also trigger this on DG1 it >>>>>     seems. >>>>> >>>>> Fixes: eb1c535f0d69 ("drm/i915: turn on small BAR support") >>>> >>>> That one landed in 6.0 - do you want to send this (with >>>> pre-requisite(s)) to stable? Or if not do you want me to send for >>>> 6.1 as part of fixes flow? In which case what are the per-requisites? >>> >>> This one is only for DG2, which is still hidden behind force_probe, >>> so not too sure if it needs stable? I think the only pre-requisite is >>> 999f45620772 ("drm/i915: allow control over the flags when >>> migrating"), but again I'm not too sure how much we care about fixes >>> for platforms hidden behind force_probe? What do you think? >> >> It is certainly not mandatory, but now that cards are about to ship >> and reach end users it may be nice to have if not too hard - at least >> for 6.1 release candidates. I am not clear on the importance of the >> fix to say for sure. Like what goes bang and under what circumstances. >> So I do basically defer to someone who knows those answers. > > It's important for small-bar DG2 systems, where it will potentially oops > somewhere in the driver without this, so if we want to support DG2 as a > platform in 6.1, then we also need this fix, along with 999f45620772. Now that you mention an oops I will definitely aim to pull it in. Thanks! Regards, Tvrtko