From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 76193CD3436 for ; Fri, 8 May 2026 09:44:07 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 17B2E10E09A; Fri, 8 May 2026 09:44:07 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="Y0JdP/JJ"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.10]) by gabe.freedesktop.org (Postfix) with ESMTPS id 1104410E09A for ; Fri, 8 May 2026 09:44:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1778233446; x=1809769446; h=date:from:to:cc:subject:in-reply-to:message-id: references:mime-version:content-id; bh=zFTUVA0y1jiQGFW5G05OCZCvO9QHEnVwzENQjlgVyX8=; b=Y0JdP/JJP/9NFf2+w4P+gFdGn9Yvq39YEz8R+SNe/F5Ecsn9Qp+goHid loeO4Rb/Vhq/PjLST+rbQPgxqSS56OWdll85a1zN0IoqRo/8yNxMWsfR9 2oha5FgQDFFBeF81SBQPT9ogDKWApqU2Xsdn43pqb/DKcBZApHNxVpzmd WaXvtXe9lJrZ1nfkIzevY9HNfEoTDFQZiujs8VRRo8TNlGLSM7O2CwrQK 5WqnB9wFwVUkWZcQqtD9rnZUsUyphuM90YfkiQVnlyBDdbeQ+2GLIkPFr uqGFnH9h93g03e7WgLJhJcQ7mZEiFzlsrNsdoIlPTte1JQa46ndd2QduM w==; X-CSE-ConnectionGUID: tfsAKbPXSPylMpdPy9F/hg== X-CSE-MsgGUID: Pd0CMyOOQZOEXK0onlTQRg== X-IronPort-AV: E=McAfee;i="6800,10657,11779"; a="96623120" X-IronPort-AV: E=Sophos;i="6.23,223,1770624000"; d="scan'208";a="96623120" Received: from orviesa004.jf.intel.com ([10.64.159.144]) by orvoesa102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 May 2026 02:44:06 -0700 X-CSE-ConnectionGUID: 8tutS5ZTS3Gm5I8aFiYuoQ== X-CSE-MsgGUID: zQT7XmF/QaScgSkjYTQVPg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.23,223,1770624000"; d="scan'208";a="241069452" Received: from dev-417.igk.intel.com ([10.91.214.181]) by orviesa004.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 May 2026 02:44:05 -0700 Date: Fri, 8 May 2026 11:44:02 +0200 (CEST) From: =?ISO-8859-2?Q?Micha=B3_Grzelak?= To: Krzysztof Karas cc: intel-gfx@lists.freedesktop.org, Andi Shyti , Sebastian Brzezinka , Krzysztof Niemiec , Janusz Krzysztofik Subject: Re: [PATCH v10 2/2] drm/i915/selftests: Run vma tests only if current->mm is present In-Reply-To: <20260508080214.1979686-3-krzysztof.karas@intel.com> Message-ID: References: <20260508080214.1979686-1-krzysztof.karas@intel.com> <20260508080214.1979686-3-krzysztof.karas@intel.com> MIME-Version: 1.0 Content-Type: multipart/mixed; BOUNDARY="8323329-522538504-1778233083=:541039" Content-ID: X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. --8323329-522538504-1778233083=:541039 Content-Type: text/plain; CHARSET=ISO-8859-2; format=flowed Content-Transfer-Encoding: 8BIT Content-ID: On Fri, 8 May 2026, Krzysztof Karas wrote: > This set of tests require userspace memory to map objects, so > run them only if this that memory is available. I think the word "this" can be dropped from the description. Otherwise, Reviewed-by: Micha³ Grzelak > > Reviewed-by: Sebastian Brzezinka > Reviewed-by: Andi Shyti > Reviewed-by: Janusz Krzysztofik > Signed-off-by: Krzysztof Karas > --- > .../gpu/drm/i915/gem/selftests/i915_gem_mman.c | 16 ++++++++-------- > 1 file changed, 8 insertions(+), 8 deletions(-) > > diff --git a/drivers/gpu/drm/i915/gem/selftests/i915_gem_mman.c b/drivers/gpu/drm/i915/gem/selftests/i915_gem_mman.c > index 9d454d0b46f2..d01acfb7d93d 100644 > --- a/drivers/gpu/drm/i915/gem/selftests/i915_gem_mman.c > +++ b/drivers/gpu/drm/i915/gem/selftests/i915_gem_mman.c > @@ -1847,11 +1847,12 @@ static int igt_mmap_revoke(void *arg) > int i915_gem_mman_live_selftests(struct drm_i915_private *i915) > { > int ret; > - bool unuse_mm = false; > static const struct i915_subtest tests[] = { > SUBTEST(igt_partial_tiling), > SUBTEST(igt_smoke_tiling), > SUBTEST(igt_mmap_offset_exhaustion), > + }; > + static const struct i915_subtest vma_tests[] = { > SUBTEST(igt_mmap), > SUBTEST(igt_mmap_migrate), > SUBTEST(igt_mmap_access), > @@ -1859,15 +1860,14 @@ int i915_gem_mman_live_selftests(struct drm_i915_private *i915) > SUBTEST(igt_mmap_gpu), > }; > > - if (!current->mm) { > - kthread_use_mm(current->active_mm); > - unuse_mm = true; > - } > - > ret = i915_live_subtests(tests, i915); > + if (ret) > + return ret; > > - if (unuse_mm) > - kthread_unuse_mm(current->active_mm); > + if (current->mm) > + ret = i915_live_subtests(vma_tests, i915); > + else > + pr_warn("No current->mm to safely borrow userspace memory from. Skipping VMA tests.\n"); > > return ret; > } > -- > 2.34.1 > > --8323329-522538504-1778233083=:541039--