Re: [PATCH 03/20] drm/i915: Allocate a drm_atomic_state for the legacy modeset code

Daniel Vetter
2015-03-27T08:59:33Z

On Fri, Mar 20, 2015 at 04:18:03PM +0200, Ander Conselvan de Oliveira wrote:
> @@ -8924,6 +8932,11 @@ retry:
> else
> intel_crtc->new_config = NULL;
> fail_unlock:
> + if (state) {
> + drm_atomic_state_free(state);
> + state = NULL;
> + }

I think we should push the NULL handling into drm_atomic_state_free like
with kfree. Can you please do such a patch on top of this for all of drm?
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation