Re: [PATCH 18/20] drm/i915: Don't look at staged config crtc when changing DRRS state

Daniel Vetter
2015-03-27T09:30:44Z

On Fri, Mar 20, 2015 at 04:18:18PM +0200, Ander Conselvan de Oliveira wrote:
> The function intel_dp_set_drrs_state() would decide which pipe to
> downclock based on the staged config for the given connector. However,
> the result of that function is immediate, and it uses input values from
> crtc->config, so it should be looking at the current crtc instead.
>
> Signed-off-by: Ander Conselvan de Oliveira <ander.conselvan.de.oliveira@intel.com>
> ---
> drivers/gpu/drm/i915/intel_dp.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c
> index 0c61aed..22bf6f2 100644
> --- a/drivers/gpu/drm/i915/intel_dp.c
> +++ b/drivers/gpu/drm/i915/intel_dp.c
> @@ -4935,7 +4935,7 @@ static void intel_dp_set_drrs_state(struct drm_device *dev, int refresh_rate)
>
> dig_port = dp_to_dig_port(intel_dp);
> encoder = &dig_port->base;
> - intel_crtc = encoder->new_crtc;
> + intel_crtc = to_intel_crtc(encoder->base.crtc);

drm_encoder->crtc is kinda deprecated too. Just not our own kind of
deprecated, since there's still some random users in the core. But I do
plan to eventually leave them all as NULL for atomic drivers, to make sure
everyone is exclusively looking at the state objects.

Anyway that's for later.
-Daniel

>
> if (!intel_crtc) {
> DRM_DEBUG_KMS("DRRS: intel_crtc not initialized\n");
> --
> 2.1.0
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx

--
Daniel Vetter
Software Engineer, Intel Corporation