From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ben Widawsky Subject: Re: [PATCH 3/4] drm/i915/contexts: Serialize default context init Date: Tue, 14 Aug 2012 09:41:33 -0700 Message-ID: References: <1344922871-2248-1-git-send-email-ben@bwidawsk.net> <1344922871-2248-3-git-send-email-ben@bwidawsk.net> <1344930093_90135@CP5-2952> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: Received: from shiva.chad-versace.us (209-20-75-48.static.cloud-ips.com [209.20.75.48]) by gabe.freedesktop.org (Postfix) with ESMTP id 0FBEA9E7B2 for ; Tue, 14 Aug 2012 09:41:31 -0700 (PDT) In-Reply-To: <1344930093_90135@CP5-2952> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Chris Wilson Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On 2012-08-14 00:41, Chris Wilson wrote: > On Mon, 13 Aug 2012 22:41:10 -0700, Ben Widawsky > wrote: >> This is possible with the new force paramter in do_switch. As stated >> in >> that patch, the goal is to get a real context stored at the time of >> initialization. >> >> References: https://bugs.freedesktop.org/show_bug.cgi?id=52429 >> Tested-by: Guang A Yang >> Signed-off-by: Ben Widawsky > > I'm missing the rationalisation for this pair of patches... For > instance, I can't see how this closes the hole we have upon resume > where > ring->context_obj == DEFAULT_CONTEXT but CCID is 0. > -Chris Yeah this doesn't fix that problem. The problem this is trying to solve is suspend/resume before any context switch actually occurs. Basically jam the default context obj in, and this allows us to force restore it on resume. However, as you point out, I guess that force restore is missing. Let me think a bit more/chat on IRC. -- Ben Widawsky, Intel Open Source Technology Center