From mboxrd@z Thu Jan 1 00:00:00 1970 From: Michel Thierry Subject: Re: [PATCH 5/8] drm/i915/icl: Add reset control register changes Date: Tue, 27 Mar 2018 09:26:07 -0700 Message-ID: References: <20180316121456.11577-1-mika.kuoppala@linux.intel.com> <20180316121456.11577-5-mika.kuoppala@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by gabe.freedesktop.org (Postfix) with ESMTPS id 0A92F6E64A for ; Tue, 27 Mar 2018 16:26:08 +0000 (UTC) In-Reply-To: Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Daniele Ceraolo Spurio , Mika Kuoppala , intel-gfx@lists.freedesktop.org Cc: Paulo Zanoni List-Id: intel-gfx@lists.freedesktop.org T24gMy8xNi8yMDE4IDE6MjggUE0sIERhbmllbGUgQ2VyYW9sbyBTcHVyaW8gd3JvdGU6Cj4gCj4g Cj4gT24gMTYvMDMvMTggMDU6MTQsIE1pa2EgS3VvcHBhbGEgd3JvdGU6Cj4+IEZyb206IE1pY2hl bCBUaGllcnJ5IDxtaWNoZWwudGhpZXJyeUBpbnRlbC5jb20+Cj4+Cj4+IFRoZSBiaXRzIHVzZWQg dG8gcmVzZXQgdGhlIGRpZmZlcmVudCBlbmdpbmVzL2RvbWFpbnMgaGF2ZSBjaGFuZ2VkIGluCj4+ IEdFTjExLCB0aGlzIHBhdGNoIG1hcHMgdGhlIHJlc2V0IGVuZ2luZSBtYXNrIGJpdHMgd2l0aCB0 aGUgbmV3IGJpdHMKPj4gaW4gdGhlIHJlc2V0IGNvbnRyb2wgcmVnaXN0ZXIuCj4+Cj4+IHYyOiBV c2Ugc2hpZnQtbGVmdCBpbnN0ZWFkIG9mIEJJVCBtYWNybyB0byBtYXRjaCB0aGUgZmlsZSBzdHls ZSAoUGF1bG8pLgo+PiB2MzogUmV1c2UgZ2VuOF9yZXNldF9lbmdpbmVzIChEYW5pZWxlKS4KPj4g djQ6IERvIG5vdCBjYWxsIGludGVsX3VuY29yZV9mb3JjZXdha2VfcmVzZXQgYWZ0ZXIgcmVzZXQs IHdlIG1heSBiZQo+PiB1c2luZyB0aGUgZm9yY2V3YWtlIHRvIHJlYWQgcHJvdGVjdGVkIHJlZ2lz dGVycyBlbHNld2hlcmUgYW5kIHRob3NlCj4+IHJlc3VsdHMgbWF5IGJlIGNsb2JiZXJlZCBieSB0 aGUgY29uY3VycmVudCBkcm9wcGluZyBvZiBmb3JjZXdha2UuCj4+Cj4+IGJzcGVjOiAxOTIxMgo+ PiBDYzogT3NjYXIgTWF0ZW8gPG9zY2FyLm1hdGVvQGludGVsLmNvbT4KPj4gQ2M6IEFudG9uaW8g QXJnZW56aWFubyA8YW50b25pby5hcmdlbnppYW5vQGludGVsLmNvbT4KPj4gQ2M6IFBhdWxvIFph bm9uaSA8cGF1bG8uci56YW5vbmlAaW50ZWwuY29tPgo+PiBDYzogRGFuaWVsZSBDZXJhb2xvIFNw dXJpbyA8ZGFuaWVsZS5jZXJhb2xvc3B1cmlvQGludGVsLmNvbT4KPj4gQWNrZWQtYnk6IERhbmll bGUgQ2VyYW9sbyBTcHVyaW8gPGRhbmllbGUuY2VyYW9sb3NwdXJpb0BpbnRlbC5jb20+Cj4+IFNp Z25lZC1vZmYtYnk6IE1pY2hlbCBUaGllcnJ5IDxtaWNoZWwudGhpZXJyeUBpbnRlbC5jb20+Cj4+ IC0tLQo+PiDCoCBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X3JlZy5owqDCoMKgwqAgfCAxMSAr KysrKysrKwo+PiDCoCBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF91bmNvcmUuYyB8IDUzIAo+ PiArKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKy0tCj4+IMKgIDIgZmlsZXMgY2hh bmdlZCwgNjIgaW5zZXJ0aW9ucygrKSwgMiBkZWxldGlvbnMoLSkKPj4KPj4gZGlmZiAtLWdpdCBh L2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfcmVnLmggCj4+IGIvZHJpdmVycy9ncHUvZHJtL2k5 MTUvaTkxNV9yZWcuaAo+PiBpbmRleCA5ZWFhYTk2Mjg3ZWMuLmYzY2M3NzY5MDEyNCAxMDA2NDQK Pj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9yZWcuaAo+PiArKysgYi9kcml2ZXJz L2dwdS9kcm0vaTkxNS9pOTE1X3JlZy5oCj4+IEBAIC0zMDEsNiArMzAxLDE3IEBAIHN0YXRpYyBp bmxpbmUgYm9vbCBpOTE1X21taW9fcmVnX3ZhbGlkKGk5MTVfcmVnX3QgCj4+IHJlZykKPj4gwqAg I2RlZmluZcKgIEdFTjZfR1JET01fVkVDU8KgwqDCoMKgwqDCoMKgICgxIDw8IDQpCj4+IMKgICNk ZWZpbmXCoCBHRU45X0dSRE9NX0dVQ8KgwqDCoMKgwqDCoMKgwqDCoMKgwqAgKDEgPDwgNSkKPj4g wqAgI2RlZmluZcKgIEdFTjhfR1JET01fTUVESUEywqDCoMKgwqDCoMKgwqAgKDEgPDwgNykKPj4g Ky8qIEdFTjExIGNoYW5nZWQgYWxsIGJpdCBkZWZzIGV4Y2VwdCBmb3IgRlVMTCAmIFJFTkRFUiAq Lwo+PiArI2RlZmluZcKgIEdFTjExX0dSRE9NX0ZVTEzCoMKgwqDCoMKgwqDCoCBHRU42X0dSRE9N X0ZVTEwKPj4gKyNkZWZpbmXCoCBHRU4xMV9HUkRPTV9SRU5ERVLCoMKgwqDCoMKgwqDCoCBHRU42 X0dSRE9NX1JFTkRFUgo+PiArI2RlZmluZcKgIEdFTjExX0dSRE9NX0JMVMKgwqDCoMKgwqDCoMKg ICgxIDw8IDIpCj4+ICsjZGVmaW5lwqAgR0VOMTFfR1JET01fR1VDwqDCoMKgwqDCoMKgwqAgKDEg PDwgMykKPj4gKyNkZWZpbmXCoCBHRU4xMV9HUkRPTV9NRURJQcKgwqDCoMKgwqDCoMKgICgxIDw8 IDUpCj4+ICsjZGVmaW5lwqAgR0VOMTFfR1JET01fTUVESUEywqDCoMKgwqDCoMKgwqAgKDEgPDwg NikKPj4gKyNkZWZpbmXCoCBHRU4xMV9HUkRPTV9NRURJQTPCoMKgwqDCoMKgwqDCoCAoMSA8PCA3 KQo+PiArI2RlZmluZcKgIEdFTjExX0dSRE9NX01FRElBNMKgwqDCoMKgwqDCoMKgICgxIDw8IDgp Cj4+ICsjZGVmaW5lwqAgR0VOMTFfR1JET01fVkVDU8KgwqDCoMKgwqDCoMKgICgxIDw8IDEzKQo+ PiArI2RlZmluZcKgIEdFTjExX0dSRE9NX1ZFQ1MywqDCoMKgwqDCoMKgwqAgKDEgPDwgMTQpCj4+ IMKgICNkZWZpbmUgUklOR19QUF9ESVJfQkFTRShlbmdpbmUpwqDCoMKgIF9NTUlPKChlbmdpbmUp LT5tbWlvX2Jhc2UrMHgyMjgpCj4+IMKgICNkZWZpbmUgUklOR19QUF9ESVJfQkFTRV9SRUFEKGVu Z2luZSkgICAgCj4+IF9NTUlPKChlbmdpbmUpLT5tbWlvX2Jhc2UrMHg1MTgpCj4+IGRpZmYgLS1n aXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF91bmNvcmUuYyAKPj4gYi9kcml2ZXJzL2dw dS9kcm0vaTkxNS9pbnRlbF91bmNvcmUuYwo+PiBpbmRleCA0YzYxNmQwNzRhOTcuLmNhYmJmMGU2 ODJlNyAxMDA2NDQKPj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfdW5jb3JlLmMK Pj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfdW5jb3JlLmMKPj4gQEAgLTE5MDks NiArMTkwOSw1MCBAQCBzdGF0aWMgaW50IGdlbjZfcmVzZXRfZW5naW5lcyhzdHJ1Y3QgCj4+IGRy bV9pOTE1X3ByaXZhdGUgKmRldl9wcml2LAo+PiDCoMKgwqDCoMKgIHJldHVybiBnZW42X2h3X2Rv bWFpbl9yZXNldChkZXZfcHJpdiwgaHdfbWFzayk7Cj4+IMKgIH0KPj4gKy8qKgo+PiArICogZ2Vu MTFfcmVzZXRfZW5naW5lcyAtIHJlc2V0IGluZGl2aWR1YWwgZW5naW5lcwo+PiArICogQGRldl9w cml2OiBpOTE1IGRldmljZQo+PiArICogQGVuZ2luZV9tYXNrOiBtYXNrIG9mIGludGVsX3Jpbmdf ZmxhZygpIGVuZ2luZXMgb3IgQUxMX0VOR0lORVMgZm9yIAo+PiBmdWxsIHJlc2V0Cj4+ICsgKgo+ PiArICogVGhpcyBmdW5jdGlvbiB3aWxsIHJlc2V0IHRoZSBpbmRpdmlkdWFsIGVuZ2luZXMgdGhh dCBhcmUgc2V0IGluIAo+PiBlbmdpbmVfbWFzay4KPj4gKyAqIElmIHlvdSBwcm92aWRlIEFMTF9F TkdJTkVTIGFzIG1hc2ssIGZ1bGwgZ2xvYmFsIGRvbWFpbiByZXNldCB3aWxsIAo+PiBiZSBpc3N1 ZWQuCj4+ICsgKgo+PiArICogTm90ZTogSXQgaXMgcmVzcG9uc2liaWxpdHkgb2YgdGhlIGNhbGxl ciB0byBoYW5kbGUgdGhlIGRpZmZlcmVuY2UgCj4+IGJldHdlZW4KPj4gKyAqIGFza2luZyBmdWxs IGRvbWFpbiByZXNldCB2ZXJzdXMgcmVzZXQgZm9yIGFsbCBhdmFpbGFibGUgaW5kaXZpZHVhbCAK Pj4gZW5naW5lcy4KPj4gKyAqCj4+ICsgKiBSZXR1cm5zIDAgb24gc3VjY2Vzcywgbm9uemVybyBv biBlcnJvci4KPj4gKyAqLwo+PiArc3RhdGljIGludCBnZW4xMV9yZXNldF9lbmdpbmVzKHN0cnVj dCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiwKPj4gK8KgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoCB1bnNpZ25lZCBlbmdpbmVfbWFzaykKPj4gK3sKPj4gK8KgwqDCoCBzdHJ1 Y3QgaW50ZWxfZW5naW5lX2NzICplbmdpbmU7Cj4+ICvCoMKgwqAgY29uc3QgdTMyIGh3X2VuZ2lu ZV9tYXNrW0k5MTVfTlVNX0VOR0lORVNdID0gewo+PiArwqDCoMKgwqDCoMKgwqAgW1JDU10gPSBH RU4xMV9HUkRPTV9SRU5ERVIsCj4+ICvCoMKgwqDCoMKgwqDCoCBbQkNTXSA9IEdFTjExX0dSRE9N X0JMVCwKPj4gK8KgwqDCoMKgwqDCoMKgIFtWQ1NdID0gR0VOMTFfR1JET01fTUVESUEsCj4+ICvC oMKgwqDCoMKgwqDCoCBbVkNTMl0gPSBHRU4xMV9HUkRPTV9NRURJQTIsCj4+ICvCoMKgwqDCoMKg wqDCoCBbVkNTM10gPSBHRU4xMV9HUkRPTV9NRURJQTMsCj4+ICvCoMKgwqDCoMKgwqDCoCBbVkNT NF0gPSBHRU4xMV9HUkRPTV9NRURJQTQsCj4+ICvCoMKgwqDCoMKgwqDCoCBbVkVDU10gPSBHRU4x MV9HUkRPTV9WRUNTLAo+PiArwqDCoMKgwqDCoMKgwqAgW1ZFQ1MyXSA9IEdFTjExX0dSRE9NX1ZF Q1MyLAo+PiArwqDCoMKgIH07Cj4gCj4gSnVzdCBhIHRob3VnaHQsIGJ1dCBzaW5jZSB0aGlzIGZ1 bmN0aW9uIGlzIGEgY29weSBvZiBnZW42X3Jlc2V0X2VuZ2luZXMgCj4gd2l0aCB0aGUgb25seSBk aWZmZXJlbmNlIGJlaW5nIHRoZSBhcnJheSAoR0VOMTFfR1JET01fRlVMTCBpcyBhbHNvIHRoZSAK PiBzYW1lIGFzIEdFTjZfR1JET01fRlVMTCksIHdvdWxkIGl0IG1ha2Ugc2Vuc2UgdG8ganVzdCBh ZGQgdGhlIGFycmF5IHRvIAo+IHRoZSBnZW42IGZ1bmN0aW9uPyBlLmcuOgoKVGhlcmUgYXJlIG1v cmUgY2hhbmdlcyBmb3IgZ2VuMTEgY29taW5nIChsb2NraW5nL3VubG9ja2luZyB0aGUgc2hhcmVk IApTRkMgdW5pdHMpLCBzbyBJIGRvbid0IHRoaW5rIGl0J3MgYSBnb29kIGlkZWEgdG8gY29tYmlu ZSB0aGVtLgoKPiAKPiAgwqDCoMKgwqBjb25zdCB1MzIgZ2VuNl9od19lbmdpbmVfbWFza1tdID0g ewo+ICDCoMKgwqDCoC4uLi4KPiAgwqDCoMKgwqB9Cj4gIMKgwqDCoMKgY29uc3QgdTMyIGdlbjEx X2h3X2VuZ2luZV9tYXNrW10gPSB7Cj4gIMKgwqDCoMKgLi4uLgo+ICDCoMKgwqDCoH0KPiAKPiAg wqDCoMKgwqBjb25zdCB1MzIgKmh3X2VuZ2luZV9tYXNrID0gSU5URUxfR0VOKGRldl9wcml2KSA+ PSAxMSA/Cj4gIMKgwqDCoMKgwqDCoMKgIGdlbjExX2h3X2VuZ2luZV9tYXNrIDogZ2VuNl9od19l bmdpbmVfbWFzazsKPiAKPiAKPiBNeSBBY2sgc3RpbGwgc3RhbmRzIHJlZ2FyZGxlc3MgYW5kIEkg YWxzbyBhZ3JlZSB3aXRoIHJlbmFtaW5nIHRoZSAKPiBkZWZpbmVzIHRvIGJlIGNsb3NlciB0byB0 aGUgc3BlY3MuCj4gCj4gRGFuaWVsZQo+IAo+PiArwqDCoMKgIHUzMiBod19tYXNrOwo+PiArCj4+ ICvCoMKgwqAgQlVJTERfQlVHX09OKFZFQ1MyICsgMSAhPSBJOTE1X05VTV9FTkdJTkVTKTsKPj4g Kwo+PiArwqDCoMKgIGlmIChlbmdpbmVfbWFzayA9PSBBTExfRU5HSU5FUykgewo+PiArwqDCoMKg wqDCoMKgwqAgaHdfbWFzayA9IEdFTjExX0dSRE9NX0ZVTEw7Cj4+ICvCoMKgwqAgfSBlbHNlIHsK Pj4gK8KgwqDCoMKgwqDCoMKgIHVuc2lnbmVkIGludCB0bXA7Cj4+ICsKPj4gK8KgwqDCoMKgwqDC oMKgIGh3X21hc2sgPSAwOwo+PiArwqDCoMKgwqDCoMKgwqAgZm9yX2VhY2hfZW5naW5lX21hc2tl ZChlbmdpbmUsIGRldl9wcml2LCBlbmdpbmVfbWFzaywgdG1wKQo+PiArwqDCoMKgwqDCoMKgwqDC oMKgwqDCoCBod19tYXNrIHw9IGh3X2VuZ2luZV9tYXNrW2VuZ2luZS0+aWRdOwo+PiArwqDCoMKg IH0KPj4gKwo+PiArwqDCoMKgIHJldHVybiBnZW42X2h3X2RvbWFpbl9yZXNldChkZXZfcHJpdiwg aHdfbWFzayk7Cj4+ICt9Cj4+ICsKPj4gwqAgLyoqCj4+IMKgwqAgKiBfX2ludGVsX3dhaXRfZm9y X3JlZ2lzdGVyX2Z3IC0gd2FpdCB1bnRpbCByZWdpc3RlciBtYXRjaGVzIAo+PiBleHBlY3RlZCBz dGF0ZQo+PiDCoMKgICogQGRldl9wcml2OiB0aGUgaTkxNSBkZXZpY2UKPj4gQEAgLTIwNTYsNyAr MjEwMCwxMCBAQCBzdGF0aWMgaW50IGdlbjhfcmVzZXRfZW5naW5lcyhzdHJ1Y3QgCj4+IGRybV9p OTE1X3ByaXZhdGUgKmRldl9wcml2LAo+PiDCoMKgwqDCoMKgwqDCoMKgwqAgaWYgKGdlbjhfcmVz ZXRfZW5naW5lX3N0YXJ0KGVuZ2luZSkpCj4+IMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIGdv dG8gbm90X3JlYWR5Owo+PiAtwqDCoMKgIHJldHVybiBnZW42X3Jlc2V0X2VuZ2luZXMoZGV2X3By aXYsIGVuZ2luZV9tYXNrKTsKPj4gK8KgwqDCoCBpZiAoSU5URUxfR0VOKGRldl9wcml2KSA+PSAx MSkKPj4gK8KgwqDCoMKgwqDCoMKgIHJldHVybiBnZW4xMV9yZXNldF9lbmdpbmVzKGRldl9wcml2 LCBlbmdpbmVfbWFzayk7Cj4+ICvCoMKgwqAgZWxzZQo+PiArwqDCoMKgwqDCoMKgwqAgcmV0dXJu IGdlbjZfcmVzZXRfZW5naW5lcyhkZXZfcHJpdiwgZW5naW5lX21hc2spOwo+PiDCoCBub3RfcmVh ZHk6Cj4+IMKgwqDCoMKgwqAgZm9yX2VhY2hfZW5naW5lX21hc2tlZChlbmdpbmUsIGRldl9wcml2 LCBlbmdpbmVfbWFzaywgdG1wKQo+PiBAQCAtMjE0MSwxMiArMjE4OCwxNCBAQCBib29sIGludGVs X2hhc19yZXNldF9lbmdpbmUoc3RydWN0IAo+PiBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdikK Pj4gwqAgaW50IGludGVsX3Jlc2V0X2d1YyhzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3By aXYpCj4+IMKgIHsKPj4gK8KgwqDCoCB1MzIgZ3VjX2RvbWFpbiA9IElOVEVMX0dFTihkZXZfcHJp dikgPj0gMTEgPyBHRU4xMV9HUkRPTV9HVUMgOgo+PiArwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgR0VOOV9HUkRPTV9HVUM7Cj4+IMKgwqDC oMKgwqAgaW50IHJldDsKPj4gwqDCoMKgwqDCoCBHRU1fQlVHX09OKCFIQVNfR1VDKGRldl9wcml2 KSk7Cj4+IMKgwqDCoMKgwqAgaW50ZWxfdW5jb3JlX2ZvcmNld2FrZV9nZXQoZGV2X3ByaXYsIEZP UkNFV0FLRV9BTEwpOwo+PiAtwqDCoMKgIHJldCA9IGdlbjZfaHdfZG9tYWluX3Jlc2V0KGRldl9w cml2LCBHRU45X0dSRE9NX0dVQyk7Cj4+ICvCoMKgwqAgcmV0ID0gZ2VuNl9od19kb21haW5fcmVz ZXQoZGV2X3ByaXYsIGd1Y19kb21haW4pOwo+PiDCoMKgwqDCoMKgIGludGVsX3VuY29yZV9mb3Jj ZXdha2VfcHV0KGRldl9wcml2LCBGT1JDRVdBS0VfQUxMKTsKPj4gwqDCoMKgwqDCoCByZXR1cm4g cmV0Owo+PgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJ bnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0 cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK