From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tvrtko Ursulin Subject: Re: [PATCH 08/11] drm/i915/uc: Simplify firmware path handling Date: Mon, 13 Mar 2017 13:55:03 +0000 Message-ID: References: <20170313131508.24439-1-arkadiusz.hiler@intel.com> <20170313131508.24439-9-arkadiusz.hiler@intel.com> <923708c1-6574-fdbc-ad63-2be0eb21845d@linux.intel.com> <20170313134817.GC5550@ahiler-desk.igk.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by gabe.freedesktop.org (Postfix) with ESMTPS id B84F06E51F for ; Mon, 13 Mar 2017 13:55:06 +0000 (UTC) In-Reply-To: <20170313134817.GC5550@ahiler-desk.igk.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Arkadiusz Hiler Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org Ck9uIDEzLzAzLzIwMTcgMTM6NDgsIEFya2FkaXVzeiBIaWxlciB3cm90ZToKPiBPbiBNb24sIE1h ciAxMywgMjAxNyBhdCAwMTozOTo0NVBNICswMDAwLCBUdnJ0a28gVXJzdWxpbiB3cm90ZToKPj4K Pj4gT24gMTMvMDMvMjAxNyAxMzoxNSwgQXJrYWRpdXN6IEhpbGVyIHdyb3RlOgo+Pj4gQ3VycmVu dGx5IGZ3LT5wYXRoIHZhbHVlcyBjYW4gcmVwcmVzZW50IG9uZSBvZiB0aHJlZSBwb3NzaWJsZSBz dGF0ZXM6Cj4+Pgo+Pj4gIDEpIE5VTEwgLSBkZXZpY2Ugd2l0aG91dCB0aGUgdUMKPj4+ICAyKSAn XDAnIC0gZGV2aWNlIHdpdGggdGhlIHVDIGJ1dCBoYXZlIG5vIGZpcm13YXJlCj4+PiAgMykgZWxz ZSAtIGRldmljZSB3aXRoIHRoZSB1QyBhbmQgd2UgaGF2ZSBmaXJtd2FyZQo+Pj4KPj4+IFNlY29u ZCBjYXNlIGlzIHVzZWQgb25seSB0byBXQVJOIGF0IGEgbGF0ZXIgc3RhZ2UuCj4+Pgo+Pj4gV2Ug Y2FuIFdBUk4gcmlnaHQgYXdheSBhbmQgbWVyZ2UgY2FzZXMgMSBhbmQgMi4KPj4+Cj4+PiBDb2Rl IGNhbiBiZSBldmVuIGZ1cnRoZXIgc2ltcGxpZmllZCBhbmQgY29tbW9uIChIdUMvR3VDIGxvZ2lj KSBoYXBwZW5pbmcKPj4+IHJpZ2h0IGJlZm9yZSB0aGUgZmV0Y2ggY2FuIGJlIG9mZmxvYWRlZCB0 byB0aGUgY29tbW9uIGZ1bmN0aW9uLgo+Pj4KPj4+IHYyOiBmZXdlciB0ZW1wb3JhcnkgdmFyaWFi bGVzLCBtb3JlIHN0cmFpZ2h0Zm9yd2FyZCBmbG93IChNLiBXYWpkZWN6a28pCj4+PiB2MzogRFJN X0VSUk9SIGluc3RlYWQgb2YgV0FSTiAoTS4gV2FqZGVjemtvKQo+Pj4gdjQ6IGNvZGluZyBzdGFu ZGFyZCAoSi4gTGFodGluZW4pCj4+PiB2NTogbm9uLXRyaXZpYWwgcmViYXNlCj4+PiB2NjogcmVt b3ZlIHBhdGggY2hlY2ssIHdlIGFyZSBjaGVja2luZyBmZXRjaCBzdGF0dXMgKE0uIFdhamRlY3pr bykKPj4+Cj4+PiBDYzogQW51c2hhIFNyaXZhdHNhIDxhbnVzaGEuc3JpdmF0c2FAaW50ZWwuY29t Pgo+Pj4gQ2M6IFR2cnRrbyBVcnN1bGluIDx0dnJ0a28udXJzdWxpbkBpbnRlbC5jb20+Cj4+PiBD YzogTWljaGFsIFdpbmlhcnNraSA8bWljaGFsLndpbmlhcnNraUBpbnRlbC5jb20+Cj4+PiBDYzog TWljaGFsIFdhamRlY3prbyA8bWljaGFsLndhamRlY3prb0BpbnRlbC5jb20+Cj4+PiBDYzogSm9v bmFzIExhaHRpbmVuIDxqb29uYXMubGFodGluZW5AbGludXguaW50ZWwuY29tPgo+Pj4gU2lnbmVk LW9mZi1ieTogQXJrYWRpdXN6IEhpbGVyIDxhcmthZGl1c3ouaGlsZXJAaW50ZWwuY29tPgo+Pj4g LS0tCj4+PiAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZ3VjX2xvYWRlci5jIHwgMzYgKysr KysrKysrKy0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tCj4+PiAgZHJpdmVycy9ncHUvZHJtL2k5MTUv aW50ZWxfaHVjLmMgICAgICAgIHwgMjEgKysrKysrLS0tLS0tLS0tLS0tLQo+Pj4gIGRyaXZlcnMv Z3B1L2RybS9pOTE1L2ludGVsX3VjLmMgICAgICAgICB8ICA0ICsrKy0KPj4+ICAzIGZpbGVzIGNo YW5nZWQsIDIwIGluc2VydGlvbnMoKyksIDQxIGRlbGV0aW9ucygtKQo+Pj4KPj4+IGRpZmYgLS1n aXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9ndWNfbG9hZGVyLmMgYi9kcml2ZXJzL2dw dS9kcm0vaTkxNS9pbnRlbF9ndWNfbG9hZGVyLmMKPj4+IGluZGV4IDBhMjljMWIuLmQ3MzFmNjgg MTAwNjQ0Cj4+PiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9ndWNfbG9hZGVyLmMK Pj4+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2d1Y19sb2FkZXIuYwo+Pj4gQEAg LTM2OCwxMyArMzY4LDYgQEAgaW50IGludGVsX2d1Y19pbml0X2h3KHN0cnVjdCBpbnRlbF9ndWMg Kmd1YykKPj4+ICAJCWludGVsX3VjX2Z3X3N0YXR1c19yZXByKGd1Yy0+ZncuZmV0Y2hfc3RhdHVz KSwKPj4+ICAJCWludGVsX3VjX2Z3X3N0YXR1c19yZXByKGd1Yy0+ZncubG9hZF9zdGF0dXMpKTsK Pj4+Cj4+PiAtCWlmICghZndfcGF0aCkgewo+Pj4gLQkJcmV0dXJuIC1FTlhJTzsKPj4+IC0JfSBl bHNlIGlmICgqZndfcGF0aCA9PSAnXDAnKSB7Cj4+PiAtCQlXQVJOKDEsICJObyBHdUMgZmlybXdh cmUga25vd24gZm9yIHRoaXMgcGxhdGZvcm0hXG4iKTsKPj4+IC0JCXJldHVybiAtRU5PREVWOwo+ Pj4gLQl9Cj4+PiAtCj4+PiAgCWlmIChndWMtPmZ3LmZldGNoX3N0YXR1cyAhPSBJTlRFTF9VQ19G SVJNV0FSRV9TVUNDRVNTKQo+Pj4gIAkJcmV0dXJuIC1FSU87Cj4+Pgo+Pj4gQEAgLTM5OSw3ICsz OTIsNiBAQCBpbnQgaW50ZWxfZ3VjX2luaXRfaHcoc3RydWN0IGludGVsX2d1YyAqZ3VjKQo+Pj4g IAlyZXR1cm4gMDsKPj4+ICB9Cj4+Pgo+Pj4gLQo+Pj4gIC8qKgo+Pj4gICAqIGludGVsX2d1Y19p bml0X2Z3KCkgLSBzZWxlY3QgYW5kIHByZXBhcmUgZmlybXdhcmUgZm9yIGxvYWRpbmcKPj4+ICAg KiBAZ3VjOglpbnRlbF9ndWMgc3RydWN0Cj4+PiBAQCAtNDEyLDM3ICs0MDQsMzEgQEAgaW50IGlu dGVsX2d1Y19pbml0X2h3KHN0cnVjdCBpbnRlbF9ndWMgKmd1YykKPj4+ICB2b2lkIGludGVsX2d1 Y19pbml0X2Z3KHN0cnVjdCBpbnRlbF9ndWMgKmd1YykKPj4+ICB7Cj4+PiAgCXN0cnVjdCBkcm1f aTkxNV9wcml2YXRlICpkZXZfcHJpdiA9IGd1Y190b19pOTE1KGd1Yyk7Cj4+PiAtCWNvbnN0IGNo YXIgKmZ3X3BhdGg7Cj4+PiArCj4+PiArCWd1Yy0+ZncucGF0aCA9IE5VTEw7Cj4+PiArCWd1Yy0+ ZncuZmV0Y2hfc3RhdHVzID0gSU5URUxfVUNfRklSTVdBUkVfTk9ORTsKPj4+ICsJZ3VjLT5mdy5s b2FkX3N0YXR1cyA9IElOVEVMX1VDX0ZJUk1XQVJFX05PTkU7Cj4+PiArCWd1Yy0+ZncuZncgPSBJ TlRFTF9VQ19GV19UWVBFX0dVQzsKPj4KPj4gSWYgbm90IHRvbyBoYXJkIG9uIHRoZSBzZXJpZXMg YW5kIGFsbCwgbWF5YmUgYmlrZXNoZWQgdGhpcyBmaWVsZCB0byAidHlwZSIuCj4KPiBNYWtlcyBz ZW5zZS4gQ2FuIHdlIGRvIHRoYXQgYXMgYSBzZXBhcmF0ZSBwYXRjaCBhZnRlcndhcmRzPwoKRmlu ZSBieSBtZS4KCj4+IE1vcmUgaW1wb3J0YW50bHksIHRoaXMgZmllbGQgd2Fzbid0IGdldHRpbmcg c2V0IGJlZm9yZT8gSSBkb24ndCBzZWUgdGhhdCBpdAo+PiBnb3QgbW92ZWQgaW4gdGhpcyBkaWZm Lgo+Cj4gSHVoLiBRdWljayBncmVwIG9uIGRybS10aXAgcmV2ZWFsZWQgdGhhdCB0aGlzIHdhcyBu b3Qgc2V0LCBvbmx5IGNoZWNrZWQKPiBhZ2FpbnN0LiBHdWVzcyBpdCB3b3JrZWQgZHVlIHRvIHB1 cmUgbHVjay4KCjopIE9rYXkuIFRoaXMgb25lIHdpbGwgYmUgcmUtc3B1biB0aGVuPwoKPj4+Cj4+ PiAgCWlmIChJU19TS1lMQUtFKGRldl9wcml2KSkgewo+Pj4gLQkJZndfcGF0aCA9IEk5MTVfU0tM X0dVQ19VQ09ERTsKPj4+ICsJCWd1Yy0+ZncucGF0aCA9IEk5MTVfU0tMX0dVQ19VQ09ERTsKPj4+ ICAJCWd1Yy0+ZncubWFqb3JfdmVyX3dhbnRlZCA9IFNLTF9GV19NQUpPUjsKPj4+ICAJCWd1Yy0+ ZncubWlub3JfdmVyX3dhbnRlZCA9IFNLTF9GV19NSU5PUjsKPj4+ICAJfSBlbHNlIGlmIChJU19C Uk9YVE9OKGRldl9wcml2KSkgewo+Pj4gLQkJZndfcGF0aCA9IEk5MTVfQlhUX0dVQ19VQ09ERTsK Pj4+ICsJCWd1Yy0+ZncucGF0aCA9IEk5MTVfQlhUX0dVQ19VQ09ERTsKPj4+ICAJCWd1Yy0+Zncu bWFqb3JfdmVyX3dhbnRlZCA9IEJYVF9GV19NQUpPUjsKPj4+ICAJCWd1Yy0+ZncubWlub3JfdmVy X3dhbnRlZCA9IEJYVF9GV19NSU5PUjsKPj4+ICAJfSBlbHNlIGlmIChJU19LQUJZTEFLRShkZXZf cHJpdikpIHsKPj4+IC0JCWZ3X3BhdGggPSBJOTE1X0tCTF9HVUNfVUNPREU7Cj4+PiArCQlndWMt PmZ3LnBhdGggPSBJOTE1X0tCTF9HVUNfVUNPREU7Cj4+PiAgCQlndWMtPmZ3Lm1ham9yX3Zlcl93 YW50ZWQgPSBLQkxfRldfTUFKT1I7Cj4+PiAgCQlndWMtPmZ3Lm1pbm9yX3Zlcl93YW50ZWQgPSBL QkxfRldfTUlOT1I7Cj4+PiAgCX0gZWxzZSB7Cj4+PiAtCQlmd19wYXRoID0gIiI7CS8qIHVua25v d24gZGV2aWNlICovCj4+PiArCQlEUk1fRVJST1IoIk5vIEd1QyBmaXJtd2FyZSBrbm93biBmb3Ig cGxhdGZvcm0gd2l0aCBHdUMhXG4iKTsKPj4KPj4gUXVpY2sgZ2xhbmNlIG92ZXIgdGhlIHNlcmll cyBzdWdnZXN0cyBpbnRlbF9ndWNfaW5pdF9mdyBpcyBjYWxsZWQKPj4gdW5jb25kaXRpb25hbGx5 IGZyb20gaTkxNV9sb2FkX21vZGVzZXRfaW5pdCBtZWFuaW5nIHRoaXMgZXJyb3IgZ2V0cyBsb2dn ZWQKPj4gb24gYWxsIG5vbi1HdUMgcGxhdGZvcm1zPyBJIG11c3QgYmUgbWlzc2luZyBzb21ldGhp bmcuLgo+Cj4gaW50ZWxfdWNfaW5pdF9mdyB3aGljaCBjYWxsIHRoYXQsIHJldHVybnMgZWFybHkg aWYgIWVuYWJsZV9ndWNfbG9hZGluZy4KPgo+IGluIGludGVsX3VjX3NuaXRpemVfb3B0aW9ucygp Ogo+IAlpZiAoIUhBU19HVUMpIGVuYWJsZV9ndWNfbG9hZGluZyA9IDAKPgo+IFRoZSBmbG93IGlz IGZ1cnRoZXIgaW1wcm92ZWQgYnkgbmV4dCBwYXRjaC4KCkFoLCBJIHdhcyBmb2lsZWQgYnkgZGlm ZiBvdXRwdXQuIEl0IGlzIGRpZmZpY3VsdCB0byBmb2xsb3cgdGhpcyBzZXJpZXMgCmlmIG9uZSBp cyBub3QgMTAwJSBpbnZlc3RlZCBpbnRvIGl0LiBMb29rcyBnb29kIHRvIG1lIHRoZW4uCgpBc3N1 bWluZyB0aGUgbXlzdGVyaW91cyBmdyB0eXBlIChmdy5mdykgYXNzaWdubWVudCBpcyByZXNvbHZl ZCBvdXRzaWRlIAp0aGlzIHBhdGNoOgoKUmV2aWV3ZWQtYnk6IFR2cnRrbyBVcnN1bGluIDx0dnJ0 a28udXJzdWxpbkBpbnRlbC5jb20+CgpSZWdhcmRzLAoKVHZydGtvCl9fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCkludGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50 ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9y Zy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeAo=