From mboxrd@z Thu Jan 1 00:00:00 1970 From: Maarten Lankhorst Subject: Re: [PATCH] drm/i915: Handle changing enable_psr parameter at runtime better Date: Thu, 8 Mar 2018 08:07:54 +0100 Message-ID: References: <20180307163939.59880-1-maarten.lankhorst@linux.intel.com> <1520462797.20396.49.camel@dk-H97M-D3H> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by gabe.freedesktop.org (Postfix) with ESMTPS id 2E5026E7F0 for ; Thu, 8 Mar 2018 07:07:57 +0000 (UTC) In-Reply-To: <1520462797.20396.49.camel@dk-H97M-D3H> Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: "Pandiyan, Dhinakaran" Cc: "intel-gfx@lists.freedesktop.org" , "bberg@redhat.com" , "Vivi, Rodrigo" List-Id: intel-gfx@lists.freedesktop.org T3AgMDctMDMtMTggb20gMjM6MjIgc2NocmVlZiBQYW5kaXlhbiwgRGhpbmFrYXJhbjoKPiBPbiBX ZWQsIDIwMTgtMDMtMDcgYXQgMTc6MzkgKzAxMDAsIE1hYXJ0ZW4gTGFua2hvcnN0IHdyb3RlOgo+ PiBTaW1pbGFyIHRvIGVuYWJsZV9mYmMsIGVuYWJsZV9wc3Igd2FzIGlnbm9yZWQgYXQgcnVudGlt ZSBpZiBpdCB3YXMKPj4gY2hhbmdlZC4gVGhlIGVhc2llc3QgZml4IGlzIHRvIHByZXRlbmQgZW5h YmxlX3BzciBpcyBpZ25vcmVkIGF0Cj4+IGNvbmZpZ3VyZSB0aW1lLCBhbmQgbmV2ZXIgYWN0aXZh dGUgaXQgZm9yICFlbmFibGVfcHNyLCBzbyBib3RoIGNhc2VzCj4+IGFyZSBoYW5kbGVkIHdpdGhv dXQgbW9kZXNldHMuCj4gV2hhdCBhYm91dCBjYXNlcyB3aGVyZSBwc3JfZmx1c2goKSBpcyBub3Qg Y2FsbGVkIGFuZCBjb25zZXF1ZW50bHkgdGhlCj4gbW9kdWxlIHBhcmFtZXRlciBpcyBub3QgY2hl Y2tlZD8gV2l0aCBIVyB0cmFja2luZywgUFNSIGlzCj4gZW5hYmxlZC9kaXNhYmxlZCBkdXJpbmcg bW9kZXNldCBhbmQgdGhlIGhhcmR3YXJlIGlzIGV4cGVjdGVkIHRvIGV4aXQgYW5kCj4gYWN0aXZh dGUgUFNSIHdpdGhvdXQgZHJpdmVyIGludGVydmVudGlvbi4KSXQgbG9va3MgbGlrZSBpbnRlbF9m cm9udGJ1ZmZlcl9mbHVzaCBhbHdheXMgY2FsbHMgaW50ZWxfcHNyX2ZsdXNoLApzbyB3ZSBhdCBs ZWFzdCBnZXQgYSBQU1IgdG9nZ2xlIGFmdGVyIGV2ZXJ5IGF0b21pYyBjb21taXQ/Cgp+TWFhcnRl bgoKPj4gU2lnbmVkLW9mZi1ieTogTWFhcnRlbiBMYW5raG9yc3QgPG1hYXJ0ZW4ubGFua2hvcnN0 QGxpbnV4LmludGVsLmNvbT4KPj4gVGVzdGVkLWJ5OiBCZW5qYW1pbiBCZXJnIDxiYmVyZ0ByZWRo YXQuY29tPgo+PiBDYzogQmVuamFtaW4gQmVyZyA8YmJlcmdAcmVkaGF0LmNvbT4KPj4gLS0tCj4+ ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9wc3IuYyB8IDE5ICsrKysrKysrKystLS0tLS0t LS0KPj4gIDEgZmlsZSBjaGFuZ2VkLCAxMCBpbnNlcnRpb25zKCspLCA5IGRlbGV0aW9ucygtKQo+ Pgo+PiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfcHNyLmMgYi9kcml2 ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9wc3IuYwo+PiBpbmRleCAyMzE3NWM1YzRhNTAuLmFjM2Nl N2ExYzJhNyAxMDA2NDQKPj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfcHNyLmMK Pj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfcHNyLmMKPj4gQEAgLTUwMiwxMSAr NTAyLDYgQEAgdm9pZCBpbnRlbF9wc3JfY29tcHV0ZV9jb25maWcoc3RydWN0IGludGVsX2RwICpp bnRlbF9kcCwKPj4gIAlpZiAoIUNBTl9QU1IoZGV2X3ByaXYpKQo+PiAgCQlyZXR1cm47Cj4+ICAK Pj4gLQlpZiAoIWk5MTVfbW9kcGFyYW1zLmVuYWJsZV9wc3IpIHsKPj4gLQkJRFJNX0RFQlVHX0tN UygiUFNSIGRpc2FibGUgYnkgZmxhZ1xuIik7Cj4+IC0JCXJldHVybjsKPj4gLQl9Cj4+IC0KPj4g IAkvKgo+PiAgCSAqIEhTVyBzcGVjIGV4cGxpY2l0bHkgc2F5cyBQU1IgaXMgdGllZCB0byBwb3J0 IEEuCj4+ICAJICogQkRXKyBwbGF0Zm9ybXMgd2l0aCBEREkgaW1wbGVtZW50YXRpb24gb2YgUFNS IGhhdmUgZGlmZmVyZW50Cj4+IEBAIC01NTksNyArNTU0LDEwIEBAIHZvaWQgaW50ZWxfcHNyX2Nv bXB1dGVfY29uZmlnKHN0cnVjdCBpbnRlbF9kcCAqaW50ZWxfZHAsCj4+ICAKPj4gIAljcnRjX3N0 YXRlLT5oYXNfcHNyID0gdHJ1ZTsKPj4gIAljcnRjX3N0YXRlLT5oYXNfcHNyMiA9IGludGVsX3Bz cjJfY29uZmlnX3ZhbGlkKGludGVsX2RwLCBjcnRjX3N0YXRlKTsKPj4gLQlEUk1fREVCVUdfS01T KCJFbmFibGluZyBQU1Ilc1xuIiwgY3J0Y19zdGF0ZS0+aGFzX3BzcjIgPyAiMiIgOiAiIik7Cj4+ ICsJaWYgKGk5MTVfbW9kcGFyYW1zLmVuYWJsZV9wc3IpCj4+ICsJCURSTV9ERUJVR19LTVMoIkVu YWJsaW5nIFBTUiVzXG4iLCBjcnRjX3N0YXRlLT5oYXNfcHNyMiA/ICIyIiA6ICIiKTsKPj4gKwll bHNlCj4+ICsJCURSTV9ERUJVR19LTVMoIlBTUiBkaXNhYmxlIGJ5IGZsYWdcbiIpOwo+PiAgfQo+ PiAgCj4+ICBzdGF0aWMgdm9pZCBpbnRlbF9wc3JfYWN0aXZhdGUoc3RydWN0IGludGVsX2RwICpp bnRlbF9kcCkKPj4gQEAgLTY1Miw3ICs2NTAsOSBAQCB2b2lkIGludGVsX3Bzcl9lbmFibGUoc3Ry dWN0IGludGVsX2RwICppbnRlbF9kcCwKPj4gIAlkZXZfcHJpdi0+cHNyLmVuYWJsZV9zb3VyY2Uo aW50ZWxfZHAsIGNydGNfc3RhdGUpOwo+PiAgCWRldl9wcml2LT5wc3IuZW5hYmxlZCA9IGludGVs X2RwOwo+PiAgCj4+IC0JaWYgKElOVEVMX0dFTihkZXZfcHJpdikgPj0gOSkgewo+PiArCWlmICgh aTkxNV9tb2RwYXJhbXMuZW5hYmxlX3Bzcikgewo+PiArCQlEUk1fREVCVUdfS01TKCJQU1IgZGlz YWJsZSBieSBmbGFnXG4iKTsKPj4gKwl9IGVsc2UgaWYgKElOVEVMX0dFTihkZXZfcHJpdikgPj0g OSkgewo+PiAgCQlpbnRlbF9wc3JfYWN0aXZhdGUoaW50ZWxfZHApOwo+PiAgCX0gZWxzZSB7Cj4+ ICAJCS8qCj4+IEBAIC04NDMsNyArODQzLDcgQEAgc3RhdGljIHZvaWQgaW50ZWxfcHNyX3dvcmso c3RydWN0IHdvcmtfc3RydWN0ICp3b3JrKQo+PiAgCSAqIHJlY2hlY2suIFNpbmNlIHBzcl9mbHVz aCBmaXJzdCBjbGVhcnMgdGhpcyBhbmQgdGhlbiByZXNjaGVkdWxlcyB3ZQo+PiAgCSAqIHdvbid0 IGV2ZXIgbWlzcyBhIGZsdXNoIHdoZW4gYmFpbGluZyBvdXQgaGVyZS4KPj4gIAkgKi8KPj4gLQlp ZiAoZGV2X3ByaXYtPnBzci5idXN5X2Zyb250YnVmZmVyX2JpdHMpCj4+ICsJaWYgKGRldl9wcml2 LT5wc3IuYnVzeV9mcm9udGJ1ZmZlcl9iaXRzIHx8ICFpOTE1X21vZHBhcmFtcy5lbmFibGVfcHNy KQo+PiAgCQlnb3RvIHVubG9jazsKPj4gIAo+PiAgCWludGVsX3Bzcl9hY3RpdmF0ZShpbnRlbF9k cCk7Cj4+IEBAIC0xMDE1LDcgKzEwMTUsOCBAQCB2b2lkIGludGVsX3Bzcl9mbHVzaChzdHJ1Y3Qg ZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYsCj4+ICAJCXJldHVybjsKPj4gIAo+PiAgCW11dGV4 X2xvY2soJmRldl9wcml2LT5wc3IubG9jayk7Cj4+IC0JaWYgKCFkZXZfcHJpdi0+cHNyLmVuYWJs ZWQpIHsKPj4gKwlpZiAoIWRldl9wcml2LT5wc3IuZW5hYmxlZCB8fCAhaTkxNV9tb2RwYXJhbXMu ZW5hYmxlX3Bzcikgewo+PiArCQlpbnRlbF9wc3JfZXhpdChkZXZfcHJpdik7Cj4+ICAJCW11dGV4 X3VubG9jaygmZGV2X3ByaXYtPnBzci5sb2NrKTsKPj4gIAkJcmV0dXJuOwo+PiAgCX0KCgpfX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJbnRlbC1nZnggbWFp bGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5m cmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK