Re: [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [v5,01/13] fbdev: Add Kconfig options to select different fb_ops helpers

Thomas Zimmermann
2023-05-31T07:19:19Z

[-- Attachment #1.1: Type: text/plain, Size: 5061 bytes --]

These warnings are expected, but invalid.

Am 31.05.23 um 09:12 schrieb Patchwork:
> == Series Details ==
>
> Series: series starting with [v5,01/13] fbdev: Add Kconfig options to select different fb_ops helpers
> URL : https://patchwork.freedesktop.org/series/118574/
> State : warning
>
> == Summary ==
>
> Error: dim checkpatch failed
> d99c025b8fad fbdev: Add Kconfig options to select different fb_ops helpers
> 305b772ca6c4 fbdev: Add initializer macros for struct fb_ops
> -:50: ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
> #50: FILE: include/linux/fb.h:557:
> +#define FB_DEFAULT_IO_OPS \
> + __FB_DEFAULT_IO_OPS_RDWR, \
> + __FB_DEFAULT_IO_OPS_DRAW, \
> + __FB_DEFAULT_IO_OPS_MMAP
>
> -:82: ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
> #82: FILE: include/linux/fb.h:590:
> +#define FB_DEFAULT_SYS_OPS \
> + __FB_DEFAULT_SYS_OPS_RDWR, \
> + __FB_DEFAULT_SYS_OPS_DRAW, \
> + __FB_DEFAULT_SYS_OPS_MMAP
>
> -:114: CHECK:MACRO_ARG_REUSE: Macro argument reuse '__damage_area' - possible side-effects?
> #114: FILE: include/linux/fb.h:670:
> +#define __FB_GEN_DEFAULT_DEFERRED_OPS_DRAW(__prefix, __damage_area, __mode) \
> + static void __prefix ## _defio_fillrect(struct fb_info *info, \
> + const struct fb_fillrect *rect) \
> + { \
> + __mode ## _fillrect(info, rect); \
> + __damage_area(info, rect->dx, rect->dy, rect->width, rect->height); \
> + } \
> + static void __prefix ## _defio_copyarea(struct fb_info *info, \
> + const struct fb_copyarea *area) \
> + { \
> + __mode ## _copyarea(info, area); \
> + __damage_area(info, area->dx, area->dy, area->width, area->height); \
> + } \
> + static void __prefix ## _defio_imageblit(struct fb_info *info, \
> + const struct fb_image *image) \
> + { \
> + __mode ## _imageblit(info, image); \
> + __damage_area(info, image->dx, image->dy, image->width, image->height); \
> + }
>
> -:134: ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
> #134: FILE: include/linux/fb.h:690:
> +#define FB_GEN_DEFAULT_DEFERRED_IO_OPS(__prefix, __damage_range, __damage_area) \
> + __FB_GEN_DEFAULT_DEFERRED_OPS_RDWR(__prefix, __damage_range, io) \
> + __FB_GEN_DEFAULT_DEFERRED_OPS_DRAW(__prefix, __damage_area, cfb)
>
> -:134: CHECK:MACRO_ARG_REUSE: Macro argument reuse '__prefix' - possible side-effects?
> #134: FILE: include/linux/fb.h:690:
> +#define FB_GEN_DEFAULT_DEFERRED_IO_OPS(__prefix, __damage_range, __damage_area) \
> + __FB_GEN_DEFAULT_DEFERRED_OPS_RDWR(__prefix, __damage_range, io) \
> + __FB_GEN_DEFAULT_DEFERRED_OPS_DRAW(__prefix, __damage_area, cfb)
>
> -:138: ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
> #138: FILE: include/linux/fb.h:694:
> +#define FB_GEN_DEFAULT_DEFERRED_SYS_OPS(__prefix, __damage_range, __damage_area) \
> + __FB_GEN_DEFAULT_DEFERRED_OPS_RDWR(__prefix, __damage_range, sys) \
> + __FB_GEN_DEFAULT_DEFERRED_OPS_DRAW(__prefix, __damage_area, sys)
>
> -:138: CHECK:MACRO_ARG_REUSE: Macro argument reuse '__prefix' - possible side-effects?
> #138: FILE: include/linux/fb.h:694:
> +#define FB_GEN_DEFAULT_DEFERRED_SYS_OPS(__prefix, __damage_range, __damage_area) \
> + __FB_GEN_DEFAULT_DEFERRED_OPS_RDWR(__prefix, __damage_range, sys) \
> + __FB_GEN_DEFAULT_DEFERRED_OPS_DRAW(__prefix, __damage_area, sys)
>
> -:158: ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
> #158: FILE: include/linux/fb.h:714:
> +#define FB_DEFAULT_DEFERRED_OPS(__prefix) \
> + __FB_DEFAULT_DEFERRED_OPS_RDWR(__prefix), \
> + __FB_DEFAULT_DEFERRED_OPS_DRAW(__prefix), \
> + __FB_DEFAULT_DEFERRED_OPS_MMAP(__prefix)
>
> -:158: CHECK:MACRO_ARG_REUSE: Macro argument reuse '__prefix' - possible side-effects?
> #158: FILE: include/linux/fb.h:714:
> +#define FB_DEFAULT_DEFERRED_OPS(__prefix) \
> + __FB_DEFAULT_DEFERRED_OPS_RDWR(__prefix), \
> + __FB_DEFAULT_DEFERRED_OPS_DRAW(__prefix), \
> + __FB_DEFAULT_DEFERRED_OPS_MMAP(__prefix)
>
> total: 5 errors, 0 warnings, 4 checks, 133 lines checked
> 8cf81153d9be drm/armada: Use regular fbdev I/O helpers
> ae8753bfd372 drm/exynos: Use regular fbdev I/O helpers
> 85594d867943 drm/gma500: Use regular fbdev I/O helpers
> 580f4398003e drm/radeon: Use regular fbdev I/O helpers
> b93785cdb74b drm/fbdev-dma: Use regular fbdev I/O helpers
> f2d84d66e5d2 drm/omapdrm: Use regular fbdev I/O helpers
> dc9598d0aa4a drm/tegra: Use regular fbdev I/O helpers
> 641517a16a6d drm/fb-helper: Export helpers for marking damage areas
> aea558947b7a drm/msm: Use regular fbdev I/O helpers
> 8632dc90593a drm/fbdev-generic: Implement dedicated fbdev I/O helpers
> f7a0a9d697f2 drm/i915: Implement dedicated fbdev I/O helpers
>
>

--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Frankenstrasse 146, 90461 Nuernberg, Germany
GF: Ivo Totev, Andrew Myers, Andrew McDonald, Boudien Moerman
HRB 36809 (AG Nuernberg)

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 840 bytes --]