From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,HK_RANDOM_FROM,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 35547C2D0E4 for ; Tue, 24 Nov 2020 17:19:32 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9FD7C205CA for ; Tue, 24 Nov 2020 17:19:31 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9FD7C205CA Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=intel-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id E3E4389BF6; Tue, 24 Nov 2020 17:19:30 +0000 (UTC) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by gabe.freedesktop.org (Postfix) with ESMTPS id 4831189BF6 for ; Tue, 24 Nov 2020 17:19:29 +0000 (UTC) IronPort-SDR: wDNEnnHodqXfnZzObTT/vEz58b1ZV9Br2a1F4AvGOwAsWPHmnjxJb4oXN28YvVYk2879Hg1rdd 3dP/c27Yrb5g== X-IronPort-AV: E=McAfee;i="6000,8403,9815"; a="159026377" X-IronPort-AV: E=Sophos;i="5.78,366,1599548400"; d="scan'208";a="159026377" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Nov 2020 09:19:28 -0800 IronPort-SDR: i4vLJ4usttF8TzGGOrrAHurNrmuv6Of3nm86S9fdY9+OUnXtCea+H3fpX3F2n/G20rXWR8QWGn +P6/b3EXNPBw== X-IronPort-AV: E=Sophos;i="5.78,366,1599548400"; d="scan'208";a="546911843" Received: from ipilchin-mobl1.ger.corp.intel.com (HELO [10.254.159.60]) ([10.254.159.60]) by orsmga005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Nov 2020 09:19:26 -0800 To: Chris Wilson , intel-gfx@lists.freedesktop.org References: <20201124114219.29020-1-chris@chris-wilson.co.uk> <20201124114219.29020-7-chris@chris-wilson.co.uk> From: Tvrtko Ursulin Organization: Intel Corporation UK Plc Message-ID: Date: Tue, 24 Nov 2020 17:19:23 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20201124114219.29020-7-chris@chris-wilson.co.uk> Content-Language: en-US Subject: Re: [Intel-gfx] [PATCH 07/16] drm/i915/gt: Check for a completed last request once X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On 24/11/2020 11:42, Chris Wilson wrote: > Pull the repeated check for the last active request being completed to a > single spot, when deciding whether or not execlist preemption is > required. > > Signed-off-by: Chris Wilson > --- > drivers/gpu/drm/i915/gt/intel_lrc.c | 15 ++++----------- > 1 file changed, 4 insertions(+), 11 deletions(-) > > diff --git a/drivers/gpu/drm/i915/gt/intel_lrc.c b/drivers/gpu/drm/i915/gt/intel_lrc.c > index cf11cbac241b..43703efb36d1 100644 > --- a/drivers/gpu/drm/i915/gt/intel_lrc.c > +++ b/drivers/gpu/drm/i915/gt/intel_lrc.c > @@ -2141,12 +2141,9 @@ static void execlists_dequeue(struct intel_engine_cs *engine) > */ > > if ((last = *active)) { > - if (need_preempt(engine, last, rb)) { > - if (i915_request_completed(last)) { > - tasklet_hi_schedule(&execlists->tasklet); > - return; > - } > - > + if (i915_request_completed(last)) { > + goto check_secondary; > + } else if (need_preempt(engine, last, rb)) { > ENGINE_TRACE(engine, > "preempting last=%llx:%lld, prio=%d, hint=%d\n", > last->fence.context, > @@ -2174,11 +2171,6 @@ static void execlists_dequeue(struct intel_engine_cs *engine) > last = NULL; > } else if (need_timeslice(engine, last, rb) && > timeslice_expired(execlists, last)) { > - if (i915_request_completed(last)) { > - tasklet_hi_schedule(&execlists->tasklet); > - return; > - } > - > ENGINE_TRACE(engine, > "expired last=%llx:%lld, prio=%d, hint=%d, yield?=%s\n", > last->fence.context, > @@ -2214,6 +2206,7 @@ static void execlists_dequeue(struct intel_engine_cs *engine) > * we hopefully coalesce several updates into a single > * submission. > */ > +check_secondary: > if (!list_is_last(&last->sched.link, > &engine->active.requests)) { Is there a tasklet_hi_schedule in here? I see set_timeslice in my checkout. Regards, Tvrtko > /* > _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx