From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tvrtko Ursulin Subject: Re: [PATCH] drm/i915: Avoid uninterruptible spinning in debugfs Date: Fri, 1 Feb 2019 17:29:45 +0000 Message-ID: References: <20190201102248.15144-1-chris@chris-wilson.co.uk> <20190201105237.12663-1-chris@chris-wilson.co.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by gabe.freedesktop.org (Postfix) with ESMTPS id 40F7B6E2E4 for ; Fri, 1 Feb 2019 17:29:39 +0000 (UTC) In-Reply-To: <20190201105237.12663-1-chris@chris-wilson.co.uk> Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org Ck9uIDAxLzAyLzIwMTkgMTA6NTIsIENocmlzIFdpbHNvbiB3cm90ZToKPiBJZiB3ZSBnZXQgY2F1 Z2h0IGluIGEga2VybmVsIGJ1Zywgd2UgbWF5IG5ldmVyIGlkbGUuIExldCB0aGUgdXNlciByZWdh aW4KPiBjb250cm9sIG9mIHRoZWlyIHN5c3RlbV5XdGVybWluYWwgYnkgcmVzcG9uZGluZyB0byBT SUdJTlQhCj4gCj4gdjI6IFB1c2ggdGhlIHNpZ25hbCBjaGVja2luZyBpbnRvIHRoZSBsb29wIGFy b3VuZCBmbHVzaF93b3JrLgo+IAo+IFJlcG9ydGVkLWJ5OiBUdnJ0a28gVXJzdWxpbiA8dHZydGtv LnVyc3VsaW5AaW50ZWwuY29tPgo+IFNpZ25lZC1vZmYtYnk6IENocmlzIFdpbHNvbiA8Y2hyaXNA Y2hyaXMtd2lsc29uLmNvLnVrPgo+IENjOiBUdnJ0a28gVXJzdWxpbiA8dHZydGtvLnVyc3VsaW5A aW50ZWwuY29tPgo+IC0tLQo+ICAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9kZWJ1Z2ZzLmMg ICAgICAgICAgICB8IDE0ICsrKysrKysrLS0tLS0tCj4gICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9p OTE1X2dlbS5jICAgICAgICAgICAgICAgIHwgMTAgKysrKysrKy0tLQo+ICAgZHJpdmVycy9ncHUv ZHJtL2k5MTUvaTkxNV91dGlscy5oICAgICAgICAgICAgICB8IDE4ICsrKysrKysrKysrKysrKy0t LQo+ICAgLi4uL2dwdS9kcm0vaTkxNS9zZWxmdGVzdHMvaTkxNV9nZW1fY29udGV4dC5jICB8ICA1 ICsrKystCj4gICA0IGZpbGVzIGNoYW5nZWQsIDM0IGluc2VydGlvbnMoKyksIDEzIGRlbGV0aW9u cygtKQo+IAo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2RlYnVnZnMu YyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZGVidWdmcy5jCj4gaW5kZXggZjNmYTMxZDg0 MGY1Li40NGZhMzRmNGViYmMgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkx NV9kZWJ1Z2ZzLmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2RlYnVnZnMuYwo+ IEBAIC0zOTQ1LDEyICszOTQ1LDE0IEBAIGk5MTVfZHJvcF9jYWNoZXNfc2V0KHZvaWQgKmRhdGEs IHU2NCB2YWwpCj4gICAJCWk5MTVfZ2VtX3Nocmlua19hbGwoaTkxNSk7Cj4gICAJZnNfcmVjbGFp bV9yZWxlYXNlKEdGUF9LRVJORUwpOwo+ICAgCj4gLQlpZiAodmFsICYgRFJPUF9JRExFKSB7Cj4g LQkJZG8gewo+IC0JCQlpZiAoUkVBRF9PTkNFKGk5MTUtPmd0LmFjdGl2ZV9yZXF1ZXN0cykpCj4g LQkJCQlmbHVzaF9kZWxheWVkX3dvcmsoJmk5MTUtPmd0LnJldGlyZV93b3JrKTsKPiAtCQkJZHJh aW5fZGVsYXllZF93b3JrKCZpOTE1LT5ndC5pZGxlX3dvcmspOwo+IC0JCX0gd2hpbGUgKFJFQURf T05DRShpOTE1LT5ndC5hd2FrZSkpOwo+ICsJaWYgKHZhbCAmIERST1BfSURMRSAmJiBSRUFEX09O Q0UoaTkxNS0+Z3QuYXdha2UpKSB7Cj4gKwkJaWYgKGRyYWluX2RlbGF5ZWRfd29ya19zdGF0ZSgm aTkxNS0+Z3QucmV0aXJlX3dvcmssCj4gKwkJCQkJICAgICBUQVNLX0lOVEVSUlVQVElCTEUpIHx8 Cj4gKwkJICAgIGRyYWluX2RlbGF5ZWRfd29ya19zdGF0ZSgmaTkxNS0+Z3QuaWRsZV93b3JrLAo+ ICsJCQkJCSAgICAgVEFTS19JTlRFUlJVUFRJQkxFKSkgewo+ICsJCQlyZXQgPSAtRUlOVFI7Cj4g KwkJCWdvdG8gb3V0Owo+ICsJCX0KClNocmlua2VyIHJlbWFpbnMgb25seSBraWxsYWJsZSBzbyBz dGlsbCBub3QgQ3RybC1DIGluIGFsbCBjYXNlcyBoZXJlLiAKRG9uJ3Qga25vdywgbm90IGhvdCBu b3QgY29sZC4gV2lsbCByZS10aGluayBpdCBuZXh0IHdlZWsuCgo+ICAgCX0KPiAgIAo+ICAgCWlm ICh2YWwgJiBEUk9QX0ZSRUVEKQo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9p OTE1X2dlbS5jIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9nZW0uYwo+IGluZGV4IDQwNjdl ZWFlZTc4YS4uZTQ3ZDUzZTliNjM0IDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1 L2k5MTVfZ2VtLmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2dlbS5jCj4gQEAg LTQ0OTksMTMgKzQ0OTksMTcgQEAgaW50IGk5MTVfZ2VtX3N1c3BlbmQoc3RydWN0IGRybV9pOTE1 X3ByaXZhdGUgKmk5MTUpCj4gICAJbXV0ZXhfdW5sb2NrKCZpOTE1LT5kcm0uc3RydWN0X211dGV4 KTsKPiAgIAlpOTE1X3Jlc2V0X2ZsdXNoKGk5MTUpOwo+ICAgCj4gLQlkcmFpbl9kZWxheWVkX3dv cmsoJmk5MTUtPmd0LnJldGlyZV93b3JrKTsKPiAtCj4gICAJLyoKPiAgIAkgKiBBcyB0aGUgaWRs ZV93b3JrIGlzIHJlYXJtaW5nIGlmIGl0IGRldGVjdHMgYSByYWNlLCBwbGF5IHNhZmUgYW5kCj4g ICAJICogcmVwZWF0IHRoZSBmbHVzaCB1bnRpbCBpdCBpcyBkZWZpbml0ZWx5IGlkbGUuCj4gICAJ ICovCj4gLQlkcmFpbl9kZWxheWVkX3dvcmsoJmk5MTUtPmd0LmlkbGVfd29yayk7Cj4gKwlpZiAo ZHJhaW5fZGVsYXllZF93b3JrX3N0YXRlKCZpOTE1LT5ndC5yZXRpcmVfd29yaywKPiArCQkJCSAg ICAgVEFTS19JTlRFUlJVUFRJQkxFKSB8fAo+ICsJICAgIGRyYWluX2RlbGF5ZWRfd29ya19zdGF0 ZSgmaTkxNS0+Z3QuaWRsZV93b3JrLAo+ICsJCQkJICAgICBUQVNLX0lOVEVSUlVQVElCTEUpKSB7 Cj4gKwkJcmV0ID0gLUVJTlRSOwo+ICsJCWdvdG8gZXJyX3VubG9jazsKPiArCX0KCkknbSBubyBz dXNwZW5kIGV4cGVydCBidXQgaXQgc291bmRzIHVuZXhwZWN0ZWQgdGhlcmUgd291bGQgYmUgc2ln bmFscyAKaW52b2x2ZWQgaW4gdGhlIHByb2Nlc3MuIERvZXMgaXQgaGF2ZSBhbiB1c2Vyc3BhY2Ug Y29tcG9uZW50PyBXZSBkb24ndCAKYm90aGVyIHdpdGggaW50ZXJydXB0aWJsZSBtdXRleCBvbiB0 aGlzIHBhdGggZWl0aGVyLgoKPiAgIAo+ICAgCS8qCj4gICAJICogQXNzZXJ0IHRoYXQgd2Ugc3Vj Y2Vzc2Z1bGx5IGZsdXNoZWQgYWxsIHRoZSB3b3JrIGFuZAo+IGRpZmYgLS1naXQgYS9kcml2ZXJz L2dwdS9kcm0vaTkxNS9pOTE1X3V0aWxzLmggYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X3V0 aWxzLmgKPiBpbmRleCBmY2M3NTFhYTFlYTguLjY4NjZiODVlNDIzOSAxMDA2NDQKPiAtLS0gYS9k cml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X3V0aWxzLmgKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0v aTkxNS9pOTE1X3V0aWxzLmgKPiBAQCAtMjUsNiArMjUsOCBAQAo+ICAgI2lmbmRlZiBfX0k5MTVf VVRJTFNfSAo+ICAgI2RlZmluZSBfX0k5MTVfVVRJTFNfSAo+ICAgCj4gKyNpbmNsdWRlIDxsaW51 eC9zY2hlZC9zaWduYWwuaD4KPiArCj4gICAjdW5kZWYgV0FSTl9PTgo+ICAgLyogTWFueSBnY2Mg c2VlbSB0byBubyBzZWUgdGhyb3VnaCB0aGlzIGFuZCBmYWxsIG92ZXIgOiggKi8KPiAgICNpZiAw Cj4gQEAgLTE0OCwxMiArMTUwLDIyIEBAIHN0YXRpYyBpbmxpbmUgdm9pZCBfX2xpc3RfZGVsX21h bnkoc3RydWN0IGxpc3RfaGVhZCAqaGVhZCwKPiAgICAqIGJ5IHJlcXVldWVpbmcgaXRzZWxmLiBO b3RlLCB0aGF0IGlmIHRoZSB3b3JrZXIgbmV2ZXIgY2FuY2VscyBpdHNlbGYsCj4gICAgKiB3ZSB3 aWxsIHNwaW4gZm9yZXZlci4KPiAgICAqLwo+IC1zdGF0aWMgaW5saW5lIHZvaWQgZHJhaW5fZGVs YXllZF93b3JrKHN0cnVjdCBkZWxheWVkX3dvcmsgKmR3KQo+ICsKPiArc3RhdGljIGlubGluZSBp bnQgZHJhaW5fZGVsYXllZF93b3JrX3N0YXRlKHN0cnVjdCBkZWxheWVkX3dvcmsgKmR3LCBpbnQg c3RhdGUpCj4gICB7Cj4gICAJZG8gewo+IC0JCXdoaWxlIChmbHVzaF9kZWxheWVkX3dvcmsoZHcp KQo+IC0JCQk7Cj4gKwkJZG8gewo+ICsJCQlpZiAoc2lnbmFsX3BlbmRpbmdfc3RhdGUoc3RhdGUs IGN1cnJlbnQpKQo+ICsJCQkJcmV0dXJuIC1FSU5UUjsKPiArCQl9IHdoaWxlIChmbHVzaF9kZWxh eWVkX3dvcmsoZHcpKTsKPiAgIAl9IHdoaWxlIChkZWxheWVkX3dvcmtfcGVuZGluZyhkdykpOwo+ ICsKPiArCXJldHVybiAwOwo+ICt9Cj4gKwo+ICtzdGF0aWMgaW5saW5lIHZvaWQgZHJhaW5fZGVs YXllZF93b3JrKHN0cnVjdCBkZWxheWVkX3dvcmsgKmR3KQo+ICt7Cj4gKwlkcmFpbl9kZWxheWVk X3dvcmtfc3RhdGUoZHcsIDApOwoKMCB3b3VsZCBiZSBUQVNLX1JVTk5JTkcuIHNpZ25hbF9wZW5k aW5nX3N0YXRlIGJhaWxzIG91dCBpbiB0aGlzIGNhc2Ugc28gCnRoYXQncyBnb29kLgoKPiAgIH0K PiAgIAo+ICAgc3RhdGljIGlubGluZSBjb25zdCBjaGFyICp5ZXNubyhib29sIHYpCj4gZGlmZiAt LWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L3NlbGZ0ZXN0cy9pOTE1X2dlbV9jb250ZXh0LmMg Yi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9zZWxmdGVzdHMvaTkxNV9nZW1fY29udGV4dC5jCj4gaW5k ZXggMmI0MjMxMjgwMDJjLi5hODc5OThiOTBiZjYgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUv ZHJtL2k5MTUvc2VsZnRlc3RzL2k5MTVfZ2VtX2NvbnRleHQuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1 L2RybS9pOTE1L3NlbGZ0ZXN0cy9pOTE1X2dlbV9jb250ZXh0LmMKPiBAQCAtMTY4Niw4ICsxNjg2 LDExIEBAIHN0YXRpYyBpbnQgX19pZ3Rfc3dpdGNoX3RvX2tlcm5lbF9jb250ZXh0KHN0cnVjdCBk cm1faTkxNV9wcml2YXRlICppOTE1LAo+ICAgCQkvKiBYWFggQm9udXMgcG9pbnRzIGZvciBwcm92 aW5nIHdlIGFyZSB0aGUga2VybmVsIGNvbnRleHQhICovCj4gICAKPiAgIAkJbXV0ZXhfdW5sb2Nr KCZpOTE1LT5kcm0uc3RydWN0X211dGV4KTsKPiAtCQlkcmFpbl9kZWxheWVkX3dvcmsoJmk5MTUt Pmd0LmlkbGVfd29yayk7Cj4gKwkJZXJyID0gZHJhaW5fZGVsYXllZF93b3JrX3N0YXRlKCZpOTE1 LT5ndC5pZGxlX3dvcmssCj4gKwkJCQkJICAgICAgIFRBU0tfS0lMTEFCTEUpOwo+ICAgCQltdXRl eF9sb2NrKCZpOTE1LT5kcm0uc3RydWN0X211dGV4KTsKPiArCQlpZiAoZXJyKQo+ICsJCQlyZXR1 cm4gLUVJTlRSOwo+ICAgCX0KPiAgIAo+ICAgCWlmIChpZ3RfZmx1c2hfdGVzdChpOTE1LCBJOTE1 X1dBSVRfTE9DS0VEKSkKPiAKClJlZ2FyZHMsCgpUdnJ0a28KX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1n ZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21h aWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cg==