From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4C56BCA1005 for ; Tue, 2 Sep 2025 13:58:11 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id E909710E731; Tue, 2 Sep 2025 13:58:10 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="WhL/vREN"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.14]) by gabe.freedesktop.org (Postfix) with ESMTPS id 43B8E10E72C; Tue, 2 Sep 2025 13:58:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1756821489; x=1788357489; h=from:to:cc:subject:in-reply-to:references:date: message-id:mime-version:content-transfer-encoding; bh=gxtznO8F4JCpV4KfWZmTjP58Lv4IaUYSH4BShpRmKNg=; b=WhL/vRENY9jQ7ctv1+xnBAiz9niyfZQMTAq1TTgHDKnUf4Bv/y2MCDTZ RHpdkXJ5hNU3GofA/wb+KgdQtdHARKaVnqLYIwDRQJBNTHlW284WPR6rS /ghauwZyyVoQ3iByPmI+lQMJeFxL/SGUKNaFUZ1GgRjhV0SEMPZPqL9J4 3XbwfbjEGXY1U8ijShOcasrLY09Fv2A5tvKjXhrthlYhu6ZLb8fnd7/gi WZII6bHPaeZVtj96WMJZ/t/yWYwPbKJBMjPUA8ZgxWHRtsH/B0yr/ShNI JBHHSV+jHQsuBvxSoy9fbHsIiL3P0jim1HYhjdw68WwOFjZig81G7u/Ru Q==; X-CSE-ConnectionGUID: UukJLV3iRKSFyHN9iL1Ptw== X-CSE-MsgGUID: GsDqZaF+RLWCgWRQx4wvVQ== X-IronPort-AV: E=McAfee;i="6800,10657,11541"; a="59165079" X-IronPort-AV: E=Sophos;i="6.18,230,1751266800"; d="scan'208";a="59165079" Received: from orviesa008.jf.intel.com ([10.64.159.148]) by fmvoesa108.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Sep 2025 06:58:09 -0700 X-CSE-ConnectionGUID: bPf1wchLSQez3+tfThfbiQ== X-CSE-MsgGUID: asib05qiS4qppkXFkGybkg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.18,230,1751266800"; d="scan'208";a="171443376" Received: from dhhellew-desk2.ger.corp.intel.com (HELO localhost) ([10.245.246.193]) by orviesa008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Sep 2025 06:58:07 -0700 From: Jani Nikula To: Ville Syrjala , intel-gfx@lists.freedesktop.org Cc: intel-xe@lists.freedesktop.org Subject: Re: [PATCH 6/8] drm/i915/dram: Fix some spelling aroynd the 16Gb DIMM w/a In-Reply-To: <20250902133113.18778-7-ville.syrjala@linux.intel.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: <20250902133113.18778-1-ville.syrjala@linux.intel.com> <20250902133113.18778-7-ville.syrjala@linux.intel.com> Date: Tue, 02 Sep 2025 16:58:03 +0300 Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Tue, 02 Sep 2025, Ville Syrjala wrote: > From: Ville Syrj=C3=A4l=C3=A4 > > Use consistent spelling when talking about the 16Gb DIMM w/a. > > Even currently language is a bit off as the w/a is actually > about DIMMs with 16Gb DRAM devices on them, not the total capacity > of the whole DIMM. But this language does more or less match how > Bspec talks about this stuff. > > Signed-off-by: Ville Syrj=C3=A4l=C3=A4 Personally, I usually prefer a space between the value and the unit, i.e. "16 Gb" but that's neither here nor there. Reviewed-by: Jani Nikula > --- > drivers/gpu/drm/i915/display/skl_watermark.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/i915/display/skl_watermark.c b/drivers/gpu/d= rm/i915/display/skl_watermark.c > index ae3ce0d65cfc..0b9c86042e78 100644 > --- a/drivers/gpu/drm/i915/display/skl_watermark.c > +++ b/drivers/gpu/drm/i915/display/skl_watermark.c > @@ -3209,9 +3209,9 @@ adjust_wm_latency(struct intel_display *display, > } >=20=20 > /* > - * WA Level-0 adjustment for 16GB DIMMs: SKL+ > + * WA Level-0 adjustment for 16Gb DIMMs: SKL+ > * If we could not get dimm info enable this WA to prevent from > - * any underrun. If not able to get Dimm info assume 16GB dimm > + * any underrun. If not able to get DIMM info assume 16Gb DIMM > * to avoid any underrun. > */ > if (!display->platform.dg2 && dram_info->has_16gb_dimms) --=20 Jani Nikula, Intel