From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, HK_RANDOM_FROM,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E66B0C433DF for ; Mon, 6 Jul 2020 15:47:07 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B9A8420720 for ; Mon, 6 Jul 2020 15:47:07 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B9A8420720 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=intel-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 54DCA89E5A; Mon, 6 Jul 2020 15:47:07 +0000 (UTC) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by gabe.freedesktop.org (Postfix) with ESMTPS id DE84E89FEA for ; Mon, 6 Jul 2020 15:47:05 +0000 (UTC) IronPort-SDR: 1AKQWS5lK/rn9/+/mL1fG8LxEGd4gkoTC3IPrqepaq5GdeAfGKt47Nm+F+FMI3JYt/bNQyPHqW Fh+JO1ebUEsw== X-IronPort-AV: E=McAfee;i="6000,8403,9673"; a="135687828" X-IronPort-AV: E=Sophos;i="5.75,320,1589266800"; d="scan'208";a="135687828" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Jul 2020 08:47:04 -0700 IronPort-SDR: JmdWsvuMPQ1H3etJ3G50VbHD07jYnF9uBwOxMBO9x5LTKUBthe8EHX6gg0C8xVbkCzZVtPVS2s 2TU6FjtxBvKw== X-IronPort-AV: E=Sophos;i="5.75,320,1589266800"; d="scan'208";a="456775566" Received: from rrodrig1-mobl.ger.corp.intel.com (HELO [10.249.45.109]) ([10.249.45.109]) by orsmga005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Jul 2020 08:47:03 -0700 To: Maarten Lankhorst , intel-gfx@lists.freedesktop.org References: <20200703122221.591656-1-maarten.lankhorst@linux.intel.com> <20200703122221.591656-7-maarten.lankhorst@linux.intel.com> <77d31489-33f1-c025-aa3c-bfe3d70a0e54@linux.intel.com> <756b6b1a-97f5-4676-65f3-4e1430945ccf@linux.intel.com> From: Tvrtko Ursulin Organization: Intel Corporation UK Plc Message-ID: Date: Mon, 6 Jul 2020 16:47:00 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.8.0 MIME-Version: 1.0 In-Reply-To: <756b6b1a-97f5-4676-65f3-4e1430945ccf@linux.intel.com> Content-Language: en-US Subject: Re: [Intel-gfx] [PATCH 06/23] drm/i915: Parse command buffer earlier in eb_relocate(slow) X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On 06/07/2020 13:53, Maarten Lankhorst wrote: > Op 03-07-2020 om 15:49 schreef Tvrtko Ursulin: >> >> On 03/07/2020 13:22, Maarten Lankhorst wrote: >>> We want to introduce backoff logic, but we need to lock the >>> pool object as well for command parsing. Because of this, we >>> will need backoff logic for the engine pool obj, move the batch >>> validation up slightly to eb_lookup_vmas, and the actual command >>> parsing in a separate function which can get called from execbuf >>> relocation fast and slowpath. >> >> On this one I also had some feedback in the previous round which you maybe missed. >> >> Regards, > Compile tested this one now, so should work. :) Cool. And what about the other comments I had? More splitting of logical steps (lookup/validate/parse/whatever)? Working on removing the reverts and making eb_relocate_parse_slow have less than 11 gotos and 4-5 labels (by the end of the series) is out the question? Removing the "dirty hack" as well later in the series? It would be really nice if you could also scan through Chris' idea. I particularly like how he manages to do it without needing to touch execlists and context handling (less invasiness should help us). But I haven't studied his series fully yet, to understand all the details. So it would be good to join forces there as well. Regards, Tvrtko _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx