From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B2E62C43334 for ; Wed, 29 Jun 2022 16:22:58 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 8D9AD10EA3D; Wed, 29 Jun 2022 16:22:53 +0000 (UTC) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by gabe.freedesktop.org (Postfix) with ESMTPS id E4C7B10EA00; Wed, 29 Jun 2022 16:22:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1656519772; x=1688055772; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=MVm+vlf7U7Q6NUkd2sQEP4K2cGYqOvBsVc6FZW4xPwU=; b=M0a0MgvAQRI8GAoPy/etFfyhshHPQb2XQNMK1CmGU6o2+k5wU9uyU4qO 5c6HQaVvRrmHv0vscyAzqOBmKvPqAgig9q47chNCdc8gzbQvOe/ZP+bm7 ccuQULViL3UcNC3emCUzXh66a/q+RKm+yedFhMYK9XJNDGkU5XgOrdRze aqRIoGnb/WAb77dIEs18OXTt6nRkhbwjCPDor0De98+XjPJCQWoEpdFcu MhPYmhkryagdAsly/dZB4TeNFfAFxCqORgJBD1J9e6pNq536drna5T2Kn oTCI0/MKcuvAi4fAm5gnNyY0id5eU1g/OO6ptYUHyR61tsX5zPmy806kf g==; X-IronPort-AV: E=McAfee;i="6400,9594,10393"; a="282810312" X-IronPort-AV: E=Sophos;i="5.92,231,1650956400"; d="scan'208";a="282810312" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Jun 2022 09:22:50 -0700 X-IronPort-AV: E=Sophos;i="5.92,231,1650956400"; d="scan'208";a="647466857" Received: from kjeldbeg-mobl2.ger.corp.intel.com (HELO [10.249.254.56]) ([10.249.254.56]) by fmsmga008-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Jun 2022 09:22:47 -0700 Message-ID: Date: Wed, 29 Jun 2022 18:22:46 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Content-Language: en-US To: Matthew Auld , intel-gfx@lists.freedesktop.org References: <20220629121427.353800-1-matthew.auld@intel.com> <20220629121427.353800-10-matthew.auld@intel.com> From: =?UTF-8?Q?Thomas_Hellstr=c3=b6m?= In-Reply-To: <20220629121427.353800-10-matthew.auld@intel.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Subject: Re: [Intel-gfx] [PATCH v3 09/13] drm/i915/selftests: skip the mman tests for stolen X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kenneth Graunke , dri-devel@lists.freedesktop.org, Daniel Vetter Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On 6/29/22 14:14, Matthew Auld wrote: > It's not supported, and just skips later anyway. With small-BAR things > get more complicated since all of stolen is likely not even CPU > accessible, hence not passing I915_BO_ALLOC_GPU_ONLY just results in the > object create failing. > > Signed-off-by: Matthew Auld > Cc: Thomas Hellström > Cc: Lionel Landwerlin > Cc: Tvrtko Ursulin > Cc: Jon Bloomfield > Cc: Daniel Vetter > Cc: Jordan Justen > Cc: Kenneth Graunke > Cc: Akeem G Abodunrin > --- > drivers/gpu/drm/i915/gem/selftests/i915_gem_mman.c | 12 ++++++++++++ > 1 file changed, 12 insertions(+) This reminds me, Is there a problem for fbdev (and hence things like plymouth) if the initial fbdev image ends up as a stolen memory object which in turn ends up not being mappable? I remember we discussed this before but can't recall what the answer was. Anyway, for this patch Reviewed-by: Thomas Hellström > > diff --git a/drivers/gpu/drm/i915/gem/selftests/i915_gem_mman.c b/drivers/gpu/drm/i915/gem/selftests/i915_gem_mman.c > index 5bc93a1ce3e3..388c85b0f764 100644 > --- a/drivers/gpu/drm/i915/gem/selftests/i915_gem_mman.c > +++ b/drivers/gpu/drm/i915/gem/selftests/i915_gem_mman.c > @@ -979,6 +979,9 @@ static int igt_mmap(void *arg) > }; > int i; > > + if (mr->private) > + continue; > + > for (i = 0; i < ARRAY_SIZE(sizes); i++) { > struct drm_i915_gem_object *obj; > int err; > @@ -1435,6 +1438,9 @@ static int igt_mmap_access(void *arg) > struct drm_i915_gem_object *obj; > int err; > > + if (mr->private) > + continue; > + > obj = __i915_gem_object_create_user(i915, PAGE_SIZE, &mr, 1); > if (obj == ERR_PTR(-ENODEV)) > continue; > @@ -1580,6 +1586,9 @@ static int igt_mmap_gpu(void *arg) > struct drm_i915_gem_object *obj; > int err; > > + if (mr->private) > + continue; > + > obj = __i915_gem_object_create_user(i915, PAGE_SIZE, &mr, 1); > if (obj == ERR_PTR(-ENODEV)) > continue; > @@ -1727,6 +1736,9 @@ static int igt_mmap_revoke(void *arg) > struct drm_i915_gem_object *obj; > int err; > > + if (mr->private) > + continue; > + > obj = __i915_gem_object_create_user(i915, PAGE_SIZE, &mr, 1); > if (obj == ERR_PTR(-ENODEV)) > continue;