From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tvrtko Ursulin Subject: Re: [RFC 27/28] drm/i915: Compartmentalize ring buffer creation Date: Thu, 13 Jun 2019 16:56:37 +0100 Message-ID: References: <20190613133539.12620-1-tvrtko.ursulin@linux.intel.com> <20190613151904.16256-1-tvrtko.ursulin@linux.intel.com> <20190613151904.16256-4-tvrtko.ursulin@linux.intel.com> <156044076342.17012.8061368513293260014@skylake-alporthouse-com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by gabe.freedesktop.org (Postfix) with ESMTPS id 8D716896ED for ; Thu, 13 Jun 2019 15:56:39 +0000 (UTC) In-Reply-To: <156044076342.17012.8061368513293260014@skylake-alporthouse-com> Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson , Intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org Ck9uIDEzLzA2LzIwMTkgMTY6NDYsIENocmlzIFdpbHNvbiB3cm90ZToKPiBRdW90aW5nIFR2cnRr byBVcnN1bGluICgyMDE5LTA2LTEzIDE2OjE5OjAzKQo+PiBGcm9tOiBUdnJ0a28gVXJzdWxpbiA8 dHZydGtvLnVyc3VsaW5AaW50ZWwuY29tPgo+Pgo+PiBDb250aW51aW5nIG9uIHRoZSB0aGVtZSBv ZiBjb21wYXJ0bWVudGFsaXppbmcgdGhlIGNvZGUgYmV0dGVyIHRvIG1ha2UKPj4gZnV0dXJlIHNw bGl0IGJldHdlZW4gZ3QgYW5kIGRpc3BsYXkgaW4gZ2xvYmFsIGk5MTUgY2xlYXJlci4KPj4KPj4g U2lnbmVkLW9mZi1ieTogVHZydGtvIFVyc3VsaW4gPHR2cnRrby51cnN1bGluQGludGVsLmNvbT4K Pj4gLS0tCj4+ICAgZHJpdmVycy9ncHUvZHJtL2k5MTUvZ3QvaW50ZWxfcmluZ2J1ZmZlci5jIHwg MTcgKysrKysrKysrLS0tLS0tLS0KPj4gICAxIGZpbGUgY2hhbmdlZCwgOSBpbnNlcnRpb25zKCsp LCA4IGRlbGV0aW9ucygtKQo+Pgo+PiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUv Z3QvaW50ZWxfcmluZ2J1ZmZlci5jIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvZ3QvaW50ZWxfcmlu Z2J1ZmZlci5jCj4+IGluZGV4IGIzYmY0N2U4MTYyZi4uMGExZDk1MmFkMTYwIDEwMDY0NAo+PiAt LS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9ndC9pbnRlbF9yaW5nYnVmZmVyLmMKPj4gKysrIGIv ZHJpdmVycy9ncHUvZHJtL2k5MTUvZ3QvaW50ZWxfcmluZ2J1ZmZlci5jCj4+IEBAIC0xMjI2LDE2 ICsxMjI2LDE2IEBAIHZvaWQgaW50ZWxfcmluZ191bnBpbihzdHJ1Y3QgaW50ZWxfcmluZyAqcmlu ZykKPj4gICAgICAgICAgaTkxNV90aW1lbGluZV91bnBpbihyaW5nLT50aW1lbGluZSk7Cj4+ICAg fQo+PiAgIAo+PiAtc3RhdGljIHN0cnVjdCBpOTE1X3ZtYSAqCj4+IC1pbnRlbF9yaW5nX2NyZWF0 ZV92bWEoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2LCBpbnQgc2l6ZSkKPj4gK3N0 YXRpYyBzdHJ1Y3QgaTkxNV92bWEgKmNyZWF0ZV9yaW5nX3ZtYShzdHJ1Y3QgaW50ZWxfZ3QgKmd0 LCBpbnQgc2l6ZSkKPiAKPiBIZXJlLCBpdCBwcm9iYWJseSBtYWtlcyBtb3JlIHNlbnNlIHRvIGJl IHBhc3NpbmcgaTkxNV9nZ3R0IChzaW5jZSB0aGlzCj4gaXMgYWJvdXQgdGhlIGk5MTVfdm1hIGl0 c2VsZikuCgpZZXAsIGdvb2QgcG9pbnQuCgo+PiAgIHsKPj4gLSAgICAgICBzdHJ1Y3QgaTkxNV9h ZGRyZXNzX3NwYWNlICp2bSA9ICZkZXZfcHJpdi0+Z2d0dC52bTsKPj4gKyAgICAgICBzdHJ1Y3Qg aTkxNV9hZGRyZXNzX3NwYWNlICp2bSA9ICZndC0+Z2d0dC0+dm07Cj4+ICsgICAgICAgc3RydWN0 IGRybV9pOTE1X3ByaXZhdGUgKmk5MTUgPSBndC0+aTkxNTsKPj4gICAgICAgICAgc3RydWN0IGRy bV9pOTE1X2dlbV9vYmplY3QgKm9iajsKPj4gICAgICAgICAgc3RydWN0IGk5MTVfdm1hICp2bWE7 Cj4+ICAgCj4+IC0gICAgICAgb2JqID0gaTkxNV9nZW1fb2JqZWN0X2NyZWF0ZV9zdG9sZW4oZGV2 X3ByaXYsIHNpemUpOwo+PiArICAgICAgIG9iaiA9IGk5MTVfZ2VtX29iamVjdF9jcmVhdGVfc3Rv bGVuKGk5MTUsIHNpemUpOwo+PiAgICAgICAgICBpZiAoIW9iaikKPj4gLSAgICAgICAgICAgICAg IG9iaiA9IGk5MTVfZ2VtX29iamVjdF9jcmVhdGVfaW50ZXJuYWwoZGV2X3ByaXYsIHNpemUpOwo+ PiArICAgICAgICAgICAgICAgb2JqID0gaTkxNV9nZW1fb2JqZWN0X2NyZWF0ZV9pbnRlcm5hbChp OTE1LCBzaXplKTsKPj4gICAgICAgICAgaWYgKElTX0VSUihvYmopKQo+PiAgICAgICAgICAgICAg ICAgIHJldHVybiBFUlJfQ0FTVChvYmopOwo+PiAgIAo+PiBAQCAtMTI2MiwxMyArMTI2MiwxNCBA QCBpbnRlbF9lbmdpbmVfY3JlYXRlX3Jpbmcoc3RydWN0IGludGVsX2VuZ2luZV9jcyAqZW5naW5l LAo+PiAgICAgICAgICAgICAgICAgICAgICAgICAgIHN0cnVjdCBpOTE1X3RpbWVsaW5lICp0aW1l bGluZSwKPj4gICAgICAgICAgICAgICAgICAgICAgICAgICBpbnQgc2l6ZSkKPj4gICB7Cj4+ICsg ICAgICAgc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmk5MTUgPSBlbmdpbmUtPmk5MTU7Cj4+ICAg ICAgICAgIHN0cnVjdCBpbnRlbF9yaW5nICpyaW5nOwo+PiAgICAgICAgICBzdHJ1Y3QgaTkxNV92 bWEgKnZtYTsKPj4gICAKPj4gICAgICAgICAgR0VNX0JVR19PTighaXNfcG93ZXJfb2ZfMihzaXpl KSk7Cj4+ICAgICAgICAgIEdFTV9CVUdfT04oUklOR19DVExfU0laRShzaXplKSAmIH5SSU5HX05S X1BBR0VTKTsKPj4gICAgICAgICAgR0VNX0JVR19PTih0aW1lbGluZSA9PSAmZW5naW5lLT50aW1l bGluZSk7Cj4+IC0gICAgICAgbG9ja2RlcF9hc3NlcnRfaGVsZCgmZW5naW5lLT5pOTE1LT5kcm0u c3RydWN0X211dGV4KTsKPj4gKyAgICAgICBsb2NrZGVwX2Fzc2VydF9oZWxkKCZpOTE1LT5kcm0u c3RydWN0X211dGV4KTsKPiAKPiBIZXJlc3kuCgpXaGF0IHdoeT8KClJlZ2FyZHMsCgpUdnJ0a28K X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4 IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4