From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tvrtko Ursulin Subject: Re: [PATCH v2 2/4] drm/i915: Verify the engine workarounds stick on application Date: Tue, 16 Apr 2019 11:36:12 +0100 Message-ID: References: <20190416081024.20536-1-chris@chris-wilson.co.uk> <20190416081024.20536-2-chris@chris-wilson.co.uk> <9e058033-37b7-e576-9962-c910febe8957@linux.intel.com> <155540866517.25605.7581655221283905781@skylake-alporthouse-com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by gabe.freedesktop.org (Postfix) with ESMTPS id D1FF889289 for ; Tue, 16 Apr 2019 10:36:14 +0000 (UTC) In-Reply-To: <155540866517.25605.7581655221283905781@skylake-alporthouse-com> Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org Ck9uIDE2LzA0LzIwMTkgMTA6NTcsIENocmlzIFdpbHNvbiB3cm90ZToKPiBRdW90aW5nIFR2cnRr byBVcnN1bGluICgyMDE5LTA0LTE2IDEwOjQzOjQzKQo+Pgo+PiBPbiAxNi8wNC8yMDE5IDA5OjEw LCBDaHJpcyBXaWxzb24gd3JvdGU6Cj4+PiBSZWFkIHRoZSBlbmdpbmUgd29ya2Fyb3VuZHMgYmFj ayB1c2luZyB0aGUgR1BVIGFmdGVyIGxvYWRpbmcgdGhlIGluaXRpYWwKPj4+IGNvbnRleHQgc3Rh dGUgdG8gdmVyaWZ5IHRoYXQgd2UgYXJlIHNldHRpbmcgdGhlbSBjb3JyZWN0bHksIGFuZCBiYWls IGlmCj4+PiBpdCBmYWlscy4KPj4+Cj4+PiBTaWduZWQtb2ZmLWJ5OiBDaHJpcyBXaWxzb24gPGNo cmlzQGNocmlzLXdpbHNvbi5jby51az4KPj4+IENjOiBUdnJ0a28gVXJzdWxpbiA8dHZydGtvLnVy c3VsaW5AaW50ZWwuY29tPgo+Pj4gLS0tCj4+PiAgICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1 X2dlbS5jICAgICAgICAgICAgICAgfCAgIDYgKwo+Pj4gICAgZHJpdmVycy9ncHUvZHJtL2k5MTUv aW50ZWxfd29ya2Fyb3VuZHMuYyAgICAgIHwgMTIwICsrKysrKysrKysrKysrKysrKwo+Pj4gICAg ZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfd29ya2Fyb3VuZHMuaCAgICAgIHwgICAyICsKPj4+ ICAgIC4uLi9kcm0vaTkxNS9zZWxmdGVzdHMvaW50ZWxfd29ya2Fyb3VuZHMuYyAgICB8ICA1MyAr LS0tLS0tLQo+Pj4gICAgNCBmaWxlcyBjaGFuZ2VkLCAxMzQgaW5zZXJ0aW9ucygrKSwgNDcgZGVs ZXRpb25zKC0pCj4+Pgo+Pj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVf Z2VtLmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2dlbS5jCj4+PiBpbmRleCAwYTgxOGE2 MGFkMzEuLjk1YWU2OTc1M2U5MSAxMDA2NDQKPj4+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1 L2k5MTVfZ2VtLmMKPj4+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZ2VtLmMKPj4+ IEBAIC00NzE3LDYgKzQ3MTcsMTIgQEAgc3RhdGljIGludCBfX2ludGVsX2VuZ2luZXNfcmVjb3Jk X2RlZmF1bHRzKHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICppOTE1KQo+Pj4gICAgICAgICAgICAg ICAgaTkxNV9yZXF1ZXN0X2FkZChycSk7Cj4+PiAgICAgICAgICAgICAgICBpZiAoZXJyKQo+Pj4g ICAgICAgICAgICAgICAgICAgICAgICBnb3RvIGVycl9hY3RpdmU7Cj4+PiArCj4+PiArICAgICAg ICAgICAgIGlmIChJU19FTkFCTEVEKENPTkZJR19EUk1fSTkxNV9ERUJVR19HRU0pICYmCj4+PiAr ICAgICAgICAgICAgICAgICBpbnRlbF9lbmdpbmVfdmVyaWZ5X3dvcmthcm91bmRzKGVuZ2luZSwg ImxvYWQiKSkgewo+Pj4gKyAgICAgICAgICAgICAgICAgICAgIGVyciA9IC1FSU87Cj4+PiArICAg ICAgICAgICAgICAgICAgICAgZ290byBlcnJfYWN0aXZlOwo+Pgo+PiBUaGUgdHdvIHN1Ym1pc3Np b24gdXNlIGRpZmZlcmVudCBjb250ZXh0cyB0aW1lbGluZXMgc28gc3RyaWN0bHkgc3BlYWtpbmcK Pj4gc2hvdWxkIGJlIHNvbWVob3cgZXhwbGljaXRseSBzZXJpYWxpemVkLgo+IAo+IFllcywgd2Ug YXJlIHJlYWRpbmcgZnJvbSB0aGUga2VybmVsIGNvbnRleHQuIE5laXRoZXIgb2YgdGhlc2UgY29u dGV4dHMKPiB3aWxsIG92ZXJ3cml0ZSB0aGUgZXhpc3RpbmcgcmVnaXN0ZXIgc3RhdGUgb24gZmly c3QgbG9hZCwgYW5kIHRoZXJlIGlzCj4gbm90aGluZyB0byBwcmV2ZW50IGZpZm8gaGVyZS4gQnV0 IGl0IGRvZXNuJ3QgbWF0dGVyIHdoaWNoIG9yZGVyIHRoZSByZWFkCj4gaXMgZG9uZSwgYXMgdGhl IHcvYSBhcmUgc2V0IGJ5IG1taW8sIG5vdCBlbmdpbmUtPmluaXRfY29udGV4dCgpLgo+IEFsdGhv dWdoIEkndmUgYmVlbiBjb250ZW1wbGF0aW5nIHVzaW5nIGluaXRfY29udGV4dCBpbiBjYXNlIExS SSB3b3JrCj4gYmV0dGVyLgoKVXNpbmcgaW5pdF9jb250ZXh0IGZvciB3aGF0LCBlbmdpbmUgd2Ev PwoKPiAKPiBJdCBjb3VsZCBiZSBpbiBhIHNlcGFyYXRlIGxvb3AgYmVmb3JlaGFuZCwgdGhlIG9u bHkgY2F0Y2ggaXMgdGhhdCB3ZQo+IGV4cGVjdCB0byBsZWF2ZSB0aGlzIGZ1bmN0aW9uIHdpdGgg dGhlIEdUIGlkbGUsIHNvIGl0J3MgYmVzdCBkb25lIGJlZm9yZQo+IHdlIHBhcmsuCgpZZXAgc2lu Y2UgdGhlIHBsYWNlbWVudCBpbiB0aGUgLT5pbml0X2NvbnRleHQgbG9vcCBjb25mdXNlZCBtZSBJ IHRoaW5rIGEgCnNlcGFyYXRlIGxvb3Agd291bGQgaW5kZWVkIGJlIGJldHRlci4KCl9faTkxNV9n ZW1fcmVzdGFydF9lbmdpbmVzIGxvb2tzIGxpa2UgdGhlIHBsYWNlLCB0byBmb2xsb3cgCmVuZ2lu ZS0+aW5pdF9odyB3aGljaCBhcHBsaWVzIHRoZSBlbmdpbmUgd29ya2Fyb3VuZHMuCgo+Pj4gZGlm ZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3dvcmthcm91bmRzLmMgYi9kcml2 ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF93b3JrYXJvdW5kcy5jCj4+PiBpbmRleCAxYzU0YjUwMzA4 MDcuLmRiOTlmMmU2NzZiYiAxMDA2NDQKPj4+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2lu dGVsX3dvcmthcm91bmRzLmMKPj4+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3dv cmthcm91bmRzLmMKPj4+IEBAIC0xMjU5LDYgKzEyNTksMTI2IEBAIHZvaWQgaW50ZWxfZW5naW5l X2FwcGx5X3dvcmthcm91bmRzKHN0cnVjdCBpbnRlbF9lbmdpbmVfY3MgKmVuZ2luZSkKPj4+ICAg ICAgICB3YV9saXN0X2FwcGx5KGVuZ2luZS0+dW5jb3JlLCAmZW5naW5lLT53YV9saXN0KTsKPj4+ ICAgIH0KPj4+ICAgIAo+Pj4gK3N0YXRpYyBzdHJ1Y3QgaTkxNV92bWEgKgo+Pj4gK2NyZWF0ZV9z Y3JhdGNoKHN0cnVjdCBpOTE1X2FkZHJlc3Nfc3BhY2UgKnZtLCBpbnQgY291bnQpCj4+PiArewo+ Pj4gKyAgICAgc3RydWN0IGRybV9pOTE1X2dlbV9vYmplY3QgKm9iajsKPj4+ICsgICAgIHN0cnVj dCBpOTE1X3ZtYSAqdm1hOwo+Pj4gKyAgICAgdW5zaWduZWQgaW50IHNpemU7Cj4+PiArICAgICBp bnQgZXJyOwo+Pj4gKwo+Pj4gKyAgICAgc2l6ZSA9IHJvdW5kX3VwKGNvdW50ICogNCwgUEFHRV9T SVpFKTsKPj4KPj4gc2l6ZW9mKHUzMikgaWYgeW91IHdhbnQuCj4+Cj4+PiArICAgICBvYmogPSBp OTE1X2dlbV9vYmplY3RfY3JlYXRlX2ludGVybmFsKHZtLT5pOTE1LCBzaXplKTsKPj4+ICsgICAg IGlmIChJU19FUlIob2JqKSkKPj4+ICsgICAgICAgICAgICAgcmV0dXJuIEVSUl9DQVNUKG9iaik7 Cj4+PiArCj4+PiArICAgICBpOTE1X2dlbV9vYmplY3Rfc2V0X2NhY2hlX2NvaGVyZW5jeShvYmos IEk5MTVfQ0FDSEVfTExDKTsKPj4+ICsKPj4+ICsgICAgIHZtYSA9IGk5MTVfdm1hX2luc3RhbmNl KG9iaiwgdm0sIE5VTEwpOwo+Pj4gKyAgICAgaWYgKElTX0VSUih2bWEpKSB7Cj4+PiArICAgICAg ICAgICAgIGVyciA9IFBUUl9FUlIodm1hKTsKPj4+ICsgICAgICAgICAgICAgZ290byBlcnJfb2Jq Owo+Pj4gKyAgICAgfQo+Pj4gKwo+Pj4gKyAgICAgZXJyID0gaTkxNV92bWFfcGluKHZtYSwgMCwg MCwKPj4+ICsgICAgICAgICAgICAgICAgICAgICAgICBpOTE1X3ZtYV9pc19nZ3R0KHZtYSkgPyBQ SU5fR0xPQkFMIDogUElOX1VTRVIpOwo+Pj4gKyAgICAgaWYgKGVycikKPj4+ICsgICAgICAgICAg ICAgZ290byBlcnJfb2JqOwo+Pj4gKwo+Pj4gKyAgICAgcmV0dXJuIHZtYTsKPj4+ICsKPj4+ICtl cnJfb2JqOgo+Pj4gKyAgICAgaTkxNV9nZW1fb2JqZWN0X3B1dChvYmopOwo+Pj4gKyAgICAgcmV0 dXJuIEVSUl9QVFIoZXJyKTsKPj4+ICt9Cj4+PiArCj4+PiArc3RhdGljIGludAo+Pj4gK3dhX2xp c3Rfc3JtKHN0cnVjdCBpOTE1X3JlcXVlc3QgKnJxLAo+Pj4gKyAgICAgICAgIGNvbnN0IHN0cnVj dCBpOTE1X3dhX2xpc3QgKndhbCwKPj4+ICsgICAgICAgICBzdHJ1Y3QgaTkxNV92bWEgKnZtYSkK Pj4+ICt7Cj4+PiArICAgICBjb25zdCBzdHJ1Y3QgaTkxNV93YSAqd2E7Cj4+PiArICAgICB1MzIg c3JtLCAqY3M7Cj4+PiArICAgICBpbnQgaTsKPj4KPj4gQSBsaXR0bGUgYml0IG9mIGluY29uc2lz dGVuY3kgYmV0d2VlbiB0eXBlIG9mIGkgaGVyZSBhbmQgaW4KPj4gZW5naW5lX3dhX2xpc3RfdmVy aWZ5LiBVcCB0byB5b3UuCj4+Cj4+PiArCj4+PiArICAgICBzcm0gPSBNSV9TVE9SRV9SRUdJU1RF Ul9NRU0gfCBNSV9TUk1fTFJNX0dMT0JBTF9HVFQ7Cj4+PiArICAgICBpZiAoSU5URUxfR0VOKHJx LT5pOTE1KSA+PSA4KQo+Pj4gKyAgICAgICAgICAgICBzcm0rKzsKPj4+ICsKPj4+ICsgICAgIGNz ID0gaW50ZWxfcmluZ19iZWdpbihycSwgNCAqIHdhbC0+Y291bnQpOwo+Pj4gKyAgICAgaWYgKElT X0VSUihjcykpCj4+PiArICAgICAgICAgICAgIHJldHVybiBQVFJfRVJSKGNzKTsKPj4+ICsKPj4+ ICsgICAgIGZvciAoaSA9IDAsIHdhID0gd2FsLT5saXN0OyBpIDwgd2FsLT5jb3VudDsgaSsrLCB3 YSsrKSB7Cj4+PiArICAgICAgICAgICAgICpjcysrID0gc3JtOwo+Pj4gKyAgICAgICAgICAgICAq Y3MrKyA9IGk5MTVfbW1pb19yZWdfb2Zmc2V0KHdhLT5yZWcpOwo+Pj4gKyAgICAgICAgICAgICAq Y3MrKyA9IGk5MTVfZ2d0dF9vZmZzZXQodm1hKSArIHNpemVvZih1MzIpICogaTsKPj4+ICsgICAg ICAgICAgICAgKmNzKysgPSAwOwo+Pj4gKyAgICAgfQo+Pj4gKyAgICAgaW50ZWxfcmluZ19hZHZh bmNlKHJxLCBjcyk7Cj4+PiArCj4+PiArICAgICByZXR1cm4gMDsKPj4+ICt9Cj4+PiArCj4+PiAr c3RhdGljIGludCBlbmdpbmVfd2FfbGlzdF92ZXJpZnkoc3RydWN0IGludGVsX2VuZ2luZV9jcyAq ZW5naW5lLAo+Pj4gKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGNvbnN0IHN0cnVjdCBp OTE1X3dhX2xpc3QgKiBjb25zdCB3YWwsCj4+PiArICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgY29uc3QgY2hhciAqZnJvbSkKPj4+ICt7Cj4+PiArICAgICBjb25zdCBzdHJ1Y3QgaTkxNV93 YSAqd2E7Cj4+PiArICAgICBzdHJ1Y3QgaTkxNV9yZXF1ZXN0ICpycTsKPj4+ICsgICAgIHN0cnVj dCBpOTE1X3ZtYSAqdm1hOwo+Pj4gKyAgICAgdW5zaWduZWQgaW50IGk7Cj4+PiArICAgICB1MzIg KnJlc3VsdHM7Cj4+PiArICAgICBpbnQgZXJyOwo+Pj4gKwo+Pj4gKyAgICAgaWYgKCF3YWwtPmNv dW50KQo+Pj4gKyAgICAgICAgICAgICByZXR1cm4gMDsKPj4+ICsKPj4+ICsgICAgIHZtYSA9IGNy ZWF0ZV9zY3JhdGNoKCZlbmdpbmUtPmk5MTUtPmdndHQudm0sIHdhbC0+Y291bnQpOwo+Pj4gKyAg ICAgaWYgKElTX0VSUih2bWEpKQo+Pj4gKyAgICAgICAgICAgICByZXR1cm4gUFRSX0VSUih2bWEp Owo+Pj4gKwo+Pj4gKyAgICAgcnEgPSBpOTE1X3JlcXVlc3RfYWxsb2MoZW5naW5lLCBlbmdpbmUt Pmtlcm5lbF9jb250ZXh0LT5nZW1fY29udGV4dCk7Cj4+PiArICAgICBpZiAoSVNfRVJSKHJxKSkg ewo+Pj4gKyAgICAgICAgICAgICBlcnIgPSBQVFJfRVJSKHJxKTsKPj4+ICsgICAgICAgICAgICAg Z290byBlcnJfdm1hOwo+Pj4gKyAgICAgfQo+Pj4gKwo+Pj4gKyAgICAgZXJyID0gd2FfbGlzdF9z cm0ocnEsIHdhbCwgdm1hKTsKPj4+ICsgICAgIGlmIChlcnIpCj4+PiArICAgICAgICAgICAgIGdv dG8gZXJyX3ZtYTsKPj4+ICsKPj4+ICsgICAgIGk5MTVfcmVxdWVzdF9hZGQocnEpOwo+Pj4gKyAg ICAgaWYgKGk5MTVfcmVxdWVzdF93YWl0KHJxLCBJOTE1X1dBSVRfTE9DS0VELCBIWiAvIDUpIDwg MCkgewo+Pgo+PiBXb3VsZG4ndDoKPj4KPj4gZXJyID0gaTkxNV9yZXF1ZXN0X3dhaXQoLi4uCj4+ IGlmIChlcnIgPCAwIHx8ICFpOTE1X3JlcXVlc3RfY29tcGxldGVkKCkpCj4+Cj4+IGJlIG1vcmUg Y29ycmVjdD8KPiAKPiBJdCBjYW4ndCByZXR1cm4gZm9yIGFueSBvdGhlciByZWFzb24gYXMgaXQn cyBhbiB1bmludGVycnVwdGlibGUgd2FpdCwgc28KPiBpdCB0aW1lcyBvdXQsIG9yIHRoZSByZXF1 ZXN0IGlzIGNvbXBsZXRlZC4KPiAKPiBJZiB5b3Ugd2FudCB0byBjb25zaWRlciB0aGF0IGhhbmdj aGVjayBjb3VsZCBoYXZlIGtpY2tlZCBpbiB0aGUgMC4ybXMKPiBhbmQgY2FuY2VsbGVkIHRoZSBy ZXF1ZXN0LCB0aGVuIHdlIGNvdWxkIG5lZWQgdG8gY2hlY2sKPiByZXF1ZXN0LT5mZW5jZS5lcnJv ci4KCkkgd2FzIGdvaW5nIGJ5IHRoZSBjb21tZW50IGZvciBpOTE1X3JlcXVlc3Rfd2FpdCB3aGlj aCBzYXlzICJSZXR1cm5zIHRoZSAKcmVtYWluaW5nIHRpbWUgKGluIGppZmZpZXMpIGlmIHRoZSBy ZXF1ZXN0IGNvbXBsZXRlZCwgd2hpY2ggbWF5IGJlIHplcm8gCm9yIC1FVElNRSBpZiB0aGUgcmVx dWVzdCBpcyB1bmZpbmlzaGVkIGFmdGVyIHRoZSB0aW1lb3V0IGV4cGlyZXMuIi4gU28gCnR3byB0 aW1lb3V0IGNvbmRpdGlvbnMuIEFueXdheXMsIEkga25vdyBpdCBpcyBoaWdobHkgaHlwb3RoZXRp Y2FsIGlmIHRoYXQuCgo+IAo+Pgo+PiBPa2F5IHNvIE1NSU8gdmVyaWZpY2F0aW9uIGhhcHBlbnMg aW1tZWRpYXRlbHkgYWZ0ZXIgYXBwbGljYXRpb24gYW5kIHdpdGgKPj4gU1JNIGZyb20gc2VsZnRl c3RzLgo+Pgo+PiBXaGF0IGFib3V0IHRoZSBjb250ZXh0IHdvcmthcm91bmRzPyBXaXRoIHRoZSBT Uk0gaW5mcmFzdHJ1Y3R1cmUgdGhvc2UKPj4gY291bGQgYmUgdmVyaWZpZWQgZWFzaWx5IGFzIHdl bGwgSSB0aGluay4KPiAKPiBUaGV5IGNhbiwgb25lIHByb2JsZW0gYXQgYXQgdGltZSA6KSBJIHRo b3VnaHQgdGhlIGNvbnRleHQgd29ya2Fyb3VuZHMKPiB3ZXJlIGxpc3RlZCBhbmQgY2hlY2tlZCBi eSBnZW1fd29ya2Fyb3VuZHMuIEF5ZSwgYnV0IG9ubHkgY3R4X3dhOgo+IAo+IHN0YXRpYyBpbnQg aTkxNV93YV9yZWdpc3RlcnMoc3RydWN0IHNlcV9maWxlICptLCB2b2lkICp1bnVzZWQpCj4gewo+ ICAgICAgICAgIHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICppOTE1ID0gbm9kZV90b19pOTE1KG0t PnByaXZhdGUpOwo+ICAgICAgICAgIGNvbnN0IHN0cnVjdCBpOTE1X3dhX2xpc3QgKndhbCA9ICZp OTE1LT5lbmdpbmVbUkNTMF0tPmN0eF93YV9saXN0Owo+ICAgICAgICAgIHN0cnVjdCBpOTE1X3dh ICp3YTsKPiAgICAgICAgICB1bnNpZ25lZCBpbnQgaTsKPiAKPiAgICAgICAgICBzZXFfcHJpbnRm KG0sICJXb3JrYXJvdW5kcyBhcHBsaWVkOiAldVxuIiwgd2FsLT5jb3VudCk7Cj4gICAgICAgICAg Zm9yIChpID0gMCwgd2EgPSB3YWwtPmxpc3Q7IGkgPCB3YWwtPmNvdW50OyBpKyssIHdhKyspCj4g ICAgICAgICAgICAgICAgICBzZXFfcHJpbnRmKG0sICIweCVYOiAweCUwOFgsIG1hc2s6IDB4JTA4 WFxuIiwKPiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgaTkxNV9tbWlvX3JlZ19vZmZzZXQo d2EtPnJlZyksIHdhLT52YWwsIHdhLT5tYXNrKTsKPiAKPiAgICAgICAgICByZXR1cm4gMDsKPiB9 Cj4gCj4gCj4gCgpZZXMgb25lIHRoaW5nIGF0IGEgdGltZSBpcyBmaW5lLiA6KQoKUmVnYXJkcywK ClR2cnRrbwoKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f CkludGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpo dHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeA==