From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tvrtko Ursulin Subject: Re: [PATCH] drm/i915: Introduce BITS_PER_TYPE Date: Fri, 6 Jul 2018 09:59:48 +0100 Message-ID: References: <20180706084455.23601-1-chris@chris-wilson.co.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by gabe.freedesktop.org (Postfix) with ESMTPS id 811D56EF8A for ; Fri, 6 Jul 2018 08:59:52 +0000 (UTC) In-Reply-To: <20180706084455.23601-1-chris@chris-wilson.co.uk> Content-Language: en-GB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson , intel-gfx@lists.freedesktop.org Cc: Jani Nikula List-Id: intel-gfx@lists.freedesktop.org Ck9uIDA2LzA3LzIwMTggMDk6NDQsIENocmlzIFdpbHNvbiB3cm90ZToKPiBCb3Jyb3cgdGhlIGlk ZWEgZnJvbSBuZXRfZGltLmggdG8gc2ltcGxpZnkgdGhlIGNvbW1vbiBkZXRlcm1pbmF0aW9uIG9m Cj4gaG93IG1hbnkgYml0cyBpbiBhIHBhcnRpY3VsYXIgdHlwZSAoc2l6ZW9mKHR5cGUpICogQklU U19QRVJfQllURSkuCj4gCj4gU3VnZ2VzdGVkLWJ5OiBWaWxsZSBTeXJqw6Rsw6QgPHZpbGxlLnN5 cmphbGFAbGludXguaW50ZWwuY29tPgo+IFNpZ25lZC1vZmYtYnk6IENocmlzIFdpbHNvbiA8Y2hy aXNAY2hyaXMtd2lsc29uLmNvLnVrPgo+IENjOiBWaWxsZSBTeXJqw6Rsw6QgPHZpbGxlLnN5cmph bGFAbGludXguaW50ZWwuY29tPgo+IENjOiBKYW5pIE5pa3VsYSA8amFuaS5uaWt1bGFAaW50ZWwu Y29tPgo+IENjOiBKb29uYXMgTGFodGluZW4gPGpvb25hcy5sYWh0aW5lbkBsaW51eC5pbnRlbC5j b20+Cj4gQ2M6IFR2cnRrbyBVcnN1bGluIDx0dnJ0a28udXJzdWxpbkBpbnRlbC5jb20+Cj4gLS0t Cj4gICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2Rydi5jICAgICAgICAgIHwgNCArKy0tCj4g ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2dlbS5jICAgICAgICAgIHwgMiArLQo+ICAgZHJp dmVycy9ncHUvZHJtL2k5MTUvaTkxNV9xdWVyeS5jICAgICAgICB8IDIgKy0KPiAgIGRyaXZlcnMv Z3B1L2RybS9pOTE1L2k5MTVfc3luY21hcC5jICAgICAgfCAzICsrLQo+ICAgZHJpdmVycy9ncHUv ZHJtL2k5MTUvaTkxNV91dGlscy5oICAgICAgICB8IDQgKysrLQo+ICAgZHJpdmVycy9ncHUvZHJt L2k5MTUvaW50ZWxfZGV2aWNlX2luZm8uYyB8IDMgKy0tCj4gICBkcml2ZXJzL2dwdS9kcm0vaTkx NS9pbnRlbF9lbmdpbmVfY3MuYyAgIHwgMiArLQo+ICAgNyBmaWxlcyBjaGFuZ2VkLCAxMSBpbnNl cnRpb25zKCspLCA5IGRlbGV0aW9ucygtKQo+IAo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9k cm0vaTkxNS9pOTE1X2Rydi5jIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9kcnYuYwo+IGlu ZGV4IDBkYjNjODNjY2UyOS4uMjQ4YzdkYjJhZTJhIDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1 L2RybS9pOTE1L2k5MTVfZHJ2LmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2Ry di5jCj4gQEAgLTg4Nyw4ICs4ODcsOCBAQCBzdGF0aWMgaW50IGk5MTVfZHJpdmVyX2luaXRfZWFy bHkoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2LAo+ICAgCWRldmljZV9pbmZvLT5k ZXZpY2VfaWQgPSBkZXZfcHJpdi0+ZHJtLnBkZXYtPmRldmljZTsKPiAgIAo+ICAgCUJVSUxEX0JV R19PTihJTlRFTF9NQVhfUExBVEZPUk1TID4KPiAtCQkgICAgIHNpemVvZihkZXZpY2VfaW5mby0+ cGxhdGZvcm1fbWFzaykgKiBCSVRTX1BFUl9CWVRFKTsKPiAtCUJVR19PTihkZXZpY2VfaW5mby0+ Z2VuID4gc2l6ZW9mKGRldmljZV9pbmZvLT5nZW5fbWFzaykgKiBCSVRTX1BFUl9CWVRFKTsKPiAr CQkgICAgIEJJVFNfUEVSX1RZUEUoZGV2aWNlX2luZm8tPnBsYXRmb3JtX21hc2spKTsKPiArCUJV R19PTihkZXZpY2VfaW5mby0+Z2VuID4gQklUU19QRVJfVFlQRShkZXZpY2VfaW5mby0+Z2VuX21h c2spKTsKPiAgIAlzcGluX2xvY2tfaW5pdCgmZGV2X3ByaXYtPmlycV9sb2NrKTsKPiAgIAlzcGlu X2xvY2tfaW5pdCgmZGV2X3ByaXYtPmdwdV9lcnJvci5sb2NrKTsKPiAgIAltdXRleF9pbml0KCZk ZXZfcHJpdi0+YmFja2xpZ2h0X2xvY2spOwo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0v aTkxNS9pOTE1X2dlbS5jIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9nZW0uYwo+IGluZGV4 IDBjMGExYTk1OWQwYi4uMGRjOWNhYWExZGM5IDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2Ry bS9pOTE1L2k5MTVfZ2VtLmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2dlbS5j Cj4gQEAgLTU4ODAsNyArNTg4MCw3IEBAIHZvaWQgaTkxNV9nZW1fdHJhY2tfZmIoc3RydWN0IGRy bV9pOTE1X2dlbV9vYmplY3QgKm9sZCwKPiAgIAkgKiB0aGUgYml0cy4KPiAgIAkgKi8KPiAgIAlC VUlMRF9CVUdfT04oSU5URUxfRlJPTlRCVUZGRVJfQklUU19QRVJfUElQRSAqIEk5MTVfTUFYX1BJ UEVTID4KPiAtCQkgICAgIHNpemVvZihhdG9taWNfdCkgKiBCSVRTX1BFUl9CWVRFKTsKPiArCQkg ICAgIEJJVFNfUEVSX1RZUEUoYXRvbWljX3QpKTsKPiAgIAo+ICAgCWlmIChvbGQpIHsKPiAgIAkJ V0FSTl9PTighKGF0b21pY19yZWFkKCZvbGQtPmZyb250YnVmZmVyX2JpdHMpICYgZnJvbnRidWZm ZXJfYml0cykpOwo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X3F1ZXJ5 LmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X3F1ZXJ5LmMKPiBpbmRleCAzZjUwMmVlZjI0 MzEuLjU4MjEwMDJjYWQ0MiAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1 X3F1ZXJ5LmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X3F1ZXJ5LmMKPiBAQCAt MjgsNyArMjgsNyBAQCBzdGF0aWMgaW50IHF1ZXJ5X3RvcG9sb2d5X2luZm8oc3RydWN0IGRybV9p OTE1X3ByaXZhdGUgKmRldl9wcml2LAo+ICAgCXNsaWNlX2xlbmd0aCA9IHNpemVvZihzc2V1LT5z bGljZV9tYXNrKTsKPiAgIAlzdWJzbGljZV9sZW5ndGggPSBzc2V1LT5tYXhfc2xpY2VzICoKPiAg IAkJRElWX1JPVU5EX1VQKHNzZXUtPm1heF9zdWJzbGljZXMsCj4gLQkJCSAgICAgc2l6ZW9mKHNz ZXUtPnN1YnNsaWNlX21hc2tbMF0pICogQklUU19QRVJfQllURSk7Cj4gKwkJCSAgICAgQklUU19Q RVJfVFlQRShzc2V1LT5zdWJzbGljZV9tYXNrWzBdKSk7Cj4gICAJZXVfbGVuZ3RoID0gc3NldS0+ bWF4X3NsaWNlcyAqIHNzZXUtPm1heF9zdWJzbGljZXMgKgo+ICAgCQlESVZfUk9VTkRfVVAoc3Nl dS0+bWF4X2V1c19wZXJfc3Vic2xpY2UsIEJJVFNfUEVSX0JZVEUpOwo+ICAgCj4gZGlmZiAtLWdp dCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfc3luY21hcC5jIGIvZHJpdmVycy9ncHUvZHJt L2k5MTUvaTkxNV9zeW5jbWFwLmMKPiBpbmRleCA1OGY4ZDBjYzEyNWMuLjE3NDFkYjZmYjBjZSAx MDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X3N5bmNtYXAuYwo+ICsrKyBi L2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfc3luY21hcC5jCj4gQEAgLTI4LDYgKzI4LDcgQEAK PiAgIAo+ICAgI2luY2x1ZGUgImk5MTVfZ2VtLmgiIC8qIEdFTV9CVUdfT04oKSAqLwo+ICAgI2lu Y2x1ZGUgImk5MTVfc2VsZnRlc3QuaCIKPiArI2luY2x1ZGUgImk5MTVfdXRpbHMuaCIgLyogQklU U19QRVJfVFlQRSgpICovCj4gICAKPiAgICNkZWZpbmUgU0hJRlQgaWxvZzIoS1NZTkNNQVApCj4g ICAjZGVmaW5lIE1BU0sgKEtTWU5DTUFQIC0gMSkKPiBAQCAtOTIsNyArOTMsNyBAQCB2b2lkIGk5 MTVfc3luY21hcF9pbml0KHN0cnVjdCBpOTE1X3N5bmNtYXAgKipyb290KQo+ICAgewo+ICAgCUJV SUxEX0JVR19PTl9OT1RfUE9XRVJfT0ZfMihLU1lOQ01BUCk7Cj4gICAJQlVJTERfQlVHX09OX05P VF9QT1dFUl9PRl8yKFNISUZUKTsKPiAtCUJVSUxEX0JVR19PTihLU1lOQ01BUCA+IEJJVFNfUEVS X0JZVEUgKiBzaXplb2YoKCpyb290KS0+Yml0bWFwKSk7Cj4gKwlCVUlMRF9CVUdfT04oS1NZTkNN QVAgPiBCSVRTX1BFUl9UWVBFKCgqcm9vdCktPmJpdG1hcCkpOwo+ICAgCSpyb290ID0gTlVMTDsK PiAgIH0KPiAgIAo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X3V0aWxz LmggYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X3V0aWxzLmgKPiBpbmRleCAwMDE2NWFkNTVm YjMuLjYxN2YwMjczN2ZkZiAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1 X3V0aWxzLmgKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X3V0aWxzLmgKPiBAQCAt NDMsNiArNDMsOCBAQAo+ICAgI2RlZmluZSBNSVNTSU5HX0NBU0UoeCkgV0FSTigxLCAiTWlzc2lu ZyBjYXNlICglcyA9PSAlbGQpXG4iLCBcCj4gICAJCQkgICAgIF9fc3RyaW5naWZ5KHgpLCAobG9u ZykoeCkpCj4gICAKPiArI2RlZmluZSBCSVRTX1BFUl9UWVBFKFQpIChzaXplb2YoVCkgKiBCSVRT X1BFUl9CWVRFKQo+ICsKPiAgICNpZiBHQ0NfVkVSU0lPTiA+PSA3MDAwMAo+ICAgI2RlZmluZSBh ZGRfb3ZlcmZsb3dzKEEsIEIpIFwKPiAgIAlfX2J1aWx0aW5fYWRkX292ZXJmbG93X3AoKEEpLCAo QiksICh0eXBlb2YoKEEpICsgKEIpKSkwKQo+IEBAIC02OCw3ICs3MCw3IEBACj4gICAKPiAgIC8q IE5vdGUgd2UgZG9uJ3QgY29uc2lkZXIgc2lnbmJpdHMgOnwgKi8KPiAgICNkZWZpbmUgb3ZlcmZs b3dzX3R5cGUoeCwgVCkgXAo+IC0JKHNpemVvZih4KSA+IHNpemVvZihUKSAmJiAoeCkgPj4gKHNp emVvZihUKSAqIEJJVFNfUEVSX0JZVEUpKQo+ICsJKHNpemVvZih4KSA+IHNpemVvZihUKSAmJiAo eCkgPj4gQklUU19QRVJfVFlQRShUKSkKPiAgIAo+ICAgI2RlZmluZSBwdHJfbWFza19iaXRzKHB0 ciwgbikgKHsJCQkJCVwKPiAgIAl1bnNpZ25lZCBsb25nIF9fdiA9ICh1bnNpZ25lZCBsb25nKShw dHIpOwkJCVwKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGV2aWNl X2luZm8uYyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2RldmljZV9pbmZvLmMKPiBpbmRl eCAwZmQxM2RmNDI0Y2YuLjE0MjI3NThhNGQzNiAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9k cm0vaTkxNS9pbnRlbF9kZXZpY2VfaW5mby5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUv aW50ZWxfZGV2aWNlX2luZm8uYwo+IEBAIC03NTAsOCArNzUwLDcgQEAgdm9pZCBpbnRlbF9kZXZp Y2VfaW5mb19ydW50aW1lX2luaXQoc3RydWN0IGludGVsX2RldmljZV9pbmZvICppbmZvKQo+ICAg CQlpbmZvLT5udW1fc2NhbGVyc1tQSVBFX0NdID0gMTsKPiAgIAl9Cj4gICAKPiAtCUJVSUxEX0JV R19PTihJOTE1X05VTV9FTkdJTkVTID4KPiAtCQkgICAgIHNpemVvZihpbnRlbF9yaW5nX21hc2tf dCkgKiBCSVRTX1BFUl9CWVRFKTsKPiArCUJVSUxEX0JVR19PTihJOTE1X05VTV9FTkdJTkVTID4g QklUU19QRVJfVFlQRShpbnRlbF9yaW5nX21hc2tfdCkpOwo+ICAgCj4gICAJLyoKPiAgIAkgKiBT a3lsYWtlIGFuZCBCcm94dG9uIGN1cnJlbnRseSBkb24ndCBleHBvc2UgdGhlIHRvcG1vc3QgcGxh bmUgYXMgaXRzCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2VuZ2lu ZV9jcy5jIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZW5naW5lX2NzLmMKPiBpbmRleCA0 NzhjOTI4OTEyYzQuLmI0NTlhMDgxOTU2OSAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0v aTkxNS9pbnRlbF9lbmdpbmVfY3MuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVs X2VuZ2luZV9jcy5jCj4gQEAgLTMzMyw3ICszMzMsNyBAQCBpbnQgaW50ZWxfZW5naW5lc19pbml0 X21taW8oc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2KQo+ICAgCj4gICAJV0FSTl9P TihyaW5nX21hc2sgPT0gMCk7Cj4gICAJV0FSTl9PTihyaW5nX21hc2sgJgo+IC0JCUdFTk1BU0so c2l6ZW9mKG1hc2spICogQklUU19QRVJfQllURSAtIDEsIEk5MTVfTlVNX0VOR0lORVMpKTsKPiAr CQlHRU5NQVNLKEJJVFNfUEVSX1RZUEUobWFzaykgLSAxLCBJOTE1X05VTV9FTkdJTkVTKSk7Cj4g ICAKPiAgIAlmb3IgKGkgPSAwOyBpIDwgQVJSQVlfU0laRShpbnRlbF9lbmdpbmVzKTsgaSsrKSB7 Cj4gICAJCWlmICghSEFTX0VOR0lORShkZXZfcHJpdiwgaSkpCj4gCgpMb29rcyBmaW5lIHRvIG1l LgoKUmV2aWV3ZWQtYnk6IFR2cnRrbyBVcnN1bGluIDx0dnJ0a28udXJzdWxpbkBpbnRlbC5jb20+ CgpSZWdhcmRzLAoKVHZydGtvCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fCkludGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNr dG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2lu dGVsLWdmeAo=