From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sujaritha Subject: Re: [PATCH v3 01/19] drm/i915/guc: Change platform default GuC mode Date: Mon, 22 Apr 2019 13:29:42 -0700 Message-ID: References: <20190417054004.28176-1-michal.wajdeczko@intel.com> <20190417054004.28176-2-michal.wajdeczko@intel.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0939373894==" Return-path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by gabe.freedesktop.org (Postfix) with ESMTPS id C737D89193 for ; Mon, 22 Apr 2019 20:48:53 +0000 (UTC) In-Reply-To: <20190417054004.28176-2-michal.wajdeczko@intel.com> Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Michal Wajdeczko , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org This is a multi-part message in MIME format. --===============0939373894== Content-Type: multipart/alternative; boundary="------------295224E36386EEF19B68BB0D" Content-Language: en-US This is a multi-part message in MIME format. --------------295224E36386EEF19B68BB0D Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit On 4/16/19 10:39 PM, Michal Wajdeczko wrote: > Today our most desired GuC configuration is to only enable HuC > if it is available and we really don't care about GuC submission. > Change platform default GuC mode to match our desire. > > Signed-off-by: Michal Wajdeczko > Cc: Joonas Lahtinen > Cc: Chris Wilson > Cc: Rodrigo Vivi > Cc: Daniele Ceraolo Spurio > Cc: John Spotswood > Cc: Vinay Belgaumkar > Cc: Tony Ye > Cc: Anusha Srivatsa > Cc: Jeff Mcgee > Cc: Antonio Argenziano > Cc: Sujaritha Sundaresan > --- > drivers/gpu/drm/i915/intel_uc.c | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/drivers/gpu/drm/i915/intel_uc.c b/drivers/gpu/drm/i915/intel_uc.c > index 25b80ffe71ad..2a56e2363888 100644 > --- a/drivers/gpu/drm/i915/intel_uc.c > +++ b/drivers/gpu/drm/i915/intel_uc.c > @@ -57,10 +57,8 @@ static int __get_platform_enable_guc(struct drm_i915_private *i915) > struct intel_uc_fw *huc_fw = &i915->huc.fw; > int enable_guc = 0; > > - /* Default is to enable GuC/HuC if we know their firmwares */ > - if (intel_uc_fw_is_selected(guc_fw)) > - enable_guc |= ENABLE_GUC_SUBMISSION; > - if (intel_uc_fw_is_selected(huc_fw)) > + /* Default is to use HuC if we know GuC and HuC firmwares */ > + if (intel_uc_fw_is_selected(guc_fw) && intel_uc_fw_is_selected(huc_fw)) > enable_guc |= ENABLE_GUC_LOAD_HUC; > > /* Any platform specific fine-tuning can be done here */ Reviewed-by: Sujaritha Sundaresan Regards, Sujaritha --------------295224E36386EEF19B68BB0D Content-Type: text/html; charset=utf-8 Content-Transfer-Encoding: 7bit

On 4/16/19 10:39 PM, Michal Wajdeczko wrote:

Today our most desired GuC configuration is to only enable HuC
if it is available and we really don't care about GuC submission.
Change platform default GuC mode to match our desire.

Signed-off-by: Michal Wajdeczko <michal.wajdeczko@intel.com>
Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
Cc: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
Cc: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>
Cc: John Spotswood <john.a.spotswood@intel.com>
Cc: Vinay Belgaumkar <vinay.belgaumkar@intel.com>
Cc: Tony Ye <tony.ye@intel.com>
Cc: Anusha Srivatsa <anusha.srivatsa@intel.com>
Cc: Jeff Mcgee <jeff.mcgee@intel.com>
Cc: Antonio Argenziano <antonio.argenziano@intel.com>
Cc: Sujaritha Sundaresan <sujaritha.sundaresan@intel.com>
---
 drivers/gpu/drm/i915/intel_uc.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/drivers/gpu/drm/i915/intel_uc.c b/drivers/gpu/drm/i915/intel_uc.c
index 25b80ffe71ad..2a56e2363888 100644
--- a/drivers/gpu/drm/i915/intel_uc.c
+++ b/drivers/gpu/drm/i915/intel_uc.c
@@ -57,10 +57,8 @@ static int __get_platform_enable_guc(struct drm_i915_private *i915)
 	struct intel_uc_fw *huc_fw = &i915->huc.fw;
 	int enable_guc = 0;
 
-	/* Default is to enable GuC/HuC if we know their firmwares */
-	if (intel_uc_fw_is_selected(guc_fw))
-		enable_guc |= ENABLE_GUC_SUBMISSION;
-	if (intel_uc_fw_is_selected(huc_fw))
+	/* Default is to use HuC if we know GuC and HuC firmwares */
+	if (intel_uc_fw_is_selected(guc_fw) && intel_uc_fw_is_selected(huc_fw))
 		enable_guc |= ENABLE_GUC_LOAD_HUC;
 
 	/* Any platform specific fine-tuning can be done here */


Reviewed-by: Sujaritha Sundaresan <sujaritha.sundaresan@intel.com>

Regards,
Sujaritha

--------------295224E36386EEF19B68BB0D-- --===============0939373894== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4 IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4 --===============0939373894==--