public inbox for intel-gfx@lists.freedesktop.org
 help / color / mirror / Atom feed
From: Darren Hart <darren.hart@intel.com>
To: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 2/2] drm/i915/vlv: remove wait for previous GFX clk disable request
Date: Thu, 2 Apr 2015 16:56:36 +0000 (UTC)	[thread overview]
Message-ID: <loom.20150402T185408-502@post.gmane.org> (raw)
In-Reply-To: 1427923378-2116-2-git-send-email-jbarnes@virtuousgeek.org

Jesse Barnes <jbarnes <at> virtuousgeek.org> writes:
> Looks like it was introduced in:
> 
> commit 650ad970a39f8b6164fe8613edc150f585315289
> Author: Imre Deak <imre.deak <at> intel.com>
> Date:   Fri Apr 18 16:35:02 2014 +0300
> 
>     drm/i915: vlv: factor out vlv_force_gfx_clock and check for pending
>     force-of
> 
> but I'm not sure why.  It has caused problems for us in the past (see
> 85250ddff7a603dfe0ec0503a9e6395f79424f61 and
> 8d4eee9cd7a170342dc6fbc2ee19ae77031a8cd5) and doesn't seem to be
> required, so let's just drop it.
> 
> References: https://bugs.freedesktop.org/show_bug.cgi?id=89611
> Signed-off-by: Jesse Barnes <jbarnes <at> virtuousgeek.org>


Thanks Jesse,

With this and 1/2 applied I was able to suspend/resume twice in a row
successfully on a MinnowBoard MAX dual-core (E3825) with the 0.78
firmware.

Tested-by: Darren Hart <dvhart@linux.intel.com>

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

  parent reply	other threads:[~2015-04-02 17:00 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-01 21:22 [PATCH 1/2] drm/i915/vlv: save/restore the power context base reg Jesse Barnes
2015-04-01 21:22 ` [PATCH 2/2] drm/i915/vlv: remove wait for previous GFX clk disable request Jesse Barnes
2015-04-02  8:15   ` Imre Deak
2015-04-02 10:41   ` Deepak S
2015-04-02 16:56   ` Darren Hart [this message]
2015-04-07 13:04     ` Jani Nikula
2015-04-02  7:45 ` [PATCH 1/2] drm/i915/vlv: save/restore the power context base reg Jani Nikula
2015-04-02  7:49 ` Imre Deak
2015-04-02 10:23 ` Deepak S

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=loom.20150402T185408-502@post.gmane.org \
    --to=darren.hart@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox