From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Michal Wajdeczko" Subject: Re: [PATCH v2 3/8] drm/i915/uc: Unify uc_fw status tracking Date: Wed, 24 Jul 2019 19:24:53 +0200 Message-ID: References: <20190724022153.8927-1-daniele.ceraolospurio@intel.com> <20190724022153.8927-4-daniele.ceraolospurio@intel.com> <8fd309ea-2624-8d8c-9eae-da7ce8d81c0d@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed"; DelSp="yes" Content-Transfer-Encoding: base64 Return-path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by gabe.freedesktop.org (Postfix) with ESMTPS id 3FA176E56E for ; Wed, 24 Jul 2019 17:24:56 +0000 (UTC) In-Reply-To: <8fd309ea-2624-8d8c-9eae-da7ce8d81c0d@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: intel-gfx@lists.freedesktop.org, Daniele Ceraolo Spurio List-Id: intel-gfx@lists.freedesktop.org T24gV2VkLCAyNCBKdWwgMjAxOSAxODozNzo1MiArMDIwMCwgRGFuaWVsZSBDZXJhb2xvIFNwdXJp byAgCjxkYW5pZWxlLmNlcmFvbG9zcHVyaW9AaW50ZWwuY29tPiB3cm90ZToKCj4+PiAtICAgIHVj X2Z3LT5sb2FkX3N0YXR1cyA9IElOVEVMX1VDX0ZJUk1XQVJFX1NVQ0NFU1M7Cj4+PiAtICAgIERS TV9ERUJVR19EUklWRVIoIiVzIGZ3IGxvYWQgJXNcbiIsCj4+PiAtICAgICAgICAgICAgIGludGVs X3VjX2Z3X3R5cGVfcmVwcih1Y19mdy0+dHlwZSksCj4+PiAtICAgICAgICAgICAgIGludGVsX3Vj X2Z3X3N0YXR1c19yZXByKHVjX2Z3LT5sb2FkX3N0YXR1cykpOwo+Pj4gKyAgICB1Y19mdy0+c3Rh dHVzID0gSU5URUxfVUNfRklSTVdBUkVfTE9BREVEOwo+Pgo+PiBtYXliZSB3ZSBjYW4gc2xpZ2h0 bHkgbW9kaWZ5IHhmZXIgZnVuY3Rpb24gYWdyZWVtZW50IGFuZCB1c2UKPj4gLUVJTlBST0dSRVNT IHRvIGluZGljYXRlIHdoZXRoZXIgZncgaXMganVzdCBsb2FkZWQgKEh1Qykgb3IKPj4gaXMgYWxy ZWFkeSBhdXRoZW50aWNhdGVkIGFuZCBydW5uaW5nIChHdUMpOgo+Pgo+PiAgICAgaWYgKCFlcnIp Cj4+ICAgICAgICAgdWNfZnctPnN0YXR1cyA9IElOVEVMX1VDX0ZJUk1XQVJFX1JVTk5JTkc7Cj4+ ICAgICBlbHNlIGlmIChlcnIgPT0gLUVJTlBST0dSRVNTKQo+PiAgICAgICAgIHVjX2Z3LT5zdGF0 dXMgPSBJTlRFTF9VQ19GSVJNV0FSRV9MT0FERUQ7Cj4+ICAgICBlbHNlCj4+ICAgICAgICAgZ290 byBmYWlsOwo+Pgo+Cj4gSSd2ZSBwdXJwb3NlbHkga2VwdCB0aGUgUlVOTklORyBzdGF0ZSBvdXRz aWRlIGJlY2F1c2UgaW4gcGF0Y2ggOCBJIG1vdmUgIAo+IHRoZSB3YWl0IG91dHNpZGUgdGhlIHhm ZXIsIHNvIHRoZSBzd2l0Y2ggdG8gdGhlIHJ1bm5pbmcgc3RhdGUgd2lsbCBiZSAgCj4gZG9uZSBv dXRzaWRlIG9mIGhlcmUgZm9yIGJvdGggdUMuIFNlZW1lZCBsaWtlIGxlc3MgY2h1cm4gdG8gZ28g ZGlyZWN0bHkgIAo+IHdpdGggdGhhdC4KCm9rLCBJIG1pc3NlZCB0aGF0IG1vdmUgaW4gZGlmZiA4 LzgKCgo+Pj4gQEAgLTM1LDEyICszNSwxNCBAQCBzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZTsKPj4+ ICAjZGVmaW5lIElOVEVMX1VDX0ZJUk1XQVJFX1VSTCAgCj4+PiAiaHR0cHM6Ly9naXQua2VybmVs Lm9yZy9wdWIvc2NtL2xpbnV4L2tlcm5lbC9naXQvZmlybXdhcmUvbGludXgtZmlybXdhcmUuZ2l0 L3RyZWUvaTkxNSIKPj4+IGVudW0gaW50ZWxfdWNfZndfc3RhdHVzIHsKPj4+IC0gICAgSU5URUxf VUNfRklSTVdBUkVfTk9UX1NVUFBPUlRFRCA9IC0yLCAvKiBubyB1YyBIVyAqLwo+Pj4gLSAgICBJ TlRFTF9VQ19GSVJNV0FSRV9GQUlMID0gLTEsCj4+PiArICAgIElOVEVMX1VDX0ZJUk1XQVJFX0xP QURfRkFJTCA9IC0zLAo+Pj4gKyAgICBJTlRFTF9VQ19GSVJNV0FSRV9GRVRDSF9GQUlMID0gLTIs Cj4+PiArICAgIElOVEVMX1VDX0ZJUk1XQVJFX05PVF9TVVBQT1JURUQgPSAtMSwgLyogbm8gdWMg SFcgKi8KPj4+ICAgICAgSU5URUxfVUNfRklSTVdBUkVfVU5JTklUSUFMSVpFRCA9IDAsIC8qIHVz ZWQgdG8gY2F0Y2ggY2hlY2tzIGRvbmUgIAo+Pj4gdG9vIGVhcmx5ICovCj4+PiAtICAgIElOVEVM X1VDX0ZJUk1XQVJFX05PVF9TVEFSVEVEID0gMSwKPj4+IC0gICAgSU5URUxfVUNfRklSTVdBUkVf UEVORElORywKPj4+IC0gICAgSU5URUxfVUNfRklSTVdBUkVfU1VDQ0VTUwo+Pj4gKyAgICBJTlRF TF9VQ19GSVJNV0FSRV9TRUxFQ1RJT05fRE9ORSwgLyogc2VsZWN0aW9uIGluY2x1ZGUgdGhlICJu byAgCj4+PiBGVyIgY2FzZSAqLwo+Pgo+PiB3aHkgZG8geW91IHdhbnQgdG8ga2VlcCAiTm8gRlci IGNhc2UgaGVyZSA/Cj4+IHdoZW4gd2Uga25vdyB0aGF0IHRoZXJlIGlzIG5vIGZ3LCB3ZSBzaG91 bGQgbm90IGF0dGVtcHQgdG8gZmV0Y2ggaXQuCj4+IHNvIHRoaXMgaXMgZGlmZmVyZW50IHN0YXRl IHRoYW4gImZ3IHdhcyBzZWxlY3RlZCwgYXdhaXRpbmcgZmV0Y2giCj4KPiBXZSBuZWVkIGEgd2F5 IHRvIGRpZmZlcmVudGlhdGUgZm9yIHRoZSBsb2dnaW5nIGFuZCBJIGRpZG4ndCB3YW50IGFuICAK PiBleHRyYSBzdGF0ZSBzaW5jZSB3ZSBjaGVjayBmdy0+cGF0aCBhbnl3YXkgdG8gbWFrZSBzdXJl IHRoZSBmdyB3YXMgIAo+IGFjdHVhbGx5IHNlbGVjdGVkLgoKQnV0ICJOL0EiIHN0YXRlIGFsc28g bWVhbnMgdGhhdCB3ZSBhbHJlYWR5IHBhc3Mgb3ZlciBpbml0X2Vhcmx5IHN0ZXAKdGhhdCBpbmNs dWRlcyBzZWxlY3Rpb24sIHNvIHdlIGRvbid0IG5lZWQgdG8gYWRkIGFueSBleHRyYSBzdGF0ZS4K Cj4KPj4KPj4+ICsgICAgSU5URUxfVUNfRklSTVdBUkVfQVZBSUxBQkxFLCAvKiBmZXRjaCBkb25l ICovCj4+PiArICAgIElOVEVMX1VDX0ZJUk1XQVJFX0xPQURFRCwgLyogZG1hIHhmZXIgZG9uZSAq Lwo+Pj4gKyAgICBJTlRFTF9VQ19GSVJNV0FSRV9SVU5OSU5HIC8qIGZ3IGluaXQvYXV0aCBkb25l ICovCj4+PiAgfTsKPj4+IGVudW0gaW50ZWxfdWNfZndfdHlwZSB7Cj4+PiBAQCAtNTcsOCArNTks NyBAQCBzdHJ1Y3QgaW50ZWxfdWNfZncgewo+Pj4gICAgICBjb25zdCBjaGFyICpwYXRoOwo+Pj4g ICAgICBzaXplX3Qgc2l6ZTsKPj4+ICAgICAgc3RydWN0IGRybV9pOTE1X2dlbV9vYmplY3QgKm9i ajsKPj4+IC0gICAgZW51bSBpbnRlbF91Y19md19zdGF0dXMgZmV0Y2hfc3RhdHVzOwo+Pj4gLSAg ICBlbnVtIGludGVsX3VjX2Z3X3N0YXR1cyBsb2FkX3N0YXR1czsKPj4+ICsgICAgZW51bSBpbnRl bF91Y19md19zdGF0dXMgc3RhdHVzOwo+Pj4gICAgIC8qCj4+PiAgICAgICAqIFRoZSBmaXJtd2Fy ZSBidWlsZCBwcm9jZXNzIHdpbGwgZ2VuZXJhdGUgYSB2ZXJzaW9uIGhlYWRlciBmaWxlICAKPj4+ IHdpdGggbWFqb3IgYW5kCj4+PiBAQCAtODMsMTggKzg0LDIyIEBAIHN0YXRpYyBpbmxpbmUKPj4+ ICBjb25zdCBjaGFyICppbnRlbF91Y19md19zdGF0dXNfcmVwcihlbnVtIGludGVsX3VjX2Z3X3N0 YXR1cyBzdGF0dXMpCj4+PiAgewo+Pj4gICAgICBzd2l0Y2ggKHN0YXR1cykgewo+Pj4gKyAgICBj YXNlIElOVEVMX1VDX0ZJUk1XQVJFX0xPQURfRkFJTDoKPj4+ICsgICAgICAgIHJldHVybiAiTE9B RCBGQUlMIjsKCnNvcnJ5IGZvciBzZWNvbmQgdGhvdWdodHMsIGJ1dCB3aXRoIHRoZXNlIG5hbWVz IHdlIGNvdWxkIGhhdmU6CgpMT0FERUQgKHVzZXI6IGh1cnJheSEpIC0tPiBOT1RfTE9BREVEICh1 c2VyOiBidXQgd2Ugd2VyZSBhbHJlYWR5IGxvYWRlZD8hPykKCnNvIG1heWJlIHBsYWluICJGQUlM IiBhcyB0aGlzIGlzIHVzZXIgZmFjaW5nIHN0YXR1cyA/Cgo+Pj4gKyAgICBjYXNlIElOVEVMX1VD X0ZJUk1XQVJFX0ZFVENIX0ZBSUw6Cj4+PiArICAgICAgICByZXR1cm4gIkZFVENIIEZBSUwiOwoK c2FtZSBoZXJlLCAiZmV0Y2giIGl0J3MgbmFtZSBvZiBvdXIgaW50ZXJuYWwgc3RlcCwKIk1JU1NJ TkciIHNvdW5kcyBiZXR0ZXIgaW1ubwoKPj4+ICAgICAgY2FzZSBJTlRFTF9VQ19GSVJNV0FSRV9O T1RfU1VQUE9SVEVEOgo+Pj4gLSAgICAgICAgcmV0dXJuICJOL0EgLSB1YyBIVyBub3QgYXZhaWxh YmxlIjsKPj4+IC0gICAgY2FzZSBJTlRFTF9VQ19GSVJNV0FSRV9GQUlMOgo+Pj4gLSAgICAgICAg cmV0dXJuICJGQUlMIjsKPj4+ICsgICAgICAgIHJldHVybiAiTi9BIjsKPj4+ICAgICAgY2FzZSBJ TlRFTF9VQ19GSVJNV0FSRV9VTklOSVRJQUxJWkVEOgo+Pj4gICAgICAgICAgcmV0dXJuICJVTklO SVRJQUxJWkVEIjsKPj4+IC0gICAgY2FzZSBJTlRFTF9VQ19GSVJNV0FSRV9OT1RfU1RBUlRFRDoK Pj4+IC0gICAgICAgIHJldHVybiAiTk9UX1NUQVJURUQiOwo+Pj4gLSAgICBjYXNlIElOVEVMX1VD X0ZJUk1XQVJFX1BFTkRJTkc6Cj4+PiAtICAgICAgICByZXR1cm4gIlBFTkRJTkciOwo+Pj4gLSAg ICBjYXNlIElOVEVMX1VDX0ZJUk1XQVJFX1NVQ0NFU1M6Cj4+PiAtICAgICAgICByZXR1cm4gIlNV Q0NFU1MiOwo+Pj4gKyAgICBjYXNlIElOVEVMX1VDX0ZJUk1XQVJFX1NFTEVDVElPTl9ET05FOgo+ Pj4gKyAgICAgICAgcmV0dXJuICJTRUxFQ1RJT04gRE9ORSI7Cj4+Cj4+IG5pdDogdGhpcyBpcyBu b3QgbXkgZmF2b3JpdGUsIHdoYXQgd2FzIHdyb25nIHdpdGgKPj4gIlBFTkRJTkciIChrbm93biwg YXdhaXRpbmcgZmV0Y2gvbG9hZCwgbG9vayBpdCdzIHRyYW5zaWVudCBzdGF0ZSEpCj4+ICJTRUxF Q1RFRCIgKHNob3J0ZXIsIGFwcGxpZXMgdG8gdGhpcyBmdyBvYmplY3QgdnMgc3RlcCkKPgo+IEkg d2FudGVkIHRvIGhpZ2hsaWdodCB0aGUgZmFjdCB0aGF0IHRoZSBzZWxlY3Rpb24gaW5jbHVkZWQg dGhlICJubyBGVyIgIAo+IGNhc2UsIHRoZSBmdyB3YXNuJ3QgbmVjZXNzYXJpbHkgInNlbGVjdGVk Ii4gV2UganVzdCBrbm93IHRoYXQgd2UndmUgcnVuICAKPiB0aHJvdWdoIHRoZSBzZWxlY3Rpb24g Y29kZS4KCmJ1dCBmcm9tIHRoZSB1c2VyIHBvdiB0aGlzIGlzIGludGVybmFsIGRldGFpbCwgbm90 IHN1cmUgaWYgd2Ugc2hvdWxkIGV4cG9zZQp0aGF0LCBvbiBvdGhlciBoYW5kLCBQRU5ESU5HIGNs ZWFybHkgaW5kaWNhdGVzIHRoYXQgd2UgYXJlIHN0aWxsIGdvaW5nIHRvICAKZG8Kc29tZXRoaW5n IHdpdGggdGhhdCBmaXJtd2FyZSAoZmV0Y2gveGZlci9hdXRoKSB1bnRpbCB3ZSByZWFjaCBlbmQg c3RhdGUuCgo+Cj4+Cj4+PiArICAgIGNhc2UgSU5URUxfVUNfRklSTVdBUkVfQVZBSUxBQkxFOgo+ Pj4gKyAgICAgICAgcmV0dXJuICJBVkFJTEFCTEUiOwo+Pj4gKyAgICBjYXNlIElOVEVMX1VDX0ZJ Uk1XQVJFX0xPQURFRDoKPj4+ICsgICAgICAgIHJldHVybiAiTE9BREVEIjsKPj4+ICsgICAgY2Fz ZSBJTlRFTF9VQ19GSVJNV0FSRV9SVU5OSU5HOgo+Pj4gKyAgICAgICAgcmV0dXJuICJSVU5OSU5H IjsKCmhtbSwgdGhlIGRpZmZlcmVuY2UgYmV0d2VlbiBMT0FERUQvUlVOTklORyBtaWdodCBiZSB1 bm5vdGljZWQgYnkgdGhlCnVzZXIsIGFzIGhlIG1heSBhbHNvIHRyZWF0IExPQURFRCBhcyBmdWxs IHN1Y2Nlc3MuCgpzbyBtYXliZSBzL0xPQURFRC9UUkFOU0ZFUlJFRCA/Cgo+Pj4gICAgICB9Cj4+ PiAgICAgIHJldHVybiAiPGludmFsaWQ+IjsKPj4+ICB9Cl9fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fCkludGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4 QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWls bWFuL2xpc3RpbmZvL2ludGVsLWdmeA==