From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BD196C4743C for ; Wed, 23 Jun 2021 14:51:58 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7D63B60041 for ; Wed, 23 Jun 2021 14:51:58 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7D63B60041 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=intel-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 1DCFC6E920; Wed, 23 Jun 2021 14:51:58 +0000 (UTC) Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by gabe.freedesktop.org (Postfix) with ESMTPS id 1617C6E920 for ; Wed, 23 Jun 2021 14:51:57 +0000 (UTC) Received: from relay2.suse.de (relay2.suse.de [149.44.160.134]) by smtp-out2.suse.de (Postfix) with ESMTP id 817AC1FD36; Wed, 23 Jun 2021 14:51:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1624459915; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=FadA493UMb/E1PakDr4gbcfyLWXAiyV6y581dnW71V8=; b=yKDkCEB1VFREhDb8H784Fr93eefpgxcfqkxtyWInDmR7YQEXgyFxWb9ODvPttDaleIaYtN Ut9ONQ4Ij2RnbRvl7x3e7KZRAp5HGvnaYpSuwiq7IrCCkrk9tXUI1aK97ot7LQ4lvbDndv K96B7Kko5XSzbI8aV3aG84PzEkSfYuE= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1624459915; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=FadA493UMb/E1PakDr4gbcfyLWXAiyV6y581dnW71V8=; b=5r18NSuoe3fflPvpxhHzwhd/tj0ZXmGsLkweCwrEot4Sbmhm+NPbM+f/uJO95JRZaawtd+ DLnKeguFp34DiuAA== Received: from alsa1.suse.de (alsa1.suse.de [10.160.4.42]) by relay2.suse.de (Postfix) with ESMTP id 6E226A3B91; Wed, 23 Jun 2021 14:51:55 +0000 (UTC) Date: Wed, 23 Jun 2021 16:51:55 +0200 Message-ID: From: Takashi Iwai To: Imre Deak In-Reply-To: <20210623134601.2128663-1-imre.deak@intel.com> References: <20210623134601.2128663-1-imre.deak@intel.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Subject: Re: [Intel-gfx] [PATCH 1/2] ALSA: hda: Release controller display power during shutdown/reboot X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Thomas Voegtle , intel-gfx@lists.freedesktop.org, alsa-devel@alsa-project.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Wed, 23 Jun 2021 15:46:00 +0200, Imre Deak wrote: > > Make sure the HDA driver's display power reference is released during > shutdown/reboot. > > During the shutdown/reboot sequence the pci device core calls the > pm_runtime_resume handler for all devices before calling the driver's > shutdown callback and so the HDA driver's runtime resume callback will > acquire a display power reference (on HSW/BDW). This triggers a power > reference held WARN on HSW/BDW in the i915 driver's subsequent shutdown > handler, which expects all display power references to be released by > that time. > > Since the HDA controller is stopped in the shutdown handler in any case, > let's follow here the same sequence as the one during runtime suspend. > This will also reset the HDA link and drop the display power reference, > getting rid of the above WARN. > > Tested on HSW. > > v2: > - Fix the build for CONFIG_PM=n (Takashi) > - s/__azx_runtime_suspend/azx_shutdown_chip/ > > Closes: https://gitlab.freedesktop.org/drm/intel/-/issues/3618 > References: https://lore.kernel.org/lkml/cea1f9a-52e0-b83-593d-52997fe1aaf6@er-systems.de > Reported-and-tested-by: Thomas Voegtle > Cc: Takashi Iwai > Signed-off-by: Imre Deak Thanks, applied both patches now. Takashi _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx