From mboxrd@z Thu Jan 1 00:00:00 1970 From: Takashi Iwai Subject: Re: [alsa-devel] [PATCH] drm/i915: Add private api for power well usage -- alignment between graphic team and audio team Date: Fri, 03 May 2013 16:31:34 +0200 Message-ID: References: <1B1032E88FFFDA4898B04D530F28DEDB53CAB7@SHSMSX101.ccr.corp.intel.com> <1B1032E88FFFDA4898B04D530F28DEDB53CB7C@SHSMSX101.ccr.corp.intel.com> <20130426145708.GN6169@phenom.ffwll.local> <20130426154207.GP6169@phenom.ffwll.local> <20130426171737.GR6169@phenom.ffwll.local> <46B810F6945F7C4788E11DCE57EC4890109D3608@SHSMSX102.ccr.corp.intel.com> <20130427113529.GT6169@phenom.ffwll.local> <20130429080219.05108857@jbarnes-desktop> <517F9D11.3020905@canonical.com> <1367332882.2460.14.camel@loki> <51827CF2.9090507@canonical.com> <46B810F6945F7C4788E11DCE57EC4890109D596D@SHSMSX102.ccr.corp.intel.com> <5183A73C.1030205@canonical.com> Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mx2.suse.de (cantor2.suse.de [195.135.220.15]) by gabe.freedesktop.org (Postfix) with ESMTP id 7790EE5D75 for ; Fri, 3 May 2013 07:31:27 -0700 (PDT) In-Reply-To: <5183A73C.1030205@canonical.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: David Henningsson Cc: "alsa-devel@alsa-project.org" , "Zanoni, Paulo R" , "Li, Jocelyn" , Daniel Vetter , "intel-gfx@lists.freedesktop.org" , "Wysocki, Rafael J" , Wang Xingchao , Liam Girdwood , "Hindman, Gavin" , "Barnes, Jesse" , "Lin, Mengdong" List-Id: intel-gfx@lists.freedesktop.org At Fri, 03 May 2013 14:02:04 +0200, David Henningsson wrote: > > On 05/03/2013 10:28 AM, Wang, Xingchao wrote: > > Hi David, > > > > Thank you very much for your draft patch. > > I have some more work on a new patchset, some ideas are from your patch. > > Thanks. > > > Here's a brief introduction of attached patchset: > > > > 1. a new bus type in /sound/had_bus.c, used to bind the single module and codec device > > It looks like ac97_bus.c > > I don't understand why this is needed. It does not look like it's used > from the gfx side either, or anything like that? > > > 2. add a new device node in "struct hda_codec", it's used to register for new bus type. > > > > 3. a new single module hdmi_i915, which compiled in only when DRM_I915 and CODEC_HDMI enabled. > > It stores the private API for gfx part. > > There's no support to probe haswell hdmi codec only yet. Power well will be used only for haswell display audio. > > > > 4. power well API implementation in gfx side. > > > > Please feel free to add your idea and I will help test your patch too. > > Ok. So the patch I wrote would (if it works) be combined with your patch > 3, which implements the gfx side. The gfx side is not my area of expertise. > > The proposed way in my patch would be more elegant since it does not > introduce any i915 related code in hda_codec* files. > > Still, Takashi is the boss here so he has the final say :-) Indeed. If the reference to power well API is limited in a newly split snd-hda-codec-hdmi-i915 driver, we don't have to create yet another driver instance. The snd-hda-codec-hdmi-i915 can simply depend on i915, by referring to a symbol exported from i915 driver. If we now touch the whole PM sequence in both gfx and audio drivers (i.e. it influences on the HD-audio controller code, hda_intel.c), then we may need a different management. But I thought it's not yet discussed here, right? Takashi